Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130120/?format=api
{ "id": 130120, "url": "http://patches.dpdk.org/api/patches/130120/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230811085805.441256-6-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230811085805.441256-6-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230811085805.441256-6-ndabilpuram@marvell.com", "date": "2023-08-11T08:57:40", "name": "[06/31] common/cnxk: fixes CGX promisc toggling", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "36e9eb289647ef290d287d112b6210621c216e79", "submitter": { "id": 1202, "url": "http://patches.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230811085805.441256-6-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 29177, "url": "http://patches.dpdk.org/api/series/29177/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29177", "date": "2023-08-11T08:57:35", "name": "[01/31] common/cnxk: add aura ref count mechanism", "version": 1, "mbox": "http://patches.dpdk.org/series/29177/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/130120/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/130120/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4995743032;\n\tFri, 11 Aug 2023 10:58:46 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 088794326C;\n\tFri, 11 Aug 2023 10:58:30 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 6B39A43264\n for <dev@dpdk.org>; Fri, 11 Aug 2023 10:58:28 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 37AMjx5O001610 for <dev@dpdk.org>; Fri, 11 Aug 2023 01:58:27 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3sd8yp9r6c-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Fri, 11 Aug 2023 01:58:27 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Fri, 11 Aug 2023 01:58:25 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Fri, 11 Aug 2023 01:58:25 -0700", "from hyd1588t430.caveonetworks.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id 790183F706B;\n Fri, 11 Aug 2023 01:58:23 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=VScEcG8DDwsq44tUr3fLcQveePexiv2ET2mKdUNpqOI=;\n b=iksv8CJVu8AO6mB1cIqdpt/w49fC43z5E3y3Cdr4ijY0M9QOIDYTKmicZ+MadPNQlEE6\n OcZvqXaxo2om1LQpnB7e/jw6+6OwfuQTTdw6h1mAmJQGLqfqOwTAIgW6WN4iBYKUaQSM\n faxNpREfcdjAMsACAynDnAnr3/yOqQ7Jsq/iVsXu6xmY2AxWAHxBn/k6814ym8viL7aW\n 2pDwCfuuZCo9EWvxVxlL1zyqJIY8ZDluiQRpSkEj1zrtAfpH6r0ioSG2LV9tzR4zbbtE\n fA4Y7kQNMLF3so+qDg7jZYUorlIrWqUm4deR96UyooW3NoNfPUP944RTHdPUnsJ7urWK uw==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>", "CC": "<jerinj@marvell.com>, <dev@dpdk.org>, Rahul Bhansali\n <rbhansali@marvell.com>", "Subject": "[PATCH 06/31] common/cnxk: fixes CGX promisc toggling", "Date": "Fri, 11 Aug 2023 14:27:40 +0530", "Message-ID": "<20230811085805.441256-6-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230811085805.441256-1-ndabilpuram@marvell.com>", "References": "<20230811085805.441256-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "6ZvSjBKVN55ZmGyW3spREuHB1xD0w9aC", "X-Proofpoint-GUID": "6ZvSjBKVN55ZmGyW3spREuHB1xD0w9aC", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26\n definitions=2023-08-10_20,2023-08-10_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Rahul Bhansali <rbhansali@marvell.com>\n\nThis will allow CGX promisc toggling even when exact\nmatch feature is enabled.\nAlso, In case of exact feature, CGX promisc enable/disable mbox\nresponse returns failure code -1101 in case if no change in the state.\nThis failure code can be ignored and proceed further.\n\nFixes: a90649722b51 (\"common/cnxk: skip CGX promisc mode with NPC exact match\")\n\nSigned-off-by: Rahul Bhansali <rbhansali@marvell.com>\n---\n drivers/common/cnxk/roc_dev.c | 13 ++++++++++++-\n drivers/common/cnxk/roc_mbox.h | 15 +++++++++++++++\n drivers/common/cnxk/roc_nix_mac.c | 8 --------\n 3 files changed, 27 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/common/cnxk/roc_dev.c b/drivers/common/cnxk/roc_dev.c\nindex 4b0ba218ed..128b9751e4 100644\n--- a/drivers/common/cnxk/roc_dev.c\n+++ b/drivers/common/cnxk/roc_dev.c\n@@ -451,7 +451,6 @@ process_msgs(struct dev *dev, struct mbox *mbox)\n \t\t\t * while PFC already configured on other VFs. This is\n \t\t\t * not an error but a warning which can be ignored.\n \t\t\t */\n-#define LMAC_AF_ERR_PERM_DENIED -1103\n \t\t\tif (msg->rc) {\n \t\t\t\tif (msg->rc == LMAC_AF_ERR_PERM_DENIED) {\n \t\t\t\t\tplt_mbox_dbg(\n@@ -464,6 +463,18 @@ process_msgs(struct dev *dev, struct mbox *mbox)\n \t\t\t\t}\n \t\t\t}\n \t\t\tbreak;\n+\t\tcase MBOX_MSG_CGX_PROMISC_DISABLE:\n+\t\tcase MBOX_MSG_CGX_PROMISC_ENABLE:\n+\t\t\tif (msg->rc) {\n+\t\t\t\tif (msg->rc == LMAC_AF_ERR_INVALID_PARAM) {\n+\t\t\t\t\tplt_mbox_dbg(\"Already in same promisc state\");\n+\t\t\t\t\tmsg->rc = 0;\n+\t\t\t\t} else {\n+\t\t\t\t\tplt_err(\"Message (%s) response has err=%d\",\n+\t\t\t\t\t\tmbox_id2name(msg->id), msg->rc);\n+\t\t\t\t}\n+\t\t\t}\n+\t\t\tbreak;\n \n \t\tdefault:\n \t\t\tif (msg->rc)\ndiff --git a/drivers/common/cnxk/roc_mbox.h b/drivers/common/cnxk/roc_mbox.h\nindex f038d3e02b..2fd01cd710 100644\n--- a/drivers/common/cnxk/roc_mbox.h\n+++ b/drivers/common/cnxk/roc_mbox.h\n@@ -540,6 +540,21 @@ struct lmtst_tbl_setup_req {\n };\n \n /* CGX mbox message formats */\n+/* CGX mailbox error codes\n+ * Range 1101 - 1200.\n+ */\n+enum cgx_af_status {\n+\tLMAC_AF_ERR_INVALID_PARAM = -1101,\n+\tLMAC_AF_ERR_PF_NOT_MAPPED = -1102,\n+\tLMAC_AF_ERR_PERM_DENIED = -1103,\n+\tLMAC_AF_ERR_PFC_ENADIS_PERM_DENIED = -1104,\n+\tLMAC_AF_ERR_8023PAUSE_ENADIS_PERM_DENIED = -1105,\n+\tLMAC_AF_ERR_CMD_TIMEOUT = -1106,\n+\tLMAC_AF_ERR_FIRMWARE_DATA_NOT_MAPPED = -1107,\n+\tLMAC_AF_ERR_EXACT_MATCH_TBL_ADD_FAILED = -1108,\n+\tLMAC_AF_ERR_EXACT_MATCH_TBL_DEL_FAILED = -1109,\n+\tLMAC_AF_ERR_EXACT_MATCH_TBL_LOOK_UP_FAILED = -1110,\n+};\n \n struct cgx_stats_rsp {\n \tstruct mbox_msghdr hdr;\ndiff --git a/drivers/common/cnxk/roc_nix_mac.c b/drivers/common/cnxk/roc_nix_mac.c\nindex 754d75ac73..ac30fb52d1 100644\n--- a/drivers/common/cnxk/roc_nix_mac.c\n+++ b/drivers/common/cnxk/roc_nix_mac.c\n@@ -201,14 +201,6 @@ roc_nix_mac_promisc_mode_enable(struct roc_nix *roc_nix, int enable)\n \t\tgoto exit;\n \t}\n \n-\t/* Skip CGX promisc toggling if NPC exact match is enabled as\n-\t * CGX filtering is disabled permanently.\n-\t */\n-\tif (nix->exact_match_ena) {\n-\t\trc = 0;\n-\t\tgoto exit;\n-\t}\n-\n \tif (enable)\n \t\tmbox_alloc_msg_cgx_promisc_enable(mbox);\n \telse\n", "prefixes": [ "06/31" ] }