Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130071/?format=api
{ "id": 130071, "url": "http://patches.dpdk.org/api/patches/130071/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230810100710.1701-1-gmuthukrishn@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230810100710.1701-1-gmuthukrishn@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230810100710.1701-1-gmuthukrishn@marvell.com", "date": "2023-08-10T10:07:10", "name": "app/dma-perf: validate copied memory", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e453351ec79a7b7946401007b5d53295c654164d", "submitter": { "id": 2301, "url": "http://patches.dpdk.org/api/people/2301/?format=api", "name": "Gowrishankar Muthukrishnan", "email": "gmuthukrishn@marvell.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230810100710.1701-1-gmuthukrishn@marvell.com/mbox/", "series": [ { "id": 29150, "url": "http://patches.dpdk.org/api/series/29150/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29150", "date": "2023-08-10T10:07:10", "name": "app/dma-perf: validate copied memory", "version": 1, "mbox": "http://patches.dpdk.org/series/29150/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/130071/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/130071/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E1D154301C;\n\tThu, 10 Aug 2023 12:07:45 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7ABC240DFB;\n\tThu, 10 Aug 2023 12:07:45 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 72F8E40DD8\n for <dev@dpdk.org>; Thu, 10 Aug 2023 12:07:43 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 37A8YU2l021277; Thu, 10 Aug 2023 03:07:42 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3scj5ma81v-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Thu, 10 Aug 2023 03:07:42 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Thu, 10 Aug 2023 03:07:40 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Thu, 10 Aug 2023 03:07:40 -0700", "from BG-LT91401.marvell.com (BG-LT91401.marvell.com [10.28.168.34])\n by maili.marvell.com (Postfix) with ESMTP id 4FFBB3F705B;\n Thu, 10 Aug 2023 03:07:38 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding :\n content-type; s=pfpt0220; bh=rajaIdRKYFAYdr4NZqt+dq7L0NOXvn2db7o0IETia9E=;\n b=FOpNcODFalA5DMc9RvdCmzXlnHwhkSr85tr8gMmN8cIVj/KjQpw/dcnjgBANTZwTxRHf\n gors6WJcVtAeNwuUr0Ggrbeo25bba8h6Cnfh6PcdmYKbrAHsVOxZjv+XWeHQZhnW3llA\n 7qo0nstD4EkxD4nqA8CH1Z0b3/2kC5xsTO8TFZs5bQUTzjpEllZi4E6RFtHCci2+xQtW\n brhNGWwpsFllET/63pyP1oDUgPOwiQEdpbFSM0OtB0/+KqgjXHggyh80vEy0IHUglikT\n LDStuqSjAXeb834trtNAGb9Hx13hG+q33SjSCxyfUsvj+HZeLz04m2xjEVPu61GzDKg+ 8Q==", "From": "Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<anoobj@marvell.com>, Cheng Jiang <cheng1.jiang@intel.com>, \"Gowrishankar\n Muthukrishnan\" <gmuthukrishn@marvell.com>", "Subject": "[PATCH] app/dma-perf: validate copied memory", "Date": "Thu, 10 Aug 2023 15:37:10 +0530", "Message-ID": "<20230810100710.1701-1-gmuthukrishn@marvell.com>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "6A0uvTSgT1kqYagmtOpwjukSwthjizg-", "X-Proofpoint-GUID": "6A0uvTSgT1kqYagmtOpwjukSwthjizg-", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26\n definitions=2023-08-10_09,2023-08-09_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Validate copied memory to ensure DMA copy did not fail.\n\nSigned-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>\nChange-Id: I9f888c061f3d077f6b7b2d8a66c6a7cb7e5f2437\n---\n app/test-dma-perf/benchmark.c | 23 +++++++++++++++++++++--\n app/test-dma-perf/main.c | 16 +++++++++++-----\n app/test-dma-perf/main.h | 2 +-\n 3 files changed, 33 insertions(+), 8 deletions(-)", "diff": "diff --git a/app/test-dma-perf/benchmark.c b/app/test-dma-perf/benchmark.c\nindex 0601e0d171..9e5b5dc770 100644\n--- a/app/test-dma-perf/benchmark.c\n+++ b/app/test-dma-perf/benchmark.c\n@@ -12,6 +12,7 @@\n #include <rte_dmadev.h>\n #include <rte_malloc.h>\n #include <rte_lcore.h>\n+#include <rte_random.h>\n \n #include \"main.h\"\n \n@@ -306,7 +307,7 @@ setup_memory_env(struct test_configure *cfg, struct rte_mbuf ***srcs,\n \t\t\tstruct rte_mbuf ***dsts)\n {\n \tunsigned int buf_size = cfg->buf_size.cur;\n-\tunsigned int nr_sockets;\n+\tunsigned int nr_sockets, i;\n \tuint32_t nr_buf = cfg->nr_buf;\n \n \tnr_sockets = rte_socket_count();\n@@ -360,10 +361,15 @@ setup_memory_env(struct test_configure *cfg, struct rte_mbuf ***srcs,\n \t\treturn -1;\n \t}\n \n+\tfor (i = 0; i < nr_buf; i++) {\n+\t\tmemset(rte_pktmbuf_mtod((*srcs)[i], void *), rte_rand(), buf_size);\n+\t\tmemset(rte_pktmbuf_mtod((*dsts)[i], void *), 0, buf_size);\n+\t}\n+\n \treturn 0;\n }\n \n-void\n+int\n mem_copy_benchmark(struct test_configure *cfg, bool is_dma)\n {\n \tuint16_t i;\n@@ -381,6 +387,7 @@ mem_copy_benchmark(struct test_configure *cfg, bool is_dma)\n \tuint32_t avg_cycles_total;\n \tfloat mops, mops_total;\n \tfloat bandwidth, bandwidth_total;\n+\tint ret = 0;\n \n \tif (setup_memory_env(cfg, &srcs, &dsts) < 0)\n \t\tgoto out;\n@@ -454,6 +461,16 @@ mem_copy_benchmark(struct test_configure *cfg, bool is_dma)\n \n \trte_eal_mp_wait_lcore();\n \n+\tfor (i = 0; i < cfg->nr_buf; i++) {\n+\t\tif (memcmp(rte_pktmbuf_mtod(srcs[i], void *),\n+\t\t\t rte_pktmbuf_mtod(dsts[i], void *),\n+\t\t\t cfg->buf_size.cur) != 0) {\n+\t\t\tprintf(\"Copy validation fails for buffer number %d\\n\", i);\n+\t\t\tret = -1;\n+\t\t\tgoto out;\n+\t\t}\n+\t}\n+\n \tmops_total = 0;\n \tbandwidth_total = 0;\n \tavg_cycles_total = 0;\n@@ -505,4 +522,6 @@ mem_copy_benchmark(struct test_configure *cfg, bool is_dma)\n \t\t\trte_dma_stop(ldm->dma_ids[i]);\n \t\t}\n \t}\n+\n+\treturn ret;\n }\ndiff --git a/app/test-dma-perf/main.c b/app/test-dma-perf/main.c\nindex de37120df6..bbba06ec1b 100644\n--- a/app/test-dma-perf/main.c\n+++ b/app/test-dma-perf/main.c\n@@ -86,20 +86,24 @@ output_header(uint32_t case_id, struct test_configure *case_cfg)\n \toutput_csv(true);\n }\n \n-static void\n+static int\n run_test_case(struct test_configure *case_cfg)\n {\n+\tint ret = 0;\n+\n \tswitch (case_cfg->test_type) {\n \tcase TEST_TYPE_DMA_MEM_COPY:\n-\t\tmem_copy_benchmark(case_cfg, true);\n+\t\tret = mem_copy_benchmark(case_cfg, true);\n \t\tbreak;\n \tcase TEST_TYPE_CPU_MEM_COPY:\n-\t\tmem_copy_benchmark(case_cfg, false);\n+\t\tret = mem_copy_benchmark(case_cfg, false);\n \t\tbreak;\n \tdefault:\n \t\tprintf(\"Unknown test type. %s\\n\", case_cfg->test_type_str);\n \t\tbreak;\n \t}\n+\n+\treturn ret;\n }\n \n static void\n@@ -144,8 +148,10 @@ run_test(uint32_t case_id, struct test_configure *case_cfg)\n \t\tcase_cfg->scenario_id++;\n \t\tprintf(\"\\nRunning scenario %d\\n\", case_cfg->scenario_id);\n \n-\t\trun_test_case(case_cfg);\n-\t\toutput_csv(false);\n+\t\tif (run_test_case(case_cfg) < 0)\n+\t\t\tprintf(\"\\nTest fails! skipping this scenario.\\n\");\n+\t\telse\n+\t\t\toutput_csv(false);\n \n \t\tif (var_entry->op == OP_ADD)\n \t\t\tvar_entry->cur += var_entry->incr;\ndiff --git a/app/test-dma-perf/main.h b/app/test-dma-perf/main.h\nindex 12bc3f4e3f..57a9f71a06 100644\n--- a/app/test-dma-perf/main.h\n+++ b/app/test-dma-perf/main.h\n@@ -59,6 +59,6 @@ struct test_configure {\n \tuint8_t scenario_id;\n };\n \n-void mem_copy_benchmark(struct test_configure *cfg, bool is_dma);\n+int mem_copy_benchmark(struct test_configure *cfg, bool is_dma);\n \n #endif /* _MAIN_H_ */\n", "prefixes": [] }