Patch Comment List
List patch comments
GET /api/patches/130/comments/?format=api
[ { "id": 3296, "web_url": "http://patches.dpdk.org/comment/3296/", "msgid": "<2469278.NhId8OL9C5@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/2469278.NhId8OL9C5@xps13", "date": "2014-11-26T21:18:22", "subject": "Re: [dpdk-dev] [PATCH] table: hash: fix entry size of configurable\n\tkey size ext and lru", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "Hi,\n\n2014-08-11 12:43, Takayuki Usui:\n> Signed-off-by: Takayuki Usui <takayuki@midokura.com>\n> ---\n> lib/librte_table/rte_table_hash_ext.c | 2 +-\n> lib/librte_table/rte_table_hash_lru.c | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/lib/librte_table/rte_table_hash_ext.c b/lib/librte_table/rte_table_hash_ext.c\n> index 6e26d98..8b86fab 100644\n> --- a/lib/librte_table/rte_table_hash_ext.c\n> +++ b/lib/librte_table/rte_table_hash_ext.c\n> @@ -221,7 +221,7 @@ rte_table_hash_ext_create(void *params, int socket_id, uint32_t entry_size)\n> \t/* Internal */\n> \tt->bucket_mask = t->n_buckets - 1;\n> \tt->key_size_shl = __builtin_ctzl(p->key_size);\n> -\tt->data_size_shl = __builtin_ctzl(p->key_size);\n> +\tt->data_size_shl = __builtin_ctzl(entry_size);\n> \n> \t/* Tables */\n> \ttable_meta_offset = 0;\n> diff --git a/lib/librte_table/rte_table_hash_lru.c b/lib/librte_table/rte_table_hash_lru.c\n> index d1a4984..bf92e81 100644\n> --- a/lib/librte_table/rte_table_hash_lru.c\n> +++ b/lib/librte_table/rte_table_hash_lru.c\n> @@ -192,7 +192,7 @@ rte_table_hash_lru_create(void *params, int socket_id, uint32_t entry_size)\n> \t/* Internal */\n> \tt->bucket_mask = t->n_buckets - 1;\n> \tt->key_size_shl = __builtin_ctzl(p->key_size);\n> -\tt->data_size_shl = __builtin_ctzl(p->key_size);\n> +\tt->data_size_shl = __builtin_ctzl(entry_size);\n> \n> \t/* Tables */\n> \ttable_meta_offset = 0;\n\nA similar patch has been recently applied:\n\thttp://dpdk.org/browse/dpdk/commit/?id=8595428e50\n\nCristian, as the author of this library, it would be appreciated that you\nreview and ack such patch. It's important to accept contributions and give\ncredit to the first author of a patch.\n\nThanks", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 3DA437F0C;\n\tWed, 26 Nov 2014 22:18:48 +0100 (CET)", "from mail-wg0-f54.google.com (mail-wg0-f54.google.com\n\t[74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 8794E2E81\n\tfor <dev@dpdk.org>; Wed, 26 Nov 2014 22:18:46 +0100 (CET)", "by mail-wg0-f54.google.com with SMTP id l2so4846851wgh.13\n\tfor <dev@dpdk.org>; Wed, 26 Nov 2014 13:18:46 -0800 (PST)", "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\tq4sm1168754wjo.46.2014.11.26.13.18.44 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 26 Nov 2014 13:18:45 -0800 (PST)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=HVOkCfMdrh3AiEDxGwmJCjiVSCK+OmQN/E2O9VZ8Bn8=;\n\tb=T0Qx5EhYt8/y7YdHdir5JuS0Yl73axLQukWtCZNj6pNhhdtIa0Y2no9OwMdPWkSpnp\n\tci4mHwMwyJ6rPPBB52Kmcw5PjxXuke4lzy8LBJBhyyJp0oHPrEixE94vE2+/NrDTN6xu\n\tk8UcObOO55Wo/jvtUu0c6CtnFcycq8/42foZTWytBp/nR2Bn7c+8VqzaJIvq1X4fSCDo\n\tyaouPSXN6zKQLPu2LZlAERW7xcfLQmY1CW536eadRkhpqeWHT9FNEfRkUQOZ6Jc9c58r\n\tWylC88Lg6FQE2YBLQ+BXfpIqluA0OpDC5eMTd28C4FMDmXXI8eEN63gH01bTP+rE1G7w\n\tV9RQ==", "X-Gm-Message-State": "ALoCoQnrdFN+B5HmZhg+YMk3o1O3gV7FffwVWf8GWO+WXj+8lygou/zf06d/8pjSNB3Y4iPmRaRS", "X-Received": "by 10.180.99.163 with SMTP id er3mr44273515wib.18.1417036726366; \n\tWed, 26 Nov 2014 13:18:46 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Takayuki Usui <takayuki@midokura.com>, cristian.dumitrescu@intel.com", "Date": "Wed, 26 Nov 2014 22:18:22 +0100", "Message-ID": "<2469278.NhId8OL9C5@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; )", "In-Reply-To": "<1407728582-19637-1-git-send-email-takayuki@midokura.com>", "References": "<1407728582-19637-1-git-send-email-takayuki@midokura.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org, balazs.nemeth@intel.com", "Subject": "Re: [dpdk-dev] [PATCH] table: hash: fix entry size of configurable\n\tkey size ext and lru", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 3311, "web_url": "http://patches.dpdk.org/comment/3311/", "msgid": "<3EB4FA525960D640B5BDFFD6A3D89126322D69FB@IRSMSX108.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/3EB4FA525960D640B5BDFFD6A3D89126322D69FB@IRSMSX108.ger.corp.intel.com", "date": "2014-11-27T10:34:59", "subject": "Re: [dpdk-dev] [PATCH] table: hash: fix entry size of configurable\n\tkey size ext and lru", "submitter": { "id": 19, "url": "http://patches.dpdk.org/api/people/19/?format=api", "name": "Cristian Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "content": "Hi Thomas,\n\nYes, we can confirm that this patch is identical to one of the fixes provided by Balazs with his set of patches which were already applied.\n\nSorry for not seeing this patch earlier.\n\nThank you, Takayuki San for doing this work and sending us the patch!\n\nRegards,\nCristian\n\n\n-----Original Message-----\nFrom: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] \nSent: Wednesday, November 26, 2014 9:18 PM\nTo: Takayuki Usui; Dumitrescu, Cristian\nCc: dev@dpdk.org; Nemeth, Balazs\nSubject: Re: [dpdk-dev] [PATCH] table: hash: fix entry size of configurable key size ext and lru\n\nHi,\n\n2014-08-11 12:43, Takayuki Usui:\n> Signed-off-by: Takayuki Usui <takayuki@midokura.com>\n> ---\n> lib/librte_table/rte_table_hash_ext.c | 2 +-\n> lib/librte_table/rte_table_hash_lru.c | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/lib/librte_table/rte_table_hash_ext.c b/lib/librte_table/rte_table_hash_ext.c\n> index 6e26d98..8b86fab 100644\n> --- a/lib/librte_table/rte_table_hash_ext.c\n> +++ b/lib/librte_table/rte_table_hash_ext.c\n> @@ -221,7 +221,7 @@ rte_table_hash_ext_create(void *params, int socket_id, uint32_t entry_size)\n> \t/* Internal */\n> \tt->bucket_mask = t->n_buckets - 1;\n> \tt->key_size_shl = __builtin_ctzl(p->key_size);\n> -\tt->data_size_shl = __builtin_ctzl(p->key_size);\n> +\tt->data_size_shl = __builtin_ctzl(entry_size);\n> \n> \t/* Tables */\n> \ttable_meta_offset = 0;\n> diff --git a/lib/librte_table/rte_table_hash_lru.c b/lib/librte_table/rte_table_hash_lru.c\n> index d1a4984..bf92e81 100644\n> --- a/lib/librte_table/rte_table_hash_lru.c\n> +++ b/lib/librte_table/rte_table_hash_lru.c\n> @@ -192,7 +192,7 @@ rte_table_hash_lru_create(void *params, int socket_id, uint32_t entry_size)\n> \t/* Internal */\n> \tt->bucket_mask = t->n_buckets - 1;\n> \tt->key_size_shl = __builtin_ctzl(p->key_size);\n> -\tt->data_size_shl = __builtin_ctzl(p->key_size);\n> +\tt->data_size_shl = __builtin_ctzl(entry_size);\n> \n> \t/* Tables */\n> \ttable_meta_offset = 0;\n\nA similar patch has been recently applied:\n\thttp://dpdk.org/browse/dpdk/commit/?id=8595428e50\n\nCristian, as the author of this library, it would be appreciated that you\nreview and ack such patch. It's important to accept contributions and give\ncredit to the first author of a patch.\n\nThanks", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id EFF255927;\n\tThu, 27 Nov 2014 11:35:27 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 1B18A2E81\n\tfor <dev@dpdk.org>; Thu, 27 Nov 2014 11:35:24 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga101.jf.intel.com with ESMTP; 27 Nov 2014 02:35:04 -0800", "from irsmsx109.ger.corp.intel.com ([163.33.3.23])\n\tby orsmga002.jf.intel.com with ESMTP; 27 Nov 2014 02:35:00 -0800", "from irsmsx108.ger.corp.intel.com ([169.254.11.150]) by\n\tIRSMSX109.ger.corp.intel.com ([169.254.13.244]) with mapi id\n\t14.03.0195.001; Thu, 27 Nov 2014 10:34:59 +0000" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.07,468,1413270000\"; d=\"scan'208\";a=\"644449355\"", "From": "\"Dumitrescu, Cristian\" <cristian.dumitrescu@intel.com>", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>, Takayuki Usui\n\t<takayuki@midokura.com>", "Thread-Topic": "[dpdk-dev] [PATCH] table: hash: fix entry size of configurable\n\tkey size ext and lru", "Thread-Index": "AQHQCb6V15zHHgkGUU6xW/F3Vk4/NZx0RL/Q", "Date": "Thu, 27 Nov 2014 10:34:59 +0000", "Message-ID": "<3EB4FA525960D640B5BDFFD6A3D89126322D69FB@IRSMSX108.ger.corp.intel.com>", "References": "<1407728582-19637-1-git-send-email-takayuki@midokura.com>\n\t<2469278.NhId8OL9C5@xps13>", "In-Reply-To": "<2469278.NhId8OL9C5@xps13>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[163.33.239.182]", "Content-Type": "text/plain; charset=\"us-ascii\"", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>, \"Nemeth, Balazs\" <balazs.nemeth@intel.com>", "Subject": "Re: [dpdk-dev] [PATCH] table: hash: fix entry size of configurable\n\tkey size ext and lru", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 3312, "web_url": "http://patches.dpdk.org/comment/3312/", "msgid": "<3EB4FA525960D640B5BDFFD6A3D89126322D6A19@IRSMSX108.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/3EB4FA525960D640B5BDFFD6A3D89126322D6A19@IRSMSX108.ger.corp.intel.com", "date": "2014-11-27T10:38:20", "subject": "Re: [dpdk-dev] [PATCH] table: hash: fix entry size of configurable\n\tkey size ext and lru", "submitter": { "id": 19, "url": "http://patches.dpdk.org/api/people/19/?format=api", "name": "Cristian Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "content": "Acked by: Cristian Dumitrescu <Cristian.Dumitrescu at intel.com>\n\n-----Original Message-----\nFrom: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] \nSent: Wednesday, November 26, 2014 9:18 PM\nTo: Takayuki Usui; Dumitrescu, Cristian\nCc: dev@dpdk.org; Nemeth, Balazs\nSubject: Re: [dpdk-dev] [PATCH] table: hash: fix entry size of configurable key size ext and lru\n\nHi,\n\n2014-08-11 12:43, Takayuki Usui:\n> Signed-off-by: Takayuki Usui <takayuki@midokura.com>\n> ---\n> lib/librte_table/rte_table_hash_ext.c | 2 +-\n> lib/librte_table/rte_table_hash_lru.c | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/lib/librte_table/rte_table_hash_ext.c b/lib/librte_table/rte_table_hash_ext.c\n> index 6e26d98..8b86fab 100644\n> --- a/lib/librte_table/rte_table_hash_ext.c\n> +++ b/lib/librte_table/rte_table_hash_ext.c\n> @@ -221,7 +221,7 @@ rte_table_hash_ext_create(void *params, int socket_id, uint32_t entry_size)\n> \t/* Internal */\n> \tt->bucket_mask = t->n_buckets - 1;\n> \tt->key_size_shl = __builtin_ctzl(p->key_size);\n> -\tt->data_size_shl = __builtin_ctzl(p->key_size);\n> +\tt->data_size_shl = __builtin_ctzl(entry_size);\n> \n> \t/* Tables */\n> \ttable_meta_offset = 0;\n> diff --git a/lib/librte_table/rte_table_hash_lru.c b/lib/librte_table/rte_table_hash_lru.c\n> index d1a4984..bf92e81 100644\n> --- a/lib/librte_table/rte_table_hash_lru.c\n> +++ b/lib/librte_table/rte_table_hash_lru.c\n> @@ -192,7 +192,7 @@ rte_table_hash_lru_create(void *params, int socket_id, uint32_t entry_size)\n> \t/* Internal */\n> \tt->bucket_mask = t->n_buckets - 1;\n> \tt->key_size_shl = __builtin_ctzl(p->key_size);\n> -\tt->data_size_shl = __builtin_ctzl(p->key_size);\n> +\tt->data_size_shl = __builtin_ctzl(entry_size);\n> \n> \t/* Tables */\n> \ttable_meta_offset = 0;\n\nA similar patch has been recently applied:\n\thttp://dpdk.org/browse/dpdk/commit/?id=8595428e50\n\nCristian, as the author of this library, it would be appreciated that you\nreview and ack such patch. It's important to accept contributions and give\ncredit to the first author of a patch.\n\nThanks", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 1A7027F41;\n\tThu, 27 Nov 2014 11:38:27 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id C26DC5927\n\tfor <dev@dpdk.org>; Thu, 27 Nov 2014 11:38:24 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga102.jf.intel.com with ESMTP; 27 Nov 2014 02:35:54 -0800", "from irsmsx109.ger.corp.intel.com ([163.33.3.23])\n\tby orsmga002.jf.intel.com with ESMTP; 27 Nov 2014 02:38:22 -0800", "from irsmsx108.ger.corp.intel.com ([169.254.11.150]) by\n\tIRSMSX109.ger.corp.intel.com ([169.254.13.244]) with mapi id\n\t14.03.0195.001; Thu, 27 Nov 2014 10:38:21 +0000" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.07,468,1413270000\"; d=\"scan'208\";a=\"644450523\"", "From": "\"Dumitrescu, Cristian\" <cristian.dumitrescu@intel.com>", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>, Takayuki Usui\n\t<takayuki@midokura.com>", "Thread-Topic": "[dpdk-dev] [PATCH] table: hash: fix entry size of configurable\n\tkey size ext and lru", "Thread-Index": "AQHQCb6V15zHHgkGUU6xW/F3Vk4/NZx0SLFA", "Date": "Thu, 27 Nov 2014 10:38:20 +0000", "Message-ID": "<3EB4FA525960D640B5BDFFD6A3D89126322D6A19@IRSMSX108.ger.corp.intel.com>", "References": "<1407728582-19637-1-git-send-email-takayuki@midokura.com>\n\t<2469278.NhId8OL9C5@xps13>", "In-Reply-To": "<2469278.NhId8OL9C5@xps13>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[163.33.239.182]", "Content-Type": "text/plain; charset=\"us-ascii\"", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>, \"Nemeth, Balazs\" <balazs.nemeth@intel.com>", "Subject": "Re: [dpdk-dev] [PATCH] table: hash: fix entry size of configurable\n\tkey size ext and lru", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]