Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129943/?format=api
{ "id": 129943, "url": "http://patches.dpdk.org/api/patches/129943/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230808113221.227319-1-yajunw@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230808113221.227319-1-yajunw@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230808113221.227319-1-yajunw@nvidia.com", "date": "2023-08-08T11:32:21", "name": "vdpa/mlx5: fix unregister kick handler order", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "461c63fac488238172412292c6ce92ae5e1da350", "submitter": { "id": 2517, "url": "http://patches.dpdk.org/api/people/2517/?format=api", "name": "Yajun Wu", "email": "yajunw@nvidia.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230808113221.227319-1-yajunw@nvidia.com/mbox/", "series": [ { "id": 29130, "url": "http://patches.dpdk.org/api/series/29130/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29130", "date": "2023-08-08T11:32:21", "name": "vdpa/mlx5: fix unregister kick handler order", "version": 1, "mbox": "http://patches.dpdk.org/series/29130/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/129943/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/129943/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9DB1C4300B;\n\tTue, 8 Aug 2023 13:33:09 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C50DF43252;\n\tTue, 8 Aug 2023 13:33:08 +0200 (CEST)", "from NAM10-BN7-obe.outbound.protection.outlook.com\n (mail-bn7nam10on2076.outbound.protection.outlook.com [40.107.92.76])\n by mails.dpdk.org (Postfix) with ESMTP id 869BD40A87;\n Tue, 8 Aug 2023 13:33:07 +0200 (CEST)", "from DS7PR03CA0186.namprd03.prod.outlook.com (2603:10b6:5:3b6::11)\n by CY5PR12MB6384.namprd12.prod.outlook.com (2603:10b6:930:3c::8) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug\n 2023 11:33:05 +0000", "from CY4PEPF0000EDD5.namprd03.prod.outlook.com\n (2603:10b6:5:3b6:cafe::56) by DS7PR03CA0186.outlook.office365.com\n (2603:10b6:5:3b6::11) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27 via Frontend\n Transport; Tue, 8 Aug 2023 11:33:05 +0000", "from mail.nvidia.com (216.228.117.161) by\n CY4PEPF0000EDD5.mail.protection.outlook.com (10.167.241.209) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6652.19 via Frontend Transport; Tue, 8 Aug 2023 11:33:05 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Tue, 8 Aug 2023\n 04:32:53 -0700", "from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Tue, 8 Aug 2023\n 04:32:50 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=QCwYJnbxI84YosnbBpWpX4RhQkG/uG0++qTMLRH9FLp/EoVR4obY+KqoUD73DM6L1f32hezwTWEzmoANcVY/wkFMdE1JxUg+9ECRQU/MPWFkueeNDfn0TtOzJw9sOz2SFpHFoLIrweK6s0+6LDEvwgj1k8XGDpCLC8OX3TQnw2a40m2b0+12nXHulbT9N367nBFu5IoAw40o5cUQqvY6gvkwQKpI+VaBI2u5JGjJ4C0IADhUDKMnMyUrObkZ01hDVslTKSujO461F37BWyYqKtOlE3haESYZ5gEV7V1A3Xjr9WDjsbsQ/jnFV7IgBT3A1JhALTDLV1IN8O3piXl2iQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=ilhw4ZJstWlaOlhF+2sDq14YtEO0nfNqiyzC3F0l/pk=;\n b=BkpS3mMC5rZZG74Z7bKcs9zDr3H16STDPHtEsSAESO0mpMz91kyeDyi1v7EIbIWg0iXClv9Ef0QkA8j+9CwtsTsk+zz3yTOTQIjVtDnGae409R5ihd4EIKsalioxWX+ny27M4RJ+XORWVNZj+squnbJOEdqBfCEwxApgKUHBCSBC/KTIBkaH7PMOUr34TCJ5FlTkWHprcsCFA2CFi0QGTE4iATNOg9uUFqSkXPPJp9dbT0NCjbMi6YWq0DwGYY9Lvam8QdmflbCBzq9WuLpEoSumZx2Kz7nxDDQoDDJ9fnfEmoYp2fPZ3Ok43Vu82HlKlWoeeFu+zKpfCVS7jM9wug==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=ilhw4ZJstWlaOlhF+2sDq14YtEO0nfNqiyzC3F0l/pk=;\n b=if89yZKcymudg/JMPgvSGZS7GwHt2Egw9biPuMi3F35HbfC6d1wgj1nUQ9WedsHhW7+q/AhrgpJFLxegi1c2kcxo4LUfbJNulBvv5MzGKJguIodmj9VZjJ0RpQ5xjoKqjNAzkmncsczAu9Bb53HQ82gv0a8zdvLio1ZHhjYTG9xBV2ai39iYjMylHf+z/1MMjJSLR7+kOYso5vB+hIhBcJ9OYbNK6RFdeJT7AmcYVmyV6W0RIfXUWs1q9yPRNm47kKPUPvqJDP+iRlOL57EHpD9VH4eeygvuvYeIIizI/qkcPkQIIz2qB568B/fPG/piy0W/V/tapwoS3e1RKiza/A==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C", "From": "Yajun Wu <yajunw@nvidia.com>", "To": "<matan@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, \"Maxime\n Coquelin\" <maxime.coquelin@redhat.com>, Li Zhang <lizh@nvidia.com>", "CC": "<dev@dpdk.org>, <thomas@monjalon.net>, <rasland@nvidia.com>,\n <roniba@nvidia.com>, <stable@dpdk.org>", "Subject": "[PATCH] vdpa/mlx5: fix unregister kick handler order", "Date": "Tue, 8 Aug 2023 19:32:21 +0800", "Message-ID": "<20230808113221.227319-1-yajunw@nvidia.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.230.35]", "X-ClientProxiedBy": "rnnvmail201.nvidia.com (10.129.68.8) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CY4PEPF0000EDD5:EE_|CY5PR12MB6384:EE_", "X-MS-Office365-Filtering-Correlation-Id": "19ee28be-4dd6-44b8-4c39-08db98033b77", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n crYDzdpJn1pbOYnm0aVqrZGXLYQsS8+R9cU77NR26vbONJ51h6yn6HkdXAFROIh8oVMcuFibh7AzVYpwrTreBR2vLvvLdBX9bcB3ig+tMUiMvxNGIl5slt6oRpufgf3o0OtbQea4cYnj0my4V+KvZtBIUjD3DJHd0mMJnz27tTJPCjDqhv+Co6pFRQjzmQF5IIQV703y8Wg5PynKuGIf2lfjcXH908D80GPKGwrqz14S3HDMb1j6mM6CINOaOIEQR6CXGU4sPzXeHmBJxrYWPSDC3BoPmCthShxklZLAoe8zKbBDySssLKFz9sjLydaJGjGmY5fe9uHsL119gjUUadG6Y/kP+SxMnixwbClhjSbCMY/FfoY+kYI9+do5yXVQA6iZsT2OcrJPAEUUPlnxdfeX71wImFXzvK3MQClQdICbIOjjBW6uGjzJoMGlzfLVpj8bMlHbUXsKPB1T4VtvBQaQY/2hpsG6JdtbXJQl/kPqS2Fg7Q2+O5Oq12YGmIvkEXHaMqfUxNFHvmti2OGsc8RRz1OSYlAVgXHcT8d1z0K8wSWia47Uri6Z0etdB1Mg304CnhcMQ01YiP7nj5fxqE01l8p+4U8YBfja7duRIXdb9fiNnIx61BT9gF0KjSDqdPTUSOqJelmvM2gpJgTSliWD1yGxWGLwgwfEassGs58FU+TLbvbzsG1LSw+fxyvP4MJfjqjogY+1JRIsb63rvbZU3NgwejRZbplSBMq6CeQZm0e2EtujJSHVIBcxjrqF", "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230028)(4636009)(136003)(346002)(376002)(39860400002)(396003)(186006)(1800799003)(451199021)(82310400008)(40470700004)(36840700001)(46966006)(2616005)(36756003)(26005)(1076003)(7696005)(6666004)(478600001)(356005)(7636003)(54906003)(82740400003)(110136005)(336012)(16526019)(6286002)(70586007)(70206006)(6636002)(4326008)(316002)(41300700001)(426003)(8936002)(8676002)(5660300002)(40460700003)(2906002)(36860700001)(83380400001)(86362001)(47076005)(40480700001)(55016003);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "08 Aug 2023 11:33:05.1648 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 19ee28be-4dd6-44b8-4c39-08db98033b77", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CY4PEPF0000EDD5.namprd03.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CY5PR12MB6384", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The mlx5_vdpa_virtq_kick_handler function may still be running and waiting\non virtq->virtq_lock while mlx5_vdpa_cqe_event_unset function is trying to\nre-initialize the virtq->virtq_lock.\n\nThis causes mlx5_vdpa_virtq_kick_handler thread can't be wake up and can't\nbe unregister. Following print may loop forever when calling\nrte_vhost_driver_unregister(socket_path):\n\n mlx5_vdpa: Try again to unregister fd 154 of virtq 11 interrupt\n mlx5_vdpa: Try again to unregister fd 154 of virtq 11 interrupt\n ...\n\nThe fix is to move mlx5_vdpa_virtq_unregister_intr_handle before\nmlx5_vdpa_cqe_event_unset.\n\nFixes: 057f7d2084 (\"vdpa/mlx5: optimize datapath-control synchronization\")\nCc: stable@dpdk.org\n\nSigned-off-by: Yajun Wu <yajunw@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/vdpa/mlx5/mlx5_vdpa.c | 1 +\n drivers/vdpa/mlx5/mlx5_vdpa_cthread.c | 1 -\n 2 files changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c\nindex f1737f82a8..8b1de8bd62 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa.c\n@@ -282,6 +282,7 @@ _internal_mlx5_vdpa_dev_close(struct mlx5_vdpa_priv *priv,\n \tint ret = 0;\n \tint vid = priv->vid;\n \n+\tmlx5_vdpa_virtq_unreg_intr_handle_all(priv);\n \tmlx5_vdpa_cqe_event_unset(priv);\n \tif (priv->state == MLX5_VDPA_STATE_CONFIGURED) {\n \t\tret |= mlx5_vdpa_lm_log(priv);\ndiff --git a/drivers/vdpa/mlx5/mlx5_vdpa_cthread.c b/drivers/vdpa/mlx5/mlx5_vdpa_cthread.c\nindex 6e6624e5a3..1d84e422d4 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa_cthread.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa_cthread.c\n@@ -190,7 +190,6 @@ mlx5_vdpa_c_thread_handle(void *arg)\n \t\t\tpthread_mutex_unlock(&virtq->virtq_lock);\n \t\t\tbreak;\n \t\tcase MLX5_VDPA_TASK_DEV_CLOSE_NOWAIT:\n-\t\t\tmlx5_vdpa_virtq_unreg_intr_handle_all(priv);\n \t\t\tpthread_mutex_lock(&priv->steer_update_lock);\n \t\t\tmlx5_vdpa_steer_unset(priv);\n \t\t\tpthread_mutex_unlock(&priv->steer_update_lock);\n", "prefixes": [] }