Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129914/?format=api
{ "id": 129914, "url": "http://patches.dpdk.org/api/patches/129914/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230804164156.118331-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230804164156.118331-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230804164156.118331-2-stephen@networkplumber.org", "date": "2023-08-04T16:41:56", "name": "[2/2] net/bnxt: remove unnecessary check for null before free", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "600901de93705c4757e99274ce26a7da5987101c", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230804164156.118331-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 29114, "url": "http://patches.dpdk.org/api/series/29114/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29114", "date": "2023-08-04T16:41:55", "name": "[1/2] app/test: remove unnecessary null check before free", "version": 1, "mbox": "http://patches.dpdk.org/series/29114/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/129914/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/129914/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E9FD142FD6;\n\tFri, 4 Aug 2023 18:42:14 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DDDD643247;\n\tFri, 4 Aug 2023 18:42:10 +0200 (CEST)", "from mail-pf1-f176.google.com (mail-pf1-f176.google.com\n [209.85.210.176])\n by mails.dpdk.org (Postfix) with ESMTP id A600240EE1\n for <dev@dpdk.org>; Fri, 4 Aug 2023 18:42:09 +0200 (CEST)", "by mail-pf1-f176.google.com with SMTP id\n d2e1a72fcca58-686b91c2744so1705450b3a.0\n for <dev@dpdk.org>; Fri, 04 Aug 2023 09:42:09 -0700 (PDT)", "from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207])\n by smtp.gmail.com with ESMTPSA id\n k188-20020a633dc5000000b0056420d3cd20sm1361356pga.71.2023.08.04.09.42.07\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 04 Aug 2023 09:42:08 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1691167328;\n x=1691772128;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=DSV+SsTo/8KBtkmUplEZqD7+GIgTAYMHWPBS5sHOQkE=;\n b=LLMklf4AfnbFeZRxmEFzuHrJweb1kRvSPOxOTWnnStA+Q9H3ws6zSQWNpnCHSWgWb7\n v273FKqW07bQyLPpdGhUeYVM3E+li9fUKfeOILuc8kEWHA7/S14ORkipS+x55i/bfJCR\n V6AXgC2pF/RQMUBNJ/WbdABvO49Zbh9atuGVxjRLoHsPRvTy0MAasFz+8R1o4qCx+ndo\n UV1hmb7+YkqXlC5HQ7tHdLZbFR6h+n4z9bKIC3LfHIirzsxsmI1OHnijnftaBPNsUJg0\n MMkYzdfQU4yt17lYd43mr0aY3nTMOierXUsSi/NTpfcwQuKVA3GRpC0+YOb8Bx4ll6Rp\n JBpg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1691167328; x=1691772128;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=DSV+SsTo/8KBtkmUplEZqD7+GIgTAYMHWPBS5sHOQkE=;\n b=Po203pAx6r31fyNJmbb1Sc7xOjPba3xoujUdp4Z08Eu9ha35pEloXpml5AgvCXO+MW\n QwQ9f/zjhE4r+R+WmOqb9DsR6PXeqNMTmDMmP5JrUmADiuFmggbImZXda/kKG1n93CUy\n G28eeKjTGPC6DYDRlti4tHUnPEiTf5tPCssLUZ6J5lI9/jghsq6wV4oyVHoixmOtfFpT\n +aJsZaiojT2/lFzbzmBpI6L99NZcfKGK96N0xpvSZWyVowBtl7ltGn0H1g9zD+HN2y0f\n dZdCExtvExiWJXIJ/iOXQBC6yHjhrZbEHYXOPkgS9OPRxi6NlYxaIrpRyJXg5ez8p5jd\n 5pQw==", "X-Gm-Message-State": "AOJu0Ywal7pOzuQ3ln5ubXUxPdQJPZU+LGNNS/Vwvob57/AEpgaYb/Mr\n BDVb/uJCwa7+5zfCSB0fixIc6sje42MFQonYyKbtRg==", "X-Google-Smtp-Source": "\n AGHT+IGMj25kWAWmWnHkfog4wMrGXqlOBTPWbhNWq1YlTGLki+9ocLPlCGyMZbUNRo1NJAMM0hUW7A==", "X-Received": "by 2002:a05:6a00:2e0f:b0:687:3f06:5939 with SMTP id\n fc15-20020a056a002e0f00b006873f065939mr2498902pfb.32.1691167328644;\n Fri, 04 Aug 2023 09:42:08 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>", "Subject": "[PATCH 2/2] net/bnxt: remove unnecessary check for null before free", "Date": "Fri, 4 Aug 2023 09:41:56 -0700", "Message-Id": "<20230804164156.118331-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230804164156.118331-1-stephen@networkplumber.org>", "References": "<20230804164156.118331-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "No need to check for null pointer before calling rte_free().\nFound by cocci/nullfree.cocci script.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 3 +--\n drivers/net/bnxt/bnxt_vnic.c | 3 +--\n 2 files changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex ee1552452a11..ec8e441a6d05 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -6002,8 +6002,7 @@ static void bnxt_free_ctx_mem_buf(struct bnxt_ctx_mem_buf_info *ctx)\n \tif (!ctx)\n \t\treturn;\n \n-\tif (ctx->va)\n-\t\trte_free(ctx->va);\n+\trte_free(ctx->va);\n \n \tctx->va = NULL;\n \tctx->dma = RTE_BAD_IOVA;\ndiff --git a/drivers/net/bnxt/bnxt_vnic.c b/drivers/net/bnxt/bnxt_vnic.c\nindex 2be456956ddc..f86d27fd7965 100644\n--- a/drivers/net/bnxt/bnxt_vnic.c\n+++ b/drivers/net/bnxt/bnxt_vnic.c\n@@ -847,8 +847,7 @@ bnxt_vnic_rss_hash_algo_update(struct bnxt *bp,\n \n int32_t bnxt_vnic_queue_db_deinit(struct bnxt *bp)\n {\n-\tif (bp->vnic_queue_db.rss_q_db != NULL)\n-\t\trte_hash_free(bp->vnic_queue_db.rss_q_db);\n+\trte_hash_free(bp->vnic_queue_db.rss_q_db);\n \treturn 0;\n }\n \n", "prefixes": [ "2/2" ] }