Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129913/?format=api
{ "id": 129913, "url": "http://patches.dpdk.org/api/patches/129913/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230804164156.118331-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230804164156.118331-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230804164156.118331-1-stephen@networkplumber.org", "date": "2023-08-04T16:41:55", "name": "[1/2] app/test: remove unnecessary null check before free", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7f084c410862f96c41193058c116cc984a30dc66", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230804164156.118331-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 29114, "url": "http://patches.dpdk.org/api/series/29114/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29114", "date": "2023-08-04T16:41:55", "name": "[1/2] app/test: remove unnecessary null check before free", "version": 1, "mbox": "http://patches.dpdk.org/series/29114/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/129913/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/129913/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5864142FD6;\n\tFri, 4 Aug 2023 18:42:10 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E343540EF1;\n\tFri, 4 Aug 2023 18:42:09 +0200 (CEST)", "from mail-pf1-f169.google.com (mail-pf1-f169.google.com\n [209.85.210.169])\n by mails.dpdk.org (Postfix) with ESMTP id F0B9240EE1\n for <dev@dpdk.org>; Fri, 4 Aug 2023 18:42:08 +0200 (CEST)", "by mail-pf1-f169.google.com with SMTP id\n d2e1a72fcca58-686f94328a4so1591600b3a.0\n for <dev@dpdk.org>; Fri, 04 Aug 2023 09:42:08 -0700 (PDT)", "from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207])\n by smtp.gmail.com with ESMTPSA id\n k188-20020a633dc5000000b0056420d3cd20sm1361356pga.71.2023.08.04.09.42.06\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 04 Aug 2023 09:42:06 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1691167327;\n x=1691772127;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=IJZkIxO7UjaaKnH5XVrv0eS4v9RXyL5HHQaWeWLajSk=;\n b=ukSwd92BR7LOI6oZLUCKAFMMd2ZZ+oqPsMADLYaf7HX2IBC03PMDbRRA83+D9yHI5D\n rRfccQ+SuTpP3IUtJbowtb2wEAJ53uboeEvw+BfiA3MufLXCYQN80jgWA8f5f2mvreZm\n Ie9tDIN9gMBxku9/rShhTYqXBk3kIiAJ9LFxkj7u3QfyQSebhvXo6dJoeg3Ky8G0srWn\n 1sJpZ2MCi4hdtw1i3p6S1bio0/TsSnt/bM6GiSnkB0Sg7up1cKtzLAGAID0jFrJKg5Fn\n tQtYijVbP5xB1mOsXuN02O0gOuezt1qv9cU1vMF6ttN1sJE5XjyN59u27vCF17GmUn1N\n pq+g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1691167327; x=1691772127;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=IJZkIxO7UjaaKnH5XVrv0eS4v9RXyL5HHQaWeWLajSk=;\n b=GPuCgeeZIAWtSOiTCFzQOgDnKVpBn90nOjxH7sVcKxBYWZSCjkJRg7PXK7J69BPKDx\n BXECWECY7XqSFG0sx8I7PhwJaOB7a+PKO1toi+jZkdYsFdmVFPRnAlMedWcvQ2+eVqKI\n ZNzJgwFsfJWn9xeCvTNfySTOSxWf6ZZLSu5kfIQdqp9rXVwj0hEXFSerbKJ/p9nJVDAa\n Wc7yesBiO07tDIvoQX43pw+l8Aw6DOwnnje40uwv2thtaEgCi2LDLTeMrMxe8THgPcOE\n ZxYX7jCagLoCBz4x1sMkBI/5s5ntRnbiKIA9P0WZTnbwv8EzNUjiK4Z6nk2qO9uMo+8/\n AntA==", "X-Gm-Message-State": "AOJu0YyhB9m1WhHN7gDK+FvZUFdP5T/2+gvZLatUu3kyST0yGgp1RYHw\n DDlYW4ChPzYSJx7Be3Ekezju0/fVUqhwoOjXoWAlzg==", "X-Google-Smtp-Source": "\n AGHT+IGRBRQl9qIMJrvn5uJ6k6jGSEhEskQqmPGJvmjBaZNNIE+LUuWmBEEY5+yhJnxDrdMS9OvkJg==", "X-Received": "by 2002:a05:6a20:8f0c:b0:138:68b9:138e with SMTP id\n b12-20020a056a208f0c00b0013868b9138emr319428pzk.8.1691167327572;\n Fri, 04 Aug 2023 09:42:07 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Akhil Goyal <gakhil@marvell.com>, Fan Zhang <fanzhang.oss@gmail.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>", "Subject": "[PATCH 1/2] app/test: remove unnecessary null check before free", "Date": "Fri, 4 Aug 2023 09:41:55 -0700", "Message-Id": "<20230804164156.118331-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "No need to check for NULL pointer before calling these functions\nFound by cocci/nullfree.cocci.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/test/test_cryptodev_asym.c | 3 +--\n app/test/test_reassembly_perf.c | 3 +--\n 2 files changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c\nindex 0ef2642fdd2b..c43a063b8262 100644\n--- a/app/test/test_cryptodev_asym.c\n+++ b/app/test/test_cryptodev_asym.c\n@@ -565,8 +565,7 @@ ut_teardown_asym(void)\n \n \tif (self->sess != NULL)\n \t\trte_cryptodev_asym_session_free(dev_id, self->sess);\n-\tif (self->op != NULL)\n-\t\trte_crypto_op_free(self->op);\n+\trte_crypto_op_free(self->op);\n \tself->sess = NULL;\n \tself->op = NULL;\n \tself->result_op = NULL;\ndiff --git a/app/test/test_reassembly_perf.c b/app/test/test_reassembly_perf.c\nindex c11b65291fec..3af104b67348 100644\n--- a/app/test/test_reassembly_perf.c\n+++ b/app/test/test_reassembly_perf.c\n@@ -81,8 +81,7 @@ reassembly_test_teardown(void)\n \tif (frag_tbl != NULL)\n \t\trte_ip_frag_table_destroy(frag_tbl);\n \n-\tif (pkt_pool != NULL)\n-\t\trte_mempool_free(pkt_pool);\n+\trte_mempool_free(pkt_pool);\n }\n \n static void\n", "prefixes": [ "1/2" ] }