Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 129534,
    "url": "http://patches.dpdk.org/api/patches/129534/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230713224002.5667-1-ivan.malov@arknetworks.am/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230713224002.5667-1-ivan.malov@arknetworks.am>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230713224002.5667-1-ivan.malov@arknetworks.am",
    "date": "2023-07-13T22:40:02",
    "name": "[1/1] net/sfc: drop redundant null check from IPv4 flow item parse",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "0293e22b6389b3844806715a5cc8b3f23731bf57",
    "submitter": {
        "id": 2962,
        "url": "http://patches.dpdk.org/api/people/2962/?format=api",
        "name": "Ivan Malov",
        "email": "ivan.malov@arknetworks.am"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230713224002.5667-1-ivan.malov@arknetworks.am/mbox/",
    "series": [
        {
            "id": 28937,
            "url": "http://patches.dpdk.org/api/series/28937/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28937",
            "date": "2023-07-13T22:40:02",
            "name": "[1/1] net/sfc: drop redundant null check from IPv4 flow item parse",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/28937/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/129534/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/129534/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 282C142E68;\n\tFri, 14 Jul 2023 00:40:13 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AC76F406B8;\n\tFri, 14 Jul 2023 00:40:12 +0200 (CEST)",
            "from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80])\n by mails.dpdk.org (Postfix) with ESMTP id E9D1E40685;\n Fri, 14 Jul 2023 00:40:10 +0200 (CEST)",
            "from localhost.localdomain (unknown [78.109.74.134])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by agw.arknetworks.am (Postfix) with ESMTPSA id 14E13E0922;\n Fri, 14 Jul 2023 02:40:10 +0400 (+04)"
        ],
        "From": "Ivan Malov <ivan.malov@arknetworks.am>",
        "To": "dev@dpdk.org",
        "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Ferruh Yigit <ferruh.yigit@amd.com>,\n Artemii Morozov <artemii.morozov@arknetworks.am>, stable@dpdk.org",
        "Subject": "[PATCH 1/1] net/sfc: drop redundant null check from IPv4 flow item\n parse",
        "Date": "Fri, 14 Jul 2023 02:40:02 +0400",
        "Message-Id": "<20230713224002.5667-1-ivan.malov@arknetworks.am>",
        "X-Mailer": "git-send-email 2.39.2",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Such check is already done at an earlier point, in\nsfc_flow_parse_pattern(), so remove it from IPv4\nitem parser. Doing so should fix Coverity issue.\n\nCoverity issue: 395526\nFixes: f79ce621e963 (\"net/sfc: support IPv4 fragment matching in transfer rules\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ivan Malov <ivan.malov@arknetworks.am>\n---\n drivers/net/sfc/sfc_mae.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c\nindex 63f6536243..60a54fd425 100644\n--- a/drivers/net/sfc/sfc_mae.c\n+++ b/drivers/net/sfc/sfc_mae.c\n@@ -2331,7 +2331,7 @@ sfc_mae_rule_parse_item_ipv4(const struct rte_flow_item *item,\n \tif (ctx_mae->match_spec != ctx_mae->match_spec_action)\n \t\tsupp_mask.hdr.fragment_offset = 0;\n \n-\tif (item != NULL && item->last != NULL) {\n+\tif (item->last != NULL) {\n \t\tlast = item->last;\n \t\titem_dup.last = NULL;\n \t}\n",
    "prefixes": [
        "1/1"
    ]
}