Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129366/?format=api
{ "id": 129366, "url": "http://patches.dpdk.org/api/patches/129366/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1688689077-5557-1-git-send-email-longli@linuxonhyperv.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1688689077-5557-1-git-send-email-longli@linuxonhyperv.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1688689077-5557-1-git-send-email-longli@linuxonhyperv.com", "date": "2023-07-07T00:17:57", "name": "net/mana: fix wrong indexing on CQE error when coalescing is used", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5fe388719e56c3cd472f82a4dc05c6bfddd9b066", "submitter": { "id": 1784, "url": "http://patches.dpdk.org/api/people/1784/?format=api", "name": "Long Li", "email": "longli@linuxonhyperv.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1688689077-5557-1-git-send-email-longli@linuxonhyperv.com/mbox/", "series": [ { "id": 28869, "url": "http://patches.dpdk.org/api/series/28869/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28869", "date": "2023-07-07T00:17:57", "name": "net/mana: fix wrong indexing on CQE error when coalescing is used", "version": 1, "mbox": "http://patches.dpdk.org/series/28869/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/129366/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/129366/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E576442DEF;\n\tFri, 7 Jul 2023 02:18:05 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6DD0D406B5;\n\tFri, 7 Jul 2023 02:18:05 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id B9BA840685\n for <dev@dpdk.org>; Fri, 7 Jul 2023 02:18:03 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1004)\n id CB3FD20AECAD; Thu, 6 Jul 2023 17:18:02 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com CB3FD20AECAD", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxonhyperv.com;\n s=default; t=1688689082;\n bh=d+yoOfhBTrZb5CXUlMUPZg2xsEKCdWJwGCcm+i4Bouw=;\n h=From:To:Cc:Subject:Date:From;\n b=JcPJCDkskWigm5UKlytWHbBseZgzvVVO9qAjAJ21HYByud1nfqG5qKCCABAuRTdeg\n qCQRTGHJQy6qnZCZ2Ez73Kv5uudmNd2X2jbh85Zh96KleuzhzguGNt7ThvR+0lLPIb\n KSRnfEkfuuT6Hr3jf4+U2hIAhdH2OzMMbpZWEX60=", "From": "longli@linuxonhyperv.com", "To": "Ferruh Yigit <ferruh.yigit@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "Cc": "dev@dpdk.org, Ajay Sharma <sharmaajay@microsoft.com>,\n Long Li <longli@microsoft.com>", "Subject": "[PATCH] net/mana: fix wrong indexing on CQE error when coalescing is\n used", "Date": "Thu, 6 Jul 2023 17:17:57 -0700", "Message-Id": "<1688689077-5557-1-git-send-email-longli@linuxonhyperv.com>", "X-Mailer": "git-send-email 1.8.3.1", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Long Li <longli@microsoft.com>\n\nOn a fatal CQE error when coalescing is used, update the correct index\nand allow proceeding to the next CQE.\n\nFixes: 3409e0f172f6 (\"net/mana: implement Rx CQE coalescing\")\nSigned-off-by: Long Li <longli@microsoft.com>\n---\n drivers/net/mana/rx.c | 18 ++++++++----------\n 1 file changed, 8 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/mana/rx.c b/drivers/net/mana/rx.c\nindex cacfd9ae1b..220b372b15 100644\n--- a/drivers/net/mana/rx.c\n+++ b/drivers/net/mana/rx.c\n@@ -416,23 +416,21 @@ mana_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n)\n \n \t\tswitch (oob->cqe_hdr.cqe_type) {\n \t\tcase CQE_RX_OKAY:\n+\t\tcase CQE_RX_COALESCED_4:\n \t\t\t/* Proceed to process mbuf */\n \t\t\tbreak;\n \n \t\tcase CQE_RX_TRUNCATED:\n-\t\t\tDP_LOG(DEBUG, \"Drop a truncated packet\");\n+\t\tdefault:\n+\t\t\tDP_LOG(ERR, \"RX CQE type %d client %d vendor %d\",\n+\t\t\t oob->cqe_hdr.cqe_type, oob->cqe_hdr.client_type,\n+\t\t\t oob->cqe_hdr.vendor_err);\n+\n \t\t\trxq->stats.errors++;\n \t\t\trte_pktmbuf_free(mbuf);\n-\t\t\tgoto drop;\n-\n-\t\tcase CQE_RX_COALESCED_4:\n-\t\t\t/* Proceed to process mbuf */\n-\t\t\tbreak;\n \n-\t\tdefault:\n-\t\t\tDP_LOG(ERR, \"Unknown RX CQE type %d\",\n-\t\t\t oob->cqe_hdr.cqe_type);\n-\t\t\tcontinue;\n+\t\t\ti++;\n+\t\t\tgoto drop;\n \t\t}\n \n \t\tDP_LOG(DEBUG, \"mana_rx_comp_oob type %d rxq %p\",\n", "prefixes": [] }