Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129260/?format=api
{ "id": 129260, "url": "http://patches.dpdk.org/api/patches/129260/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230704210237.72933-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230704210237.72933-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230704210237.72933-1-stephen@networkplumber.org", "date": "2023-07-04T21:02:37", "name": "[v2] pcap: support MTU set", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "26565ea70f5a8c4b143b7c25ae3ae0a182b00508", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230704210237.72933-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 28813, "url": "http://patches.dpdk.org/api/series/28813/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28813", "date": "2023-07-04T21:02:37", "name": "[v2] pcap: support MTU set", "version": 2, "mbox": "http://patches.dpdk.org/series/28813/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/129260/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/129260/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 43A3442DAB;\n\tTue, 4 Jul 2023 23:02:44 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DA8B540A4B;\n\tTue, 4 Jul 2023 23:02:43 +0200 (CEST)", "from mail-pf1-f173.google.com (mail-pf1-f173.google.com\n [209.85.210.173])\n by mails.dpdk.org (Postfix) with ESMTP id A037E406B7\n for <dev@dpdk.org>; Tue, 4 Jul 2023 23:02:41 +0200 (CEST)", "by mail-pf1-f173.google.com with SMTP id\n d2e1a72fcca58-668711086f4so37021b3a.1\n for <dev@dpdk.org>; Tue, 04 Jul 2023 14:02:41 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n k13-20020a63d10d000000b00528da88275bsm7354836pgg.47.2023.07.04.14.02.39\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 04 Jul 2023 14:02:39 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688504560;\n x=1691096560;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=xywe4t7PzqLIYDZccvzE9JP7LJXfbFkiqda0OqzkdLU=;\n b=2O9sqdTXqM+oCfDxLdVruEC80dBlBpGhl4vy0gQS+kH5bjd/EjUyhSWF8xP2hUcTqd\n oIvq4SR0U8oJ9q7+1h68JTBJedAl/WN3RMXkA69p2rUu3Mh39UT2ln3jOj12l5P09Uom\n LoiJCZjVbRGFtvVAO2clSz5AMS8i9ThzedicnuUwA3zVlVrnvJ5VQb19Oa8XWI5mKMDh\n yCtX5OPY5Mw+6mIb39kBA4BDfrW9djapxUURFD7X9BOnc40QYHA8tqLST2LX5W/Znp5N\n sWxt00kMJiY8qnTgM86KUj0aL2oOhcqmSFUpT9q3Hhu5957T8uK1n+QyukROOM2mpiZL\n I6RQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1688504560; x=1691096560;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=xywe4t7PzqLIYDZccvzE9JP7LJXfbFkiqda0OqzkdLU=;\n b=dCPAvUfktlG8gxZXP8HRmqy4QywzgpUuFIo06MYof3KYtr5OlyI67e2Cm8Wrg4xGX9\n za28qZnw8/CBHv/nd2p5lYFtAWE1qYRO5Ce2g/yqFQA7dsdgUbI4ttqnPB4h31eAAvcI\n SKKakLlcaGHK2X4Vw7hBTvvZp0oM8DBaluLiPyWwph//Epc1jygxDQKnsevVVqFBCyj7\n ckzbSijGOyQPvTLIS7IHXiy+tZi/a6UlxqMbeep2D6OK/Mmrg5nvhIjJmZ2rGVQCteo4\n TnYo9DTLiI9HfbwT5aVUSXnHlizpU7/A2oE77T+balC5yewzxKFGyOkVrs1sui6GyI6s\n 222A==", "X-Gm-Message-State": "ABy/qLY+AzsbiNsjhBQdrQ2cocnM7bNk/IBCH8xXbm+evGbZiRr8EB9P\n etWx9jbpHNA6sZkE83fHXV/iY/Fk2/fOneK5CPk=", "X-Google-Smtp-Source": "\n APBJJlHRomngNwZD1BxBqM1J+fB8Z7YbNIuF2GsO1XknFjowsbytuFM3E1S5AbM69rl6hJUuQ97o3g==", "X-Received": "by 2002:a05:6a00:1953:b0:668:98a1:5e9d with SMTP id\n s19-20020a056a00195300b0066898a15e9dmr455917pfk.6.1688504560203;\n Tue, 04 Jul 2023 14:02:40 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Ido Goshen <ido@cgstowernetworks.com>", "Subject": "[PATCH v2] pcap: support MTU set", "Date": "Tue, 4 Jul 2023 14:02:37 -0700", "Message-Id": "<20230704210237.72933-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20220317174347.110909-1-ido@cgstowernetworks.com>", "References": "<20220317174347.110909-1-ido@cgstowernetworks.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Support rte_eth_dev_set_mtu for pcap driver when the\npcap device is convigured to point to a network interface.\n\nThis is rebased an consolidated from earlier version.\nAdded support for FreeBSD.\n\nSigned-off-by: Ido Goshen <ido@cgstowernetworks.com>\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\nv2 - fix FreeBSD part\n\n drivers/net/pcap/pcap_ethdev.c | 49 ++++++++++++++++++++++++++-\n drivers/net/pcap/pcap_osdep.h | 1 +\n drivers/net/pcap/pcap_osdep_freebsd.c | 23 +++++++++++++\n drivers/net/pcap/pcap_osdep_linux.c | 21 ++++++++++++\n drivers/net/pcap/pcap_osdep_windows.c | 7 ++++\n 5 files changed, 100 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/pcap_ethdev.c\nindex bfec0850456f..672f42d30d8e 100644\n--- a/drivers/net/pcap/pcap_ethdev.c\n+++ b/drivers/net/pcap/pcap_ethdev.c\n@@ -5,6 +5,7 @@\n */\n \n #include <stdlib.h>\n+#include <stdbool.h>\n #include <time.h>\n \n #include <pcap.h>\n@@ -495,8 +496,13 @@ eth_pcap_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t */\n \t\tret = pcap_sendpacket(pcap,\n \t\t\trte_pktmbuf_read(mbuf, 0, len, temp_data), len);\n-\t\tif (unlikely(ret != 0))\n+\t\tif (unlikely(ret != 0)) {\n+\t\t\t/* Oversize packet dropped due to MTU */\n+\t\t\tif (errno == EMSGSIZE)\n+\t\t\t\tcontinue;\n \t\t\tbreak;\n+\t\t}\n+\n \t\tnum_tx++;\n \t\ttx_bytes += len;\n \t\trte_pktmbuf_free(mbuf);\n@@ -808,6 +814,46 @@ eth_stats_reset(struct rte_eth_dev *dev)\n \treturn 0;\n }\n \n+static int\n+eth_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\n+{\n+\tstruct pmd_internals *internals = dev->data->dev_private;\n+\tunsigned int i;\n+\tbool is_supported = false;\n+\tint ret;\n+\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\tstruct pcap_rx_queue *queue = &internals->rx_queue[i];\n+\n+\t\tif ((strcmp(queue->type, ETH_PCAP_IFACE_ARG) == 0) ||\n+\t\t (strcmp(queue->type, ETH_PCAP_RX_IFACE_ARG) == 0) ||\n+\t\t (strcmp(queue->type, ETH_PCAP_RX_IFACE_IN_ARG) == 0)) {\n+\t\t\tret = osdep_iface_mtu_set(queue->name, mtu);\n+\t\t\tif (ret < 0)\n+\t\t\t\treturn ret;\n+\t\t\tis_supported = true;\n+\t\t}\n+\t}\n+\n+\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n+\t\tstruct pcap_tx_queue *queue = &internals->tx_queue[i];\n+\n+\t\tif ((strcmp(queue->type, ETH_PCAP_IFACE_ARG) == 0) ||\n+\t\t (strcmp(queue->type, ETH_PCAP_TX_IFACE_ARG) == 0)) {\n+\t\t\tret = osdep_iface_mtu_set(queue->name, mtu);\n+\t\t\tif (ret < 0)\n+\t\t\t\treturn ret;\n+\t\t\tis_supported = true;\n+\t\t}\n+\t}\n+\n+\tif (!is_supported)\n+\t\treturn -ENOTSUP;\n+\n+\tPMD_LOG(INFO, \"MTU set %s %u\\n\", dev->device->name, mtu);\n+\treturn 0;\n+}\n+\n static inline void\n infinite_rx_ring_free(struct rte_ring *pkts)\n {\n@@ -1005,6 +1051,7 @@ static const struct eth_dev_ops ops = {\n \t.link_update = eth_link_update,\n \t.stats_get = eth_stats_get,\n \t.stats_reset = eth_stats_reset,\n+\t.mtu_set = eth_mtu_set,\n };\n \n static int\ndiff --git a/drivers/net/pcap/pcap_osdep.h b/drivers/net/pcap/pcap_osdep.h\nindex bf41cba982ec..043677ec777d 100644\n--- a/drivers/net/pcap/pcap_osdep.h\n+++ b/drivers/net/pcap/pcap_osdep.h\n@@ -14,5 +14,6 @@ extern int eth_pcap_logtype;\n \n int osdep_iface_index_get(const char *name);\n int osdep_iface_mac_get(const char *name, struct rte_ether_addr *mac);\n+int osdep_iface_mtu_set(const char *name, uint16_t mtu);\n \n #endif\ndiff --git a/drivers/net/pcap/pcap_osdep_freebsd.c b/drivers/net/pcap/pcap_osdep_freebsd.c\nindex 20556b3e9215..de6358197391 100644\n--- a/drivers/net/pcap/pcap_osdep_freebsd.c\n+++ b/drivers/net/pcap/pcap_osdep_freebsd.c\n@@ -6,7 +6,9 @@\n \n #include <net/if.h>\n #include <net/if_dl.h>\n+#include <sys/ioctl.h>\n #include <sys/sysctl.h>\n+#include <unistd.h>\n \n #include <rte_malloc.h>\n #include <rte_memcpy.h>\n@@ -57,3 +59,24 @@ osdep_iface_mac_get(const char *if_name, struct rte_ether_addr *mac)\n \trte_free(buf);\n \treturn 0;\n }\n+\n+int\n+osdep_iface_mtu_set(const char *if_name, uint16_t mtu)\n+{\n+\tstruct ifreq ifr = { };\n+\tint if_fd = socket(AF_INET, SOCK_DGRAM, 0);\n+\n+\tif (if_fd == -1)\n+\t\treturn -errno;\n+\n+\tstrlcpy(ifr.ifr_name, if_name, sizeof(ifr.ifr_name));\n+\tifr.ifr_mtu = mtu;\n+\tif (ioctl(if_fd, SIOCSIFMTU, &ifr)) {\n+\t\tPMD_LOG(ERR, \"%s mtu set to %d failed\\n\", if_name, mtu);\n+\t\tclose(if_fd);\n+\t\treturn -errno;\n+\t}\n+\n+\tclose(if_fd);\n+\treturn 0;\n+}\ndiff --git a/drivers/net/pcap/pcap_osdep_linux.c b/drivers/net/pcap/pcap_osdep_linux.c\nindex 97033f57c5d9..845296595f86 100644\n--- a/drivers/net/pcap/pcap_osdep_linux.c\n+++ b/drivers/net/pcap/pcap_osdep_linux.c\n@@ -40,3 +40,24 @@ osdep_iface_mac_get(const char *if_name, struct rte_ether_addr *mac)\n \tclose(if_fd);\n \treturn 0;\n }\n+\n+int\n+osdep_iface_mtu_set(const char *if_name, uint16_t mtu)\n+{\n+\tstruct ifreq ifr;\n+\tint if_fd = socket(AF_INET, SOCK_DGRAM, 0);\n+\n+\tif (if_fd == -1)\n+\t\treturn -errno;\n+\n+\trte_strscpy(ifr.ifr_name, if_name, sizeof(ifr.ifr_name));\n+\tifr.ifr_mtu = mtu;\n+\tif (ioctl(if_fd, SIOCSIFMTU, &ifr)) {\n+\t\tPMD_LOG(ERR, \"%s mtu set to %d failed\\n\", if_name, mtu);\n+\t\tclose(if_fd);\n+\t\treturn -errno;\n+\t}\n+\n+\tclose(if_fd);\n+\treturn 0;\n+}\ndiff --git a/drivers/net/pcap/pcap_osdep_windows.c b/drivers/net/pcap/pcap_osdep_windows.c\nindex 1d398dc7ed9f..db34fc49e22e 100644\n--- a/drivers/net/pcap/pcap_osdep_windows.c\n+++ b/drivers/net/pcap/pcap_osdep_windows.c\n@@ -116,3 +116,10 @@ osdep_iface_mac_get(const char *device_name, struct rte_ether_addr *mac)\n \tfree(info);\n \treturn ret;\n }\n+\n+int\n+osdep_iface_mtu_set(__rte_unused const char *device_name, __rte_unused uint16_t mtu)\n+{\n+\tPMD_LOG(ERR, \"mtu set not supported on Windows\\n\");\n+\treturn -ENOTSUP;\n+}\n", "prefixes": [ "v2" ] }