Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129137/?format=api
{ "id": 129137, "url": "http://patches.dpdk.org/api/patches/129137/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230630063950.432641-1-bingz@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230630063950.432641-1-bingz@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230630063950.432641-1-bingz@nvidia.com", "date": "2023-06-30T06:39:50", "name": "[7/7] net/mlx5: fix the error in VLAN actions creation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "574bc85eb91164a9d79fc781a4261e8efab745d3", "submitter": { "id": 1976, "url": "http://patches.dpdk.org/api/people/1976/?format=api", "name": "Bing Zhao", "email": "bingz@nvidia.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230630063950.432641-1-bingz@nvidia.com/mbox/", "series": [ { "id": 28725, "url": "http://patches.dpdk.org/api/series/28725/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28725", "date": "2023-06-30T06:28:47", "name": null, "version": 1, "mbox": "http://patches.dpdk.org/series/28725/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/129137/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/129137/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3460E42D73;\n\tFri, 30 Jun 2023 08:40:25 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 22EA941133;\n\tFri, 30 Jun 2023 08:40:25 +0200 (CEST)", "from NAM02-SN1-obe.outbound.protection.outlook.com\n (mail-sn1nam02on2075.outbound.protection.outlook.com [40.107.96.75])\n by mails.dpdk.org (Postfix) with ESMTP id 8C913406B5\n for <dev@dpdk.org>; Fri, 30 Jun 2023 08:40:23 +0200 (CEST)", "from MW4P220CA0023.NAMP220.PROD.OUTLOOK.COM (2603:10b6:303:115::28)\n by MW6PR12MB7069.namprd12.prod.outlook.com (2603:10b6:303:238::11)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.19; Fri, 30 Jun\n 2023 06:40:21 +0000", "from CO1NAM11FT032.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:115:cafe::3c) by MW4P220CA0023.outlook.office365.com\n (2603:10b6:303:115::28) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.22 via Frontend\n Transport; Fri, 30 Jun 2023 06:40:21 +0000", "from mail.nvidia.com (216.228.117.161) by\n CO1NAM11FT032.mail.protection.outlook.com (10.13.174.218) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6521.43 via Frontend Transport; Fri, 30 Jun 2023 06:40:19 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Thu, 29 Jun 2023\n 23:40:06 -0700", "from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Thu, 29 Jun\n 2023 23:40:04 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=k95+h6igt0tvllBFM9/xtsSkpP7CIMkbqkUdhChDtq9oS5CpTiCk56TVpbXAfBFsx4oUI7HBgntIE04ECfZb1uLP01dc7yZBhqd4IwxqL/O0dinilKL1xKkm55rMJMBdAWw3fa3W/TdjuGvY2RU7VWuW0N3tQjuFhgkxbj5CQtbgKVlJo7m9ukBOaotBvtZFpFW2CBRqh18OH3hmJld/9lZWkZd1R3fmDzL7rZZeUUHHI/Intege8l3t8xdX3fvQ1yV0OHcjExAcQv5qcM7LKXGC73raGt/Uirlwm3LCayYOHSRWgCXn9c5prY5E3QUT9lKwS9BnjGSU9xcwGj0lIg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=7NZpJgbXKq/CpFiTFS6hvCUJvPh5vMTmbcoPaNznyMs=;\n b=WTf9kiwsYcK2Ub8GcyWqjH1qmHSk2H2n5OdO6WnJKyR/agE3S+otPRyC7041CFp9llNqOCmhduP0C+GY0qk1+Gm0ypAhVI8fsGRUAhyHdXeVnKDWfBnd+IkbVjxYaUrjOyd6LCzpBYWu6sbxn8KiL5yXSOgwVVJTIw6LwNzYMOweU4Jk6YAUbJfRoCju6hAYgoc8+gOsOTpQZDP8OfdlRm0Pe+mpk5N9EtEQ7CXKuT1myOttuH84NriJAGfVdokKRPhpnIhOCitR0iqhP5Suz/1spJ8MXHx11mPsKlbh4PbJH6rfG6wuvUPFzTvWSzj6YUKSOLoly9yIWXuEiBwjZQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=7NZpJgbXKq/CpFiTFS6hvCUJvPh5vMTmbcoPaNznyMs=;\n b=oHEHDrJdhEf0tmbMHPHBCCcaB7W/Tiz7oGhvKBhIwMKzMmXUje55xFhyQiwvh/60Lmlt2lAb+4lhWRzWK9CbeJfPaL3WiqypeWS56O/1EygQPGmnbS4rXkbDUG73bHahWPo6+H5Vb04SxiMVNS9RFZsDTSjxyH+uuEjviTzudD6Hixrw8AbReFApHKgHO4g3jrwdng9CKUIrGbEXKMVZ4gLoQE0K+VvkR5QiHrotFUNQs6hMRYbCo3fj4uwFsmzCRFJ77oYCinjEFDGICwFjq6nM+CgkgGrWojB64peYfckWpu1/CcGzTh33gH+ph9vIfMzi3o35RA35lWJ9578Yeg==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C", "From": "Bing Zhao <bingz@nvidia.com>", "To": "<matan@nvidia.com>, <viacheslavo@nvidia.com>, <orika@nvidia.com>,\n <suanmingm@nvidia.com>, <rasland@nvidia.com>", "CC": "<dev@dpdk.org>, <getelson@nvidia.com>", "Subject": "[PATCH 7/7] net/mlx5: fix the error in VLAN actions creation", "Date": "Fri, 30 Jun 2023 09:39:50 +0300", "Message-ID": "<20230630063950.432641-1-bingz@nvidia.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.230.35]", "X-ClientProxiedBy": "rnnvmail203.nvidia.com (10.129.68.9) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CO1NAM11FT032:EE_|MW6PR12MB7069:EE_", "X-MS-Office365-Filtering-Correlation-Id": "8588115b-9794-407e-b551-08db7934df3b", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n pyRG4PrlXTYnIZHwM99WzBBhbqQE8612QTBZs1smNJBdWIW2gCo0M5biTk+AOdJHXnjyCii6uwS1ITrFsR3X9tdoNrRl7qA30jzeYzPig98abdASuv9E2WzNgU8PL+L0PIZ8WheOxxeIccitRgXQkrmxJr66YBrEWdoKPkqrovvd7NppRKKF2Le5PvacZ9yxPymI76gamKiwD/92itjtuXqNiu4Jg+woa4CxdXfM9v7RIgoPWnQjEljAf8Erc7PDDIGNSmYKaE/8ASJvy8yHs7qsX/107pyIn3yaoqM2W/gv3khl16BOuiRgdzLk6HFf2Vb9Uzowug+QPT1O5X+UNjNvoNg4FoF02OgRgg1NxyKQTU5yQDPwxWDp54PdXuOboEmtTh0IKZXqVVFP+yuXoU0TGGYiC5kndKxSYtqR5+jJP1tOD6gy7jJdLwq9RYvCUVBogIzwwFieoCO2to9WKK8tgCcAMrBgXtfyUsIKVQCYYFJnqBAGeTmNdEo5xSQ8FlVJAAR/biIBIiio+GJ4fYV12P7odp5L85a7Mn9NebjKSErSAz6+YpqLzjAdt6GXPuha81EeLCuGUZjtCSK50ETuwR5n6+rl/pfBO0oHW8deGrPpEhv+WbppReISpTISVDnSeygIZD55ZRnluu293OeyIJLGldt+Ip18P7nkIxythvuATfRdlWrEZqJhS7GNL9reLtSW91ZLB4RbYyZlz8GNRgndwdrANenTn1v4jbkGJDpSo/PYYBsch6Re+INQ", "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230028)(4636009)(396003)(39860400002)(376002)(346002)(136003)(451199021)(46966006)(36840700001)(40470700004)(40460700003)(41300700001)(316002)(83380400001)(82310400005)(426003)(36860700001)(86362001)(336012)(16526019)(6286002)(186003)(1076003)(26005)(2616005)(2906002)(82740400003)(7636003)(356005)(40480700001)(55016003)(47076005)(5660300002)(36756003)(8676002)(8936002)(107886003)(478600001)(110136005)(54906003)(70206006)(70586007)(6636002)(4326008)(6666004)(7696005);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "30 Jun 2023 06:40:19.1987 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 8588115b-9794-407e-b551-08db7934df3b", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT032.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MW6PR12MB7069", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When a failure occurs during the VLAN actions creating, the value\nof \"rte_errno\" is already set by the mlx5dr_action_create*. The\nvalue can be returned directly to reflect the actual reason.\n\nIn the meanwhile, the \"rte_flow_error\" structure should also be set\nwith explict message.\n\nFixes: 773ca0e91ba1 (\"net/mlx5: support VLAN push/pop/modify with HWS\")\nCc: getelson@nvidia.com\n\nSigned-off-by: Bing Zhao <bingz@nvidia.com>\nAcked-by: Ori Kam <orika@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow_hw.c | 14 +++++++++-----\n 1 file changed, 9 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c\nindex 20941b4fc7..36a7f0989c 100644\n--- a/drivers/net/mlx5/mlx5_flow_hw.c\n+++ b/drivers/net/mlx5/mlx5_flow_hw.c\n@@ -7125,27 +7125,28 @@ flow_hw_create_vlan(struct rte_eth_dev *dev)\n \t\tMLX5DR_ACTION_FLAG_HWS_FDB\n \t};\n \n+\t/* rte_errno is set in the mlx5dr_action* functions. */\n \tfor (i = MLX5DR_TABLE_TYPE_NIC_RX; i <= MLX5DR_TABLE_TYPE_NIC_TX; i++) {\n \t\tpriv->hw_pop_vlan[i] =\n \t\t\tmlx5dr_action_create_pop_vlan(priv->dr_ctx, flags[i]);\n \t\tif (!priv->hw_pop_vlan[i])\n-\t\t\treturn -ENOENT;\n+\t\t\treturn -rte_errno;\n \t\tpriv->hw_push_vlan[i] =\n \t\t\tmlx5dr_action_create_push_vlan(priv->dr_ctx, flags[i]);\n \t\tif (!priv->hw_pop_vlan[i])\n-\t\t\treturn -ENOENT;\n+\t\t\treturn -rte_errno;\n \t}\n \tif (priv->sh->config.dv_esw_en && priv->master) {\n \t\tpriv->hw_pop_vlan[MLX5DR_TABLE_TYPE_FDB] =\n \t\t\tmlx5dr_action_create_pop_vlan\n \t\t\t\t(priv->dr_ctx, MLX5DR_ACTION_FLAG_HWS_FDB);\n \t\tif (!priv->hw_pop_vlan[MLX5DR_TABLE_TYPE_FDB])\n-\t\t\treturn -ENOENT;\n+\t\t\treturn -rte_errno;\n \t\tpriv->hw_push_vlan[MLX5DR_TABLE_TYPE_FDB] =\n \t\t\tmlx5dr_action_create_push_vlan\n \t\t\t\t(priv->dr_ctx, MLX5DR_ACTION_FLAG_HWS_FDB);\n \t\tif (!priv->hw_pop_vlan[MLX5DR_TABLE_TYPE_FDB])\n-\t\t\treturn -ENOENT;\n+\t\t\treturn -rte_errno;\n \t}\n \treturn 0;\n }\n@@ -7920,8 +7921,11 @@ flow_hw_configure(struct rte_eth_dev *dev,\n \t\t}\n \t}\n \tret = flow_hw_create_vlan(dev);\n-\tif (ret)\n+\tif (ret) {\n+\t\trte_flow_error_set(error, -ret, RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t NULL, \"Failed to VLAN actions.\");\n \t\tgoto err;\n+\t}\n \tif (_queue_attr)\n \t\tmlx5_free(_queue_attr);\n \tif (port_attr->flags & RTE_FLOW_PORT_FLAG_STRICT_QUEUE)\n", "prefixes": [ "7/7" ] }