Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 128378,
    "url": "http://patches.dpdk.org/api/patches/128378/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230608065458.333670-9-gakhil@marvell.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230608065458.333670-9-gakhil@marvell.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230608065458.333670-9-gakhil@marvell.com",
    "date": "2023-06-08T06:54:53",
    "name": "[v3,08/13] test/security: verify MACsec stats",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "4318799945f66cccde6671dea7af7b8da8b42481",
    "submitter": {
        "id": 2094,
        "url": "http://patches.dpdk.org/api/people/2094/?format=api",
        "name": "Akhil Goyal",
        "email": "gakhil@marvell.com"
    },
    "delegate": {
        "id": 6690,
        "url": "http://patches.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230608065458.333670-9-gakhil@marvell.com/mbox/",
    "series": [
        {
            "id": 28406,
            "url": "http://patches.dpdk.org/api/series/28406/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28406",
            "date": "2023-06-08T06:54:50",
            "name": "Add MACsec unit test cases",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/28406/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/128378/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/128378/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 757A642C5A;\n\tThu,  8 Jun 2023 08:56:24 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C115F42D40;\n\tThu,  8 Jun 2023 08:55:52 +0200 (CEST)",
            "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 3677742D2F\n for <dev@dpdk.org>; Thu,  8 Jun 2023 08:55:51 +0200 (CEST)",
            "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 357LwHmB023579; Wed, 7 Jun 2023 23:55:48 -0700",
            "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3r329c1jum-2\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Wed, 07 Jun 2023 23:55:43 -0700",
            "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Wed, 7 Jun 2023 23:55:34 -0700",
            "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Wed, 7 Jun 2023 23:55:34 -0700",
            "from localhost.localdomain (unknown [10.28.36.102])\n by maili.marvell.com (Postfix) with ESMTP id 78F4A3F7055;\n Wed,  7 Jun 2023 23:55:31 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=fbB26+QhBYPuN3Dhxe6+f8bH+mpX5ZHsYV7P89NF08o=;\n b=YyuJRdIXR6f5jhLiFx+zIvBEA5d6tHbYFTiHK+e96rrEmOfF26B0MqFv86ZUg6yNbT0y\n wf/y7eQ1ERl01w868vvqjeaU8Pgl3nUIV4PFFGmgGIDed1Tnwua6M8J0VQ8PDAq0BRQt\n MNotJ5kAp3X5EnAieW8ijNyfSvt7rsbHTTQWcyoX0LLo/Xp29AEOXZcJr0pTyXXCQmGO\n FzBRC9BCXRbhiMRrkyBGNMuICIX12tOaBGMs7DSepOYXKWoyel4e8jP5h9Si4mBvC88P\n U0UYEZNgcPyC2rfDQKCeoa6q1Jqn2sHxWdcNyoL3savOIbxkF+gD57dJayrzSv+VbKMa Yw==",
        "From": "Akhil Goyal <gakhil@marvell.com>",
        "To": "<dev@dpdk.org>",
        "CC": "<thomas@monjalon.net>, <olivier.matz@6wind.com>, <orika@nvidia.com>,\n <david.marchand@redhat.com>, <hemant.agrawal@nxp.com>,\n <vattunuru@marvell.com>, <ferruh.yigit@amd.com>,\n <andrew.rybchenko@oktetlabs.ru>, <jerinj@marvell.com>,\n <adwivedi@marvell.com>, Akhil Goyal <gakhil@marvell.com>",
        "Subject": "[PATCH v3 08/13] test/security: verify MACsec stats",
        "Date": "Thu, 8 Jun 2023 12:24:53 +0530",
        "Message-ID": "<20230608065458.333670-9-gakhil@marvell.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20230608065458.333670-1-gakhil@marvell.com>",
        "References": "<20230607151940.223417-1-gakhil@marvell.com>\n <20230608065458.333670-1-gakhil@marvell.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Proofpoint-GUID": "uZCShW3Q_MoYvbfKC6ejvcnn1JLhPpja",
        "X-Proofpoint-ORIG-GUID": "uZCShW3Q_MoYvbfKC6ejvcnn1JLhPpja",
        "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26\n definitions=2023-06-08_04,2023-06-07_01,2023-05-22_02",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Added cases to verify various stats of MACsec.\n\nSigned-off-by: Akhil Goyal <gakhil@marvell.com>\n---\n app/test/test_security_inline_macsec.c | 222 +++++++++++++++++++++++++\n 1 file changed, 222 insertions(+)",
    "diff": "diff --git a/app/test/test_security_inline_macsec.c b/app/test/test_security_inline_macsec.c\nindex 2a06f31f37..9cab3253f4 100644\n--- a/app/test/test_security_inline_macsec.c\n+++ b/app/test/test_security_inline_macsec.c\n@@ -1438,6 +1438,140 @@ test_inline_macsec_sa_not_in_use(const void *data __rte_unused)\n \treturn all_err;\n }\n \n+static int\n+test_inline_macsec_decap_stats(const void *data __rte_unused)\n+{\n+\tconst struct mcs_test_vector *cur_td;\n+\tstruct mcs_test_opts opts = {0};\n+\tint err, all_err = 0;\n+\tint i, size;\n+\n+\topts.val_frames = RTE_SECURITY_MACSEC_VALIDATE_STRICT;\n+\topts.protect_frames = true;\n+\topts.sa_in_use = 1;\n+\topts.nb_td = 1;\n+\topts.sectag_insert_mode = 1;\n+\topts.mtu = RTE_ETHER_MTU;\n+\topts.check_decap_stats = 1;\n+\n+\tsize = (sizeof(list_mcs_cipher_vectors) / sizeof((list_mcs_cipher_vectors)[0]));\n+\n+\tfor (i = 0; i < size; i++) {\n+\t\tcur_td = &list_mcs_cipher_vectors[i];\n+\t\terr = test_macsec(&cur_td, MCS_DECAP, &opts);\n+\t\tif (err) {\n+\t\t\tprintf(\"\\nDecap stats case %d failed\", cur_td->test_idx);\n+\t\t\terr = -1;\n+\t\t} else {\n+\t\t\tprintf(\"\\nDecap stats case %d passed\", cur_td->test_idx);\n+\t\t\terr = 0;\n+\t\t}\n+\t\tall_err += err;\n+\t}\n+\tprintf(\"\\n%s: Success: %d, Failure: %d\\n\", __func__, size + all_err, -all_err);\n+\n+\treturn all_err;\n+}\n+\n+static int\n+test_inline_macsec_verify_only_stats(const void *data __rte_unused)\n+{\n+\tconst struct mcs_test_vector *cur_td;\n+\tstruct mcs_test_opts opts = {0};\n+\tint err, all_err = 0;\n+\tint i, size;\n+\n+\topts.val_frames = RTE_SECURITY_MACSEC_VALIDATE_STRICT;\n+\topts.protect_frames = true;\n+\topts.sa_in_use = 1;\n+\topts.nb_td = 1;\n+\topts.sectag_insert_mode = 1;\n+\topts.mtu = RTE_ETHER_MTU;\n+\topts.check_verify_only_stats = 1;\n+\n+\tsize = (sizeof(list_mcs_integrity_vectors) / sizeof((list_mcs_integrity_vectors)[0]));\n+\n+\tfor (i = 0; i < size; i++) {\n+\t\tcur_td = &list_mcs_integrity_vectors[i];\n+\t\terr = test_macsec(&cur_td, MCS_VERIFY_ONLY, &opts);\n+\t\tif (err) {\n+\t\t\tprintf(\"\\nVerify only stats case %d failed\", cur_td->test_idx);\n+\t\t\terr = -1;\n+\t\t} else {\n+\t\t\tprintf(\"\\nVerify only stats case %d Passed\", cur_td->test_idx);\n+\t\t\terr = 0;\n+\t\t}\n+\t\tall_err += err;\n+\t}\n+\tprintf(\"\\n%s: Success: %d, Failure: %d\\n\", __func__, size + all_err, -all_err);\n+\n+\treturn all_err;\n+}\n+\n+static int\n+test_inline_macsec_pkts_invalid_stats(const void *data __rte_unused)\n+{\n+\tconst struct mcs_test_vector *cur_td;\n+\tstruct mcs_test_opts opts = {0};\n+\tint err, all_err = 0;\n+\tint i, size;\n+\n+\topts.val_frames = RTE_SECURITY_MACSEC_VALIDATE_STRICT;\n+\topts.protect_frames = true;\n+\topts.sa_in_use = 1;\n+\topts.nb_td = 1;\n+\topts.sectag_insert_mode = 1;\n+\topts.mtu = RTE_ETHER_MTU;\n+\n+\tsize = (sizeof(list_mcs_err_cipher_vectors) / sizeof((list_mcs_err_cipher_vectors)[0]));\n+\n+\tfor (i = 0; i < size; i++) {\n+\t\tcur_td = &list_mcs_err_cipher_vectors[i];\n+\t\terr = test_macsec(&cur_td, MCS_DECAP, &opts);\n+\t\tif (err)\n+\t\t\terr = 0;\n+\t\telse\n+\t\t\terr = -1;\n+\n+\t\tall_err += err;\n+\t}\n+\tprintf(\"\\n%s: Success: %d, Failure: %d\\n\", __func__, size + all_err, -all_err);\n+\treturn all_err;\n+}\n+\n+static int\n+test_inline_macsec_pkts_unchecked_stats(const void *data __rte_unused)\n+{\n+\tconst struct mcs_test_vector *cur_td;\n+\tstruct mcs_test_opts opts = {0};\n+\tint err, all_err = 0;\n+\tint i, size;\n+\n+\topts.val_frames = RTE_SECURITY_MACSEC_VALIDATE_DISABLE;\n+\topts.protect_frames = true;\n+\topts.sa_in_use = 1;\n+\topts.nb_td = 1;\n+\topts.sectag_insert_mode = 1;\n+\topts.mtu = RTE_ETHER_MTU;\n+\topts.check_pkts_unchecked_stats = 1;\n+\n+\tsize = (sizeof(list_mcs_integrity_vectors) / sizeof((list_mcs_integrity_vectors)[0]));\n+\n+\tfor (i = 0; i < size; i++) {\n+\t\tcur_td = &list_mcs_integrity_vectors[i];\n+\t\terr = test_macsec(&cur_td, MCS_VERIFY_ONLY, &opts);\n+\t\tif (err)\n+\t\t\terr = -1;\n+\t\telse\n+\t\t\terr = 0;\n+\n+\t\tall_err += err;\n+\t}\n+\n+\tprintf(\"\\n%s: Success: %d, Failure: %d\\n\", __func__, size + all_err, -all_err);\n+\treturn all_err;\n+}\n+\n static int\n test_inline_macsec_out_pkts_untagged(const void *data __rte_unused)\n {\n@@ -1504,6 +1638,70 @@ test_inline_macsec_out_pkts_toolong(const void *data __rte_unused)\n \treturn all_err;\n }\n \n+static int\n+test_inline_macsec_encap_stats(const void *data __rte_unused)\n+{\n+\tconst struct mcs_test_vector *cur_td;\n+\tstruct mcs_test_opts opts = {0};\n+\tint err, all_err = 0;\n+\tint i, size;\n+\n+\topts.val_frames = RTE_SECURITY_MACSEC_VALIDATE_STRICT;\n+\topts.encrypt = true;\n+\topts.protect_frames = true;\n+\topts.sa_in_use = 1;\n+\topts.nb_td = 1;\n+\topts.sectag_insert_mode = 1;\n+\topts.mtu = RTE_ETHER_MTU;\n+\topts.check_encap_stats = 1;\n+\n+\tsize = (sizeof(list_mcs_cipher_vectors) / sizeof((list_mcs_cipher_vectors)[0]));\n+\tfor (i = 0; i < size; i++) {\n+\t\tcur_td = &list_mcs_cipher_vectors[i];\n+\t\terr = test_macsec(&cur_td, MCS_ENCAP, &opts);\n+\t\tif (err)\n+\t\t\terr = -1;\n+\t\telse\n+\t\t\terr = 0;\n+\t\tall_err += err;\n+\t}\n+\n+\tprintf(\"\\n%s: Success: %d, Failure: %d\\n\", __func__, size + all_err, -all_err);\n+\treturn all_err;\n+}\n+\n+static int\n+test_inline_macsec_auth_only_stats(const void *data __rte_unused)\n+{\n+\tconst struct mcs_test_vector *cur_td;\n+\tstruct mcs_test_opts opts = {0};\n+\tint err, all_err = 0;\n+\tint i, size;\n+\n+\topts.val_frames = RTE_SECURITY_MACSEC_VALIDATE_STRICT;\n+\topts.protect_frames = true;\n+\topts.sa_in_use = 1;\n+\topts.nb_td = 1;\n+\topts.sectag_insert_mode = 1;\n+\topts.mtu = RTE_ETHER_MTU;\n+\topts.check_auth_only_stats = 1;\n+\n+\tsize = (sizeof(list_mcs_integrity_vectors) / sizeof((list_mcs_integrity_vectors)[0]));\n+\n+\tfor (i = 0; i < size; i++) {\n+\t\tcur_td = &list_mcs_integrity_vectors[i];\n+\t\terr = test_macsec(&cur_td, MCS_AUTH_ONLY, &opts);\n+\t\tif (err)\n+\t\t\terr = -1;\n+\t\telse\n+\t\t\terr = 0;\n+\t\tall_err += err;\n+\t}\n+\n+\tprintf(\"\\n%s: Success: %d, Failure: %d\\n\", __func__, size + all_err, -all_err);\n+\treturn all_err;\n+}\n+\n static int\n ut_setup_inline_macsec(void)\n {\n@@ -1697,6 +1895,22 @@ static struct unit_test_suite inline_macsec_testsuite  = {\n \t\t\t\"MACsec SA not in use\",\n \t\t\tut_setup_inline_macsec, ut_teardown_inline_macsec,\n \t\t\ttest_inline_macsec_sa_not_in_use),\n+\t\tTEST_CASE_NAMED_ST(\n+\t\t\t\"MACsec decap stats\",\n+\t\t\tut_setup_inline_macsec, ut_teardown_inline_macsec,\n+\t\t\ttest_inline_macsec_decap_stats),\n+\t\tTEST_CASE_NAMED_ST(\n+\t\t\t\"MACsec verify only stats\",\n+\t\t\tut_setup_inline_macsec, ut_teardown_inline_macsec,\n+\t\t\ttest_inline_macsec_verify_only_stats),\n+\t\tTEST_CASE_NAMED_ST(\n+\t\t\t\"MACsec pkts invalid stats\",\n+\t\t\tut_setup_inline_macsec, ut_teardown_inline_macsec,\n+\t\t\ttest_inline_macsec_pkts_invalid_stats),\n+\t\tTEST_CASE_NAMED_ST(\n+\t\t\t\"MACsec pkts unchecked stats\",\n+\t\t\tut_setup_inline_macsec, ut_teardown_inline_macsec,\n+\t\t\ttest_inline_macsec_pkts_unchecked_stats),\n \t\tTEST_CASE_NAMED_ST(\n \t\t\t\"MACsec out pkts untagged\",\n \t\t\tut_setup_inline_macsec, ut_teardown_inline_macsec,\n@@ -1705,6 +1919,14 @@ static struct unit_test_suite inline_macsec_testsuite  = {\n \t\t\t\"MACsec out pkts too long\",\n \t\t\tut_setup_inline_macsec, ut_teardown_inline_macsec,\n \t\t\ttest_inline_macsec_out_pkts_toolong),\n+\t\tTEST_CASE_NAMED_ST(\n+\t\t\t\"MACsec Encap stats\",\n+\t\t\tut_setup_inline_macsec, ut_teardown_inline_macsec,\n+\t\t\ttest_inline_macsec_encap_stats),\n+\t\tTEST_CASE_NAMED_ST(\n+\t\t\t\"MACsec auth only stats\",\n+\t\t\tut_setup_inline_macsec, ut_teardown_inline_macsec,\n+\t\t\ttest_inline_macsec_auth_only_stats),\n \n \t\tTEST_CASES_END() /**< NULL terminate unit test array */\n \t},\n",
    "prefixes": [
        "v3",
        "08/13"
    ]
}