Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128374/?format=api
{ "id": 128374, "url": "http://patches.dpdk.org/api/patches/128374/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230608065458.333670-2-gakhil@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230608065458.333670-2-gakhil@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230608065458.333670-2-gakhil@marvell.com", "date": "2023-06-08T06:54:46", "name": "[v3,01/13] security: add direction in SA/SC configuration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "45b59ab948186e2b3f9621fc2eccf39efd906049", "submitter": { "id": 2094, "url": "http://patches.dpdk.org/api/people/2094/?format=api", "name": "Akhil Goyal", "email": "gakhil@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230608065458.333670-2-gakhil@marvell.com/mbox/", "series": [ { "id": 28406, "url": "http://patches.dpdk.org/api/series/28406/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28406", "date": "2023-06-08T06:54:50", "name": "Add MACsec unit test cases", "version": 3, "mbox": "http://patches.dpdk.org/series/28406/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/128374/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/128374/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3269642C5A;\n\tThu, 8 Jun 2023 08:55:48 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0A1D142D13;\n\tThu, 8 Jun 2023 08:55:34 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 672F240EE3\n for <dev@dpdk.org>; Thu, 8 Jun 2023 08:55:29 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 357LwAdY023531; Wed, 7 Jun 2023 23:55:26 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3r329c1jsf-2\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Wed, 07 Jun 2023 23:55:26 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Wed, 7 Jun 2023 23:55:07 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Wed, 7 Jun 2023 23:55:07 -0700", "from localhost.localdomain (unknown [10.28.36.102])\n by maili.marvell.com (Postfix) with ESMTP id 7DFA73F7055;\n Wed, 7 Jun 2023 23:55:04 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=U1wtuqs0uQIJVTTth0OGRHqCuskhjA81tRkticd2Rvw=;\n b=f3NaX+Caew2SIdv9w5O5/zHIvEznwlwKEE0G916emSMEPi3249buSPhuU7wZVI9/QStJ\n kHrv1OS1sy6domAKALrkoJRUJcQBlfWgEP/5Bt7GFFWlGF6yTC0t6sqIvRaxXzLWWhbr\n 5Vp3ovk2kfABEtX1mGiKJMMKn0+Gd51quGJXh1OTpQy2PMv7hkz4I2wIuostrTHVE5YN\n GfsWheo3ta+Y1GwCdJtf4Z/b8QlwlqxMD1FYo9FioyQXmJSdidTPa379U0522ZyI8BtD\n aAsCoWsiVx2oUKzb1vaGkRBCC+pJdMs8EmaLiQWAjGg6SfXMU4Rgp0X5OL5UKhY9XnjN Ww==", "From": "Akhil Goyal <gakhil@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<thomas@monjalon.net>, <olivier.matz@6wind.com>, <orika@nvidia.com>,\n <david.marchand@redhat.com>, <hemant.agrawal@nxp.com>,\n <vattunuru@marvell.com>, <ferruh.yigit@amd.com>,\n <andrew.rybchenko@oktetlabs.ru>, <jerinj@marvell.com>,\n <adwivedi@marvell.com>, Akhil Goyal <gakhil@marvell.com>", "Subject": "[PATCH v3 01/13] security: add direction in SA/SC configuration", "Date": "Thu, 8 Jun 2023 12:24:46 +0530", "Message-ID": "<20230608065458.333670-2-gakhil@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230608065458.333670-1-gakhil@marvell.com>", "References": "<20230607151940.223417-1-gakhil@marvell.com>\n <20230608065458.333670-1-gakhil@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "BXPnlHL0p7r2Lk64dkfH2nxauqkdpuA2", "X-Proofpoint-ORIG-GUID": "BXPnlHL0p7r2Lk64dkfH2nxauqkdpuA2", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26\n definitions=2023-06-08_04,2023-06-07_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "MACsec SC/SA ids are created based on direction of the flow.\nHence, added the missing field for configuration and cleanup\nof the SCs and SAs.\n\nSigned-off-by: Akhil Goyal <gakhil@marvell.com>\n---\n devtools/libabigail.abignore | 4 ++++\n lib/security/rte_security.c | 16 ++++++++++------\n lib/security/rte_security.h | 14 ++++++++++----\n lib/security/rte_security_driver.h | 12 ++++++++++--\n 4 files changed, 34 insertions(+), 12 deletions(-)", "diff": "diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore\nindex c0361bfc7b..03bfbce259 100644\n--- a/devtools/libabigail.abignore\n+++ b/devtools/libabigail.abignore\n@@ -41,3 +41,7 @@\n ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;\n ; Temporary exceptions till next major ABI version ;\n ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;\n+\n+; Ignore changes to rte_security_ops which are internal to PMD.\n+[suppress_type]\n+ name = rte_security_ops\ndiff --git a/lib/security/rte_security.c b/lib/security/rte_security.c\nindex e102c55e55..c4d64bb8e9 100644\n--- a/lib/security/rte_security.c\n+++ b/lib/security/rte_security.c\n@@ -164,13 +164,14 @@ rte_security_macsec_sa_create(struct rte_security_ctx *instance,\n }\n \n int\n-rte_security_macsec_sc_destroy(struct rte_security_ctx *instance, uint16_t sc_id)\n+rte_security_macsec_sc_destroy(struct rte_security_ctx *instance, uint16_t sc_id,\n+\t\t\t enum rte_security_macsec_direction dir)\n {\n \tint ret;\n \n \tRTE_PTR_CHAIN3_OR_ERR_RET(instance, ops, macsec_sc_destroy, -EINVAL, -ENOTSUP);\n \n-\tret = instance->ops->macsec_sc_destroy(instance->device, sc_id);\n+\tret = instance->ops->macsec_sc_destroy(instance->device, sc_id, dir);\n \tif (ret != 0)\n \t\treturn ret;\n \n@@ -181,13 +182,14 @@ rte_security_macsec_sc_destroy(struct rte_security_ctx *instance, uint16_t sc_id\n }\n \n int\n-rte_security_macsec_sa_destroy(struct rte_security_ctx *instance, uint16_t sa_id)\n+rte_security_macsec_sa_destroy(struct rte_security_ctx *instance, uint16_t sa_id,\n+\t\t\t enum rte_security_macsec_direction dir)\n {\n \tint ret;\n \n \tRTE_PTR_CHAIN3_OR_ERR_RET(instance, ops, macsec_sa_destroy, -EINVAL, -ENOTSUP);\n \n-\tret = instance->ops->macsec_sa_destroy(instance->device, sa_id);\n+\tret = instance->ops->macsec_sa_destroy(instance->device, sa_id, dir);\n \tif (ret != 0)\n \t\treturn ret;\n \n@@ -199,22 +201,24 @@ rte_security_macsec_sa_destroy(struct rte_security_ctx *instance, uint16_t sa_id\n \n int\n rte_security_macsec_sc_stats_get(struct rte_security_ctx *instance, uint16_t sc_id,\n+\t\t\t\t enum rte_security_macsec_direction dir,\n \t\t\t\t struct rte_security_macsec_sc_stats *stats)\n {\n \tRTE_PTR_CHAIN3_OR_ERR_RET(instance, ops, macsec_sc_stats_get, -EINVAL, -ENOTSUP);\n \tRTE_PTR_OR_ERR_RET(stats, -EINVAL);\n \n-\treturn instance->ops->macsec_sc_stats_get(instance->device, sc_id, stats);\n+\treturn instance->ops->macsec_sc_stats_get(instance->device, sc_id, dir, stats);\n }\n \n int\n rte_security_macsec_sa_stats_get(struct rte_security_ctx *instance, uint16_t sa_id,\n+\t\t\t\t enum rte_security_macsec_direction dir,\n \t\t\t\t struct rte_security_macsec_sa_stats *stats)\n {\n \tRTE_PTR_CHAIN3_OR_ERR_RET(instance, ops, macsec_sa_stats_get, -EINVAL, -ENOTSUP);\n \tRTE_PTR_OR_ERR_RET(stats, -EINVAL);\n \n-\treturn instance->ops->macsec_sa_stats_get(instance->device, sa_id, stats);\n+\treturn instance->ops->macsec_sa_stats_get(instance->device, sa_id, dir, stats);\n }\n \n int\ndiff --git a/lib/security/rte_security.h b/lib/security/rte_security.h\nindex 4bacf9fcd9..c7a523b6d6 100644\n--- a/lib/security/rte_security.h\n+++ b/lib/security/rte_security.h\n@@ -761,6 +761,7 @@ rte_security_macsec_sc_create(struct rte_security_ctx *instance,\n *\n * @param instance\tsecurity instance\n * @param sc_id\tSC ID to be destroyed\n+ * @param dir\t\tdirection of the SC\n * @return\n * - 0 if successful.\n * - -EINVAL if sc_id is invalid or instance is NULL.\n@@ -768,7 +769,8 @@ rte_security_macsec_sc_create(struct rte_security_ctx *instance,\n */\n __rte_experimental\n int\n-rte_security_macsec_sc_destroy(struct rte_security_ctx *instance, uint16_t sc_id);\n+rte_security_macsec_sc_destroy(struct rte_security_ctx *instance, uint16_t sc_id,\n+\t\t\t enum rte_security_macsec_direction dir);\n \n /**\n * @warning\n@@ -798,6 +800,7 @@ rte_security_macsec_sa_create(struct rte_security_ctx *instance,\n *\n * @param instance\tsecurity instance\n * @param sa_id\tSA ID to be destroyed\n+ * @param dir\t\tdirection of the SA\n * @return\n * - 0 if successful.\n * - -EINVAL if sa_id is invalid or instance is NULL.\n@@ -805,7 +808,8 @@ rte_security_macsec_sa_create(struct rte_security_ctx *instance,\n */\n __rte_experimental\n int\n-rte_security_macsec_sa_destroy(struct rte_security_ctx *instance, uint16_t sa_id);\n+rte_security_macsec_sa_destroy(struct rte_security_ctx *instance, uint16_t sa_id,\n+\t\t\t enum rte_security_macsec_direction dir);\n \n /** Device-specific metadata field type */\n typedef uint64_t rte_security_dynfield_t;\n@@ -1077,6 +1081,7 @@ rte_security_session_stats_get(struct rte_security_ctx *instance,\n *\n * @param\tinstance\tsecurity instance\n * @param\tsa_id\t\tSA ID for which stats are needed\n+ * @param\tdir\t\tdirection of the SA\n * @param\tstats\t\tstatistics\n * @return\n * - On success, return 0.\n@@ -1085,7 +1090,7 @@ rte_security_session_stats_get(struct rte_security_ctx *instance,\n __rte_experimental\n int\n rte_security_macsec_sa_stats_get(struct rte_security_ctx *instance,\n-\t\t\t\t uint16_t sa_id,\n+\t\t\t\t uint16_t sa_id, enum rte_security_macsec_direction dir,\n \t\t\t\t struct rte_security_macsec_sa_stats *stats);\n \n /**\n@@ -1096,6 +1101,7 @@ rte_security_macsec_sa_stats_get(struct rte_security_ctx *instance,\n *\n * @param\tinstance\tsecurity instance\n * @param\tsc_id\t\tSC ID for which stats are needed\n+ * @param\tdir\t\tdirection of the SC\n * @param\tstats\t\tSC statistics\n * @return\n * - On success, return 0.\n@@ -1104,7 +1110,7 @@ rte_security_macsec_sa_stats_get(struct rte_security_ctx *instance,\n __rte_experimental\n int\n rte_security_macsec_sc_stats_get(struct rte_security_ctx *instance,\n-\t\t\t\t uint16_t sc_id,\n+\t\t\t\t uint16_t sc_id, enum rte_security_macsec_direction dir,\n \t\t\t\t struct rte_security_macsec_sc_stats *stats);\n \n /**\ndiff --git a/lib/security/rte_security_driver.h b/lib/security/rte_security_driver.h\nindex 421e6f7780..677c7d1f91 100644\n--- a/lib/security/rte_security_driver.h\n+++ b/lib/security/rte_security_driver.h\n@@ -106,8 +106,10 @@ typedef int (*security_macsec_sc_create_t)(void *device, struct rte_security_mac\n *\n * @param\tdevice\t\tCrypto/eth device pointer\n * @param\tsc_id\t\tMACsec SC ID\n+ * @param\tdir\t\tDirection of SC\n */\n-typedef int (*security_macsec_sc_destroy_t)(void *device, uint16_t sc_id);\n+typedef int (*security_macsec_sc_destroy_t)(void *device, uint16_t sc_id,\n+\t\tenum rte_security_macsec_direction dir);\n \n /**\n * Configure a MACsec security Association (SA) on a device.\n@@ -128,8 +130,10 @@ typedef int (*security_macsec_sa_create_t)(void *device, struct rte_security_mac\n *\n * @param\tdevice\t\tCrypto/eth device pointer\n * @param\tsa_id\t\tMACsec SA ID\n+ * @param\tdir\t\tDirection of SA\n */\n-typedef int (*security_macsec_sa_destroy_t)(void *device, uint16_t sa_id);\n+typedef int (*security_macsec_sa_destroy_t)(void *device, uint16_t sa_id,\n+\t\tenum rte_security_macsec_direction dir);\n \n /**\n * Get the size of a security session\n@@ -162,6 +166,7 @@ typedef int (*security_session_stats_get_t)(void *device,\n *\n * @param\tdevice\t\tCrypto/eth device pointer\n * @param\tsc_id\t\tsecure channel ID created by rte_security_macsec_sc_create()\n+ * @param\tdir\t\tdirection of SC\n * @param\tstats\t\tSC stats of the driver\n *\n * @return\n@@ -169,6 +174,7 @@ typedef int (*security_session_stats_get_t)(void *device,\n * - -EINVAL if sc_id or device is invalid.\n */\n typedef int (*security_macsec_sc_stats_get_t)(void *device, uint16_t sc_id,\n+\t\tenum rte_security_macsec_direction dir,\n \t\tstruct rte_security_macsec_sc_stats *stats);\n \n /**\n@@ -176,6 +182,7 @@ typedef int (*security_macsec_sc_stats_get_t)(void *device, uint16_t sc_id,\n *\n * @param\tdevice\t\tCrypto/eth device pointer\n * @param\tsa_id\t\tsecure channel ID created by rte_security_macsec_sc_create()\n+ * @param\tdir\t\tdirection of SA\n * @param\tstats\t\tSC stats of the driver\n *\n * @return\n@@ -183,6 +190,7 @@ typedef int (*security_macsec_sc_stats_get_t)(void *device, uint16_t sc_id,\n * - -EINVAL if sa_id or device is invalid.\n */\n typedef int (*security_macsec_sa_stats_get_t)(void *device, uint16_t sa_id,\n+\t\tenum rte_security_macsec_direction dir,\n \t\tstruct rte_security_macsec_sa_stats *stats);\n \n \n", "prefixes": [ "v3", "01/13" ] }