Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128357/?format=api
{ "id": 128357, "url": "http://patches.dpdk.org/api/patches/128357/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230607175725.17488-1-corezeng@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230607175725.17488-1-corezeng@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230607175725.17488-1-corezeng@gmail.com", "date": "2023-06-07T17:57:25", "name": "[v3] net/vmxnet3: fix return code in initializing", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d51954a04b1aa6f7554af557f2705e186598b647", "submitter": { "id": 3079, "url": "http://patches.dpdk.org/api/people/3079/?format=api", "name": "Kaijun Zeng", "email": "corezeng@gmail.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230607175725.17488-1-corezeng@gmail.com/mbox/", "series": [ { "id": 28396, "url": "http://patches.dpdk.org/api/series/28396/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28396", "date": "2023-06-07T17:57:25", "name": "[v3] net/vmxnet3: fix return code in initializing", "version": 3, "mbox": "http://patches.dpdk.org/series/28396/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/128357/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/128357/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DE20A42C54;\n\tWed, 7 Jun 2023 22:52:17 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 06F7242C76;\n\tWed, 7 Jun 2023 22:52:14 +0200 (CEST)", "from mail-qk1-f193.google.com (mail-qk1-f193.google.com\n [209.85.222.193])\n by mails.dpdk.org (Postfix) with ESMTP id F21DA41611;\n Wed, 7 Jun 2023 19:57:48 +0200 (CEST)", "by mail-qk1-f193.google.com with SMTP id\n af79cd13be357-75d4dd6f012so593325785a.2;\n Wed, 07 Jun 2023 10:57:48 -0700 (PDT)", "from localhost ([2001:19f0:5:3fd8:5400:3ff:fe7e:6d40])\n by smtp.gmail.com with ESMTPSA id\n n13-20020a05620a152d00b0075ebbd60771sm63617qkk.84.2023.06.07.10.57.47\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 07 Jun 2023 10:57:47 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20221208; t=1686160668; x=1688752668;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=3QMBfvpLKXlVx/o30W90vhZ+FV78cwHKkR2N3lO8Y2Y=;\n b=hP6dKM12iq66dF6zhakkBnnlu7zMOGA8/p3wLEvYePTkW48BjmmL3YNpCDwu8VAiPG\n RK66JTwmYxs/I4elXXYltgrUBF5wENqts4pLulXiueAkQzHbkyZGmotkAGoPhLU3rz13\n RLckctMkcqF9M2Z4bK8q1e8mx7sz8bxUVz0fULSkgtGyW2s8ddhq+d8OcWFvPMpVv2ts\n Rrmu+s5VpVq2KggEoasK5xYpVybKrQUNPWR+e69OTtcP8zTtq8WwLmDkuH73K5mCipa3\n w3TsS2e62jzxEd6OKGT8M6/IDhMtyE/sQ7HrUKpclaZC2D0YnQ2NqFo9H1pQAjc6jvIG\n RvCg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1686160668; x=1688752668;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=3QMBfvpLKXlVx/o30W90vhZ+FV78cwHKkR2N3lO8Y2Y=;\n b=NGfhe5nRJMCh0Uef0xY8hlCTsDr1QmI8Tbla9ErZAQs2//Y/w+qxy7gtCB2H26LN+8\n Gc0NkTqJN0375a2el6RYQ/QF+JQYJvDy92+0j0CT1dww05FjMvb0I1SkzvgLL+KHYpmX\n 4ize1GYlZEO5pkaSgbMidBZpiOrpx/vCWUluDdNwmaCV51F/id13f/ANVsSF8unpYkXE\n 6bEOjW5dMGM5xwSr2UZmW+pPYqtY2gxoG2cMkGKzCA2iBpcXCGunL7VTg9gjr/UToZvC\n zajDmezXJjkAqLJOEes1hhCJNjpYtkw9WPksEgF6X1MRXq/iknu1t4VJSwHr0pdS0G/y\n Vohw==", "X-Gm-Message-State": "AC+VfDwasysHt0j1o3DfcyIHNagS7RL3FmgtcGg7TuwUlfqJzz60N3F6\n TEFW+O+ghaHVMmibIqw2PtNWSs2KN50v+aRAeh8=", "X-Google-Smtp-Source": "\n ACHHUZ6Xbyq6JsOIUws5lReBy+/Mhh9dOJ1eGNldWyOC+PRgI4EvuUOMVPJjzls/J6gXYNaS+oSteA==", "X-Received": "by 2002:a05:620a:8b0d:b0:75d:ecb2:36a3 with SMTP id\n qw13-20020a05620a8b0d00b0075decb236a3mr2373701qkn.69.1686160668302;\n Wed, 07 Jun 2023 10:57:48 -0700 (PDT)", "From": "Kaijun Zeng <corezeng@gmail.com>", "To": "dev@dpdk.org", "Cc": "Ferruh Yigit <ferruh.yigit@amd.com>, Kaijun Zeng <corezeng@gmail.com>,\n stable@dpdk.org, Jochen Behrens <jbehrens@vmware.com>,\n Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH v3] net/vmxnet3: fix return code in initializing", "Date": "Wed, 7 Jun 2023 13:57:25 -0400", "Message-Id": "<20230607175725.17488-1-corezeng@gmail.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20230602164438.45939-1-corezeng@gmail.com>", "References": "<20230602164438.45939-1-corezeng@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Wed, 07 Jun 2023 22:52:11 +0200", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Improve error handling\n\nBugzilla ID: 1239\nFixes: dfaff37fc46d (\"vmxnet3: import new vmxnet3 poll mode driver implementation\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kaijun Zeng <corezeng@gmail.com>\n---\nv3:\n* Improve coding style\n\nv2:\n* Improve error handling\n---\n drivers/net/vmxnet3/vmxnet3_rxtx.c | 15 +++++++++++----\n 1 file changed, 11 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c\nindex a875ffec07..e6e36dca93 100644\n--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c\n+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c\n@@ -1311,11 +1311,18 @@ vmxnet3_dev_rxtx_init(struct rte_eth_dev *dev)\n \t\tfor (j = 0; j < VMXNET3_RX_CMDRING_SIZE; j++) {\n \t\t\t/* Passing 0 as alloc_num will allocate full ring */\n \t\t\tret = vmxnet3_post_rx_bufs(rxq, j);\n-\t\t\tif (ret <= 0) {\n+\n+\t\t\t/* Zero number of descriptors in the configuration of the RX queue */\n+\t\t\tif (ret == 0) {\n \t\t\t\tPMD_INIT_LOG(ERR,\n-\t\t\t\t\t \"ERROR: Posting Rxq: %d buffers ring: %d\",\n-\t\t\t\t\t i, j);\n-\t\t\t\treturn -ret;\n+\t\t\t\t\t\"Invalid configuration in Rx queue: %d, buffers ring: %d\\n\",\n+\t\t\t\t\ti, j);\n+\t\t\t\treturn -EINVAL;\n+\t\t\t}\n+\t\t\t/* Return the error number */\n+\t\t\tif (ret < 0) {\n+\t\t\t\tPMD_INIT_LOG(ERR, \"Posting Rxq: %d buffers ring: %d\", i, j);\n+\t\t\t\treturn ret;\n \t\t\t}\n \t\t\t/*\n \t\t\t * Updating device with the index:next2fill to fill the\n", "prefixes": [ "v3" ] }