Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128356/?format=api
{ "id": 128356, "url": "http://patches.dpdk.org/api/patches/128356/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230607165410.13711-1-corezeng@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230607165410.13711-1-corezeng@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230607165410.13711-1-corezeng@gmail.com", "date": "2023-06-07T16:54:10", "name": "net/vmxnet3: fix return code in initializing", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d51954a04b1aa6f7554af557f2705e186598b647", "submitter": { "id": 3079, "url": "http://patches.dpdk.org/api/people/3079/?format=api", "name": "Kaijun Zeng", "email": "corezeng@gmail.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230607165410.13711-1-corezeng@gmail.com/mbox/", "series": [ { "id": 28395, "url": "http://patches.dpdk.org/api/series/28395/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28395", "date": "2023-06-07T16:54:10", "name": "net/vmxnet3: fix return code in initializing", "version": 1, "mbox": "http://patches.dpdk.org/series/28395/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/128356/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/128356/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4308942C54;\n\tWed, 7 Jun 2023 22:52:13 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C41D341611;\n\tWed, 7 Jun 2023 22:52:12 +0200 (CEST)", "from mail-qk1-f195.google.com (mail-qk1-f195.google.com\n [209.85.222.195])\n by mails.dpdk.org (Postfix) with ESMTP id 0B4A942C4D;\n Wed, 7 Jun 2023 18:54:39 +0200 (CEST)", "by mail-qk1-f195.google.com with SMTP id\n af79cd13be357-75d4094f9baso445270785a.1;\n Wed, 07 Jun 2023 09:54:38 -0700 (PDT)", "from localhost ([2001:19f0:5:3fd8:5400:3ff:fe7e:6d40])\n by smtp.gmail.com with ESMTPSA id\n d13-20020a05620a140d00b0075cc95eb30asm52804qkj.8.2023.06.07.09.54.37\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 07 Jun 2023 09:54:37 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20221208; t=1686156878; x=1688748878;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=0zjeQP9ec289jvSBl45VU8mh2VGRWMZozmLf/0rhgI4=;\n b=IlXeCj5fwTJmsYcryo56WqnaQW+1BOR/VXrd7AWtd5y2cMFnHUVTZT5JXAfZku+Iba\n 2J42oMa8wBQ6rVpW7ijQQsUyeruLezSccHZwcMqds8RbX9ZhO7YjFrqyzAOnQI8wdycH\n n1Mj4W9aMrRgf8yMunveMA10grJcuysTmmBwMDoC4FuOM9of3U2w+j5HnLiNCbSeSO6o\n OqGN4hcYxcdXPOBjqNLnMlMxkjp/rIh0sdY7U5tpPjnM3t5OYkliLQO10jqei4v1ojax\n cl/aNZx72QnmLGjqCKRFi2kLc4GMug6vMGEXc/K7qJViHuSiRG0/ceLtWhHTWwgfMUXr\n oPqA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1686156878; x=1688748878;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=0zjeQP9ec289jvSBl45VU8mh2VGRWMZozmLf/0rhgI4=;\n b=Kfp93/gsJzuACpiGLJ5WhlWKxZ47ka56jxhHazqCeZe7CXvG8fd4W24J03T6EfVZzx\n jOnCrFLooaLuaPMlxtYm7sZNHo/fiTSe23iMnZ0mLesY4ibENcF1xJtqLKFqLYaPig0l\n dlCMi9VtHPywksOh1BSiRICe+WnAIRMUw13QaYN78NlChX28IZtkhOGSwvJQy1hhUWIk\n Oy/qdcX83+PCbPjGUWFrqDloKFsEccSZ3eQXQMJPUBG24SNSCyek3SEdpdUaRerUsjfX\n EcbbYRR/G1pFfciTwBefupSm19FFknISNFX2CMvcFhMCttPsw+UH+DPm4KUeSkqzN/2C\n FWmQ==", "X-Gm-Message-State": "AC+VfDxgLojZ5NSDDsohFnZtmPHg2ZUttfDvzxc5w5Ja5TTdHmpAhnTv\n HsixP+lVVztrSZLnxpDPwLDdBb38s9f6xE1rsQvMoQ==", "X-Google-Smtp-Source": "\n ACHHUZ7mTTOrV8u0z7FhwZoQr8Iq0CfEGAQgV57mlCb4wEdmuzzDEM4xop8K4+QJSEAtEO0ih3dGCg==", "X-Received": "by 2002:a05:620a:4096:b0:75b:23a1:3671 with SMTP id\n f22-20020a05620a409600b0075b23a13671mr3435903qko.50.1686156878339;\n Wed, 07 Jun 2023 09:54:38 -0700 (PDT)", "From": "Kaijun Zeng <corezeng@gmail.com>", "To": "dev@dpdk.org", "Cc": "Ferruh Yigit <ferruh.yigit@amd.com>, Kaijun Zeng <corezeng@gmail.com>,\n stable@dpdk.org, Jochen Behrens <jbehrens@vmware.com>,\n Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH] net/vmxnet3: fix return code in initializing", "Date": "Wed, 7 Jun 2023 12:54:10 -0400", "Message-Id": "<20230607165410.13711-1-corezeng@gmail.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20230528143734.145326-1-user@sklga>", "References": "<20230528143734.145326-1-user@sklga>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Wed, 07 Jun 2023 22:52:11 +0200", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Improve error handling and code style\n\nBugzilla ID: 1239\n\nFixes: dfaff37fc46d (\"vmxnet3: import new vmxnet3 poll mode driver implementation\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kaijun Zeng <corezeng@gmail.com>\n\n---\n drivers/net/vmxnet3/vmxnet3_rxtx.c | 15 +++++++++++----\n 1 file changed, 11 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c\nindex a875ffec07..e6e36dca93 100644\n--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c\n+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c\n@@ -1311,11 +1311,18 @@ vmxnet3_dev_rxtx_init(struct rte_eth_dev *dev)\n \t\tfor (j = 0; j < VMXNET3_RX_CMDRING_SIZE; j++) {\n \t\t\t/* Passing 0 as alloc_num will allocate full ring */\n \t\t\tret = vmxnet3_post_rx_bufs(rxq, j);\n-\t\t\tif (ret <= 0) {\n+\n+\t\t\t/* Zero number of descriptors in the configuration of the RX queue */\n+\t\t\tif (ret == 0) {\n \t\t\t\tPMD_INIT_LOG(ERR,\n-\t\t\t\t\t \"ERROR: Posting Rxq: %d buffers ring: %d\",\n-\t\t\t\t\t i, j);\n-\t\t\t\treturn -ret;\n+\t\t\t\t\t\"Invalid configuration in Rx queue: %d, buffers ring: %d\\n\",\n+\t\t\t\t\ti, j);\n+\t\t\t\treturn -EINVAL;\n+\t\t\t}\n+\t\t\t/* Return the error number */\n+\t\t\tif (ret < 0) {\n+\t\t\t\tPMD_INIT_LOG(ERR, \"Posting Rxq: %d buffers ring: %d\", i, j);\n+\t\t\t\treturn ret;\n \t\t\t}\n \t\t\t/*\n \t\t\t * Updating device with the index:next2fill to fill the\n", "prefixes": [] }