Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128310/?format=api
{ "id": 128310, "url": "http://patches.dpdk.org/api/patches/128310/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230607130245.8048-22-ivan.malov@arknetworks.am/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230607130245.8048-22-ivan.malov@arknetworks.am>", "list_archive_url": "https://inbox.dpdk.org/dev/20230607130245.8048-22-ivan.malov@arknetworks.am", "date": "2023-06-07T13:02:32", "name": "[v4,21/34] common/sfc_efx/base: provide an API to clone MAE match specs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "71dfefc58c83b8adeb150cc7d1c12297c31ace6b", "submitter": { "id": 2962, "url": "http://patches.dpdk.org/api/people/2962/?format=api", "name": "Ivan Malov", "email": "ivan.malov@arknetworks.am" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230607130245.8048-22-ivan.malov@arknetworks.am/mbox/", "series": [ { "id": 28390, "url": "http://patches.dpdk.org/api/series/28390/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28390", "date": "2023-06-07T13:02:11", "name": "net/sfc: support HW conntrack assistance", "version": 4, "mbox": "http://patches.dpdk.org/series/28390/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/128310/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/128310/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5EF9C42C4D;\n\tWed, 7 Jun 2023 15:05:59 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B601C42F88;\n\tWed, 7 Jun 2023 15:03:13 +0200 (CEST)", "from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80])\n by mails.dpdk.org (Postfix) with ESMTP id CCB45427F2\n for <dev@dpdk.org>; Wed, 7 Jun 2023 15:02:58 +0200 (CEST)", "from localhost.localdomain (unknown [78.109.69.83])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by agw.arknetworks.am (Postfix) with ESMTPSA id 57EA9E1B5B;\n Wed, 7 Jun 2023 17:02:58 +0400 (+04)" ], "From": "Ivan Malov <ivan.malov@arknetworks.am>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Ferruh Yigit <ferruh.yigit@amd.com>, Andy Moreton <amoreton@xilinx.com>", "Subject": "[PATCH v4 21/34] common/sfc_efx/base: provide an API to clone MAE\n match specs", "Date": "Wed, 7 Jun 2023 17:02:32 +0400", "Message-Id": "<20230607130245.8048-22-ivan.malov@arknetworks.am>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20230607130245.8048-1-ivan.malov@arknetworks.am>", "References": "<20230601195538.8265-1-ivan.malov@arknetworks.am>\n <20230607130245.8048-1-ivan.malov@arknetworks.am>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The DPDK driver would like to have a means to make a copy of\nthe action rule match specification before trying to dissect\nit to possibly move out the per-connection 5-tuple data from\nit to build up an entry in the HW conntrack assistance table.\n\nMaking such a copy at the end of parsing should be preferred\nover maintaining DPDK-level structures because the resulting\ncode is easier on eyes and less prone to errors in this case.\n\nSigned-off-by: Ivan Malov <ivan.malov@arknetworks.am>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/common/sfc_efx/base/efx.h | 7 +++++++\n drivers/common/sfc_efx/base/efx_mae.c | 26 ++++++++++++++++++++++++++\n drivers/common/sfc_efx/version.map | 1 +\n 3 files changed, 34 insertions(+)", "diff": "diff --git a/drivers/common/sfc_efx/base/efx.h b/drivers/common/sfc_efx/base/efx.h\nindex 49f807823e..97271f0f00 100644\n--- a/drivers/common/sfc_efx/base/efx.h\n+++ b/drivers/common/sfc_efx/base/efx.h\n@@ -4452,6 +4452,13 @@ efx_mae_match_spec_recirc_id_set(\n \t__in\t\t\t\tefx_mae_match_spec_t *spec,\n \t__in\t\t\t\tuint8_t recirc_id);\n \n+LIBEFX_API\n+extern\t__checkReturn\t\t\tefx_rc_t\n+efx_mae_match_spec_clone(\n+\t__in\t\t\t\tefx_nic_t *enp,\n+\t__in\t\t\t\tefx_mae_match_spec_t *orig,\n+\t__out\t\t\t\tefx_mae_match_spec_t **clonep);\n+\n LIBEFX_API\n extern\t__checkReturn\t\t\tboolean_t\n efx_mae_match_specs_equal(\ndiff --git a/drivers/common/sfc_efx/base/efx_mae.c b/drivers/common/sfc_efx/base/efx_mae.c\nindex 7732d99992..43dfba518a 100644\n--- a/drivers/common/sfc_efx/base/efx_mae.c\n+++ b/drivers/common/sfc_efx/base/efx_mae.c\n@@ -1163,6 +1163,32 @@ efx_mae_match_spec_mport_set(\n \n fail2:\n \tEFSYS_PROBE(fail2);\n+fail1:\n+\tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n+\treturn (rc);\n+}\n+\n+\t__checkReturn\t\t\tefx_rc_t\n+efx_mae_match_spec_clone(\n+\t__in\t\t\t\tefx_nic_t *enp,\n+\t__in\t\t\t\tefx_mae_match_spec_t *orig,\n+\t__out\t\t\t\tefx_mae_match_spec_t **clonep)\n+{\n+\tefx_mae_match_spec_t *clone;\n+\tefx_rc_t rc;\n+\n+\tEFSYS_KMEM_ALLOC(enp->en_esip, sizeof (*clone), clone);\n+\tif (clone == NULL) {\n+\t\trc = ENOMEM;\n+\t\tgoto fail1;\n+\t}\n+\n+\tmemcpy(clone, orig, sizeof (efx_mae_match_spec_t));\n+\n+\t*clonep = clone;\n+\n+\treturn (0);\n+\n fail1:\n \tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n \treturn (rc);\ndiff --git a/drivers/common/sfc_efx/version.map b/drivers/common/sfc_efx/version.map\nindex d083a54a03..931d556e80 100644\n--- a/drivers/common/sfc_efx/version.map\n+++ b/drivers/common/sfc_efx/version.map\n@@ -124,6 +124,7 @@ INTERNAL {\n \tefx_mae_mac_addr_alloc;\n \tefx_mae_mac_addr_free;\n \tefx_mae_match_spec_bit_set;\n+\tefx_mae_match_spec_clone;\n \tefx_mae_match_spec_field_set;\n \tefx_mae_match_spec_fini;\n \tefx_mae_match_spec_init;\n", "prefixes": [ "v4", "21/34" ] }