Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128300/?format=api
{ "id": 128300, "url": "http://patches.dpdk.org/api/patches/128300/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230607130245.8048-12-ivan.malov@arknetworks.am/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230607130245.8048-12-ivan.malov@arknetworks.am>", "list_archive_url": "https://inbox.dpdk.org/dev/20230607130245.8048-12-ivan.malov@arknetworks.am", "date": "2023-06-07T13:02:22", "name": "[v4,11/34] net/sfc: add API to manage HW Conntrack table", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6706d001490dbfabdefc0b5bed35a257c7e31e91", "submitter": { "id": 2962, "url": "http://patches.dpdk.org/api/people/2962/?format=api", "name": "Ivan Malov", "email": "ivan.malov@arknetworks.am" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230607130245.8048-12-ivan.malov@arknetworks.am/mbox/", "series": [ { "id": 28390, "url": "http://patches.dpdk.org/api/series/28390/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28390", "date": "2023-06-07T13:02:11", "name": "net/sfc: support HW conntrack assistance", "version": 4, "mbox": "http://patches.dpdk.org/series/28390/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/128300/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/128300/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C9F3942C4D;\n\tWed, 7 Jun 2023 15:04:31 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A826C42D6C;\n\tWed, 7 Jun 2023 15:03:00 +0200 (CEST)", "from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80])\n by mails.dpdk.org (Postfix) with ESMTP id 3466E42D39\n for <dev@dpdk.org>; Wed, 7 Jun 2023 15:02:53 +0200 (CEST)", "from localhost.localdomain (unknown [78.109.69.83])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by agw.arknetworks.am (Postfix) with ESMTPSA id A044BE12CA;\n Wed, 7 Jun 2023 17:02:52 +0400 (+04)" ], "From": "Ivan Malov <ivan.malov@arknetworks.am>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Ferruh Yigit <ferruh.yigit@amd.com>,\n Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>,\n Andy Moreton <amoreton@xilinx.com>", "Subject": "[PATCH v4 11/34] net/sfc: add API to manage HW Conntrack table", "Date": "Wed, 7 Jun 2023 17:02:22 +0400", "Message-Id": "<20230607130245.8048-12-ivan.malov@arknetworks.am>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20230607130245.8048-1-ivan.malov@arknetworks.am>", "References": "<20230601195538.8265-1-ivan.malov@arknetworks.am>\n <20230607130245.8048-1-ivan.malov@arknetworks.am>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>\n\nThe new API allows to manipulate entries in\nthe HW Conntrack table.\nIt uses a new Table Access API as a backend.\n\nSigned-off-by: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>\nReviewed-by: Ivan Malov <ivan.malov@arknetworks.am>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/net/sfc/meson.build | 1 +\n drivers/net/sfc/sfc_mae_ct.c | 201 +++++++++++++++++++++++++++++++++++\n drivers/net/sfc/sfc_mae_ct.h | 68 ++++++++++++\n 3 files changed, 270 insertions(+)\n create mode 100644 drivers/net/sfc/sfc_mae_ct.c\n create mode 100644 drivers/net/sfc/sfc_mae_ct.h", "diff": "diff --git a/drivers/net/sfc/meson.build b/drivers/net/sfc/meson.build\nindex c9d4264674..5adde68517 100644\n--- a/drivers/net/sfc/meson.build\n+++ b/drivers/net/sfc/meson.build\n@@ -92,6 +92,7 @@ sources = files(\n 'sfc_tbl_meta_cache.c',\n 'sfc_mae.c',\n 'sfc_mae_counter.c',\n+ 'sfc_mae_ct.c',\n 'sfc_flow.c',\n 'sfc_flow_rss.c',\n 'sfc_flow_tunnel.c',\ndiff --git a/drivers/net/sfc/sfc_mae_ct.c b/drivers/net/sfc/sfc_mae_ct.c\nnew file mode 100644\nindex 0000000000..fd6819c8a5\n--- /dev/null\n+++ b/drivers/net/sfc/sfc_mae_ct.c\n@@ -0,0 +1,201 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ *\n+ * Copyright (c) 2023 Advanced Micro Devices, Inc.\n+ */\n+\n+#include \"sfc.h\"\n+#include \"sfc_mae_ct.h\"\n+\n+/* SF-123102-TC-1A § 10.6.3: Conntrack_Table key */\n+static void\n+sfc_mae_ct_key_to_mcdi_key(const sfc_mae_conntrack_key_t *key,\n+\t\t\t const efx_table_field_descriptor_t *fields,\n+\t\t\t unsigned int n_fields, uint32_t *mcdi_key,\n+\t\t\t unsigned int key_size)\n+{\n+\tunsigned int i;\n+\n+\tfor (i = 0; i < n_fields; i++) {\n+\t\tconst efx_table_field_descriptor_t *desc = &fields[i];\n+\n+\t\tif (desc->mask_type == EFX_TABLE_FIELD_MASK_NEVER)\n+\t\t\tcontinue;\n+\n+\t\tswitch (desc->field_id) {\n+\t\tcase EFX_TABLE_FIELD_ID_IP_PROTO:\n+\t\t\tsfc_tbls_field_set_u8(mcdi_key, key_size, desc->lbn,\n+\t\t\t\t\t desc->width, key->ip_proto);\n+\t\t\tbreak;\n+\t\tcase EFX_TABLE_FIELD_ID_ETHER_TYPE:\n+\t\t\tsfc_tbls_field_set_u16(mcdi_key, key_size, desc->lbn,\n+\t\t\t\t\t desc->width, key->ether_type_le);\n+\t\t\tbreak;\n+\t\tcase EFX_TABLE_FIELD_ID_SRC_PORT:\n+\t\t\tsfc_tbls_field_set_u16(mcdi_key, key_size, desc->lbn,\n+\t\t\t\t\t desc->width, key->src_port_le);\n+\t\t\tbreak;\n+\t\tcase EFX_TABLE_FIELD_ID_DST_PORT:\n+\t\t\tsfc_tbls_field_set_u16(mcdi_key, key_size, desc->lbn,\n+\t\t\t\t\t desc->width, key->dst_port_le);\n+\t\t\tbreak;\n+\t\tcase EFX_TABLE_FIELD_ID_SRC_IP:\n+\t\t\tsfc_tbls_field_set_ip(mcdi_key, key_size, desc->lbn,\n+\t\t\t\t\t desc->width,\n+\t\t\t\t\t (const uint32_t *)key->src_addr_le);\n+\t\t\tbreak;\n+\t\tcase EFX_TABLE_FIELD_ID_DST_IP:\n+\t\t\tsfc_tbls_field_set_ip(mcdi_key, key_size, desc->lbn,\n+\t\t\t\t\t desc->width,\n+\t\t\t\t\t (const uint32_t *)key->dst_addr_le);\n+\t\t\tbreak;\n+\n+\t\tdefault:\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+}\n+\n+/* SF-123102-TC-1A § 10.6.4: Conntrack_Table response */\n+static void\n+sfc_mae_ct_response_to_mcdi_response(const sfc_mae_conntrack_response_t *response,\n+\t\t\t\t const efx_table_field_descriptor_t *fields,\n+\t\t\t\t unsigned int n_fields, uint32_t *mcdi_resp,\n+\t\t\t\t unsigned int resp_size)\n+{\n+\tunsigned int i;\n+\n+\tfor (i = 0; i < n_fields; i++) {\n+\t\tconst efx_table_field_descriptor_t *desc = &fields[i];\n+\n+\t\tif (desc->mask_type == EFX_TABLE_FIELD_MASK_NEVER)\n+\t\t\tcontinue;\n+\n+\t\t/* Fields of responses are always reported with the EXACT type. */\n+\t\tSFC_ASSERT(desc->mask_type == EFX_TABLE_FIELD_MASK_EXACT);\n+\n+\t\tswitch (desc->field_id) {\n+\t\tcase EFX_TABLE_FIELD_ID_CT_MARK:\n+\t\t\tsfc_tbls_field_set_u32(mcdi_resp, resp_size, desc->lbn,\n+\t\t\t\t\t desc->width, response->ct_mark);\n+\t\t\tbreak;\n+\t\tcase EFX_TABLE_FIELD_ID_COUNTER_ID:\n+\t\t\tsfc_tbls_field_set_u32(mcdi_resp, resp_size, desc->lbn,\n+\t\t\t\t\t desc->width, response->counter_id);\n+\t\t\tbreak;\n+\t\tcase EFX_TABLE_FIELD_ID_NAT_DIR:\n+\t\t\tsfc_tbls_field_set_u8(mcdi_resp, resp_size, desc->lbn,\n+\t\t\t\t\t desc->width, response->nat.dir_is_dst);\n+\t\t\tbreak;\n+\t\tcase EFX_TABLE_FIELD_ID_NAT_IP:\n+\t\t\tsfc_tbls_field_set_u32(mcdi_resp, resp_size, desc->lbn,\n+\t\t\t\t\t desc->width, response->nat.ip_le);\n+\t\t\tbreak;\n+\t\tcase EFX_TABLE_FIELD_ID_NAT_PORT:\n+\t\t\tsfc_tbls_field_set_u16(mcdi_resp, resp_size, desc->lbn,\n+\t\t\t\t\t desc->width, response->nat.port_le);\n+\t\t\tbreak;\n+\n+\t\tdefault:\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+}\n+\n+int\n+sfc_mae_conntrack_insert(struct sfc_adapter *sa,\n+\t\t\t const sfc_mae_conntrack_key_t *key,\n+\t\t\t const sfc_mae_conntrack_response_t *response)\n+{\n+\tconst struct sfc_tbls *tables = &sa->hw_tables;\n+\tuint8_t data[EFX_TABLE_ENTRY_LENGTH_MAX] = {0};\n+\tconst struct sfc_tbl_meta *meta = NULL;\n+\tunsigned int response_size;\n+\tuint32_t *response_data;\n+\tunsigned int data_size;\n+\tunsigned int key_size;\n+\tuint32_t *start_data;\n+\tuint16_t resp_width;\n+\tuint16_t key_width;\n+\tuint32_t *key_data;\n+\tuint32_t *end_data;\n+\tint rc = 0;\n+\n+\tif (tables->status != SFC_TBLS_STATUS_SUPPORTED)\n+\t\treturn -ENOTSUP;\n+\n+\tif (!sfc_mae_conntrack_is_supported(sa))\n+\t\treturn -ENOTSUP;\n+\n+\tmeta = sfc_mae_conntrack_meta_lookup(sa);\n+\tif (meta == NULL)\n+\t\treturn -ENOENT;\n+\n+\tkey_width = meta->descriptor.key_width;\n+\tresp_width = meta->descriptor.resp_width;\n+\n+\tstart_data = (uint32_t *)data;\n+\tkey_data = start_data;\n+\tresponse_data = sfc_tbls_next_req_fields(key_data, key_width);\n+\tend_data = sfc_tbls_next_req_fields(response_data, resp_width);\n+\n+\tkey_size = RTE_PTR_DIFF(response_data, key_data);\n+\tresponse_size = RTE_PTR_DIFF(end_data, response_data);\n+\tdata_size = RTE_PTR_DIFF(end_data, start_data);\n+\tSFC_ASSERT(data_size <= sizeof(data));\n+\n+\tsfc_mae_ct_key_to_mcdi_key(key, meta->keys,\n+\t\t\t\t meta->descriptor.n_key_fields, key_data,\n+\t\t\t\t key_size);\n+\tsfc_mae_ct_response_to_mcdi_response(response, meta->responses,\n+\t\t\t\t\t meta->descriptor.n_resp_fields,\n+\t\t\t\t\t response_data, response_size);\n+\n+\trc = sfc_tbls_bcam_entry_insert(sa->nic, EFX_TABLE_ID_CONNTRACK,\n+\t\t\t\t\tkey_width, resp_width, data,\n+\t\t\t\t\tdata_size);\n+\n+\treturn rc;\n+}\n+\n+int\n+sfc_mae_conntrack_delete(struct sfc_adapter *sa,\n+\t\t\t const sfc_mae_conntrack_key_t *key)\n+{\n+\tconst struct sfc_tbls *tables = &sa->hw_tables;\n+\tuint8_t data[EFX_TABLE_ENTRY_LENGTH_MAX] = {0};\n+\tconst struct sfc_tbl_meta *meta = NULL;\n+\tunsigned int data_size;\n+\tuint32_t *start_data;\n+\tuint16_t key_width;\n+\tuint32_t *key_data;\n+\tuint32_t *end_data;\n+\tint rc = 0;\n+\n+\tif (tables->status != SFC_TBLS_STATUS_SUPPORTED)\n+\t\treturn -ENOTSUP;\n+\n+\tif (!sfc_mae_conntrack_is_supported(sa))\n+\t\treturn -ENOTSUP;\n+\n+\tmeta = sfc_mae_conntrack_meta_lookup(sa);\n+\tif (meta == NULL)\n+\t\treturn -ENOENT;\n+\n+\tkey_width = meta->descriptor.key_width;\n+\n+\tstart_data = (uint32_t *)data;\n+\tkey_data = start_data;\n+\tend_data = sfc_tbls_next_req_fields(key_data, key_width);\n+\n+\tdata_size = RTE_PTR_DIFF(end_data, start_data);\n+\tSFC_ASSERT(data_size <= sizeof(data));\n+\n+\tsfc_mae_ct_key_to_mcdi_key(key, meta->keys,\n+\t\t\t\t meta->descriptor.n_key_fields,\n+\t\t\t\t key_data, data_size);\n+\n+\trc = sfc_tbls_bcam_entry_delete(sa->nic, EFX_TABLE_ID_CONNTRACK,\n+\t\t\t\t\tkey_width, data, data_size);\n+\n+\treturn rc;\n+}\ndiff --git a/drivers/net/sfc/sfc_mae_ct.h b/drivers/net/sfc/sfc_mae_ct.h\nnew file mode 100644\nindex 0000000000..b5a3181cd3\n--- /dev/null\n+++ b/drivers/net/sfc/sfc_mae_ct.h\n@@ -0,0 +1,68 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ *\n+ * Copyright (c) 2023 Advanced Micro Devices, Inc.\n+ */\n+\n+#ifndef _SFC_MAE_CONNTRACK_H\n+#define _SFC_MAE_CONNTRACK_H\n+\n+#include <stdbool.h>\n+\n+#include <rte_ip.h>\n+\n+#include \"efx.h\"\n+\n+#include \"sfc_tbls.h\"\n+\n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n+typedef struct sfc_mae_conntrack_key_s {\n+\tuint8_t\t\tip_proto;\n+\tuint16_t\tether_type_le;\n+\n+\tuint16_t\tsrc_port_le;\n+\tuint16_t\tdst_port_le;\n+\n+\tuint8_t\t\tsrc_addr_le[RTE_SIZEOF_FIELD(struct rte_ipv6_hdr, src_addr)];\n+\tuint8_t\t\tdst_addr_le[RTE_SIZEOF_FIELD(struct rte_ipv6_hdr, dst_addr)];\n+} sfc_mae_conntrack_key_t;\n+\n+typedef struct sfc_mae_conntrack_nat_s {\n+\tuint32_t\tip_le;\n+\tuint16_t\tport_le;\n+\tbool\t\tdir_is_dst;\n+} sfc_mae_conntrack_nat_t;\n+\n+typedef struct sfc_mae_conntrack_response_s {\n+\tuint32_t\t\tct_mark;\n+\tsfc_mae_conntrack_nat_t\tnat;\n+\tuint32_t\t\tcounter_id;\n+} sfc_mae_conntrack_response_t;\n+\n+struct sfc_adapter;\n+\n+static inline bool\n+sfc_mae_conntrack_is_supported(struct sfc_adapter *sa)\n+{\n+\treturn sfc_tbls_id_is_supported(sa, EFX_TABLE_ID_CONNTRACK);\n+}\n+\n+static inline const struct sfc_tbl_meta *\n+sfc_mae_conntrack_meta_lookup(struct sfc_adapter *sa)\n+{\n+\treturn sfc_tbl_meta_lookup(sa, EFX_TABLE_ID_CONNTRACK);\n+}\n+\n+int sfc_mae_conntrack_insert(struct sfc_adapter *sa,\n+\t\t\t const sfc_mae_conntrack_key_t *key,\n+\t\t\t const sfc_mae_conntrack_response_t *response);\n+\n+int sfc_mae_conntrack_delete(struct sfc_adapter *sa,\n+\t\t\t const sfc_mae_conntrack_key_t *key);\n+\n+#ifdef __cplusplus\n+}\n+#endif\n+#endif /* _SFC_MAE_CONNTRACK_H */\n", "prefixes": [ "v4", "11/34" ] }