Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128260/?format=api
{ "id": 128260, "url": "http://patches.dpdk.org/api/patches/128260/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230607035144.1214492-13-zhirun.yan@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230607035144.1214492-13-zhirun.yan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230607035144.1214492-13-zhirun.yan@intel.com", "date": "2023-06-07T03:51:39", "name": "[v9,12/17] graph: introduce graph walk by cross-core dispatch", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "6365af4fc8cca11a356dabb9121419a64e75fd07", "submitter": { "id": 1154, "url": "http://patches.dpdk.org/api/people/1154/?format=api", "name": "Yan, Zhirun", "email": "zhirun.yan@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230607035144.1214492-13-zhirun.yan@intel.com/mbox/", "series": [ { "id": 28383, "url": "http://patches.dpdk.org/api/series/28383/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28383", "date": "2023-06-07T03:51:27", "name": "graph enhancement for multi-core dispatch", "version": 9, "mbox": "http://patches.dpdk.org/series/28383/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/128260/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/128260/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 38ED042C46;\n\tWed, 7 Jun 2023 06:01:12 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7691B42D8B;\n\tWed, 7 Jun 2023 06:00:29 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id 45A1F42D6C\n for <dev@dpdk.org>; Wed, 7 Jun 2023 06:00:26 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 06 Jun 2023 21:00:25 -0700", "from dpdk-zhirun-lmm.sh.intel.com ([10.67.119.94])\n by orsmga006.jf.intel.com with ESMTP; 06 Jun 2023 21:00:22 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1686110426; x=1717646426;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=J6yvh+QMdHB91tvUuhJGraJTLG7gKn7LGa0hBaNxO6E=;\n b=l1C8sxsESMmDYGdGMal3ppJwUSF1uXLAfqqDQw2bSxHEk4KlK7sIuKsJ\n 1nw1wG6lvx6zhg0APwvMmHL6z/ilbZKVJqd444LWG/+f9KVkR6fjF6ttG\n mRS2QlVRQnwp3YgLT3q47uc0FqqytlPDSeYNJxzTZ+t113crhzs0q+OAi\n JzVyHqz8r6SFz+VYmvNG5XFSys+4H2VZmOvNgnPGv3jen95Blh8Ygi4dj\n hFot0Asl087N5Yal3hvj1x7n6u0EJxvhRUzgHTegIzUS0xRZmpbClOnet\n 62lP7HbdjOK/DKldjBiqfowVX6AM6bk2wFILgVNouSNzu43ZjR7YQOG+h w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10733\"; a=\"359336690\"", "E=Sophos;i=\"6.00,222,1681196400\"; d=\"scan'208\";a=\"359336690\"", "E=McAfee;i=\"6600,9927,10733\"; a=\"686759349\"", "E=Sophos;i=\"6.00,222,1681196400\"; d=\"scan'208\";a=\"686759349\"" ], "X-ExtLoop1": "1", "From": "Zhirun Yan <zhirun.yan@intel.com>", "To": "dev@dpdk.org, jerinj@marvell.com, kirankumark@marvell.com,\n ndabilpuram@marvell.com, stephen@networkplumber.org,\n pbhagavatula@marvell.com, jerinjacobk@gmail.com", "Cc": "cunming.liang@intel.com, haiyue.wang@intel.com,\n mattias.ronnblom@ericsson.com, Zhirun Yan <zhirun.yan@intel.com>", "Subject": "[PATCH v9 12/17] graph: introduce graph walk by cross-core dispatch", "Date": "Wed, 7 Jun 2023 11:51:39 +0800", "Message-Id": "<20230607035144.1214492-13-zhirun.yan@intel.com>", "X-Mailer": "git-send-email 2.37.2", "In-Reply-To": "<20230607035144.1214492-1-zhirun.yan@intel.com>", "References": "<20230606144746.708388-1-zhirun.yan@intel.com>\n <20230607035144.1214492-1-zhirun.yan@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch introduces the task scheduler mechanism to enable dispatching\ntasks to another worker cores. Currently, there is only a local work\nqueue for one graph to walk. We introduce a scheduler worker queue in\neach worker core for dispatching tasks. It will perform the walk on\nscheduler work queue first, then handle the local work queue.\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\nSigned-off-by: Cunming Liang <cunming.liang@intel.com>\nSigned-off-by: Zhirun Yan <zhirun.yan@intel.com>\n---\n lib/graph/rte_graph_model_mcore_dispatch.h | 44 ++++++++++++++++++++++\n 1 file changed, 44 insertions(+)", "diff": "diff --git a/lib/graph/rte_graph_model_mcore_dispatch.h b/lib/graph/rte_graph_model_mcore_dispatch.h\nindex 6163f96c37..c78a3bbdf9 100644\n--- a/lib/graph/rte_graph_model_mcore_dispatch.h\n+++ b/lib/graph/rte_graph_model_mcore_dispatch.h\n@@ -83,6 +83,50 @@ __rte_experimental\n int rte_graph_model_mcore_dispatch_node_lcore_affinity_set(const char *name,\n \t\t\t\t\t\t\t unsigned int lcore_id);\n \n+/**\n+ * Perform graph walk on the circular buffer and invoke the process function\n+ * of the nodes and collect the stats.\n+ *\n+ * @param graph\n+ * Graph pointer returned from rte_graph_lookup function.\n+ *\n+ * @see rte_graph_lookup()\n+ */\n+__rte_experimental\n+static inline void\n+rte_graph_walk_mcore_dispatch(struct rte_graph *graph)\n+{\n+\tconst rte_graph_off_t *cir_start = graph->cir_start;\n+\tconst rte_node_t mask = graph->cir_mask;\n+\tuint32_t head = graph->head;\n+\tstruct rte_node *node;\n+\n+\tRTE_ASSERT(graph->parent_id != RTE_GRAPH_ID_INVALID);\n+\tif (graph->dispatch.wq != NULL)\n+\t\t__rte_graph_mcore_dispatch_sched_wq_process(graph);\n+\n+\twhile (likely(head != graph->tail)) {\n+\t\tnode = (struct rte_node *)RTE_PTR_ADD(graph, cir_start[(int32_t)head++]);\n+\n+\t\t/* skip the src nodes which not bind with current worker */\n+\t\tif ((int32_t)head < 0 && node->dispatch.lcore_id != graph->dispatch.lcore_id)\n+\t\t\tcontinue;\n+\n+\t\t/* Schedule the node until all task/objs are done */\n+\t\tif (node->dispatch.lcore_id != RTE_MAX_LCORE &&\n+\t\t graph->dispatch.lcore_id != node->dispatch.lcore_id &&\n+\t\t graph->dispatch.rq != NULL &&\n+\t\t __rte_graph_mcore_dispatch_sched_node_enqueue(node, graph->dispatch.rq))\n+\t\t\tcontinue;\n+\n+\t\t__rte_node_process(graph, node);\n+\n+\t\thead = likely((int32_t)head > 0) ? head & mask : head;\n+\t}\n+\n+\tgraph->tail = 0;\n+}\n+\n #ifdef __cplusplus\n }\n #endif\n", "prefixes": [ "v9", "12/17" ] }