Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128255/?format=api
http://patches.dpdk.org/api/patches/128255/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230607035144.1214492-8-zhirun.yan@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230607035144.1214492-8-zhirun.yan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230607035144.1214492-8-zhirun.yan@intel.com", "date": "2023-06-07T03:51:34", "name": "[v9,07/17] graph: move node clone name func into private as common", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "1c52a013aa4c5be5839fcfa5e4479b7c0dac9838", "submitter": { "id": 1154, "url": "http://patches.dpdk.org/api/people/1154/?format=api", "name": "Yan, Zhirun", "email": "zhirun.yan@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230607035144.1214492-8-zhirun.yan@intel.com/mbox/", "series": [ { "id": 28383, "url": "http://patches.dpdk.org/api/series/28383/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28383", "date": "2023-06-07T03:51:27", "name": "graph enhancement for multi-core dispatch", "version": 9, "mbox": "http://patches.dpdk.org/series/28383/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/128255/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/128255/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4D7AC42C46;\n\tWed, 7 Jun 2023 06:00:40 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D245542D44;\n\tWed, 7 Jun 2023 06:00:22 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id 9105942D38\n for <dev@dpdk.org>; Wed, 7 Jun 2023 06:00:18 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 06 Jun 2023 21:00:17 -0700", "from dpdk-zhirun-lmm.sh.intel.com ([10.67.119.94])\n by orsmga006.jf.intel.com with ESMTP; 06 Jun 2023 21:00:05 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1686110418; x=1717646418;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=WCFvBmK+rTDHcSHbPyRP1RLErZOEt4Nj/q9/+o2jH3s=;\n b=UNQ8Q/+Kyv9saYZge9tnYzrumZInC2L9vyikpsE5nmBdEDjN4dQs8Hn1\n u4qOyj/Ocg/wPX4zGucY+zS+PDHISFz5+YBthsYyC1q/kN8YIxNvklqHJ\n Xr1f15B37l1KpBx3rk+Y+xHNJS55MpQPwk0U/Gea00Uk6cHdZYU8WvRrW\n aOsX/klXjK39x0nuNiApYd+EWqn1+MMDVhYHrGsiCfnESfoQ7y6hL3sIZ\n QnUTGVl30Lu2x6xB5hTF7U9j77b/HoC82cYJKeGlfejS8IQnLlXXgJR4R\n uqlq/X7loGpcYC9VgJX+4R3CEc0QtL4WWpxCUmEKAN/eRQRJJSKwObU1u g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10733\"; a=\"359336618\"", "E=Sophos;i=\"6.00,222,1681196400\"; d=\"scan'208\";a=\"359336618\"", "E=McAfee;i=\"6600,9927,10733\"; a=\"686759260\"", "E=Sophos;i=\"6.00,222,1681196400\"; d=\"scan'208\";a=\"686759260\"" ], "X-ExtLoop1": "1", "From": "Zhirun Yan <zhirun.yan@intel.com>", "To": "dev@dpdk.org, jerinj@marvell.com, kirankumark@marvell.com,\n ndabilpuram@marvell.com, stephen@networkplumber.org,\n pbhagavatula@marvell.com, jerinjacobk@gmail.com", "Cc": "cunming.liang@intel.com, haiyue.wang@intel.com,\n mattias.ronnblom@ericsson.com, Zhirun Yan <zhirun.yan@intel.com>", "Subject": "[PATCH v9 07/17] graph: move node clone name func into private as\n common", "Date": "Wed, 7 Jun 2023 11:51:34 +0800", "Message-Id": "<20230607035144.1214492-8-zhirun.yan@intel.com>", "X-Mailer": "git-send-email 2.37.2", "In-Reply-To": "<20230607035144.1214492-1-zhirun.yan@intel.com>", "References": "<20230606144746.708388-1-zhirun.yan@intel.com>\n <20230607035144.1214492-1-zhirun.yan@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Move clone_name() into graph_private.h as a common function for both node\nand graph to naming a new cloned object.\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\nSigned-off-by: Cunming Liang <cunming.liang@intel.com>\nSigned-off-by: Zhirun Yan <zhirun.yan@intel.com>\n---\n lib/graph/graph_private.h | 41 +++++++++++++++++++++++++++++++++++++++\n lib/graph/node.c | 26 +------------------------\n 2 files changed, 42 insertions(+), 25 deletions(-)", "diff": "diff --git a/lib/graph/graph_private.h b/lib/graph/graph_private.h\nindex 6d2137c81b..a6d8c6e98b 100644\n--- a/lib/graph/graph_private.h\n+++ b/lib/graph/graph_private.h\n@@ -11,6 +11,8 @@\n #include <rte_common.h>\n #include <rte_eal.h>\n #include <rte_spinlock.h>\n+#include <rte_errno.h>\n+#include <rte_string_fns.h>\n \n #include \"rte_graph.h\"\n #include \"rte_graph_worker.h\"\n@@ -114,6 +116,45 @@ struct graph {\n \t/**< Nodes in a graph. */\n };\n \n+/* Node and graph common functions */\n+/**\n+ * @internal\n+ *\n+ * Naming a cloned graph or node by appending a string to base name.\n+ *\n+ * @param new_name\n+ * Pointer to the name of the cloned object.\n+ * @param base_name\n+ * Pointer to the name of original object.\n+ * @param append_str\n+ * Pointer to the appended string.\n+ *\n+ * @return\n+ * 0 on success, negative errno value otherwise.\n+ */\n+static inline int clone_name(char *new_name, char *base_name, const char *append_str)\n+{\n+\tssize_t sz, rc;\n+\n+#define SZ RTE_MIN(RTE_NODE_NAMESIZE, RTE_GRAPH_NAMESIZE)\n+\trc = rte_strscpy(new_name, base_name, SZ);\n+\tif (rc < 0)\n+\t\tgoto fail;\n+\tsz = rc;\n+\trc = rte_strscpy(new_name + sz, \"-\", RTE_MAX((int16_t)(SZ - sz), 0));\n+\tif (rc < 0)\n+\t\tgoto fail;\n+\tsz += rc;\n+\tsz = rte_strscpy(new_name + sz, append_str, RTE_MAX((int16_t)(SZ - sz), 0));\n+\tif (sz < 0)\n+\t\tgoto fail;\n+\n+\treturn 0;\n+fail:\n+\trte_errno = E2BIG;\n+\treturn -rte_errno;\n+}\n+\n /* Node functions */\n STAILQ_HEAD(node_head, node);\n \ndiff --git a/lib/graph/node.c b/lib/graph/node.c\nindex 339b4a0da5..99a9622779 100644\n--- a/lib/graph/node.c\n+++ b/lib/graph/node.c\n@@ -115,30 +115,6 @@ __rte_node_register(const struct rte_node_register *reg)\n \treturn RTE_NODE_ID_INVALID;\n }\n \n-static int\n-clone_name(struct rte_node_register *reg, struct node *node, const char *name)\n-{\n-\tssize_t sz, rc;\n-\n-#define SZ RTE_NODE_NAMESIZE\n-\trc = rte_strscpy(reg->name, node->name, SZ);\n-\tif (rc < 0)\n-\t\tgoto fail;\n-\tsz = rc;\n-\trc = rte_strscpy(reg->name + sz, \"-\", RTE_MAX((int16_t)(SZ - sz), 0));\n-\tif (rc < 0)\n-\t\tgoto fail;\n-\tsz += rc;\n-\tsz = rte_strscpy(reg->name + sz, name, RTE_MAX((int16_t)(SZ - sz), 0));\n-\tif (sz < 0)\n-\t\tgoto fail;\n-\n-\treturn 0;\n-fail:\n-\trte_errno = E2BIG;\n-\treturn -rte_errno;\n-}\n-\n static rte_node_t\n node_clone(struct node *node, const char *name)\n {\n@@ -170,7 +146,7 @@ node_clone(struct node *node, const char *name)\n \t\treg->next_nodes[i] = node->next_nodes[i];\n \n \t/* Naming ceremony of the new node. name is node->name + \"-\" + name */\n-\tif (clone_name(reg, node, name))\n+\tif (clone_name(reg->name, node->name, name))\n \t\tgoto free;\n \n \trc = __rte_node_register(reg);\n", "prefixes": [ "v9", "07/17" ] }{ "id": 128255, "url": "