Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128250/?format=api
{ "id": 128250, "url": "http://patches.dpdk.org/api/patches/128250/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230607035144.1214492-3-zhirun.yan@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230607035144.1214492-3-zhirun.yan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230607035144.1214492-3-zhirun.yan@intel.com", "date": "2023-06-07T03:51:29", "name": "[v9,02/17] graph: split graph worker into common and default model", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "e8ef0ab55fcbdd7521908b851f984891f1b9cfaf", "submitter": { "id": 1154, "url": "http://patches.dpdk.org/api/people/1154/?format=api", "name": "Yan, Zhirun", "email": "zhirun.yan@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230607035144.1214492-3-zhirun.yan@intel.com/mbox/", "series": [ { "id": 28383, "url": "http://patches.dpdk.org/api/series/28383/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28383", "date": "2023-06-07T03:51:27", "name": "graph enhancement for multi-core dispatch", "version": 9, "mbox": "http://patches.dpdk.org/series/28383/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/128250/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/128250/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 239AB42C46;\n\tWed, 7 Jun 2023 05:59:58 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D3A0E4113F;\n\tWed, 7 Jun 2023 05:59:52 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id 3CAEC40A84\n for <dev@dpdk.org>; Wed, 7 Jun 2023 05:59:51 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 06 Jun 2023 20:59:50 -0700", "from dpdk-zhirun-lmm.sh.intel.com ([10.67.119.94])\n by orsmga006.jf.intel.com with ESMTP; 06 Jun 2023 20:59:47 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1686110391; x=1717646391;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=nCdy8MQJAPQROCK1tFl/63aQavqnGyCsD52wCoDrE6Q=;\n b=CN2EaRwez7cq5rrzw16tqKMHYq/Bjmu7+ClWcS5Q4O2zjGURG+tvOdMH\n JgJDdKxgfXuppGqzDSTy63BBFykGCtDmQ9kYf1yHPP2HPFjoWQw6Etlnd\n 1piNVCzld+hBvp3WvUyZutaaHi8eSbstP60zi18KicqkWLFihVwqYpDFZ\n BMYeXgzGGBC47mGm0OrX5lpUhkO281lzLTbcv01G5DhpejbZCF/7/P21P\n FNWASp7JDCpJnt3LIZCIInh3Bu3CJ+ulEHBOXtogwXeWwvHemkWdN4eB+\n 8SQQxoa5BctidViW4k66TbXC9VDW3pxY4yvmw5kQvWNYSIwPneR1gOCos Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10733\"; a=\"359336544\"", "E=Sophos;i=\"6.00,222,1681196400\"; d=\"scan'208\";a=\"359336544\"", "E=McAfee;i=\"6600,9927,10733\"; a=\"686759033\"", "E=Sophos;i=\"6.00,222,1681196400\"; d=\"scan'208\";a=\"686759033\"" ], "X-ExtLoop1": "1", "From": "Zhirun Yan <zhirun.yan@intel.com>", "To": "dev@dpdk.org, jerinj@marvell.com, kirankumark@marvell.com,\n ndabilpuram@marvell.com, stephen@networkplumber.org,\n pbhagavatula@marvell.com, jerinjacobk@gmail.com", "Cc": "cunming.liang@intel.com, haiyue.wang@intel.com,\n mattias.ronnblom@ericsson.com, Zhirun Yan <zhirun.yan@intel.com>", "Subject": "[PATCH v9 02/17] graph: split graph worker into common and default\n model", "Date": "Wed, 7 Jun 2023 11:51:29 +0800", "Message-Id": "<20230607035144.1214492-3-zhirun.yan@intel.com>", "X-Mailer": "git-send-email 2.37.2", "In-Reply-To": "<20230607035144.1214492-1-zhirun.yan@intel.com>", "References": "<20230606144746.708388-1-zhirun.yan@intel.com>\n <20230607035144.1214492-1-zhirun.yan@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "To support multiple graph worker model, split graph into common\nand default. Naming the current walk function as rte_graph_model_rtc\ncause the default model is RTC(Run-to-completion).\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\nSigned-off-by: Cunming Liang <cunming.liang@intel.com>\nSigned-off-by: Zhirun Yan <zhirun.yan@intel.com>\n---\n lib/graph/graph_pcap.c | 2 +-\n lib/graph/graph_private.h | 2 +-\n lib/graph/meson.build | 2 +-\n lib/graph/rte_graph_model_rtc.h | 62 +++++++++++++++++++++++++++++\n lib/graph/rte_graph_worker.h | 35 ++++++++++++++++\n lib/graph/rte_graph_worker_common.h | 57 --------------------------\n 6 files changed, 100 insertions(+), 60 deletions(-)\n create mode 100644 lib/graph/rte_graph_model_rtc.h\n create mode 100644 lib/graph/rte_graph_worker.h", "diff": "diff --git a/lib/graph/graph_pcap.c b/lib/graph/graph_pcap.c\nindex 8a220370fa..6c43330029 100644\n--- a/lib/graph/graph_pcap.c\n+++ b/lib/graph/graph_pcap.c\n@@ -10,7 +10,7 @@\n #include <rte_mbuf.h>\n #include <rte_pcapng.h>\n \n-#include \"rte_graph_worker_common.h\"\n+#include \"rte_graph_worker.h\"\n \n #include \"graph_pcap_private.h\"\n \ndiff --git a/lib/graph/graph_private.h b/lib/graph/graph_private.h\nindex 307e5f70bc..eacdef45f0 100644\n--- a/lib/graph/graph_private.h\n+++ b/lib/graph/graph_private.h\n@@ -13,7 +13,7 @@\n #include <rte_spinlock.h>\n \n #include \"rte_graph.h\"\n-#include \"rte_graph_worker_common.h\"\n+#include \"rte_graph_worker.h\"\n \n extern int rte_graph_logtype;\n \ndiff --git a/lib/graph/meson.build b/lib/graph/meson.build\nindex 4e2b612ad3..3526d1b5d4 100644\n--- a/lib/graph/meson.build\n+++ b/lib/graph/meson.build\n@@ -16,6 +16,6 @@ sources = files(\n 'graph_populate.c',\n 'graph_pcap.c',\n )\n-headers = files('rte_graph.h', 'rte_graph_worker_common.h')\n+headers = files('rte_graph.h', 'rte_graph_worker.h')\n \n deps += ['eal', 'pcapng']\ndiff --git a/lib/graph/rte_graph_model_rtc.h b/lib/graph/rte_graph_model_rtc.h\nnew file mode 100644\nindex 0000000000..10b359772f\n--- /dev/null\n+++ b/lib/graph/rte_graph_model_rtc.h\n@@ -0,0 +1,62 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(C) 2020 Marvell International Ltd.\n+ * Copyright(C) 2023 Intel Corporation\n+ */\n+\n+#include \"rte_graph_worker_common.h\"\n+\n+/**\n+ * Perform graph walk on the circular buffer and invoke the process function\n+ * of the nodes and collect the stats.\n+ *\n+ * @param graph\n+ * Graph pointer returned from rte_graph_lookup function.\n+ *\n+ * @see rte_graph_lookup()\n+ */\n+static inline void\n+rte_graph_walk_rtc(struct rte_graph *graph)\n+{\n+\tconst rte_graph_off_t *cir_start = graph->cir_start;\n+\tconst rte_node_t mask = graph->cir_mask;\n+\tuint32_t head = graph->head;\n+\tstruct rte_node *node;\n+\tuint64_t start;\n+\tuint16_t rc;\n+\tvoid **objs;\n+\n+\t/*\n+\t * Walk on the source node(s) ((cir_start - head) -> cir_start) and then\n+\t * on the pending streams (cir_start -> (cir_start + mask) -> cir_start)\n+\t * in a circular buffer fashion.\n+\t *\n+\t *\t+-----+ <= cir_start - head [number of source nodes]\n+\t *\t| |\n+\t *\t| ... | <= source nodes\n+\t *\t| |\n+\t *\t+-----+ <= cir_start [head = 0] [tail = 0]\n+\t *\t| |\n+\t *\t| ... | <= pending streams\n+\t *\t| |\n+\t *\t+-----+ <= cir_start + mask\n+\t */\n+\twhile (likely(head != graph->tail)) {\n+\t\tnode = (struct rte_node *)RTE_PTR_ADD(graph, cir_start[(int32_t)head++]);\n+\t\tRTE_ASSERT(node->fence == RTE_GRAPH_FENCE);\n+\t\tobjs = node->objs;\n+\t\trte_prefetch0(objs);\n+\n+\t\tif (rte_graph_has_stats_feature()) {\n+\t\t\tstart = rte_rdtsc();\n+\t\t\trc = node->process(graph, node, objs, node->idx);\n+\t\t\tnode->total_cycles += rte_rdtsc() - start;\n+\t\t\tnode->total_calls++;\n+\t\t\tnode->total_objs += rc;\n+\t\t} else {\n+\t\t\tnode->process(graph, node, objs, node->idx);\n+\t\t}\n+\t\t\tnode->idx = 0;\n+\t\t\thead = likely((int32_t)head > 0) ? head & mask : head;\n+\t}\n+\tgraph->tail = 0;\n+}\ndiff --git a/lib/graph/rte_graph_worker.h b/lib/graph/rte_graph_worker.h\nnew file mode 100644\nindex 0000000000..5b58f7bda9\n--- /dev/null\n+++ b/lib/graph/rte_graph_worker.h\n@@ -0,0 +1,35 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(C) 2020 Marvell International Ltd.\n+ * Copyright(C) 2023 Intel Corporation\n+ */\n+\n+#ifndef _RTE_GRAPH_WORKER_H_\n+#define _RTE_GRAPH_WORKER_H_\n+\n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n+#include \"rte_graph_model_rtc.h\"\n+\n+/**\n+ * Perform graph walk on the circular buffer and invoke the process function\n+ * of the nodes and collect the stats.\n+ *\n+ * @param graph\n+ * Graph pointer returned from rte_graph_lookup function.\n+ *\n+ * @see rte_graph_lookup()\n+ */\n+__rte_experimental\n+static inline void\n+rte_graph_walk(struct rte_graph *graph)\n+{\n+\trte_graph_walk_rtc(graph);\n+}\n+\n+#ifdef __cplusplus\n+}\n+#endif\n+\n+#endif /* _RTE_GRAPH_WORKER_H_ */\ndiff --git a/lib/graph/rte_graph_worker_common.h b/lib/graph/rte_graph_worker_common.h\nindex 0bad2938f3..b58f8f6947 100644\n--- a/lib/graph/rte_graph_worker_common.h\n+++ b/lib/graph/rte_graph_worker_common.h\n@@ -128,63 +128,6 @@ __rte_experimental\n void __rte_node_stream_alloc_size(struct rte_graph *graph,\n \t\t\t\t struct rte_node *node, uint16_t req_size);\n \n-/**\n- * Perform graph walk on the circular buffer and invoke the process function\n- * of the nodes and collect the stats.\n- *\n- * @param graph\n- * Graph pointer returned from rte_graph_lookup function.\n- *\n- * @see rte_graph_lookup()\n- */\n-__rte_experimental\n-static inline void\n-rte_graph_walk(struct rte_graph *graph)\n-{\n-\tconst rte_graph_off_t *cir_start = graph->cir_start;\n-\tconst rte_node_t mask = graph->cir_mask;\n-\tuint32_t head = graph->head;\n-\tstruct rte_node *node;\n-\tuint64_t start;\n-\tuint16_t rc;\n-\tvoid **objs;\n-\n-\t/*\n-\t * Walk on the source node(s) ((cir_start - head) -> cir_start) and then\n-\t * on the pending streams (cir_start -> (cir_start + mask) -> cir_start)\n-\t * in a circular buffer fashion.\n-\t *\n-\t *\t+-----+ <= cir_start - head [number of source nodes]\n-\t *\t| |\n-\t *\t| ... | <= source nodes\n-\t *\t| |\n-\t *\t+-----+ <= cir_start [head = 0] [tail = 0]\n-\t *\t| |\n-\t *\t| ... | <= pending streams\n-\t *\t| |\n-\t *\t+-----+ <= cir_start + mask\n-\t */\n-\twhile (likely(head != graph->tail)) {\n-\t\tnode = (struct rte_node *)RTE_PTR_ADD(graph, cir_start[(int32_t)head++]);\n-\t\tRTE_ASSERT(node->fence == RTE_GRAPH_FENCE);\n-\t\tobjs = node->objs;\n-\t\trte_prefetch0(objs);\n-\n-\t\tif (rte_graph_has_stats_feature()) {\n-\t\t\tstart = rte_rdtsc();\n-\t\t\trc = node->process(graph, node, objs, node->idx);\n-\t\t\tnode->total_cycles += rte_rdtsc() - start;\n-\t\t\tnode->total_calls++;\n-\t\t\tnode->total_objs += rc;\n-\t\t} else {\n-\t\t\tnode->process(graph, node, objs, node->idx);\n-\t\t}\n-\t\tnode->idx = 0;\n-\t\thead = likely((int32_t)head > 0) ? head & mask : head;\n-\t}\n-\tgraph->tail = 0;\n-}\n-\n /* Fast path helper functions */\n \n /**\n", "prefixes": [ "v9", "02/17" ] }