Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128002/?format=api
{ "id": 128002, "url": "http://patches.dpdk.org/api/patches/128002/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230604000051.7877-14-ivan.malov@arknetworks.am/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230604000051.7877-14-ivan.malov@arknetworks.am>", "list_archive_url": "https://inbox.dpdk.org/dev/20230604000051.7877-14-ivan.malov@arknetworks.am", "date": "2023-06-04T00:00:30", "name": "[v2,13/34] net/sfc: turn flow create/destroy methods into lock wrappers", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f4921aeda4e17269454d387f4022daf0a92b2081", "submitter": { "id": 2962, "url": "http://patches.dpdk.org/api/people/2962/?format=api", "name": "Ivan Malov", "email": "ivan.malov@arknetworks.am" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230604000051.7877-14-ivan.malov@arknetworks.am/mbox/", "series": [ { "id": 28334, "url": "http://patches.dpdk.org/api/series/28334/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28334", "date": "2023-06-04T00:00:17", "name": "net/sfc: support HW conntrack assistance", "version": 2, "mbox": "http://patches.dpdk.org/series/28334/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/128002/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/128002/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D448442BDE;\n\tSun, 4 Jun 2023 02:02:30 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2374842D85;\n\tSun, 4 Jun 2023 02:01:11 +0200 (CEST)", "from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80])\n by mails.dpdk.org (Postfix) with ESMTP id 6E27942D42\n for <dev@dpdk.org>; Sun, 4 Jun 2023 02:01:00 +0200 (CEST)", "from localhost.localdomain (unknown [78.109.69.101])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by agw.arknetworks.am (Postfix) with ESMTPSA id EFC92E12C8;\n Sun, 4 Jun 2023 04:00:59 +0400 (+04)" ], "From": "Ivan Malov <ivan.malov@arknetworks.am>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Ferruh Yigit <ferruh.yigit@amd.com>, Andy Moreton <amoreton@xilinx.com>", "Subject": "[PATCH v2 13/34] net/sfc: turn flow create/destroy methods into lock\n wrappers", "Date": "Sun, 4 Jun 2023 04:00:30 +0400", "Message-Id": "<20230604000051.7877-14-ivan.malov@arknetworks.am>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20230604000051.7877-1-ivan.malov@arknetworks.am>", "References": "<20230601195538.8265-1-ivan.malov@arknetworks.am>\n <20230604000051.7877-1-ivan.malov@arknetworks.am>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Doing so is useful to facilitate driver-internal flow rework.\n\nSigned-off-by: Ivan Malov <ivan.malov@arknetworks.am>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/net/sfc/sfc_flow.c | 42 ++++++++++++++++++++++++++++++--------\n drivers/net/sfc/sfc_flow.h | 9 ++++++++\n 2 files changed, 42 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c\nindex fe1f5ba55f..432295ea62 100644\n--- a/drivers/net/sfc/sfc_flow.c\n+++ b/drivers/net/sfc/sfc_flow.c\n@@ -2610,16 +2610,32 @@ sfc_flow_create(struct rte_eth_dev *dev,\n \t\tstruct rte_flow_error *error)\n {\n \tstruct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);\n+\tstruct rte_flow *flow;\n+\n+\tsfc_adapter_lock(sa);\n+\tflow = sfc_flow_create_locked(sa, attr, pattern, actions, error);\n+\tsfc_adapter_unlock(sa);\n+\n+\treturn flow;\n+}\n+\n+struct rte_flow *\n+sfc_flow_create_locked(struct sfc_adapter *sa,\n+\t\t const struct rte_flow_attr *attr,\n+\t\t const struct rte_flow_item pattern[],\n+\t\t const struct rte_flow_action actions[],\n+\t\t struct rte_flow_error *error)\n+{\n \tstruct rte_flow *flow = NULL;\n \tint rc;\n \n+\tSFC_ASSERT(sfc_adapter_is_locked(sa));\n+\n \tflow = sfc_flow_zmalloc(error);\n \tif (flow == NULL)\n \t\tgoto fail_no_mem;\n \n-\tsfc_adapter_lock(sa);\n-\n-\trc = sfc_flow_parse(dev, attr, pattern, actions, flow, error);\n+\trc = sfc_flow_parse(sa->eth_dev, attr, pattern, actions, flow, error);\n \tif (rc != 0)\n \t\tgoto fail_bad_value;\n \n@@ -2631,8 +2647,6 @@ sfc_flow_create(struct rte_eth_dev *dev,\n \t\t\tgoto fail_flow_insert;\n \t}\n \n-\tsfc_adapter_unlock(sa);\n-\n \treturn flow;\n \n fail_flow_insert:\n@@ -2640,7 +2654,6 @@ sfc_flow_create(struct rte_eth_dev *dev,\n \n fail_bad_value:\n \tsfc_flow_free(sa, flow);\n-\tsfc_adapter_unlock(sa);\n \n fail_no_mem:\n \treturn NULL;\n@@ -2652,10 +2665,23 @@ sfc_flow_destroy(struct rte_eth_dev *dev,\n \t\t struct rte_flow_error *error)\n {\n \tstruct sfc_adapter *sa = sfc_adapter_by_eth_dev(dev);\n+\tint rc;\n+\n+\tsfc_adapter_lock(sa);\n+\trc = sfc_flow_destroy_locked(sa, flow, error);\n+\tsfc_adapter_unlock(sa);\n+\n+\treturn rc;\n+}\n+\n+int\n+sfc_flow_destroy_locked(struct sfc_adapter *sa, struct rte_flow *flow,\n+\t\t\tstruct rte_flow_error *error)\n+{\n \tstruct rte_flow *flow_ptr;\n \tint rc = EINVAL;\n \n-\tsfc_adapter_lock(sa);\n+\tSFC_ASSERT(sfc_adapter_is_locked(sa));\n \n \tTAILQ_FOREACH(flow_ptr, &sa->flow_list, entries) {\n \t\tif (flow_ptr == flow)\n@@ -2675,8 +2701,6 @@ sfc_flow_destroy(struct rte_eth_dev *dev,\n \tsfc_flow_free(sa, flow);\n \n fail_bad_value:\n-\tsfc_adapter_unlock(sa);\n-\n \treturn -rc;\n }\n \ndiff --git a/drivers/net/sfc/sfc_flow.h b/drivers/net/sfc/sfc_flow.h\nindex 12875344b5..a3ca09f225 100644\n--- a/drivers/net/sfc/sfc_flow.h\n+++ b/drivers/net/sfc/sfc_flow.h\n@@ -195,6 +195,15 @@ typedef int (sfc_flow_query_cb_t)(struct rte_eth_dev *dev,\n \t\t\t\t void *data,\n \t\t\t\t struct rte_flow_error *error);\n \n+struct rte_flow *sfc_flow_create_locked(struct sfc_adapter *sa,\n+\t\t\t\t\tconst struct rte_flow_attr *attr,\n+\t\t\t\t\tconst struct rte_flow_item pattern[],\n+\t\t\t\t\tconst struct rte_flow_action actions[],\n+\t\t\t\t\tstruct rte_flow_error *error);\n+\n+int sfc_flow_destroy_locked(struct sfc_adapter *sa, struct rte_flow *flow,\n+\t\t\t struct rte_flow_error *error);\n+\n #ifdef __cplusplus\n }\n #endif\n", "prefixes": [ "v2", "13/34" ] }