Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127932/?format=api
{ "id": 127932, "url": "http://patches.dpdk.org/api/patches/127932/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230601200812.672233-27-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230601200812.672233-27-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230601200812.672233-27-maxime.coquelin@redhat.com", "date": "2023-06-01T20:08:12", "name": "[v4,26/26] vhost: add VDUSE device stop", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a352dc3188291168e8ebcde1ec747522a832a1a2", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230601200812.672233-27-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 28308, "url": "http://patches.dpdk.org/api/series/28308/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28308", "date": "2023-06-01T20:07:46", "name": "Add VDUSE support to Vhost library", "version": 4, "mbox": "http://patches.dpdk.org/series/28308/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/127932/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/127932/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E2FA842C08;\n\tThu, 1 Jun 2023 22:10:53 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9198943012;\n\tThu, 1 Jun 2023 22:09:51 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id E6D7542FA2\n for <dev@dpdk.org>; Thu, 1 Jun 2023 22:09:49 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-16-cx5refUtN4SvJtFoQKCgsw-1; Thu, 01 Jun 2023 16:09:46 -0400", "from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com\n [10.11.54.4])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 020DD802E58;\n Thu, 1 Jun 2023 20:09:46 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.39.208.25])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 611432029F6D;\n Thu, 1 Jun 2023 20:09:43 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1685650189;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=z5Q8mdzoqgAPpj9w6VIVQmHquuECEspqe72O1F9vM9s=;\n b=HWElXy4kBXhgoE7lSy2KSaX3iwN0n/G7MeOte+afyA0ym7uSKyKlvOZDdP2s8uK6vLGCLW\n XPGAzEzBi02gqr/CcxDkZNLN4wQBu4NuaqKrPe4vZcSYVU/CQqA3BYi2CBQ4DzbBGQuEl/\n Yv1HlE9Vv/qNxOXHMfZm/1IjUfvQuCA=", "X-MC-Unique": "cx5refUtN4SvJtFoQKCgsw-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, chenbo.xia@intel.com, david.marchand@redhat.com,\n mkp@redhat.com, fbl@redhat.com, jasowang@redhat.com,\n cunming.liang@intel.com, xieyongji@bytedance.com, echaudro@redhat.com,\n eperezma@redhat.com, amorenoz@redhat.com, lulu@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Subject": "[PATCH v4 26/26] vhost: add VDUSE device stop", "Date": "Thu, 1 Jun 2023 22:08:12 +0200", "Message-Id": "<20230601200812.672233-27-maxime.coquelin@redhat.com>", "In-Reply-To": "<20230601200812.672233-1-maxime.coquelin@redhat.com>", "References": "<20230601200812.672233-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch adds VDUSE device stop and cleanup of its\nvirtqueues.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n doc/guides/rel_notes/release_23_07.rst | 6 +++\n lib/vhost/vduse.c | 72 +++++++++++++++++++++++---\n 2 files changed, 70 insertions(+), 8 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/rel_notes/release_23_07.rst\nindex 7034fb664c..6f43e8e633 100644\n--- a/doc/guides/rel_notes/release_23_07.rst\n+++ b/doc/guides/rel_notes/release_23_07.rst\n@@ -67,6 +67,12 @@ New Features\n Introduced ``rte_vhost_driver_set_max_queue_num()`` to be able to limit the\n maximum number of supported queue pairs, required for VDUSE support.\n \n+* **Added VDUSE support into Vhost library.**\n+\n+ VDUSE aims at implementing vDPA devices in userspace. It can be used as an\n+ alternative to Vhost-user when using Vhost-vDPA, but also enable providing a\n+ virtio-net netdev to the host when using Virtio-vDPA driver.\n+\n \n Removed Items\n -------------\ndiff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c\nindex 699cfed9e3..f421b1cf4c 100644\n--- a/lib/vhost/vduse.c\n+++ b/lib/vhost/vduse.c\n@@ -252,6 +252,44 @@ vduse_vring_setup(struct virtio_net *dev, unsigned int index)\n \t}\n }\n \n+static void\n+vduse_vring_cleanup(struct virtio_net *dev, unsigned int index)\n+{\n+\tstruct vhost_virtqueue *vq = dev->virtqueue[index];\n+\tstruct vduse_vq_eventfd vq_efd;\n+\tint ret;\n+\n+\tif (vq == dev->cvq && vq->kickfd >= 0) {\n+\t\tfdset_del(&vduse.fdset, vq->kickfd);\n+\t\tfdset_pipe_notify(&vduse.fdset);\n+\t}\n+\n+\tvq_efd.index = index;\n+\tvq_efd.fd = VDUSE_EVENTFD_DEASSIGN;\n+\n+\tret = ioctl(dev->vduse_dev_fd, VDUSE_VQ_SETUP_KICKFD, &vq_efd);\n+\tif (ret)\n+\t\tVHOST_LOG_CONFIG(dev->ifname, ERR, \"Failed to cleanup kickfd for VQ %u: %s\\n\",\n+\t\t\t\tindex, strerror(errno));\n+\n+\tclose(vq->kickfd);\n+\tvq->kickfd = VIRTIO_UNINITIALIZED_EVENTFD;\n+\n+\tvring_invalidate(dev, vq);\n+\n+\trte_free(vq->batch_copy_elems);\n+\tvq->batch_copy_elems = NULL;\n+\n+\trte_free(vq->shadow_used_split);\n+\tvq->shadow_used_split = NULL;\n+\n+\tvq->enabled = false;\n+\tvq->ready = false;\n+\tvq->size = 0;\n+\tvq->last_used_idx = 0;\n+\tvq->last_avail_idx = 0;\n+}\n+\n static void\n vduse_device_start(struct virtio_net *dev)\n {\n@@ -304,6 +342,23 @@ vduse_device_start(struct virtio_net *dev)\n \t}\n }\n \n+static void\n+vduse_device_stop(struct virtio_net *dev)\n+{\n+\tunsigned int i;\n+\n+\tVHOST_LOG_CONFIG(dev->ifname, INFO, \"Stopping device...\\n\");\n+\n+\tvhost_destroy_device_notify(dev);\n+\n+\tdev->flags &= ~VIRTIO_DEV_READY;\n+\n+\tfor (i = 0; i < dev->nr_vring; i++)\n+\t\tvduse_vring_cleanup(dev, i);\n+\n+\tvhost_user_iotlb_flush_all(dev);\n+}\n+\n static void\n vduse_events_handler(int fd, void *arg, int *remove __rte_unused)\n {\n@@ -311,6 +366,7 @@ vduse_events_handler(int fd, void *arg, int *remove __rte_unused)\n \tstruct vduse_dev_request req;\n \tstruct vduse_dev_response resp;\n \tstruct vhost_virtqueue *vq;\n+\tuint8_t old_status;\n \tint ret;\n \n \tmemset(&resp, 0, sizeof(resp));\n@@ -339,10 +395,15 @@ vduse_events_handler(int fd, void *arg, int *remove __rte_unused)\n \tcase VDUSE_SET_STATUS:\n \t\tVHOST_LOG_CONFIG(dev->ifname, INFO, \"\\tnew status: 0x%08x\\n\",\n \t\t\t\treq.s.status);\n+\t\told_status = dev->status;\n \t\tdev->status = req.s.status;\n \n-\t\tif (dev->status & VIRTIO_DEVICE_STATUS_DRIVER_OK)\n-\t\t\tvduse_device_start(dev);\n+\t\tif ((old_status ^ dev->status) & VIRTIO_DEVICE_STATUS_DRIVER_OK) {\n+\t\t\tif (dev->status & VIRTIO_DEVICE_STATUS_DRIVER_OK)\n+\t\t\t\tvduse_device_start(dev);\n+\t\t\telse\n+\t\t\t\tvduse_device_stop(dev);\n+\t\t}\n \n \t\tresp.result = VDUSE_REQ_RESULT_OK;\n \t\tbreak;\n@@ -560,12 +621,7 @@ vduse_device_destroy(const char *path)\n \tif (vid == RTE_MAX_VHOST_DEVICE)\n \t\treturn -1;\n \n-\tif (dev->cvq && dev->cvq->kickfd >= 0) {\n-\t\tfdset_del(&vduse.fdset, dev->cvq->kickfd);\n-\t\tfdset_pipe_notify(&vduse.fdset);\n-\t\tclose(dev->cvq->kickfd);\n-\t\tdev->cvq->kickfd = VIRTIO_UNINITIALIZED_EVENTFD;\n-\t}\n+\tvduse_device_stop(dev);\n \n \tfdset_del(&vduse.fdset, dev->vduse_dev_fd);\n \tfdset_pipe_notify(&vduse.fdset);\n", "prefixes": [ "v4", "26/26" ] }