Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127927/?format=api
{ "id": 127927, "url": "http://patches.dpdk.org/api/patches/127927/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230601200812.672233-21-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230601200812.672233-21-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230601200812.672233-21-maxime.coquelin@redhat.com", "date": "2023-06-01T20:08:06", "name": "[v4,20/26] vhost: add VDUSE events handler", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2e40687c80a1759703145acd1ef743a16bf05e5e", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230601200812.672233-21-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 28308, "url": "http://patches.dpdk.org/api/series/28308/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28308", "date": "2023-06-01T20:07:46", "name": "Add VDUSE support to Vhost library", "version": 4, "mbox": "http://patches.dpdk.org/series/28308/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/127927/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/127927/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C463A42C08;\n\tThu, 1 Jun 2023 22:10:25 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9CB5842FE0;\n\tThu, 1 Jun 2023 22:09:26 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id 0647442BDA\n for <dev@dpdk.org>; Thu, 1 Jun 2023 22:09:24 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-475-CEui7vqoMhWSEDhCPuT5ZA-1; Thu, 01 Jun 2023 16:09:20 -0400", "from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com\n [10.11.54.4])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 539D9185A79B;\n Thu, 1 Jun 2023 20:09:20 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.39.208.25])\n by smtp.corp.redhat.com (Postfix) with ESMTP id AC5412029F6D;\n Thu, 1 Jun 2023 20:09:17 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1685650164;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=/NaxkaDcGVWBez8isP823L/8Qgqwaypg58E+DhHMgoE=;\n b=NdZ/+gOJUY3GdWy1aVe+8+cwtyLHv911CmP/u+BjGWzEcGQPJhGaW1zI6U36bmbVeWzuKl\n KaswwlkpebA9lrzrgldwEWuJzoxNYhR5JQG+wYw30EKuK7ebJMe2sa/3T7bd/rAp3qV9X7\n nGC3MV7ENEmLxfH0aI008r7dFFQv5iQ=", "X-MC-Unique": "CEui7vqoMhWSEDhCPuT5ZA-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, chenbo.xia@intel.com, david.marchand@redhat.com,\n mkp@redhat.com, fbl@redhat.com, jasowang@redhat.com,\n cunming.liang@intel.com, xieyongji@bytedance.com, echaudro@redhat.com,\n eperezma@redhat.com, amorenoz@redhat.com, lulu@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Subject": "[PATCH v4 20/26] vhost: add VDUSE events handler", "Date": "Thu, 1 Jun 2023 22:08:06 +0200", "Message-Id": "<20230601200812.672233-21-maxime.coquelin@redhat.com>", "In-Reply-To": "<20230601200812.672233-1-maxime.coquelin@redhat.com>", "References": "<20230601200812.672233-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch makes use of Vhost lib's FD manager to install\na handler for VDUSE events occurring on the VDUSE device FD.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\nReviewed-by: Chenbo Xia <chenbo.xia@intel.com>\n---\n lib/vhost/vduse.c | 101 ++++++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 101 insertions(+)", "diff": "diff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c\nindex d39e39b9dc..92c515cff2 100644\n--- a/lib/vhost/vduse.c\n+++ b/lib/vhost/vduse.c\n@@ -17,6 +17,7 @@\n \n #include <rte_common.h>\n \n+#include \"fd_man.h\"\n #include \"iotlb.h\"\n #include \"vduse.h\"\n #include \"vhost.h\"\n@@ -42,6 +43,31 @@\n \t\t\t\t(1ULL << VIRTIO_F_IN_ORDER) | \\\n \t\t\t\t(1ULL << VIRTIO_F_IOMMU_PLATFORM))\n \n+struct vduse {\n+\tstruct fdset fdset;\n+};\n+\n+static struct vduse vduse = {\n+\t.fdset = {\n+\t\t.fd = { [0 ... MAX_FDS - 1] = {-1, NULL, NULL, NULL, 0} },\n+\t\t.fd_mutex = PTHREAD_MUTEX_INITIALIZER,\n+\t\t.fd_pooling_mutex = PTHREAD_MUTEX_INITIALIZER,\n+\t\t.num = 0\n+\t},\n+};\n+\n+static bool vduse_events_thread;\n+\n+static const char * const vduse_reqs_str[] = {\n+\t\"VDUSE_GET_VQ_STATE\",\n+\t\"VDUSE_SET_STATUS\",\n+\t\"VDUSE_UPDATE_IOTLB\",\n+};\n+\n+#define vduse_req_id_to_str(id) \\\n+\t(id < RTE_DIM(vduse_reqs_str) ? \\\n+\tvduse_reqs_str[id] : \"Unknown\")\n+\n static int\n vduse_inject_irq(struct virtio_net *dev, struct vhost_virtqueue *vq)\n {\n@@ -115,16 +141,80 @@ static struct vhost_backend_ops vduse_backend_ops = {\n \t.inject_irq = vduse_inject_irq,\n };\n \n+static void\n+vduse_events_handler(int fd, void *arg, int *remove __rte_unused)\n+{\n+\tstruct virtio_net *dev = arg;\n+\tstruct vduse_dev_request req;\n+\tstruct vduse_dev_response resp;\n+\tint ret;\n+\n+\tmemset(&resp, 0, sizeof(resp));\n+\n+\tret = read(fd, &req, sizeof(req));\n+\tif (ret < 0) {\n+\t\tVHOST_LOG_CONFIG(dev->ifname, ERR, \"Failed to read request: %s\\n\",\n+\t\t\t\tstrerror(errno));\n+\t\treturn;\n+\t} else if (ret < (int)sizeof(req)) {\n+\t\tVHOST_LOG_CONFIG(dev->ifname, ERR, \"Incomplete to read request %d\\n\", ret);\n+\t\treturn;\n+\t}\n+\n+\tVHOST_LOG_CONFIG(dev->ifname, INFO, \"New request: %s (%u)\\n\",\n+\t\t\tvduse_req_id_to_str(req.type), req.type);\n+\n+\tswitch (req.type) {\n+\tdefault:\n+\t\tresp.result = VDUSE_REQ_RESULT_FAILED;\n+\t\tbreak;\n+\t}\n+\n+\tresp.request_id = req.request_id;\n+\n+\tret = write(dev->vduse_dev_fd, &resp, sizeof(resp));\n+\tif (ret != sizeof(resp)) {\n+\t\tVHOST_LOG_CONFIG(dev->ifname, ERR, \"Failed to write response %s\\n\",\n+\t\t\t\tstrerror(errno));\n+\t\treturn;\n+\t}\n+\tVHOST_LOG_CONFIG(dev->ifname, INFO, \"Request %s (%u) handled successfully\\n\",\n+\t\t\tvduse_req_id_to_str(req.type), req.type);\n+}\n+\n int\n vduse_device_create(const char *path)\n {\n \tint control_fd, dev_fd, vid, ret;\n+\tpthread_t fdset_tid;\n \tuint32_t i;\n \tstruct virtio_net *dev;\n \tuint64_t ver = VHOST_VDUSE_API_VERSION;\n \tstruct vduse_dev_config *dev_config = NULL;\n \tconst char *name = path + strlen(\"/dev/vduse/\");\n \n+\t/* If first device, create events dispatcher thread */\n+\tif (vduse_events_thread == false) {\n+\t\t/**\n+\t\t * create a pipe which will be waited by poll and notified to\n+\t\t * rebuild the wait list of poll.\n+\t\t */\n+\t\tif (fdset_pipe_init(&vduse.fdset) < 0) {\n+\t\t\tVHOST_LOG_CONFIG(path, ERR, \"failed to create pipe for vduse fdset\\n\");\n+\t\t\treturn -1;\n+\t\t}\n+\n+\t\tret = rte_ctrl_thread_create(&fdset_tid, \"vduse-events\", NULL,\n+\t\t\t\tfdset_event_dispatch, &vduse.fdset);\n+\t\tif (ret != 0) {\n+\t\t\tVHOST_LOG_CONFIG(path, ERR, \"failed to create vduse fdset handling thread\\n\");\n+\t\t\tfdset_pipe_uninit(&vduse.fdset);\n+\t\t\treturn -1;\n+\t\t}\n+\n+\t\tvduse_events_thread = true;\n+\t}\n+\n \tcontrol_fd = open(VDUSE_CTRL_PATH, O_RDWR);\n \tif (control_fd < 0) {\n \t\tVHOST_LOG_CONFIG(name, ERR, \"Failed to open %s: %s\\n\",\n@@ -215,6 +305,14 @@ vduse_device_create(const char *path)\n \t\t}\n \t}\n \n+\tret = fdset_add(&vduse.fdset, dev->vduse_dev_fd, vduse_events_handler, NULL, dev);\n+\tif (ret) {\n+\t\tVHOST_LOG_CONFIG(name, ERR, \"Failed to add fd %d to vduse fdset\\n\",\n+\t\t\t\tdev->vduse_dev_fd);\n+\t\tgoto out_dev_destroy;\n+\t}\n+\tfdset_pipe_notify(&vduse.fdset);\n+\n \tfree(dev_config);\n \n \treturn 0;\n@@ -253,6 +351,9 @@ vduse_device_destroy(const char *path)\n \tif (vid == RTE_MAX_VHOST_DEVICE)\n \t\treturn -1;\n \n+\tfdset_del(&vduse.fdset, dev->vduse_dev_fd);\n+\tfdset_pipe_notify(&vduse.fdset);\n+\n \tif (dev->vduse_dev_fd >= 0) {\n \t\tclose(dev->vduse_dev_fd);\n \t\tdev->vduse_dev_fd = -1;\n", "prefixes": [ "v4", "20/26" ] }