Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127911/?format=api
{ "id": 127911, "url": "http://patches.dpdk.org/api/patches/127911/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230601200812.672233-3-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230601200812.672233-3-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230601200812.672233-3-maxime.coquelin@redhat.com", "date": "2023-06-01T20:07:48", "name": "[v4,02/26] vhost: add helper of IOTLB entries coredump", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fc07041808385d72f440d06394d2d914f680d2f2", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230601200812.672233-3-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 28308, "url": "http://patches.dpdk.org/api/series/28308/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28308", "date": "2023-06-01T20:07:46", "name": "Add VDUSE support to Vhost library", "version": 4, "mbox": "http://patches.dpdk.org/series/28308/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/127911/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/127911/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C63E542C08;\n\tThu, 1 Jun 2023 22:08:40 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B800742D44;\n\tThu, 1 Jun 2023 22:08:33 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id 2F78342BC9\n for <dev@dpdk.org>; Thu, 1 Jun 2023 22:08:29 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-665-GkX6WxP3OKCwKVOq9sByKw-1; Thu, 01 Jun 2023 16:08:25 -0400", "from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com\n [10.11.54.4])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F091638294A0;\n Thu, 1 Jun 2023 20:08:24 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.39.208.25])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 41E3A2029F6D;\n Thu, 1 Jun 2023 20:08:22 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1685650109;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=nghe3pVt71XrFPUd8X5i89nN3A/M9CrhzX8c+jD0QKw=;\n b=HWh6BOYXIi9fXXYfDh5Xw9EpApiC0mfVTjVvvzTuYpdoIlmOFfuzij93fBk/3YBZJOYeMb\n RAnXuysZIWDjwjxkE4hUeySEpVrPjXCHqDhfKDBDjEy8Ef/HL+GiSK9Hj5Of2jU/zvKwJz\n tPtbpSk4Dpcq6b+u841teEK2V1jzbGA=", "X-MC-Unique": "GkX6WxP3OKCwKVOq9sByKw-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, chenbo.xia@intel.com, david.marchand@redhat.com,\n mkp@redhat.com, fbl@redhat.com, jasowang@redhat.com,\n cunming.liang@intel.com, xieyongji@bytedance.com, echaudro@redhat.com,\n eperezma@redhat.com, amorenoz@redhat.com, lulu@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Subject": "[PATCH v4 02/26] vhost: add helper of IOTLB entries coredump", "Date": "Thu, 1 Jun 2023 22:07:48 +0200", "Message-Id": "<20230601200812.672233-3-maxime.coquelin@redhat.com>", "In-Reply-To": "<20230601200812.672233-1-maxime.coquelin@redhat.com>", "References": "<20230601200812.672233-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch reworks IOTLB code to extract madvise-related\nbits into dedicated helper. This refactoring improves code\nsharing.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\nReviewed-by: Chenbo Xia <chenbo.xia@intel.com>\n---\n lib/vhost/iotlb.c | 77 +++++++++++++++++++++++++----------------------\n 1 file changed, 41 insertions(+), 36 deletions(-)", "diff": "diff --git a/lib/vhost/iotlb.c b/lib/vhost/iotlb.c\nindex 870c8acb88..51d45de446 100644\n--- a/lib/vhost/iotlb.c\n+++ b/lib/vhost/iotlb.c\n@@ -23,6 +23,34 @@ struct vhost_iotlb_entry {\n \n #define IOTLB_CACHE_SIZE 2048\n \n+static void\n+vhost_user_iotlb_set_dump(struct virtio_net *dev, struct vhost_iotlb_entry *node)\n+{\n+\tuint64_t align;\n+\n+\talign = hua_to_alignment(dev->mem, (void *)(uintptr_t)node->uaddr);\n+\n+\tmem_set_dump((void *)(uintptr_t)node->uaddr, node->size, true, align);\n+}\n+\n+static void\n+vhost_user_iotlb_clear_dump(struct virtio_net *dev, struct vhost_iotlb_entry *node,\n+\t\tstruct vhost_iotlb_entry *prev, struct vhost_iotlb_entry *next)\n+{\n+\tuint64_t align, mask;\n+\n+\talign = hua_to_alignment(dev->mem, (void *)(uintptr_t)node->uaddr);\n+\tmask = ~(align - 1);\n+\n+\t/* Don't disable coredump if the previous node is in the same page */\n+\tif (prev == NULL || (node->uaddr & mask) != ((prev->uaddr + prev->size - 1) & mask)) {\n+\t\t/* Don't disable coredump if the next node is in the same page */\n+\t\tif (next == NULL ||\n+\t\t\t\t((node->uaddr + node->size - 1) & mask) != (next->uaddr & mask))\n+\t\t\tmem_set_dump((void *)(uintptr_t)node->uaddr, node->size, false, align);\n+\t}\n+}\n+\n static struct vhost_iotlb_entry *\n vhost_user_iotlb_pool_get(struct vhost_virtqueue *vq)\n {\n@@ -149,8 +177,8 @@ vhost_user_iotlb_cache_remove_all(struct virtio_net *dev, struct vhost_virtqueue\n \trte_rwlock_write_lock(&vq->iotlb_lock);\n \n \tRTE_TAILQ_FOREACH_SAFE(node, &vq->iotlb_list, next, temp_node) {\n-\t\tmem_set_dump((void *)(uintptr_t)node->uaddr, node->size, false,\n-\t\t\thua_to_alignment(dev->mem, (void *)(uintptr_t)node->uaddr));\n+\t\tvhost_user_iotlb_clear_dump(dev, node, NULL, NULL);\n+\n \t\tTAILQ_REMOVE(&vq->iotlb_list, node, next);\n \t\tvhost_user_iotlb_pool_put(vq, node);\n \t}\n@@ -164,7 +192,6 @@ static void\n vhost_user_iotlb_cache_random_evict(struct virtio_net *dev, struct vhost_virtqueue *vq)\n {\n \tstruct vhost_iotlb_entry *node, *temp_node, *prev_node = NULL;\n-\tuint64_t alignment, mask;\n \tint entry_idx;\n \n \trte_rwlock_write_lock(&vq->iotlb_lock);\n@@ -173,20 +200,10 @@ vhost_user_iotlb_cache_random_evict(struct virtio_net *dev, struct vhost_virtque\n \n \tRTE_TAILQ_FOREACH_SAFE(node, &vq->iotlb_list, next, temp_node) {\n \t\tif (!entry_idx) {\n-\t\t\tstruct vhost_iotlb_entry *next_node;\n-\t\t\talignment = hua_to_alignment(dev->mem, (void *)(uintptr_t)node->uaddr);\n-\t\t\tmask = ~(alignment - 1);\n-\n-\t\t\t/* Don't disable coredump if the previous node is in the same page */\n-\t\t\tif (prev_node == NULL || (node->uaddr & mask) !=\n-\t\t\t\t\t((prev_node->uaddr + prev_node->size - 1) & mask)) {\n-\t\t\t\tnext_node = RTE_TAILQ_NEXT(node, next);\n-\t\t\t\t/* Don't disable coredump if the next node is in the same page */\n-\t\t\t\tif (next_node == NULL || ((node->uaddr + node->size - 1) & mask) !=\n-\t\t\t\t\t\t(next_node->uaddr & mask))\n-\t\t\t\t\tmem_set_dump((void *)(uintptr_t)node->uaddr, node->size,\n-\t\t\t\t\t\t\tfalse, alignment);\n-\t\t\t}\n+\t\t\tstruct vhost_iotlb_entry *next_node = RTE_TAILQ_NEXT(node, next);\n+\n+\t\t\tvhost_user_iotlb_clear_dump(dev, node, prev_node, next_node);\n+\n \t\t\tTAILQ_REMOVE(&vq->iotlb_list, node, next);\n \t\t\tvhost_user_iotlb_pool_put(vq, node);\n \t\t\tvq->iotlb_cache_nr--;\n@@ -240,16 +257,16 @@ vhost_user_iotlb_cache_insert(struct virtio_net *dev, struct vhost_virtqueue *vq\n \t\t\tvhost_user_iotlb_pool_put(vq, new_node);\n \t\t\tgoto unlock;\n \t\t} else if (node->iova > new_node->iova) {\n-\t\t\tmem_set_dump((void *)(uintptr_t)new_node->uaddr, new_node->size, true,\n-\t\t\t\thua_to_alignment(dev->mem, (void *)(uintptr_t)new_node->uaddr));\n+\t\t\tvhost_user_iotlb_set_dump(dev, new_node);\n+\n \t\t\tTAILQ_INSERT_BEFORE(node, new_node, next);\n \t\t\tvq->iotlb_cache_nr++;\n \t\t\tgoto unlock;\n \t\t}\n \t}\n \n-\tmem_set_dump((void *)(uintptr_t)new_node->uaddr, new_node->size, true,\n-\t\thua_to_alignment(dev->mem, (void *)(uintptr_t)new_node->uaddr));\n+\tvhost_user_iotlb_set_dump(dev, new_node);\n+\n \tTAILQ_INSERT_TAIL(&vq->iotlb_list, new_node, next);\n \tvq->iotlb_cache_nr++;\n \n@@ -265,7 +282,6 @@ vhost_user_iotlb_cache_remove(struct virtio_net *dev, struct vhost_virtqueue *vq\n \t\t\t\t\tuint64_t iova, uint64_t size)\n {\n \tstruct vhost_iotlb_entry *node, *temp_node, *prev_node = NULL;\n-\tuint64_t alignment, mask;\n \n \tif (unlikely(!size))\n \t\treturn;\n@@ -278,20 +294,9 @@ vhost_user_iotlb_cache_remove(struct virtio_net *dev, struct vhost_virtqueue *vq\n \t\t\tbreak;\n \n \t\tif (iova < node->iova + node->size) {\n-\t\t\tstruct vhost_iotlb_entry *next_node;\n-\t\t\talignment = hua_to_alignment(dev->mem, (void *)(uintptr_t)node->uaddr);\n-\t\t\tmask = ~(alignment-1);\n-\n-\t\t\t/* Don't disable coredump if the previous node is in the same page */\n-\t\t\tif (prev_node == NULL || (node->uaddr & mask) !=\n-\t\t\t\t\t((prev_node->uaddr + prev_node->size - 1) & mask)) {\n-\t\t\t\tnext_node = RTE_TAILQ_NEXT(node, next);\n-\t\t\t\t/* Don't disable coredump if the next node is in the same page */\n-\t\t\t\tif (next_node == NULL || ((node->uaddr + node->size - 1) & mask) !=\n-\t\t\t\t\t\t(next_node->uaddr & mask))\n-\t\t\t\t\tmem_set_dump((void *)(uintptr_t)node->uaddr, node->size,\n-\t\t\t\t\t\t\tfalse, alignment);\n-\t\t\t}\n+\t\t\tstruct vhost_iotlb_entry *next_node = RTE_TAILQ_NEXT(node, next);\n+\n+\t\t\tvhost_user_iotlb_clear_dump(dev, node, prev_node, next_node);\n \n \t\t\tTAILQ_REMOVE(&vq->iotlb_list, node, next);\n \t\t\tvhost_user_iotlb_pool_put(vq, node);\n", "prefixes": [ "v4", "02/26" ] }