Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127910/?format=api
{ "id": 127910, "url": "http://patches.dpdk.org/api/patches/127910/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230601200812.672233-4-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230601200812.672233-4-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230601200812.672233-4-maxime.coquelin@redhat.com", "date": "2023-06-01T20:07:49", "name": "[v4,03/26] vhost: add helper for IOTLB entries shared page check", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1b958d6dba9bb90953fad81bc13db55b380b08b6", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230601200812.672233-4-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 28308, "url": "http://patches.dpdk.org/api/series/28308/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28308", "date": "2023-06-01T20:07:46", "name": "Add VDUSE support to Vhost library", "version": 4, "mbox": "http://patches.dpdk.org/series/28308/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/127910/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/127910/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B94BE42C08;\n\tThu, 1 Jun 2023 22:08:34 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 86EA342BC9;\n\tThu, 1 Jun 2023 22:08:32 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 1083440EF0\n for <dev@dpdk.org>; Thu, 1 Jun 2023 22:08:29 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-122-eL0ZHQFWOji4Z9kq_EAS2Q-1; Thu, 01 Jun 2023 16:08:28 -0400", "from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com\n [10.11.54.4])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D64651C05152;\n Thu, 1 Jun 2023 20:08:27 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.39.208.25])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 444B02029F6D;\n Thu, 1 Jun 2023 20:08:25 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1685650109;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=xtWU2swtOfVhpOdXEIx7YzgGQtuh2JboI/uCu+jZY8U=;\n b=D7eEqlb9JzKvvjVcJU6P4fwcaYYl8r5LGmC5Bg7ye+dLFC8l6v/NvYlASzcVtwjdYTNa1Q\n hmOC4zcMjxFVwOMlNTJ873pE7WMVP8wn6tvdn5XvHRiBds3oTU3zAYuBTIKrS6Aixb+clD\n IQXkpLulf8G/GZ+fdge/UG/N3q5al+Q=", "X-MC-Unique": "eL0ZHQFWOji4Z9kq_EAS2Q-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, chenbo.xia@intel.com, david.marchand@redhat.com,\n mkp@redhat.com, fbl@redhat.com, jasowang@redhat.com,\n cunming.liang@intel.com, xieyongji@bytedance.com, echaudro@redhat.com,\n eperezma@redhat.com, amorenoz@redhat.com, lulu@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Subject": "[PATCH v4 03/26] vhost: add helper for IOTLB entries shared page\n check", "Date": "Thu, 1 Jun 2023 22:07:49 +0200", "Message-Id": "<20230601200812.672233-4-maxime.coquelin@redhat.com>", "In-Reply-To": "<20230601200812.672233-1-maxime.coquelin@redhat.com>", "References": "<20230601200812.672233-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch introduces a helper to check whether two IOTLB\nentries share a page.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\nAcked-by: Mike Pattrick <mkp@redhat.com>\nReviewed-by: Chenbo Xia <chenbo.xia@intel.com>\n---\n lib/vhost/iotlb.c | 25 ++++++++++++++++++++-----\n 1 file changed, 20 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/vhost/iotlb.c b/lib/vhost/iotlb.c\nindex 51d45de446..4ef038adff 100644\n--- a/lib/vhost/iotlb.c\n+++ b/lib/vhost/iotlb.c\n@@ -23,6 +23,23 @@ struct vhost_iotlb_entry {\n \n #define IOTLB_CACHE_SIZE 2048\n \n+static bool\n+vhost_user_iotlb_share_page(struct vhost_iotlb_entry *a, struct vhost_iotlb_entry *b,\n+\t\tuint64_t align)\n+{\n+\tuint64_t a_end, b_start;\n+\n+\tif (a == NULL || b == NULL)\n+\t\treturn false;\n+\n+\t/* Assumes entry a lower than entry b */\n+\tRTE_ASSERT(a->uaddr < b->uaddr);\n+\ta_end = RTE_ALIGN_CEIL(a->uaddr + a->size, align);\n+\tb_start = RTE_ALIGN_FLOOR(b->uaddr, align);\n+\n+\treturn a_end > b_start;\n+}\n+\n static void\n vhost_user_iotlb_set_dump(struct virtio_net *dev, struct vhost_iotlb_entry *node)\n {\n@@ -37,16 +54,14 @@ static void\n vhost_user_iotlb_clear_dump(struct virtio_net *dev, struct vhost_iotlb_entry *node,\n \t\tstruct vhost_iotlb_entry *prev, struct vhost_iotlb_entry *next)\n {\n-\tuint64_t align, mask;\n+\tuint64_t align;\n \n \talign = hua_to_alignment(dev->mem, (void *)(uintptr_t)node->uaddr);\n-\tmask = ~(align - 1);\n \n \t/* Don't disable coredump if the previous node is in the same page */\n-\tif (prev == NULL || (node->uaddr & mask) != ((prev->uaddr + prev->size - 1) & mask)) {\n+\tif (!vhost_user_iotlb_share_page(prev, node, align)) {\n \t\t/* Don't disable coredump if the next node is in the same page */\n-\t\tif (next == NULL ||\n-\t\t\t\t((node->uaddr + node->size - 1) & mask) != (next->uaddr & mask))\n+\t\tif (!vhost_user_iotlb_share_page(node, next, align))\n \t\t\tmem_set_dump((void *)(uintptr_t)node->uaddr, node->size, false, align);\n \t}\n }\n", "prefixes": [ "v4", "03/26" ] }