Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127891/?format=api
{ "id": 127891, "url": "http://patches.dpdk.org/api/patches/127891/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230601195538.8265-19-ivan.malov@arknetworks.am/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230601195538.8265-19-ivan.malov@arknetworks.am>", "list_archive_url": "https://inbox.dpdk.org/dev/20230601195538.8265-19-ivan.malov@arknetworks.am", "date": "2023-06-01T19:55:22", "name": "[18/34] net/sfc: move MAE counter stream start to action set handler", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ed2f8028d1fcfbe351dfbd38e9499118e2effc8a", "submitter": { "id": 2962, "url": "http://patches.dpdk.org/api/people/2962/?format=api", "name": "Ivan Malov", "email": "ivan.malov@arknetworks.am" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230601195538.8265-19-ivan.malov@arknetworks.am/mbox/", "series": [ { "id": 28307, "url": "http://patches.dpdk.org/api/series/28307/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28307", "date": "2023-06-01T19:55:04", "name": "net/sfc: support HW conntrack assistance", "version": 1, "mbox": "http://patches.dpdk.org/series/28307/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/127891/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/127891/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8216842C07;\n\tThu, 1 Jun 2023 21:57:47 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B21DE42F8A;\n\tThu, 1 Jun 2023 21:56:03 +0200 (CEST)", "from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80])\n by mails.dpdk.org (Postfix) with ESMTP id E842942D51\n for <dev@dpdk.org>; Thu, 1 Jun 2023 21:55:50 +0200 (CEST)", "from localhost.localdomain (unknown [78.109.69.146])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by agw.arknetworks.am (Postfix) with ESMTPSA id 7A95EE1B59;\n Thu, 1 Jun 2023 23:55:50 +0400 (+04)" ], "From": "Ivan Malov <ivan.malov@arknetworks.am>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Ferruh Yigit <ferruh.yigit@amd.com>, Andy Moreton <amoreton@xilinx.com>", "Subject": "[PATCH 18/34] net/sfc: move MAE counter stream start to action set\n handler", "Date": "Thu, 1 Jun 2023 23:55:22 +0400", "Message-Id": "<20230601195538.8265-19-ivan.malov@arknetworks.am>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20230601195538.8265-1-ivan.malov@arknetworks.am>", "References": "<20230601195538.8265-1-ivan.malov@arknetworks.am>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Logically, starting flow counter streaming belongs in action\nset enable path. Move it there as a preparation step for the\npatch that will make action rules shareable by several flows.\n\nSigned-off-by: Ivan Malov <ivan.malov@arknetworks.am>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/net/sfc/sfc_mae.c | 22 ++++++++++++----------\n 1 file changed, 12 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c\nindex f61a859032..74614fe9a5 100644\n--- a/drivers/net/sfc/sfc_mae.c\n+++ b/drivers/net/sfc/sfc_mae.c\n@@ -1063,6 +1063,18 @@ sfc_mae_action_set_enable(struct sfc_adapter *sa,\n \t\t\treturn rc;\n \t\t}\n \n+\t\tif (action_set->n_counters > 0) {\n+\t\t\trc = sfc_mae_counter_start(sa);\n+\t\t\tif (rc != 0) {\n+\t\t\t\tsfc_err(sa, \"failed to start MAE counters support: %s\",\n+\t\t\t\t\trte_strerror(rc));\n+\t\t\t\tsfc_mae_encap_header_disable(sa, encap_header);\n+\t\t\t\tsfc_mae_mac_addr_disable(sa, src_mac_addr);\n+\t\t\t\tsfc_mae_mac_addr_disable(sa, dst_mac_addr);\n+\t\t\t\treturn rc;\n+\t\t\t}\n+\t\t}\n+\n \t\trc = sfc_mae_counters_enable(sa, counters,\n \t\t\t\t\t action_set->n_counters,\n \t\t\t\t\t action_set->spec);\n@@ -4143,15 +4155,6 @@ sfc_mae_flow_insert(struct sfc_adapter *sa,\n \tif (rc != 0)\n \t\tgoto fail_action_set_enable;\n \n-\tif (action_set->n_counters > 0) {\n-\t\trc = sfc_mae_counter_start(sa);\n-\t\tif (rc != 0) {\n-\t\t\tsfc_err(sa, \"failed to start MAE counters support: %s\",\n-\t\t\t\trte_strerror(rc));\n-\t\t\tgoto fail_mae_counter_start;\n-\t\t}\n-\t}\n-\n \tfw_rsrc = &action_set->fw_rsrc;\n \n \trc = efx_mae_action_rule_insert(sa->nic, spec_mae->match_spec,\n@@ -4166,7 +4169,6 @@ sfc_mae_flow_insert(struct sfc_adapter *sa,\n \treturn 0;\n \n fail_action_rule_insert:\n-fail_mae_counter_start:\n \tsfc_mae_action_set_disable(sa, action_set);\n \n fail_action_set_enable:\n", "prefixes": [ "18/34" ] }