Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127880/?format=api
{ "id": 127880, "url": "http://patches.dpdk.org/api/patches/127880/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230601195538.8265-8-ivan.malov@arknetworks.am/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230601195538.8265-8-ivan.malov@arknetworks.am>", "list_archive_url": "https://inbox.dpdk.org/dev/20230601195538.8265-8-ivan.malov@arknetworks.am", "date": "2023-06-01T19:55:11", "name": "[07/34] common/sfc_efx/base: add API to delete entry from HW table", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4f913dd821d1af7852193a1cf96035b4a2bf1414", "submitter": { "id": 2962, "url": "http://patches.dpdk.org/api/people/2962/?format=api", "name": "Ivan Malov", "email": "ivan.malov@arknetworks.am" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230601195538.8265-8-ivan.malov@arknetworks.am/mbox/", "series": [ { "id": 28307, "url": "http://patches.dpdk.org/api/series/28307/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28307", "date": "2023-06-01T19:55:04", "name": "net/sfc: support HW conntrack assistance", "version": 1, "mbox": "http://patches.dpdk.org/series/28307/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/127880/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/127880/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E56D242C07;\n\tThu, 1 Jun 2023 21:56:33 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D382442D4E;\n\tThu, 1 Jun 2023 21:55:49 +0200 (CEST)", "from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80])\n by mails.dpdk.org (Postfix) with ESMTP id C6F7842D0D\n for <dev@dpdk.org>; Thu, 1 Jun 2023 21:55:44 +0200 (CEST)", "from localhost.localdomain (unknown [78.109.69.146])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by agw.arknetworks.am (Postfix) with ESMTPSA id 47C6BE003C;\n Thu, 1 Jun 2023 23:55:44 +0400 (+04)" ], "From": "Ivan Malov <ivan.malov@arknetworks.am>", "To": "dev@dpdk.org", "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Ferruh Yigit <ferruh.yigit@amd.com>,\n Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>,\n Andy Moreton <amoreton@xilinx.com>", "Subject": "[PATCH 07/34] common/sfc_efx/base: add API to delete entry from HW\n table", "Date": "Thu, 1 Jun 2023 23:55:11 +0400", "Message-Id": "<20230601195538.8265-8-ivan.malov@arknetworks.am>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20230601195538.8265-1-ivan.malov@arknetworks.am>", "References": "<20230601195538.8265-1-ivan.malov@arknetworks.am>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>\n\nAPI allows to delete entry from any supported HW table.\n\nSigned-off-by: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>\nReviewed-by: Ivan Malov <ivan.malov@arknetworks.am>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/common/sfc_efx/base/efx.h | 11 ++++\n drivers/common/sfc_efx/base/efx_table.c | 77 +++++++++++++++++++++++++\n drivers/common/sfc_efx/version.map | 1 +\n 3 files changed, 89 insertions(+)", "diff": "diff --git a/drivers/common/sfc_efx/base/efx.h b/drivers/common/sfc_efx/base/efx.h\nindex 1683d8ce7b..cdf8a99abf 100644\n--- a/drivers/common/sfc_efx/base/efx.h\n+++ b/drivers/common/sfc_efx/base/efx.h\n@@ -5182,6 +5182,17 @@ efx_table_entry_insert(\n \t__in_bcount(data_size)\t\tuint8_t *entry_datap,\n \t__in\t\t\t\tunsigned int data_size);\n \n+LIBEFX_API\n+extern\t__checkReturn\t\t\tefx_rc_t\n+efx_table_entry_delete(\n+\t__in\t\t\t\tefx_nic_t *enp,\n+\t__in\t\t\t\tefx_table_id_t table_id,\n+\t__in\t\t\t\tuint16_t mask_id,\n+\t__in\t\t\t\tuint16_t key_width,\n+\t__in\t\t\t\tuint16_t mask_width,\n+\t__in_bcount(data_size)\t\tuint8_t *entry_datap,\n+\t__in\t\t\t\tunsigned int data_size);\n+\n #ifdef\t__cplusplus\n }\n #endif\ndiff --git a/drivers/common/sfc_efx/base/efx_table.c b/drivers/common/sfc_efx/base/efx_table.c\nindex 63fc319666..10a1c2ddcd 100644\n--- a/drivers/common/sfc_efx/base/efx_table.c\n+++ b/drivers/common/sfc_efx/base/efx_table.c\n@@ -419,6 +419,83 @@ efx_table_entry_insert(\n \n fail4:\n \tEFSYS_PROBE(fail4);\n+fail3:\n+\tEFSYS_PROBE(fail3);\n+fail2:\n+\tEFSYS_PROBE(fail2);\n+fail1:\n+\tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n+\treturn (rc);\n+}\n+\n+\t__checkReturn\t\t\tefx_rc_t\n+efx_table_entry_delete(\n+\t__in\t\t\t\tefx_nic_t *enp,\n+\t__in\t\t\t\tefx_table_id_t table_id,\n+\t__in\t\t\t\tuint16_t mask_id,\n+\t__in\t\t\t\tuint16_t key_width,\n+\t__in\t\t\t\tuint16_t mask_width,\n+\t__in_bcount(data_size)\t\tuint8_t *entry_datap,\n+\t__in\t\t\t\tunsigned int data_size)\n+{\n+\tconst efx_nic_cfg_t *encp = efx_nic_cfg_get(enp);\n+\tunsigned int n_dwords;\n+\tefx_mcdi_req_t req;\n+\tefx_rc_t rc;\n+\tEFX_MCDI_DECLARE_BUF(payload,\n+\t MC_CMD_TABLE_DELETE_IN_LENMAX_MCDI2,\n+\t MC_CMD_TABLE_DELETE_OUT_LEN);\n+\n+\t/*\n+\t * Ensure MCDI number of 32bit units matches EFX maximum possible\n+\t * data in bytes.\n+\t */\n+\tEFX_STATIC_ASSERT((MC_CMD_TABLE_DELETE_IN_LENMAX * sizeof(uint32_t)) ==\n+\t\tEFX_TABLE_ENTRY_LENGTH_MAX);\n+\n+\tif (encp->enc_table_api_supported == B_FALSE) {\n+\t\trc = ENOTSUP;\n+\t\tgoto fail1;\n+\t}\n+\n+\tif ((data_size % sizeof(uint32_t)) != 0) {\n+\t\trc = EINVAL;\n+\t\tgoto fail2;\n+\t}\n+\n+\tif ((data_size == 0) || (data_size > EFX_TABLE_ENTRY_LENGTH_MAX)) {\n+\t\trc = EINVAL;\n+\t\tgoto fail3;\n+\t}\n+\n+\tn_dwords = data_size / sizeof(uint32_t);\n+\n+\treq.emr_cmd = MC_CMD_TABLE_DELETE;\n+\treq.emr_in_buf = payload;\n+\treq.emr_in_length = MC_CMD_TABLE_DELETE_IN_LEN(n_dwords);\n+\treq.emr_out_buf = payload;\n+\treq.emr_out_length = MC_CMD_TABLE_DELETE_OUT_LEN;\n+\n+\tMCDI_IN_SET_DWORD(req, TABLE_DELETE_IN_TABLE_ID, (uint32_t)table_id);\n+\tMCDI_IN_SET_WORD(req, TABLE_DELETE_IN_MASK_ID, mask_id);\n+\tMCDI_IN_SET_WORD(req, TABLE_DELETE_IN_KEY_WIDTH, key_width);\n+\tMCDI_IN_SET_WORD(req, TABLE_DELETE_IN_MASK_WIDTH, mask_width);\n+\n+\n+\tmemcpy(MCDI_IN2(req, uint8_t, TABLE_DELETE_IN_DATA), entry_datap, data_size);\n+\n+\tefx_mcdi_execute(enp, &req);\n+\n+\tif (req.emr_rc != 0) {\n+\t\trc = req.emr_rc;\n+\t\tgoto fail4;\n+\t}\n+\n+\treturn (0);\n+\n+fail4:\n+\tEFSYS_PROBE(fail4);\n+\n fail3:\n \tEFSYS_PROBE(fail3);\n fail2:\ndiff --git a/drivers/common/sfc_efx/version.map b/drivers/common/sfc_efx/version.map\nindex f6a2003c3e..b596369c48 100644\n--- a/drivers/common/sfc_efx/version.map\n+++ b/drivers/common/sfc_efx/version.map\n@@ -234,6 +234,7 @@ INTERNAL {\n \tefx_sram_buf_tbl_set;\n \n \tefx_table_describe;\n+\tefx_table_entry_delete;\n \tefx_table_entry_insert;\n \tefx_table_is_supported;\n \tefx_table_list;\n", "prefixes": [ "07/34" ] }