Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127843/?format=api
{ "id": 127843, "url": "http://patches.dpdk.org/api/patches/127843/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230601150106.18375-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230601150106.18375-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230601150106.18375-4-stephen@networkplumber.org", "date": "2023-06-01T15:00:44", "name": "[03/25] lib: use strlcpy instead of snprintf", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "f6b7b50fee1adf22b0923a3e45df2cbd0f5a10ee", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230601150106.18375-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 28302, "url": "http://patches.dpdk.org/api/series/28302/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28302", "date": "2023-06-01T15:00:41", "name": "replace snprintf with strlcpy", "version": 1, "mbox": "http://patches.dpdk.org/series/28302/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/127843/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/127843/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CB67E42C04;\n\tThu, 1 Jun 2023 17:01:45 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F1EE142D3D;\n\tThu, 1 Jun 2023 17:01:17 +0200 (CEST)", "from mail-pl1-f181.google.com (mail-pl1-f181.google.com\n [209.85.214.181])\n by mails.dpdk.org (Postfix) with ESMTP id 495DE42D3A\n for <dev@dpdk.org>; Thu, 1 Jun 2023 17:01:17 +0200 (CEST)", "by mail-pl1-f181.google.com with SMTP id\n d9443c01a7336-1b041cceb16so8048995ad.2\n for <dev@dpdk.org>; Thu, 01 Jun 2023 08:01:17 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.15\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 01 Jun 2023 08:01:15 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631676;\n x=1688223676;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=3JuhadsjfflQsneHaARKKs7cNuYBKeWlaNdhUAcHkpo=;\n b=m+t1s4hyAr96btn/BFl3aqUcR8ATZc20UOCYSDXgsAinqa5g8CCz4zahZnAWuWhOPY\n d41nLxBD6uO9JubjrVStvIgvPQcbWOdihuc44Sf++0opLpBVtonsxEPxsbk1YsxPKwLm\n AVllHLFnUhII540/neIGjtpEELr/XmvsyYOBThgAtxhN/9zud6m1aPSdy0sP/zoKppyF\n 4jCzz//UwT8ixZUwlTIA1r56xXXqHNmsDolw5YCTSIxiDxYuIap5WfUF0A8phZAit2kK\n EhGYpLyF8MHd6rm40RQhrlilbHikDof/4J0AT2GxoqSAm2s2R+QLp8OP7JmFaAnL+ZTB\n 6eow==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1685631676; x=1688223676;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=3JuhadsjfflQsneHaARKKs7cNuYBKeWlaNdhUAcHkpo=;\n b=apdlacn4VvYfbvhWWdRP0cmPFUbiuLBgG4opzw4LSURfhjgGblLR/q76bnLN/y8NKl\n fkkrB/zxcXBgWjbjPCEkUCEiyWAWe1RYn0gzIjJ3BJtnPvsf/yZ5tfHcPePl66puNrAm\n zG83JUBFy6tNKG0Rfw8b6EDjKWHwTP5Fp7s9d9fT90ReG/59SdqEgGyV11qq9K3TvlkV\n G8Sfz9ulfGQXLpy+tdWr2ids7V+84zkpVPuJQfL8kVoUOSbvnPzTahbKb5RCWgih7fG9\n ueMuyTCqZkZ0jrGA0U6ivYwFSvePsdOuLSd/FPlXY6loxYkO5uBtTNZIbSuDpOnLURBf\n ef6w==", "X-Gm-Message-State": "AC+VfDyewH2orrPhoPQpl3XTocpiFxo6j7bGiYrbAecjgi409hbl4x1i\n 9Ps83dxpNh0ybvRWCZecJDhmIf7OHhhvSTlz2OBjZw==", "X-Google-Smtp-Source": "\n ACHHUZ5CRbnBmT3ZND6cy7YOS9VW5kVmmb/SV76j4xViZB2jfByQQEpYkIzC1X3ccuFdenT+wdG57Q==", "X-Received": "by 2002:a17:903:2284:b0:1b0:45e2:ef38 with SMTP id\n b4-20020a170903228400b001b045e2ef38mr10320049plh.26.1685631676174;\n Thu, 01 Jun 2023 08:01:16 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Nicolas Chautru <nicolas.chautru@intel.com>,\n Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "Subject": "[PATCH 03/25] lib: use strlcpy instead of snprintf", "Date": "Thu, 1 Jun 2023 08:00:44 -0700", "Message-Id": "<20230601150106.18375-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230601150106.18375-1-stephen@networkplumber.org>", "References": "<20230601150106.18375-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace snprintf with strlcpy where possible.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/bbdev/rte_bbdev.c | 2 +-\n lib/ethdev/sff_8636.c | 11 +++++++----\n 2 files changed, 8 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c\nindex 581509b5a213..7cc126a0e7be 100644\n--- a/lib/bbdev/rte_bbdev.c\n+++ b/lib/bbdev/rte_bbdev.c\n@@ -212,7 +212,7 @@ rte_bbdev_allocate(const char *name)\n \tbbdev->data->dev_id = dev_id;\n \tbbdev->state = RTE_BBDEV_INITIALIZED;\n \n-\tret = snprintf(bbdev->data->name, RTE_BBDEV_NAME_MAX_LEN, \"%s\", name);\n+\tret = strlcpy(bbdev->data->name, name, RTE_BBDEV_NAME_MAX_LEN);\n \tif ((ret < 0) || (ret >= RTE_BBDEV_NAME_MAX_LEN)) {\n \t\trte_bbdev_log(ERR, \"Copying device name \\\"%s\\\" failed\", name);\n \t\treturn NULL;\ndiff --git a/lib/ethdev/sff_8636.c b/lib/ethdev/sff_8636.c\nindex 6b65f47efedf..a623e0d065d8 100644\n--- a/lib/ethdev/sff_8636.c\n+++ b/lib/ethdev/sff_8636.c\n@@ -203,16 +203,19 @@ static void sff_8636_show_ext_identifier(const uint8_t *data, struct rte_tel_dat\n \n \tswitch (data[SFF_8636_EXT_ID_OFFSET] & SFF_8636_EXT_ID_EPWR_CLASS_MASK) {\n \tcase SFF_8636_EXT_ID_PWR_CLASS_LEGACY:\n-\t\tsnprintf(val_string, sizeof(val_string), \"%s\", \"\");\n+\t\tstrlcpy(val_string, \"\", sizeof(val_string));\n \t\tbreak;\n \tcase SFF_8636_EXT_ID_PWR_CLASS_5:\n-\t\tsnprintf(val_string, sizeof(val_string), \"%s\", \"4.0W max. Power consumption, \");\n+\t\tstrlcpy(val_string, \"4.0W max. Power consumption, \",\n+\t\t\tsizeof(val_string));\n \t\tbreak;\n \tcase SFF_8636_EXT_ID_PWR_CLASS_6:\n-\t\tsnprintf(val_string, sizeof(val_string), \"%s\", \"4.5W max. Power consumption, \");\n+\t\tstrlcpy(val_string, \"4.5W max. Power consumption, \",\n+\t\t\tsizeof(val_string));\n \t\tbreak;\n \tcase SFF_8636_EXT_ID_PWR_CLASS_7:\n-\t\tsnprintf(val_string, sizeof(val_string), \"%s\", \"5.0W max. Power consumption, \");\n+\t\tstrlcpy(val_string, \"5.0W max. Power consumption, \",\n+\t\t\tsizeof(val_string));\n \t\tbreak;\n \t}\n \n", "prefixes": [ "03/25" ] }