Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127690/?format=api
{ "id": 127690, "url": "http://patches.dpdk.org/api/patches/127690/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230530090510.56812-3-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230530090510.56812-3-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230530090510.56812-3-haijie1@huawei.com", "date": "2023-05-30T09:05:02", "name": "[02/10] ethdev: support RxTx offload display", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "ffd2e6e7a50b0671df6101f71ffda7d9648779fe", "submitter": { "id": 2935, "url": "http://patches.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230530090510.56812-3-haijie1@huawei.com/mbox/", "series": [ { "id": 28245, "url": "http://patches.dpdk.org/api/series/28245/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28245", "date": "2023-05-30T09:05:00", "name": "support telemetry query ethdev info", "version": 1, "mbox": "http://patches.dpdk.org/series/28245/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/127690/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/127690/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A962C42BE1;\n\tTue, 30 May 2023 11:07:43 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C444942D0D;\n\tTue, 30 May 2023 11:07:42 +0200 (CEST)", "from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])\n by mails.dpdk.org (Postfix) with ESMTP id 55A2342BC9\n for <dev@dpdk.org>; Tue, 30 May 2023 11:07:41 +0200 (CEST)", "from kwepemi500020.china.huawei.com (unknown [172.30.72.57])\n by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4QVmdL4JmGz18Lc8;\n Tue, 30 May 2023 17:03:02 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.23; Tue, 30 May 2023 17:07:39 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit\n <ferruh.yigit@amd.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "CC": "<dev@dpdk.org>, <liudongdong3@huawei.com>", "Subject": "[PATCH 02/10] ethdev: support RxTx offload display", "Date": "Tue, 30 May 2023 17:05:02 +0800", "Message-ID": "<20230530090510.56812-3-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20230530090510.56812-1-haijie1@huawei.com>", "References": "<20230530090510.56812-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n kwepemi500020.china.huawei.com (7.221.188.8)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Currently, Rx/Tx offloads are displayed in numeric format,\nwhich is not easy to understand. This patch fixes it.\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n lib/ethdev/rte_ethdev.c | 67 +++++++++++++++++++++++++++++++++++------\n 1 file changed, 57 insertions(+), 10 deletions(-)", "diff": "diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex 65e0101fc0eb..3207b3177256 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -6607,16 +6607,44 @@ eth_dev_handle_port_link_status(const char *cmd __rte_unused,\n \treturn 0;\n }\n \n+static void\n+eth_dev_parse_rx_offloads(uint64_t offload, struct rte_tel_data *d)\n+{\n+\tuint32_t i;\n+\n+\trte_tel_data_start_array(d, RTE_TEL_STRING_VAL);\n+\tfor (i = 0; i < RTE_DIM(eth_dev_rx_offload_names); i++) {\n+\t\tif ((offload & eth_dev_rx_offload_names[i].offload) != 0)\n+\t\t\trte_tel_data_add_array_string(d,\n+\t\t\t\teth_dev_rx_offload_names[i].name);\n+\t}\n+}\n+\n+static void\n+eth_dev_parse_tx_offloads(uint64_t offload, struct rte_tel_data *d)\n+{\n+\tuint32_t i;\n+\n+\trte_tel_data_start_array(d, RTE_TEL_STRING_VAL);\n+\tfor (i = 0; i < RTE_DIM(eth_dev_tx_offload_names); i++) {\n+\t\tif ((offload & eth_dev_tx_offload_names[i].offload) != 0)\n+\t\t\trte_tel_data_add_array_string(d,\n+\t\t\t\teth_dev_tx_offload_names[i].name);\n+\t}\n+}\n+\n static int\n eth_dev_handle_port_info(const char *cmd __rte_unused,\n \t\tconst char *params,\n \t\tstruct rte_tel_data *d)\n {\n+\tstruct rte_tel_data *rx_offload, *tx_offload;\n \tstruct rte_tel_data *rxq_state, *txq_state;\n \tchar mac_addr[RTE_ETHER_ADDR_FMT_SIZE];\n \tstruct rte_eth_dev *eth_dev;\n \tchar *end_param;\n-\tint port_id, i;\n+\tint port_id;\n+\tuint32_t i;\n \n \tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n \t\treturn -1;\n@@ -6632,14 +6660,20 @@ eth_dev_handle_port_info(const char *cmd __rte_unused,\n \teth_dev = &rte_eth_devices[port_id];\n \n \trxq_state = rte_tel_data_alloc();\n-\tif (!rxq_state)\n+\tif (rxq_state == NULL)\n \t\treturn -ENOMEM;\n \n \ttxq_state = rte_tel_data_alloc();\n-\tif (!txq_state) {\n-\t\trte_tel_data_free(rxq_state);\n-\t\treturn -ENOMEM;\n-\t}\n+\tif (txq_state == NULL)\n+\t\tgoto free_rxq_state;\n+\n+\trx_offload = rte_tel_data_alloc();\n+\tif (rx_offload == NULL)\n+\t\tgoto free_txq_state;\n+\n+\ttx_offload = rte_tel_data_alloc();\n+\tif (tx_offload == NULL)\n+\t\tgoto free_rx_offload;\n \n \trte_tel_data_start_dict(d);\n \trte_tel_data_add_dict_string(d, \"name\", eth_dev->data->name);\n@@ -6681,14 +6715,27 @@ eth_dev_handle_port_info(const char *cmd __rte_unused,\n \trte_tel_data_add_dict_int(d, \"numa_node\", eth_dev->data->numa_node);\n \trte_tel_data_add_dict_uint_hex(d, \"dev_flags\",\n \t\t\teth_dev->data->dev_flags, 0);\n-\trte_tel_data_add_dict_uint_hex(d, \"rx_offloads\",\n-\t\t\teth_dev->data->dev_conf.rxmode.offloads, 0);\n-\trte_tel_data_add_dict_uint_hex(d, \"tx_offloads\",\n-\t\t\teth_dev->data->dev_conf.txmode.offloads, 0);\n+\n+\teth_dev_parse_rx_offloads(eth_dev->data->dev_conf.rxmode.offloads,\n+\t\t\trx_offload);\n+\trte_tel_data_add_dict_container(d, \"rx_offloads\", rx_offload, 0);\n+\teth_dev_parse_tx_offloads(eth_dev->data->dev_conf.txmode.offloads,\n+\t\t\ttx_offload);\n+\trte_tel_data_add_dict_container(d, \"tx_offloads\", tx_offload, 0);\n+\n \trte_tel_data_add_dict_uint_hex(d, \"ethdev_rss_hf\",\n \t\t\teth_dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf, 0);\n \n \treturn 0;\n+\n+free_rx_offload:\n+\trte_tel_data_free(rx_offload);\n+free_txq_state:\n+\trte_tel_data_free(txq_state);\n+free_rxq_state:\n+\trte_tel_data_free(rxq_state);\n+\n+\treturn -ENOMEM;\n }\n \n int\n", "prefixes": [ "02/10" ] }