Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 127511,
    "url": "http://patches.dpdk.org/api/patches/127511/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230525232331.34645-5-nicolas.chautru@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230525232331.34645-5-nicolas.chautru@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230525232331.34645-5-nicolas.chautru@intel.com",
    "date": "2023-05-25T23:23:31",
    "name": "[v1,4/4] bbdev: improving error handling for queue configuration",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "dc709a137634e8f099151b0e595d94ac61d7c5bb",
    "submitter": {
        "id": 1314,
        "url": "http://patches.dpdk.org/api/people/1314/?format=api",
        "name": "Chautru, Nicolas",
        "email": "nicolas.chautru@intel.com"
    },
    "delegate": {
        "id": 2642,
        "url": "http://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230525232331.34645-5-nicolas.chautru@intel.com/mbox/",
    "series": [
        {
            "id": 28192,
            "url": "http://patches.dpdk.org/api/series/28192/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28192",
            "date": "2023-05-25T23:23:27",
            "name": "bbdev: API extension for 23.11",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/28192/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/127511/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/127511/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 23BCE42BA1;\n\tFri, 26 May 2023 01:29:18 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DA07542D20;\n\tFri, 26 May 2023 01:29:03 +0200 (CEST)",
            "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by mails.dpdk.org (Postfix) with ESMTP id 2E7D642BD9\n for <dev@dpdk.org>; Fri, 26 May 2023 01:28:58 +0200 (CEST)",
            "from orsmga003.jf.intel.com ([10.7.209.27])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 May 2023 16:28:47 -0700",
            "from spr-npg-bds1-eec2.sn.intel.com (HELO spr-npg-bds1-eec2..)\n ([10.233.181.123])\n by orsmga003.jf.intel.com with ESMTP; 25 May 2023 16:28:43 -0700"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1685057339; x=1716593339;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=b2iVj2oYnCNJF/PaqupOplAg+78d3FUeV/voSpxZXvc=;\n b=dAYAABl/Uzjt7ocv2eyZk/JXz5RqWH3m/gBTtkXoqQ+DnK+IYcjM57CJ\n KzkycSZji/roD6kWrXP9hhd0H9Voap+iLbYMqpVRqQeykM0HbVX7ftTM8\n 21R9AKpVIoZKOy34iNTV7MOuspe6QGgqK+SakTM4UH4zcfr9BWiOLKjtL\n uOzc0yUDv8XG9K5qn4TJkIlT7hlnyYQCCqzvE2z/HryJbU4+rOZhYIpRp\n 2mMzJH62u2npOD3v0PRZXNooyougmc4q/x5BLCvk4iniLyc7HI9Qj7H2F\n cHnszAnIx/pnlTuY8zlo4XcwZVmirvisXucVBOjX70fLzteBLYkL9D4up w==;",
        "X-IronPort-AV": [
            "E=McAfee;i=\"6600,9927,10721\"; a=\"338653656\"",
            "E=Sophos;i=\"6.00,192,1681196400\"; d=\"scan'208\";a=\"338653656\"",
            "E=McAfee;i=\"6600,9927,10721\"; a=\"655428644\"",
            "E=Sophos;i=\"6.00,192,1681196400\"; d=\"scan'208\";a=\"655428644\""
        ],
        "X-ExtLoop1": "1",
        "From": "Nicolas Chautru <nicolas.chautru@intel.com>",
        "To": "dev@dpdk.org,\n\tmaxime.coquelin@redhat.com",
        "Cc": "trix@redhat.com, hemant.agrawal@nxp.com, david.marchand@redhat.com,\n hernan.vargas@intel.com, Nicolas Chautru <nicolas.chautru@intel.com>",
        "Subject": "[PATCH v1 4/4] bbdev: improving error handling for queue\n configuration",
        "Date": "Thu, 25 May 2023 23:23:31 +0000",
        "Message-Id": "<20230525232331.34645-5-nicolas.chautru@intel.com>",
        "X-Mailer": "git-send-email 2.34.1",
        "In-Reply-To": "<20230525232331.34645-1-nicolas.chautru@intel.com>",
        "References": "<20230525232331.34645-1-nicolas.chautru@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Refactor of the error handling based on available priority\nqueue to be more generic.\n\nSigned-off-by: Nicolas Chautru <nicolas.chautru@intel.com>\n---\n lib/bbdev/rte_bbdev.c | 15 ++++++---------\n 1 file changed, 6 insertions(+), 9 deletions(-)",
    "diff": "diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c\nindex 26fc077bdc..589b796ea3 100644\n--- a/lib/bbdev/rte_bbdev.c\n+++ b/lib/bbdev/rte_bbdev.c\n@@ -441,6 +441,7 @@ rte_bbdev_queue_configure(uint16_t dev_id, uint16_t queue_id,\n \tconst struct rte_bbdev_op_cap *p;\n \tstruct rte_bbdev_queue_conf *stored_conf;\n \tconst char *op_type_str;\n+\tunsigned int max_priority;\n \tVALID_DEV_OR_RET_ERR(dev, dev_id);\n \n \tVALID_DEV_OPS_OR_RET_ERR(dev, dev_id);\n@@ -494,20 +495,16 @@ rte_bbdev_queue_configure(uint16_t dev_id, uint16_t queue_id,\n \t\t\t\t\tconf->queue_size, queue_id, dev_id);\n \t\t\treturn -EINVAL;\n \t\t}\n-\t\tif (conf->op_type == RTE_BBDEV_OP_TURBO_DEC &&\n-\t\t\tconf->priority > dev_info.max_ul_queue_priority) {\n+\t\tif ((uint8_t)conf->op_type >= RTE_BBDEV_OP_TYPE_SIZE_MAX) {\n \t\t\trte_bbdev_log(ERR,\n-\t\t\t\t\t\"Priority (%u) of queue %u of bbdev %u must be <= %u\",\n-\t\t\t\t\tconf->priority, queue_id, dev_id,\n-\t\t\t\t\tdev_info.max_ul_queue_priority);\n+\t\t\t\t\t\"Invalid operation type (%u) \", conf->op_type);\n \t\t\treturn -EINVAL;\n \t\t}\n-\t\tif (conf->op_type == RTE_BBDEV_OP_TURBO_ENC &&\n-\t\t\tconf->priority > dev_info.max_dl_queue_priority) {\n+\t\tmax_priority = dev_info.queue_priority[conf->op_type];\n+\t\tif (conf->priority > max_priority) {\n \t\t\trte_bbdev_log(ERR,\n \t\t\t\t\t\"Priority (%u) of queue %u of bbdev %u must be <= %u\",\n-\t\t\t\t\tconf->priority, queue_id, dev_id,\n-\t\t\t\t\tdev_info.max_dl_queue_priority);\n+\t\t\t\t\tconf->priority, queue_id, dev_id, max_priority);\n \t\t\treturn -EINVAL;\n \t\t}\n \t}\n",
    "prefixes": [
        "v1",
        "4/4"
    ]
}