Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127495/?format=api
{ "id": 127495, "url": "http://patches.dpdk.org/api/patches/127495/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230525162551.70359-27-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230525162551.70359-27-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230525162551.70359-27-maxime.coquelin@redhat.com", "date": "2023-05-25T16:25:49", "name": "[v3,26/28] vhost: add VDUSE device startup", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "af2e71d10f3e628bcfbdcf6e604beb6d84f3ef71", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230525162551.70359-27-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 28187, "url": "http://patches.dpdk.org/api/series/28187/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28187", "date": "2023-05-25T16:25:23", "name": "Add VDUSE support to Vhost library", "version": 3, "mbox": "http://patches.dpdk.org/series/28187/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/127495/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/127495/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E845842B9D;\n\tThu, 25 May 2023 18:28:35 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A25D942F94;\n\tThu, 25 May 2023 18:27:33 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id C6E8A40E6E\n for <dev@dpdk.org>; Thu, 25 May 2023 18:27:31 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-10-1vcObvENMD2kBhpEjzRFZg-1; Thu, 25 May 2023 12:27:28 -0400", "from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com\n [10.11.54.7])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F122C185A792;\n Thu, 25 May 2023 16:27:27 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.39.208.23])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 6CEF8140E95D;\n Thu, 25 May 2023 16:27:25 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1685032051;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=YwlzYHwt7IM+hV5pg2MDq7egkCHBIQihzJGivnXO/ZE=;\n b=Lp16kaHApyiFwygqLfUnPwVUhrv2BNq+DvsSNaLoP22V/3+fUzrW6zUHDxcFYMJ48Scy9G\n NbB0voIOjqcod6/WDuen89L+0zNsQBQl5/yMk6wryluDGu2iIrr4i6THhLUoAJzXIp4quY\n bLwQwQmohfLMmUr/w9MFmYgA5jkncXk=", "X-MC-Unique": "1vcObvENMD2kBhpEjzRFZg-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, chenbo.xia@intel.com, david.marchand@redhat.com,\n mkp@redhat.com, fbl@redhat.com, jasowang@redhat.com,\n cunming.liang@intel.com, xieyongji@bytedance.com, echaudro@redhat.com,\n eperezma@redhat.com, amorenoz@redhat.com, lulu@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Subject": "[PATCH v3 26/28] vhost: add VDUSE device startup", "Date": "Thu, 25 May 2023 18:25:49 +0200", "Message-Id": "<20230525162551.70359-27-maxime.coquelin@redhat.com>", "In-Reply-To": "<20230525162551.70359-1-maxime.coquelin@redhat.com>", "References": "<20230525162551.70359-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.7", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch adds the device and its virtqueues\ninitialization once the Virtio driver has set the DRIVER_OK\nin the Virtio status register.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\nReviewed-by: Chenbo Xia <chenbo.xia@intel.com>\n---\n lib/vhost/vduse.c | 126 ++++++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 126 insertions(+)", "diff": "diff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c\nindex 110654ec68..a10dc24d38 100644\n--- a/lib/vhost/vduse.c\n+++ b/lib/vhost/vduse.c\n@@ -141,6 +141,128 @@ static struct vhost_backend_ops vduse_backend_ops = {\n \t.inject_irq = vduse_inject_irq,\n };\n \n+static void\n+vduse_vring_setup(struct virtio_net *dev, unsigned int index)\n+{\n+\tstruct vhost_virtqueue *vq = dev->virtqueue[index];\n+\tstruct vhost_vring_addr *ra = &vq->ring_addrs;\n+\tstruct vduse_vq_info vq_info;\n+\tstruct vduse_vq_eventfd vq_efd;\n+\tint ret;\n+\n+\tvq_info.index = index;\n+\tret = ioctl(dev->vduse_dev_fd, VDUSE_VQ_GET_INFO, &vq_info);\n+\tif (ret) {\n+\t\tVHOST_LOG_CONFIG(dev->ifname, ERR, \"Failed to get VQ %u info: %s\\n\",\n+\t\t\t\tindex, strerror(errno));\n+\t\treturn;\n+\t}\n+\n+\tVHOST_LOG_CONFIG(dev->ifname, INFO, \"VQ %u info:\\n\", index);\n+\tVHOST_LOG_CONFIG(dev->ifname, INFO, \"\\tnum: %u\\n\", vq_info.num);\n+\tVHOST_LOG_CONFIG(dev->ifname, INFO, \"\\tdesc_addr: %llx\\n\", vq_info.desc_addr);\n+\tVHOST_LOG_CONFIG(dev->ifname, INFO, \"\\tdriver_addr: %llx\\n\", vq_info.driver_addr);\n+\tVHOST_LOG_CONFIG(dev->ifname, INFO, \"\\tdevice_addr: %llx\\n\", vq_info.device_addr);\n+\tVHOST_LOG_CONFIG(dev->ifname, INFO, \"\\tavail_idx: %u\\n\", vq_info.split.avail_index);\n+\tVHOST_LOG_CONFIG(dev->ifname, INFO, \"\\tready: %u\\n\", vq_info.ready);\n+\n+\tvq->last_avail_idx = vq_info.split.avail_index;\n+\tvq->size = vq_info.num;\n+\tvq->ready = true;\n+\tvq->enabled = vq_info.ready;\n+\tra->desc_user_addr = vq_info.desc_addr;\n+\tra->avail_user_addr = vq_info.driver_addr;\n+\tra->used_user_addr = vq_info.device_addr;\n+\n+\tvq->kickfd = eventfd(0, EFD_NONBLOCK | EFD_CLOEXEC);\n+\tif (vq->kickfd < 0) {\n+\t\tVHOST_LOG_CONFIG(dev->ifname, ERR, \"Failed to init kickfd for VQ %u: %s\\n\",\n+\t\t\t\tindex, strerror(errno));\n+\t\tvq->kickfd = VIRTIO_INVALID_EVENTFD;\n+\t\treturn;\n+\t}\n+\tVHOST_LOG_CONFIG(dev->ifname, INFO, \"\\tkick fd: %d\\n\", vq->kickfd);\n+\n+\tvq->shadow_used_split = rte_malloc_socket(NULL,\n+\t\t\t\tvq->size * sizeof(struct vring_used_elem),\n+\t\t\t\tRTE_CACHE_LINE_SIZE, 0);\n+\tvq->batch_copy_elems = rte_malloc_socket(NULL,\n+\t\t\t\tvq->size * sizeof(struct batch_copy_elem),\n+\t\t\t\tRTE_CACHE_LINE_SIZE, 0);\n+\n+\tvhost_user_iotlb_rd_lock(vq);\n+\tif (vring_translate(dev, vq))\n+\t\tVHOST_LOG_CONFIG(dev->ifname, ERR, \"Failed to translate vring %d addresses\\n\",\n+\t\t\t\tindex);\n+\n+\tif (vhost_enable_guest_notification(dev, vq, 0))\n+\t\tVHOST_LOG_CONFIG(dev->ifname, ERR,\n+\t\t\t\t\"Failed to disable guest notifications on vring %d\\n\",\n+\t\t\t\tindex);\n+\tvhost_user_iotlb_rd_unlock(vq);\n+\n+\tvq_efd.index = index;\n+\tvq_efd.fd = vq->kickfd;\n+\n+\tret = ioctl(dev->vduse_dev_fd, VDUSE_VQ_SETUP_KICKFD, &vq_efd);\n+\tif (ret) {\n+\t\tVHOST_LOG_CONFIG(dev->ifname, ERR, \"Failed to setup kickfd for VQ %u: %s\\n\",\n+\t\t\t\tindex, strerror(errno));\n+\t\tclose(vq->kickfd);\n+\t\tvq->kickfd = VIRTIO_UNINITIALIZED_EVENTFD;\n+\t\treturn;\n+\t}\n+}\n+\n+static void\n+vduse_device_start(struct virtio_net *dev)\n+{\n+\tunsigned int i, ret;\n+\n+\tVHOST_LOG_CONFIG(dev->ifname, INFO, \"Starting device...\\n\");\n+\n+\tdev->notify_ops = vhost_driver_callback_get(dev->ifname);\n+\tif (!dev->notify_ops) {\n+\t\tVHOST_LOG_CONFIG(dev->ifname, ERR,\n+\t\t\t\t\"Failed to get callback ops for driver\\n\");\n+\t\treturn;\n+\t}\n+\n+\tret = ioctl(dev->vduse_dev_fd, VDUSE_DEV_GET_FEATURES, &dev->features);\n+\tif (ret) {\n+\t\tVHOST_LOG_CONFIG(dev->ifname, ERR, \"Failed to get features: %s\\n\",\n+\t\t\t\tstrerror(errno));\n+\t\treturn;\n+\t}\n+\n+\tVHOST_LOG_CONFIG(dev->ifname, INFO, \"Negotiated Virtio features: 0x%\" PRIx64 \"\\n\",\n+\t\tdev->features);\n+\n+\tif (dev->features &\n+\t\t((1ULL << VIRTIO_NET_F_MRG_RXBUF) |\n+\t\t (1ULL << VIRTIO_F_VERSION_1) |\n+\t\t (1ULL << VIRTIO_F_RING_PACKED))) {\n+\t\tdev->vhost_hlen = sizeof(struct virtio_net_hdr_mrg_rxbuf);\n+\t} else {\n+\t\tdev->vhost_hlen = sizeof(struct virtio_net_hdr);\n+\t}\n+\n+\tfor (i = 0; i < dev->nr_vring; i++)\n+\t\tvduse_vring_setup(dev, i);\n+\n+\tdev->flags |= VIRTIO_DEV_READY;\n+\n+\tif (dev->notify_ops->new_device(dev->vid) == 0)\n+\t\tdev->flags |= VIRTIO_DEV_RUNNING;\n+\n+\tfor (i = 0; i < dev->nr_vring; i++) {\n+\t\tstruct vhost_virtqueue *vq = dev->virtqueue[i];\n+\n+\t\tif (dev->notify_ops->vring_state_changed)\n+\t\t\tdev->notify_ops->vring_state_changed(dev->vid, i, vq->enabled);\n+\t}\n+}\n+\n static void\n vduse_events_handler(int fd, void *arg, int *remove __rte_unused)\n {\n@@ -177,6 +299,10 @@ vduse_events_handler(int fd, void *arg, int *remove __rte_unused)\n \t\tVHOST_LOG_CONFIG(dev->ifname, INFO, \"\\tnew status: 0x%08x\\n\",\n \t\t\t\treq.s.status);\n \t\tdev->status = req.s.status;\n+\n+\t\tif (dev->status & VIRTIO_DEVICE_STATUS_DRIVER_OK)\n+\t\t\tvduse_device_start(dev);\n+\n \t\tresp.result = VDUSE_REQ_RESULT_OK;\n \t\tbreak;\n \tcase VDUSE_UPDATE_IOTLB:\n", "prefixes": [ "v3", "26/28" ] }