Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127488/?format=api
{ "id": 127488, "url": "http://patches.dpdk.org/api/patches/127488/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230525162551.70359-20-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230525162551.70359-20-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230525162551.70359-20-maxime.coquelin@redhat.com", "date": "2023-05-25T16:25:42", "name": "[v3,19/28] vhost: add VDUSE callback for IOTLB miss", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "24eeaa5e18f234115c66e1bab5af06b42f2321ba", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230525162551.70359-20-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 28187, "url": "http://patches.dpdk.org/api/series/28187/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28187", "date": "2023-05-25T16:25:23", "name": "Add VDUSE support to Vhost library", "version": 3, "mbox": "http://patches.dpdk.org/series/28187/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/127488/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/127488/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 42A8742B9D;\n\tThu, 25 May 2023 18:28:00 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C9BD142FDC;\n\tThu, 25 May 2023 18:27:13 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id 68471427EE\n for <dev@dpdk.org>; Thu, 25 May 2023 18:27:10 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-587-IPVe5OSJMEGjdMOvyRhVfQ-1; Thu, 25 May 2023 12:27:07 -0400", "from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com\n [10.11.54.7])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 95B543814582;\n Thu, 25 May 2023 16:27:06 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.39.208.23])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 22BF4140E95D;\n Thu, 25 May 2023 16:27:04 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1685032030;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=bCjb9bPrkWjcMRuH9nhbBJ1yUcyb/M8upG8Hsux6BOI=;\n b=iqSjgxUfcHXMSmSk04FgMCTs0g+Zj50ybE2RLd5wVgrLf9V9wyPR0u/dxQOT8Q3A9LK+bR\n b6TmFcS3x/1KkowSmoDjw24LZ4zZJQh3SkIj3HVjez2t4M96JwTpkPECyeQWH1W5iNDOGV\n L9tWp/M5kUu+1XKoMlA9RM3bvF20XWU=", "X-MC-Unique": "IPVe5OSJMEGjdMOvyRhVfQ-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, chenbo.xia@intel.com, david.marchand@redhat.com,\n mkp@redhat.com, fbl@redhat.com, jasowang@redhat.com,\n cunming.liang@intel.com, xieyongji@bytedance.com, echaudro@redhat.com,\n eperezma@redhat.com, amorenoz@redhat.com, lulu@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Subject": "[PATCH v3 19/28] vhost: add VDUSE callback for IOTLB miss", "Date": "Thu, 25 May 2023 18:25:42 +0200", "Message-Id": "<20230525162551.70359-20-maxime.coquelin@redhat.com>", "In-Reply-To": "<20230525162551.70359-1-maxime.coquelin@redhat.com>", "References": "<20230525162551.70359-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.7", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch implements the VDUSE callback for IOTLB misses,\nwhich is done by using the VDUSE VDUSE_IOTLB_GET_FD ioctl.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\nReviewed-by: Chenbo Xia <chenbo.xia@intel.com>\n---\n lib/vhost/vduse.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 58 insertions(+)", "diff": "diff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c\nindex d67818bfb5..f72c7bf6ab 100644\n--- a/lib/vhost/vduse.c\n+++ b/lib/vhost/vduse.c\n@@ -13,9 +13,11 @@\n \n #include <sys/ioctl.h>\n #include <sys/mman.h>\n+#include <sys/stat.h>\n \n #include <rte_common.h>\n \n+#include \"iotlb.h\"\n #include \"vduse.h\"\n #include \"vhost.h\"\n \n@@ -40,7 +42,63 @@\n \t\t\t\t(1ULL << VIRTIO_F_IN_ORDER) | \\\n \t\t\t\t(1ULL << VIRTIO_F_IOMMU_PLATFORM))\n \n+static int\n+vduse_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm __rte_unused)\n+{\n+\tstruct vduse_iotlb_entry entry;\n+\tuint64_t size, page_size;\n+\tstruct stat stat;\n+\tvoid *mmap_addr;\n+\tint fd, ret;\n+\n+\tentry.start = iova;\n+\tentry.last = iova + 1;\n+\n+\tret = ioctl(dev->vduse_dev_fd, VDUSE_IOTLB_GET_FD, &entry);\n+\tif (ret < 0) {\n+\t\tVHOST_LOG_CONFIG(dev->ifname, ERR, \"Failed to get IOTLB entry for 0x%\" PRIx64 \"\\n\",\n+\t\t\t\tiova);\n+\t\treturn -1;\n+\t}\n+\n+\tfd = ret;\n+\n+\tVHOST_LOG_CONFIG(dev->ifname, DEBUG, \"New IOTLB entry:\\n\");\n+\tVHOST_LOG_CONFIG(dev->ifname, DEBUG, \"\\tIOVA: %\" PRIx64 \" - %\" PRIx64 \"\\n\",\n+\t\t\t(uint64_t)entry.start, (uint64_t)entry.last);\n+\tVHOST_LOG_CONFIG(dev->ifname, DEBUG, \"\\toffset: %\" PRIx64 \"\\n\", (uint64_t)entry.offset);\n+\tVHOST_LOG_CONFIG(dev->ifname, DEBUG, \"\\tfd: %d\\n\", fd);\n+\tVHOST_LOG_CONFIG(dev->ifname, DEBUG, \"\\tperm: %x\\n\", entry.perm);\n+\n+\tsize = entry.last - entry.start + 1;\n+\tmmap_addr = mmap(0, size + entry.offset, entry.perm, MAP_SHARED, fd, 0);\n+\tif (!mmap_addr) {\n+\t\tVHOST_LOG_CONFIG(dev->ifname, ERR,\n+\t\t\t\t\"Failed to mmap IOTLB entry for 0x%\" PRIx64 \"\\n\", iova);\n+\t\tret = -1;\n+\t\tgoto close_fd;\n+\t}\n+\n+\tret = fstat(fd, &stat);\n+\tif (ret < 0) {\n+\t\tVHOST_LOG_CONFIG(dev->ifname, ERR, \"Failed to get page size.\\n\");\n+\t\tmunmap(mmap_addr, entry.offset + size);\n+\t\tgoto close_fd;\n+\t}\n+\tpage_size = (uint64_t)stat.st_blksize;\n+\n+\tvhost_user_iotlb_cache_insert(dev, entry.start, (uint64_t)(uintptr_t)mmap_addr,\n+\t\tentry.offset, size, page_size, entry.perm);\n+\n+\tret = 0;\n+close_fd:\n+\tclose(fd);\n+\n+\treturn ret;\n+}\n+\n static struct vhost_backend_ops vduse_backend_ops = {\n+\t.iotlb_miss = vduse_iotlb_miss,\n };\n \n int\n", "prefixes": [ "v3", "19/28" ] }