Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127425/?format=api
http://patches.dpdk.org/api/patches/127425/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230525095904.3967080-12-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230525095904.3967080-12-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230525095904.3967080-12-ndabilpuram@marvell.com", "date": "2023-05-25T09:58:44", "name": "[v3,12/32] common/cnxk: fix null pointer dereference", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "299b25146df05a2f65290e99fce6eab2b875c7a4", "submitter": { "id": 1202, "url": "http://patches.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230525095904.3967080-12-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 28180, "url": "http://patches.dpdk.org/api/series/28180/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28180", "date": "2023-05-25T09:58:36", "name": "[v3,01/32] common/cnxk: allocate dynamic BPIDs", "version": 3, "mbox": "http://patches.dpdk.org/series/28180/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/127425/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/127425/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E088F42B9A;\n\tThu, 25 May 2023 12:37:24 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 319D742D42;\n\tThu, 25 May 2023 12:37:15 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 8282B42D38;\n Thu, 25 May 2023 12:37:13 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 34P9Il39025637; Thu, 25 May 2023 03:37:12 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3qsspt2cm7-5\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Thu, 25 May 2023 03:37:12 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Thu, 25 May 2023 03:37:11 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Thu, 25 May 2023 03:37:11 -0700", "from hyd1588t430.caveonetworks.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id EA80A5B6BD8;\n Thu, 25 May 2023 02:59:52 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=qYs25ZXfnGe51QT8i4c7DAYsiQUh1+sENiSBIabishs=;\n b=F55Pe6AIR9qXirHbyKQA7I9Sdu99MvhXGMnic+yQb303NjL7/7DCDC3uT2Ig3Cf56Fpi\n YndwIXzhOnWc/AgbVssdZzNsARsOucdozJvd1CujZufntkSR8RqufA3esAcTdqxezme7\n 6XLOU0CK2SpoBRuTHplPUSW6dopkkVUnA+FQ90FPrMzpYsprTnscgAy9CPG0YPtT6CPX\n b+g73y4js7/DDY31pEgLUs88SFiAGP1tswNC08VQQp/2bE9QPod6rjCtp8jmN5xbSxFw\n LMUJHqg+1jdfc4/iya/I7r4XAMOIeKxRrSOUZIEmNxg6yWEcJreg+/YRoAMZxUCI1fmU 5g==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>", "CC": "<jerinj@marvell.com>, <dev@dpdk.org>, Gowrishankar Muthukrishnan\n <gmuthukrishn@marvell.com>, <stable@dpdk.org>", "Subject": "[PATCH v3 12/32] common/cnxk: fix null pointer dereference", "Date": "Thu, 25 May 2023 15:28:44 +0530", "Message-ID": "<20230525095904.3967080-12-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230525095904.3967080-1-ndabilpuram@marvell.com>", "References": "<20230411091144.1087887-1-ndabilpuram@marvell.com>\n <20230525095904.3967080-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "2gMFPBSPY_1do2rgKsRjEWSAk9vwDlft", "X-Proofpoint-ORIG-GUID": "2gMFPBSPY_1do2rgKsRjEWSAk9vwDlft", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26\n definitions=2023-05-25_06,2023-05-24_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>\n\nFix null pointer dereferences reported by klocwork.\n\nFixes: 4398c4092f3d (\"common/cnxk: dump inline device RQ context\")\nFixes: 79dc6f324e82 (\"common/cnxk: add inline function for statistics\")\ncc: stable@dpdk.org\n\nSigned-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>\n---\n drivers/common/cnxk/roc_nix_debug.c | 8 +++++++-\n drivers/common/cnxk/roc_nix_inl_dev.c | 2 +-\n 2 files changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/common/cnxk/roc_nix_debug.c b/drivers/common/cnxk/roc_nix_debug.c\nindex 399d0d7eae..a1c3db284b 100644\n--- a/drivers/common/cnxk/roc_nix_debug.c\n+++ b/drivers/common/cnxk/roc_nix_debug.c\n@@ -733,7 +733,13 @@ roc_nix_queues_ctx_dump(struct roc_nix *roc_nix, FILE *file)\n \tinl_rq = roc_nix_inl_dev_rq(roc_nix);\n \tif (inl_rq) {\n \t\tstruct idev_cfg *idev = idev_get_cfg();\n-\t\tstruct nix_inl_dev *inl_dev = idev->nix_inl_dev;\n+\t\tstruct nix_inl_dev *inl_dev = NULL;\n+\n+\t\tif (idev && idev->nix_inl_dev)\n+\t\t\tinl_dev = idev->nix_inl_dev;\n+\n+\t\tif (!inl_dev)\n+\t\t\treturn -EINVAL;\n \n \t\trc = nix_q_ctx_get(&inl_dev->dev, NIX_AQ_CTYPE_RQ, inl_rq->qid, &ctx);\n \t\tif (rc) {\ndiff --git a/drivers/common/cnxk/roc_nix_inl_dev.c b/drivers/common/cnxk/roc_nix_inl_dev.c\nindex 0df148c3ed..ca948d3bc7 100644\n--- a/drivers/common/cnxk/roc_nix_inl_dev.c\n+++ b/drivers/common/cnxk/roc_nix_inl_dev.c\n@@ -843,7 +843,7 @@ roc_nix_inl_dev_stats_get(struct roc_nix_stats *stats)\n \tif (stats == NULL)\n \t\treturn NIX_ERR_PARAM;\n \n-\tif (!idev && idev->nix_inl_dev)\n+\tif (idev && idev->nix_inl_dev)\n \t\tinl_dev = idev->nix_inl_dev;\n \n \tif (!inl_dev)\n", "prefixes": [ "v3", "12/32" ] }{ "id": 127425, "url": "