Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127421/?format=api
{ "id": 127421, "url": "http://patches.dpdk.org/api/patches/127421/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230525095904.3967080-32-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230525095904.3967080-32-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230525095904.3967080-32-ndabilpuram@marvell.com", "date": "2023-05-25T09:59:04", "name": "[v3,32/32] common/cnxk: add check for null auth and anti-replay", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3f53458b390252129d1b516a89fd5fd6c7a98160", "submitter": { "id": 1202, "url": "http://patches.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230525095904.3967080-32-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 28180, "url": "http://patches.dpdk.org/api/series/28180/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28180", "date": "2023-05-25T09:58:36", "name": "[v3,01/32] common/cnxk: allocate dynamic BPIDs", "version": 3, "mbox": "http://patches.dpdk.org/series/28180/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/127421/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/127421/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6824C42B9A;\n\tThu, 25 May 2023 12:11:53 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DE09142F92;\n\tThu, 25 May 2023 12:10:23 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id AC9FA42DAF\n for <dev@dpdk.org>; Thu, 25 May 2023 12:10:16 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 34PA2W0S020284 for <dev@dpdk.org>; Thu, 25 May 2023 03:10:15 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3qt5jng0pa-17\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 25 May 2023 03:10:15 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Thu, 25 May 2023 03:09:49 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Thu, 25 May 2023 03:09:49 -0700", "from hyd1588t430.caveonetworks.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id 9A63C5B6D86;\n Thu, 25 May 2023 03:00:52 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=t+dbgs7XkhEwxUbAkCfvm5gtvH78te1drlYCqir6PmM=;\n b=LLK34JS4ikaXTvBwnUKz2xq/z/fmRsRcrXotpscjGmXc+VXKx67wE3ft9a0y6RwJvA/V\n e0P/QRHMFpqB22roNVc7CISzDSUt5LMEN9YfSzrS/J5vv/HbKPZKQKQlaxtcVm2B2anl\n d8NVIZ2GG2wQAHtqOB+hVGRf4D21/awbJYk3fuEJEgHIutwQA6fXcuwdRnKXA2SM0seZ\n L8zqkX5ysougbMHTRwgPvGYLDSIlxiAOXD1iNtjpU77YOAf0UZXszAHhcCDE3mUtUsx+\n YORKcL+3Ia94umMOUq9KS9fyg8fdrIHjoGJWyFbPLUNlcXjptEZ5HqLT5kyh4FJIC14J kQ==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>", "CC": "<jerinj@marvell.com>, <dev@dpdk.org>, Srujana Challa <schalla@marvell.com>", "Subject": "[PATCH v3 32/32] common/cnxk: add check for null auth and anti-replay", "Date": "Thu, 25 May 2023 15:29:04 +0530", "Message-ID": "<20230525095904.3967080-32-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230525095904.3967080-1-ndabilpuram@marvell.com>", "References": "<20230411091144.1087887-1-ndabilpuram@marvell.com>\n <20230525095904.3967080-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "cD5PFDNiRQM_DzVTdQg1ESwnTvumrL1l", "X-Proofpoint-GUID": "cD5PFDNiRQM_DzVTdQg1ESwnTvumrL1l", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26\n definitions=2023-05-25_06,2023-05-24_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Srujana Challa <schalla@marvell.com>\n\nAs per IPsec RFC, the anti-replay service can be selected for\nan SA only if the integrity service is selected for that SA.\nThis patch adds the validation check for the same.\n\nSigned-off-by: Srujana Challa <schalla@marvell.com>\n---\n drivers/common/cnxk/cnxk_security.c | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/drivers/common/cnxk/cnxk_security.c b/drivers/common/cnxk/cnxk_security.c\nindex 13ca2c7791..a8c3ba90cd 100644\n--- a/drivers/common/cnxk/cnxk_security.c\n+++ b/drivers/common/cnxk/cnxk_security.c\n@@ -155,6 +155,10 @@ ot_ipsec_sa_common_param_fill(union roc_ot_ipsec_sa_word2 *w2,\n \n \t\tswitch (auth_xfrm->auth.algo) {\n \t\tcase RTE_CRYPTO_AUTH_NULL:\n+\t\t\tif (w2->s.dir == ROC_IE_SA_DIR_INBOUND && ipsec_xfrm->replay_win_sz) {\n+\t\t\t\tplt_err(\"anti-replay can't be supported with integrity service disabled\");\n+\t\t\t\treturn -EINVAL;\n+\t\t\t}\n \t\t\tw2->s.auth_type = ROC_IE_OT_SA_AUTH_NULL;\n \t\t\tbreak;\n \t\tcase RTE_CRYPTO_AUTH_SHA1_HMAC:\n@@ -1392,6 +1396,11 @@ cnxk_on_ipsec_inb_sa_create(struct rte_security_ipsec_xform *ipsec,\n \tif (ret)\n \t\treturn ret;\n \n+\tif (crypto_xform->type != RTE_CRYPTO_SYM_XFORM_AEAD &&\n+\t crypto_xform->auth.algo == RTE_CRYPTO_AUTH_NULL && ipsec->replay_win_sz) {\n+\t\tplt_err(\"anti-replay can't be supported with integrity service disabled\");\n+\t\treturn -EINVAL;\n+\t}\n \tif (crypto_xform->type == RTE_CRYPTO_SYM_XFORM_AEAD ||\n \t auth_xform->auth.algo == RTE_CRYPTO_AUTH_NULL ||\n \t auth_xform->auth.algo == RTE_CRYPTO_AUTH_AES_GMAC) {\n", "prefixes": [ "v3", "32/32" ] }