Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127417/?format=api
{ "id": 127417, "url": "http://patches.dpdk.org/api/patches/127417/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230525095904.3967080-28-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230525095904.3967080-28-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230525095904.3967080-28-ndabilpuram@marvell.com", "date": "2023-05-25T09:59:00", "name": "[v3,28/32] common/nix: check for null dereference", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ff997b451059fcb88aecb4d241d7b97b390fb521", "submitter": { "id": 1202, "url": "http://patches.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230525095904.3967080-28-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 28180, "url": "http://patches.dpdk.org/api/series/28180/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28180", "date": "2023-05-25T09:58:36", "name": "[v3,01/32] common/cnxk: allocate dynamic BPIDs", "version": 3, "mbox": "http://patches.dpdk.org/series/28180/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/127417/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/127417/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3546142B9A;\n\tThu, 25 May 2023 12:11:29 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EC46042DB7;\n\tThu, 25 May 2023 12:10:18 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 220AF42D84\n for <dev@dpdk.org>; Thu, 25 May 2023 12:10:14 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 34PA2W0N020284 for <dev@dpdk.org>; Thu, 25 May 2023 03:10:14 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3qt5jng0pa-13\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 25 May 2023 03:10:14 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Thu, 25 May 2023 03:09:49 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Thu, 25 May 2023 03:09:48 -0700", "from hyd1588t430.caveonetworks.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id B681C5B6E9F;\n Thu, 25 May 2023 03:00:39 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=3F5qvE8MCgnCTDafuCTzNxAOZNJcI5GGmtdKUPmPiCA=;\n b=ZbAO3064hl061vgIO9qVppxhiMDSbnBSFJN55mc7UBS+H8elIOalJOkEoZDQAi+5CCQC\n 3t57xcqDMSVdXEpxcjlmCE9ixOjJWxPl5oS79tXgtkNYcCOsRaq48PCl2YzGzp9bRxpj\n lKsHdkcMrsLQbavdaxacVlydJ/c3a3qSrTBhsThcrNqpn8UbFglsgTHW8pCr6Kb1LcrW\n Ul/CxpAgtyhuatcTTB+LUrl8nisWlMAomP3NR2Qt2gmlDmlccqIwcKvt6+RmKEx9PUOO\n eTjeagFraTFSDK5ql/ihM5wf2GxX29UHF823yUJEt+5Y3ifnzbfT8yEkF/I3Tm5nJp6e 0A==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>", "CC": "<jerinj@marvell.com>, <dev@dpdk.org>, Gowrishankar Muthukrishnan\n <gmuthukrishn@marvell.com>", "Subject": "[PATCH v3 28/32] common/nix: check for null dereference", "Date": "Thu, 25 May 2023 15:29:00 +0530", "Message-ID": "<20230525095904.3967080-28-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230525095904.3967080-1-ndabilpuram@marvell.com>", "References": "<20230411091144.1087887-1-ndabilpuram@marvell.com>\n <20230525095904.3967080-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "7HFY5mSHjv_uYZYYIq7PLVx93ZLdIXi8", "X-Proofpoint-GUID": "7HFY5mSHjv_uYZYYIq7PLVx93ZLdIXi8", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26\n definitions=2023-05-25_06,2023-05-24_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>\n\nCheck for NULL value return before dereferencing on it.\n\nSigned-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>\n---\n drivers/common/cnxk/roc_nix.c | 8 +++++++-\n drivers/common/cnxk/roc_nix_fc.c | 7 ++++++-\n 2 files changed, 13 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/common/cnxk/roc_nix.c b/drivers/common/cnxk/roc_nix.c\nindex 39943e4ba7..152ef7269e 100644\n--- a/drivers/common/cnxk/roc_nix.c\n+++ b/drivers/common/cnxk/roc_nix.c\n@@ -392,6 +392,7 @@ roc_nix_dev_init(struct roc_nix *roc_nix)\n {\n \tenum roc_nix_rss_reta_sz reta_sz;\n \tstruct plt_pci_device *pci_dev;\n+\tstruct roc_nix_list *nix_list;\n \tuint16_t max_sqb_count;\n \tuint64_t blkaddr;\n \tstruct dev *dev;\n@@ -417,7 +418,12 @@ roc_nix_dev_init(struct roc_nix *roc_nix)\n \tnix = roc_nix_to_nix_priv(roc_nix);\n \tpci_dev = roc_nix->pci_dev;\n \tdev = &nix->dev;\n-\tTAILQ_INSERT_TAIL(roc_idev_nix_list_get(), roc_nix, next);\n+\n+\tnix_list = roc_idev_nix_list_get();\n+\tif (nix_list == NULL)\n+\t\treturn -EINVAL;\n+\n+\tTAILQ_INSERT_TAIL(nix_list, roc_nix, next);\n \n \tif (nix->dev.drv_inited)\n \t\treturn 0;\ndiff --git a/drivers/common/cnxk/roc_nix_fc.c b/drivers/common/cnxk/roc_nix_fc.c\nindex 44eade5ba6..f79baf9242 100644\n--- a/drivers/common/cnxk/roc_nix_fc.c\n+++ b/drivers/common/cnxk/roc_nix_fc.c\n@@ -431,13 +431,18 @@ static int\n nix_rx_chan_multi_bpid_cfg(struct roc_nix *roc_nix, uint8_t chan, uint16_t bpid, uint16_t *bpid_new)\n {\n \tstruct roc_nix *roc_nix_tmp, *roc_nix_pre = NULL;\n+\tstruct roc_nix_list *nix_list;\n \tuint8_t chan_pre;\n \n \tif (!roc_feature_nix_has_rxchan_multi_bpid())\n \t\treturn -ENOTSUP;\n \n+\tnix_list = roc_idev_nix_list_get();\n+\tif (nix_list == NULL)\n+\t\treturn -EINVAL;\n+\n \t/* Find associated NIX RX channel if Aura BPID is of that of a NIX. */\n-\tTAILQ_FOREACH(roc_nix_tmp, roc_idev_nix_list_get(), next) {\n+\tTAILQ_FOREACH(roc_nix_tmp, nix_list, next) {\n \t\tstruct nix *nix = roc_nix_to_nix_priv(roc_nix_tmp);\n \t\tint i;\n \n", "prefixes": [ "v3", "28/32" ] }