Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127372/?format=api
http://patches.dpdk.org/api/patches/127372/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230525074041.2370704-3-dongzhou@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230525074041.2370704-3-dongzhou@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230525074041.2370704-3-dongzhou@nvidia.com", "date": "2023-05-25T07:40:40", "name": "[v3,2/3] net/mlx5: add support for infiniband BTH match", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3866d6e05dfc5071ced29d6c9efa8ac59ad4c168", "submitter": { "id": 2011, "url": "http://patches.dpdk.org/api/people/2011/?format=api", "name": "Dong Zhou", "email": "dongzhou@nvidia.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230525074041.2370704-3-dongzhou@nvidia.com/mbox/", "series": [ { "id": 28170, "url": "http://patches.dpdk.org/api/series/28170/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28170", "date": "2023-05-25T07:40:38", "name": "add support for infiniband BTH match", "version": 3, "mbox": "http://patches.dpdk.org/series/28170/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/127372/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/127372/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E152442B95;\n\tThu, 25 May 2023 09:41:32 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D5AA3427EE;\n\tThu, 25 May 2023 09:41:32 +0200 (CEST)", "from NAM10-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam10on2041.outbound.protection.outlook.com [40.107.93.41])\n by mails.dpdk.org (Postfix) with ESMTP id C384E40FDF\n for <dev@dpdk.org>; Thu, 25 May 2023 09:41:31 +0200 (CEST)", "from MW2PR2101CA0023.namprd21.prod.outlook.com (2603:10b6:302:1::36)\n by DM6PR12MB4878.namprd12.prod.outlook.com (2603:10b6:5:1b8::24) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.15; Thu, 25 May\n 2023 07:41:28 +0000", "from CO1NAM11FT065.eop-nam11.prod.protection.outlook.com\n (2603:10b6:302:1:cafe::fb) by MW2PR2101CA0023.outlook.office365.com\n (2603:10b6:302:1::36) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.7 via Frontend\n Transport; Thu, 25 May 2023 07:41:28 +0000", "from mail.nvidia.com (216.228.117.161) by\n CO1NAM11FT065.mail.protection.outlook.com (10.13.174.62) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6411.29 via Frontend Transport; Thu, 25 May 2023 07:41:27 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Thu, 25 May 2023\n 00:41:14 -0700", "from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Thu, 25 May\n 2023 00:41:12 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=wWBNN6Pja01WJ/uJxXsfxX6UZRHNWZLxFQzAGZnoF60=;\n b=fkyzhkGqO8EOrZQxTvjtOd1/jJcreoSdh8J5XGp87PyqBHWUvb3lrsGDIGj7WaMT3UvDDUeNGRQJD5qQysrKResbdTiBXlnNepFv+V0Cl6RqVreZ8bOhXoDIQrIOUJbHg1+fpoiqwW4STr4jziC1TgmErMUE/seC+4ZemSk3STACIhOowbc/EhCSkDDkULBsNfgVI8bf22QUZMQnN/v+fm509DFcT9mAXVqOrlnxE/4sJeJ4w7uWQP67bcKAiJY91CJa5UQ/IausCiwuxWj0CSSoKiaduaxIAGFMFMIzXvgtSDj3J/Zdcfb6cqVdVCN2Ot7lsXiTHtMHnyiQH2o9Hg==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C", "From": "Dong Zhou <dongzhou@nvidia.com>", "To": "<orika@nvidia.com>, <viacheslavo@nvidia.com>, <thomas@monjalon.net>,\n \"Matan Azrad\" <matan@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>", "CC": "<dev@dpdk.org>, <rasland@nvidia.com>", "Subject": "[PATCH v3 2/3] net/mlx5: add support for infiniband BTH match", "Date": "Thu, 25 May 2023 10:40:40 +0300", "Message-ID": "<20230525074041.2370704-3-dongzhou@nvidia.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20230525074041.2370704-1-dongzhou@nvidia.com>", "References": "<20230524100805.2215154-1-dongzhou@nvidia.com>\n <20230525074041.2370704-1-dongzhou@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.231.35]", "X-ClientProxiedBy": "rnnvmail203.nvidia.com (10.129.68.9) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CO1NAM11FT065:EE_|DM6PR12MB4878:EE_", "X-MS-Office365-Filtering-Correlation-Id": "25c192ac-19b5-469d-a805-08db5cf37304", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 1ZJQRu6i9FvWcjaByQEPS1eqfENUFjcGtzFH/1mLc9plQGxfrBDQwT2Z33qzHm76NsDcxCMtBWwOVhdVdYHoX/QeEVCYQRivUOk4TSbZWYZq1KfO4QOpmzdNz50xpACw4PXY4psaAQSCa3afFBIoaa7WNBxqgJWhmIKPyjdIh9HDZL9BubsH7wUWyfv1WuYPPR5+gZbOyqEJHnbrtdMr/M4kN94VhShx5WPaG13MrUtKNcS+iuw7jHQ0Hz77iJ0HGwnpBz1IISErLLEzT7b7NfPAFS8Erl4U5SBAWCHeCHE5JJ4ywDV24ang4U/a9HgeSQcsv49g774WGUp2oW193ov/b66chhalI9lR3Z57+gJkNr7o4ekRTROmox4wr2J3ltjVXSVBGwNgo8KyRjfNG9ZBWL4aStxo3Afx4mHdIXA9quicLcTZagfLGDzH/Szf3+q30o2hzzqMyxTBAiRtk008D2+G1GZm/VOE+2W1yP77kT8eiU7MSvGTGbGJIxEnkg/HnCutmPy8B3n37aJYKueGIrovrRUNDHPV6fc2eC7cBxh6CmjbfznJNXcOQ0hvsV7ACgigL8QBX/PbSo/EkGthCzjj0nUzyfFV5CEs7eTtxkE7hbSVpOTRDUjTDz9BZJxuQM2j5AQhtTOMPdhmQEczch6NW5i/ArhmPO4Abzj93ipixkrdP+Ex3Fl9YNxJaGi+nUveDntYecgJ1rSaD0UUJPKqNP8X6BQ9Dovv+O49jtbbS12i8yaTS96mGwQc", "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230028)(4636009)(376002)(39860400002)(136003)(346002)(396003)(451199021)(36840700001)(46966006)(40470700004)(2906002)(54906003)(6666004)(47076005)(82310400005)(36860700001)(5660300002)(8676002)(8936002)(6636002)(40460700003)(41300700001)(70586007)(316002)(4326008)(110136005)(478600001)(70206006)(36756003)(40480700001)(55016003)(7696005)(1076003)(2616005)(86362001)(26005)(107886003)(83380400001)(186003)(6286002)(7636003)(16526019)(336012)(426003)(356005)(82740400003);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "25 May 2023 07:41:27.8144 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 25c192ac-19b5-469d-a805-08db5cf37304", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT065.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR12MB4878", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch adds support to match opcode and dst_qp fields in\ninfiniband BTH. Currently, only the RoCEv2 packet is supported,\nthe input BTH match item is defaulted to match one RoCEv2 packet.\n\nSigned-off-by: Dong Zhou <dongzhou@nvidia.com>\nAcked-by: Ori Kam <orika@nvidia.com>\n---\n drivers/common/mlx5/mlx5_prm.h | 5 +-\n drivers/net/mlx5/mlx5_flow.h | 6 ++\n drivers/net/mlx5/mlx5_flow_dv.c | 102 ++++++++++++++++++++++++++++++++\n 3 files changed, 111 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h\nindex ed3d5efbb7..8f55fd59b3 100644\n--- a/drivers/common/mlx5/mlx5_prm.h\n+++ b/drivers/common/mlx5/mlx5_prm.h\n@@ -932,7 +932,7 @@ struct mlx5_ifc_fte_match_set_misc_bits {\n \tu8 gre_key_h[0x18];\n \tu8 gre_key_l[0x8];\n \tu8 vxlan_vni[0x18];\n-\tu8 reserved_at_b8[0x8];\n+\tu8 bth_opcode[0x8];\n \tu8 geneve_vni[0x18];\n \tu8 lag_rx_port_affinity[0x4];\n \tu8 reserved_at_e8[0x2];\n@@ -945,7 +945,8 @@ struct mlx5_ifc_fte_match_set_misc_bits {\n \tu8 reserved_at_120[0xa];\n \tu8 geneve_opt_len[0x6];\n \tu8 geneve_protocol_type[0x10];\n-\tu8 reserved_at_140[0x20];\n+\tu8 reserved_at_140[0x8];\n+\tu8 bth_dst_qp[0x18];\n \tu8 inner_esp_spi[0x20];\n \tu8 outer_esp_spi[0x20];\n \tu8 reserved_at_1a0[0x60];\ndiff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h\nindex 1d116ea0f6..c1d6a71708 100644\n--- a/drivers/net/mlx5/mlx5_flow.h\n+++ b/drivers/net/mlx5/mlx5_flow.h\n@@ -227,6 +227,9 @@ enum mlx5_feature_name {\n /* Aggregated affinity item */\n #define MLX5_FLOW_ITEM_AGGR_AFFINITY (UINT64_C(1) << 49)\n \n+/* IB BTH ITEM. */\n+#define MLX5_FLOW_ITEM_IB_BTH (1ull << 51)\n+\n /* Outer Masks. */\n #define MLX5_FLOW_LAYER_OUTER_L3 \\\n \t(MLX5_FLOW_LAYER_OUTER_L3_IPV4 | MLX5_FLOW_LAYER_OUTER_L3_IPV6)\n@@ -364,6 +367,9 @@ enum mlx5_feature_name {\n #define MLX5_UDP_PORT_VXLAN 4789\n #define MLX5_UDP_PORT_VXLAN_GPE 4790\n \n+/* UDP port numbers for RoCEv2. */\n+#define MLX5_UDP_PORT_ROCEv2 4791\n+\n /* UDP port numbers for GENEVE. */\n #define MLX5_UDP_PORT_GENEVE 6081\n \ndiff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex d14661298c..a3b72dbb5f 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -7193,6 +7193,65 @@ flow_dv_validate_item_flex(struct rte_eth_dev *dev,\n \treturn 0;\n }\n \n+/**\n+ * Validate IB BTH item.\n+ *\n+ * @param[in] dev\n+ * Pointer to the rte_eth_dev structure.\n+ * @param[in] udp_dport\n+ * UDP destination port\n+ * @param[in] item\n+ * Item specification.\n+ * @param root\n+ * Whether action is on root table.\n+ * @param[out] error\n+ * Pointer to the error structure.\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+static int\n+mlx5_flow_validate_item_ib_bth(struct rte_eth_dev *dev,\n+\t\t\t uint16_t udp_dport,\n+\t\t\t const struct rte_flow_item *item,\n+\t\t\t bool root,\n+\t\t\t struct rte_flow_error *error)\n+{\n+\tconst struct rte_flow_item_ib_bth *mask = item->mask;\n+\tstruct mlx5_priv *priv = dev->data->dev_private;\n+\tconst struct rte_flow_item_ib_bth *valid_mask;\n+\tint ret;\n+\n+\tvalid_mask = &rte_flow_item_ib_bth_mask;\n+\tif (udp_dport && udp_dport != MLX5_UDP_PORT_ROCEv2)\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM, item,\n+\t\t\t\t\t \"protocol filtering not compatible\"\n+\t\t\t\t\t \" with UDP layer\");\n+\tif (mask && (mask->hdr.se || mask->hdr.m || mask->hdr.padcnt ||\n+\t\tmask->hdr.tver || mask->hdr.pkey || mask->hdr.f || mask->hdr.b ||\n+\t\tmask->hdr.rsvd0 || mask->hdr.a || mask->hdr.rsvd1 ||\n+\t\tmask->hdr.psn[0] || mask->hdr.psn[1] || mask->hdr.psn[2]))\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM, item,\n+\t\t\t\t\t \"only opcode and dst_qp are supported\");\n+\tif (root || priv->sh->steering_format_version ==\n+\t\tMLX5_STEERING_LOGIC_FORMAT_CONNECTX_5)\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\t\t item,\n+\t\t\t\t\t \"IB BTH item is not supported\");\n+\tif (!mask)\n+\t\tmask = &rte_flow_item_ib_bth_mask;\n+\tret = mlx5_flow_item_acceptable(item, (const uint8_t *)mask,\n+\t\t\t\t\t(const uint8_t *)valid_mask,\n+\t\t\t\t\tsizeof(struct rte_flow_item_ib_bth),\n+\t\t\t\t\tMLX5_ITEM_RANGE_NOT_ACCEPTED, error);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\treturn 0;\n+}\n+\n /**\n * Internal validation function. For validating both actions and items.\n *\n@@ -7700,6 +7759,14 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,\n \t\t\t\treturn ret;\n \t\t\tlast_item = MLX5_FLOW_ITEM_AGGR_AFFINITY;\n \t\t\tbreak;\n+\t\tcase RTE_FLOW_ITEM_TYPE_IB_BTH:\n+\t\t\tret = mlx5_flow_validate_item_ib_bth(dev, udp_dport,\n+\t\t\t\t\t\t\t items, is_root, error);\n+\t\t\tif (ret < 0)\n+\t\t\t\treturn ret;\n+\n+\t\t\tlast_item = MLX5_FLOW_ITEM_IB_BTH;\n+\t\t\tbreak;\n \t\tdefault:\n \t\t\treturn rte_flow_error_set(error, ENOTSUP,\n \t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n@@ -10971,6 +11038,37 @@ flow_dv_translate_item_aggr_affinity(void *key,\n \t\t affinity_v->affinity & affinity_m->affinity);\n }\n \n+static void\n+flow_dv_translate_item_ib_bth(void *key,\n+\t\t\t const struct rte_flow_item *item,\n+\t\t\t int inner, uint32_t key_type)\n+{\n+\tconst struct rte_flow_item_ib_bth *bth_m;\n+\tconst struct rte_flow_item_ib_bth *bth_v;\n+\tvoid *headers_v, *misc_v;\n+\tuint16_t udp_dport;\n+\tchar *qpn_v;\n+\tint i, size;\n+\n+\theaders_v = inner ? MLX5_ADDR_OF(fte_match_param, key, inner_headers) :\n+\t\tMLX5_ADDR_OF(fte_match_param, key, outer_headers);\n+\tif (!MLX5_GET16(fte_match_set_lyr_2_4, headers_v, udp_dport)) {\n+\t\tudp_dport = key_type & MLX5_SET_MATCHER_M ?\n+\t\t\t0xFFFF : MLX5_UDP_PORT_ROCEv2;\n+\t\tMLX5_SET(fte_match_set_lyr_2_4, headers_v, udp_dport, udp_dport);\n+\t}\n+\tif (MLX5_ITEM_VALID(item, key_type))\n+\t\treturn;\n+\tMLX5_ITEM_UPDATE(item, key_type, bth_v, bth_m, &rte_flow_item_ib_bth_mask);\n+\tmisc_v = MLX5_ADDR_OF(fte_match_param, key, misc_parameters);\n+\tMLX5_SET(fte_match_set_misc, misc_v, bth_opcode,\n+\t\t bth_v->hdr.opcode & bth_m->hdr.opcode);\n+\tqpn_v = MLX5_ADDR_OF(fte_match_set_misc, misc_v, bth_dst_qp);\n+\tsize = sizeof(bth_m->hdr.dst_qp);\n+\tfor (i = 0; i < size; ++i)\n+\t\tqpn_v[i] = bth_m->hdr.dst_qp[i] & bth_v->hdr.dst_qp[i];\n+}\n+\n static uint32_t matcher_zero[MLX5_ST_SZ_DW(fte_match_param)] = { 0 };\n \n #define HEADER_IS_ZERO(match_criteria, headers)\t\t\t\t \\\n@@ -13772,6 +13870,10 @@ flow_dv_translate_items(struct rte_eth_dev *dev,\n \t\tflow_dv_translate_item_aggr_affinity(key, items, key_type);\n \t\tlast_item = MLX5_FLOW_ITEM_AGGR_AFFINITY;\n \t\tbreak;\n+\tcase RTE_FLOW_ITEM_TYPE_IB_BTH:\n+\t\tflow_dv_translate_item_ib_bth(key, items, tunnel, key_type);\n+\t\tlast_item = MLX5_FLOW_ITEM_IB_BTH;\n+\t\tbreak;\n \tdefault:\n \t\tbreak;\n \t}\n", "prefixes": [ "v3", "2/3" ] }{ "id": 127372, "url": "