Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127178/?format=api
{ "id": 127178, "url": "http://patches.dpdk.org/api/patches/127178/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230522190453.453281-1-kamilx.godzwon@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230522190453.453281-1-kamilx.godzwon@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230522190453.453281-1-kamilx.godzwon@intel.com", "date": "2023-05-22T19:04:52", "name": "[v2] lib/cryptodev: fix assertion to remove GCC compilation warning", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "15e66c0c07e879a901d7144c83de18761d61c6d0", "submitter": { "id": 3074, "url": "http://patches.dpdk.org/api/people/3074/?format=api", "name": "Kamil Godzwon", "email": "kamilx.godzwon@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230522190453.453281-1-kamilx.godzwon@intel.com/mbox/", "series": [ { "id": 28117, "url": "http://patches.dpdk.org/api/series/28117/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28117", "date": "2023-05-22T19:04:52", "name": "[v2] lib/cryptodev: fix assertion to remove GCC compilation warning", "version": 2, "mbox": "http://patches.dpdk.org/series/28117/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/127178/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/127178/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6B72842B76;\n\tMon, 22 May 2023 21:06:24 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E63A140EE7;\n\tMon, 22 May 2023 21:06:23 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by mails.dpdk.org (Postfix) with ESMTP id AE90340EE5\n for <dev@dpdk.org>; Mon, 22 May 2023 21:06:20 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 May 2023 12:06:20 -0700", "from fedora37.igk.intel.com ([10.237.87.194])\n by fmsmga002.fm.intel.com with ESMTP; 22 May 2023 12:06:18 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1684782381; x=1716318381;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Hp9QGc1Hjzxe+vKWfqcBT+/oI/Dv7qJwJvjjt13+Ai0=;\n b=WrZx73TsZE+kMROCW3QQJKzXD4Szph+BZRawAKfdot3YreIzzOZFyJSL\n 7hS3eM2e0QUA2uAR9Jes9TkLvx3JbhLXgTxOqvfU1f7rZZMhukqK6hG4/\n J0IF09shK2yt2Pz6/2i7s+HWA9L9a64GSekU7BC5+SBuvi1M6e6U/47oU\n h8q7i8+ZRRczKxIpNop7c9eLRT5+7540hSWa0ut0K3hwivxQMSMZKpFYt\n h81ZmygYg+nTjb+vXV4A/rWiJcg46ifepbiwEMUt1IoDZgdxvzoml3rAg\n z7Ch7BI+lTAeF1QHJ6eRjeHwV74xB5WdfioK1qC/JRq4H0DZD+S5eWZQP Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10718\"; a=\"337603105\"", "E=Sophos;i=\"6.00,184,1681196400\"; d=\"scan'208\";a=\"337603105\"", "E=McAfee;i=\"6600,9927,10718\"; a=\"815801855\"", "E=Sophos;i=\"6.00,184,1681196400\"; d=\"scan'208\";a=\"815801855\"" ], "X-ExtLoop1": "1", "From": "Kamil Godzwon <kamilx.godzwon@intel.com>", "To": "dev@dpdk.org", "Cc": "Akhil Goyal <gakhil@marvell.com>,\n\tFan Zhang <fanzhang.oss@gmail.com>", "Subject": "[PATCH v2] lib/cryptodev: fix assertion to remove GCC compilation\n warning", "Date": "Mon, 22 May 2023 15:04:52 -0400", "Message-Id": "<20230522190453.453281-1-kamilx.godzwon@intel.com>", "X-Mailer": "git-send-email 2.40.1", "In-Reply-To": "<20230522184951.452626-1-kamilx.godzwon@intel.com>", "References": "<20230522184951.452626-1-kamilx.godzwon@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "/home/vagrant/dpdk/build/include/rte_crypto_sym.h:1009:4: \\\nwarning: Value stored to 'left' is never read [deadcode.DeadStores]\n left = 0;\n ^ ~\n 1 warning generated.\n\nCompilator sees that the variable 'left' is never read after\nassignment a '0' value. To get rid of this warning message, use 'if'\ncondition to verify the 'left' value before RTE_ASSERT.\n\nSigned-off-by: Kamil Godzwon <kamilx.godzwon@intel.com>\n---\nv2:\nChanged commit message as the line was too long\nRemoved braces\n---\n lib/cryptodev/rte_crypto_sym.h | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/cryptodev/rte_crypto_sym.h b/lib/cryptodev/rte_crypto_sym.h\nindex b43174dbec..dcef1a5049 100644\n--- a/lib/cryptodev/rte_crypto_sym.h\n+++ b/lib/cryptodev/rte_crypto_sym.h\n@@ -1016,7 +1016,9 @@ rte_crypto_mbuf_to_vec(const struct rte_mbuf *mb, uint32_t ofs, uint32_t len,\n \t\tleft -= seglen;\n \t}\n \n-\tRTE_ASSERT(left == 0);\n+\tif (left != 0)\n+\t\tRTE_ASSERT(false);\n+\n \treturn i;\n }\n \n", "prefixes": [ "v2" ] }