Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127132/?format=api
{ "id": 127132, "url": "http://patches.dpdk.org/api/patches/127132/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230519174611.11232-20-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230519174611.11232-20-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230519174611.11232-20-stephen@networkplumber.org", "date": "2023-05-19T17:46:11", "name": "[v3,19/19] Remove use of term sanity check", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "661e181ad5845df97180d459aea909726f20fc9f", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230519174611.11232-20-stephen@networkplumber.org/mbox/", "series": [ { "id": 28092, "url": "http://patches.dpdk.org/api/series/28092/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28092", "date": "2023-05-19T17:45:52", "name": "Replace use \"sanity check\"", "version": 3, "mbox": "http://patches.dpdk.org/series/28092/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/127132/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/127132/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9822D42B4B;\n\tFri, 19 May 2023 19:48:16 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4EFB842F9E;\n\tFri, 19 May 2023 19:46:40 +0200 (CEST)", "from mail-pl1-f180.google.com (mail-pl1-f180.google.com\n [209.85.214.180])\n by mails.dpdk.org (Postfix) with ESMTP id AFFAC42D56\n for <dev@dpdk.org>; Fri, 19 May 2023 19:46:36 +0200 (CEST)", "by mail-pl1-f180.google.com with SMTP id\n d9443c01a7336-1ae615d5018so20605595ad.1\n for <dev@dpdk.org>; Fri, 19 May 2023 10:46:36 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n e3-20020a170902744300b001aaf2e7b06csm3713101plt.132.2023.05.19.10.46.34\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 19 May 2023 10:46:35 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1684518395;\n x=1687110395;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=IZ8g6Ml3xxg5roU39QxW2esztWRwohY9nM8G06iCqJY=;\n b=2oFXDcqsyz8H1JEa7/lWoTsiLTozSAOktoOSzw0bEs9GKiXwErS3zx4EPUndlw05/5\n 86Amphq7Gcnbq87Wmog/QSrqbYjT1FEs2UqxYLr8oVczIRMLMvnEiG6Q4LDwCkrjWoC+\n c29JCP+fP20g06jEdKY5+1Vv7p1HG70Fx0G/QZcXItbshS7jwN2HxP865AnrqIrADU8T\n SwK8R6uedy0aCerdIC89gmW/M31TXCxMai788z8EKbc11dtg7Tp9lDcA2r7bdk84K72r\n 6pN/F8hgL8oniYMkn/k+9WSOSBvFfQnv6u1qHwh+covoiVuaApZGBb5oGo+OJrnLGWhT\n Hr7Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1684518395; x=1687110395;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=IZ8g6Ml3xxg5roU39QxW2esztWRwohY9nM8G06iCqJY=;\n b=ZBIoZNjeJjdgOHu0g8mGSWUqu3+yrQZJ+2/yJ+OIVMZvRMSRlsWKA30KbdPmduLBmD\n E+FR7DicxjVrsjuEjiqbb2vOlQxKxlhX9IAnMYV3mEI+ffx2A3VvtpL4fcevLKyxtE8f\n xYcHcuh7A2PN3QHDycPwTqgSwUWZZr6wG5bzp8WlFOdJ4xAmcyiauR5kjEF0TgCioHJK\n OobqW8RV+3zq2aCrSEklEF8CeHrejqHqQg1GT5bj2dpXsyuWZaqHrFZFxDQ1bcU5Myyb\n LdEMN1qfCiqKmIapr7VvXGFPJx5ZF6oCPz/JQrPuk2BeFS7u4UYxwmXdvdIW461FYl/k\n Rn/A==", "X-Gm-Message-State": "AC+VfDxB0SKliYNmbjnXkxHJ33/8DTWg66fSoNOCPF4sjbOLQCfFTmwg\n vGFOIJNrCE6WCrLwneX6DQc+VLxNMe9MFVRLneeU3x4p", "X-Google-Smtp-Source": "\n ACHHUZ7ppYSHmE0MWlv+0MUt/ww3dhATBXzC06LUb6HffyfCWtp2g+78b5bki6i6GPOrZuVsU0UwYg==", "X-Received": "by 2002:a17:902:c944:b0:19f:3d59:e0ac with SMTP id\n i4-20020a170902c94400b0019f3d59e0acmr4263690pla.44.1684518395666;\n Fri, 19 May 2023 10:46:35 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n Sachin Saxena <sachin.saxena@nxp.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>, Chas Williams <chas3@att.com>,\n \"Min Hu (Connor)\" <humin29@huawei.com>, Liron Himi <lironh@marvell.com>,\n Devendra Singh Rawat <dsinghrawat@marvell.com>,\n Alok Prasad <palok@marvell.com>", "Subject": "[PATCH v3 19/19] Remove use of term sanity check", "Date": "Fri, 19 May 2023 10:46:11 -0700", "Message-Id": "<20230519174611.11232-20-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230519174611.11232-1-stephen@networkplumber.org>", "References": "<20230517161603.117728-1-stephen@networkplumber.org>\n <20230519174611.11232-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace non-inclusive language with better comments.\n\nAcked-by: Hemant Agrawal <hemant.agrawal@nxp.com>\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/bus/fslmc/qbman/qbman_sys_decl.h | 2 +-\n drivers/common/dpaax/caamflib/desc.h | 2 +-\n drivers/dma/idxd/idxd_pci.c | 2 +-\n drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +-\n drivers/net/mvpp2/mrvl_qos.c | 2 +-\n drivers/net/qede/qede_rxtx.c | 6 +++---\n 6 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/bus/fslmc/qbman/qbman_sys_decl.h b/drivers/bus/fslmc/qbman/qbman_sys_decl.h\nindex caaae417773c..2b6162d0ceaf 100644\n--- a/drivers/bus/fslmc/qbman/qbman_sys_decl.h\n+++ b/drivers/bus/fslmc/qbman/qbman_sys_decl.h\n@@ -9,7 +9,7 @@\n #include <compat.h>\n #include <fsl_qbman_base.h>\n \n-/* Sanity check */\n+/* Byte order check */\n #if (__BYTE_ORDER__ != __ORDER_BIG_ENDIAN__) && \\\n \t(__BYTE_ORDER__ != __ORDER_LITTLE_ENDIAN__)\n #error \"Unknown endianness!\"\ndiff --git a/drivers/common/dpaax/caamflib/desc.h b/drivers/common/dpaax/caamflib/desc.h\nindex 635d6bad071f..feb6a5d7bb2d 100644\n--- a/drivers/common/dpaax/caamflib/desc.h\n+++ b/drivers/common/dpaax/caamflib/desc.h\n@@ -107,7 +107,7 @@ extern enum rta_sec_era rta_sec_era;\n \n /*\n * ONE - should always be set. Combination of ONE (always\n- * set) and ZRO (always clear) forms an endianness sanity check\n+ * set) and ZRO (always clear) forms an endianness check\n */\n #define HDR_ONE\t\t\tBIT(23)\n #define HDR_ZRO\t\t\tBIT(15)\ndiff --git a/drivers/dma/idxd/idxd_pci.c b/drivers/dma/idxd/idxd_pci.c\nindex 781fa02db3ca..a1e9b08940d9 100644\n--- a/drivers/dma/idxd/idxd_pci.c\n+++ b/drivers/dma/idxd/idxd_pci.c\n@@ -196,7 +196,7 @@ init_pci_device(struct rte_pci_device *dev, struct idxd_dmadev *idxd,\n \tpci->portals = dev->mem_resource[2].addr;\n \tpci->wq_cfg_sz = (pci->regs->wqcap >> 24) & 0x0F;\n \n-\t/* sanity check device status */\n+\t/* check device status */\n \tif (pci->regs->gensts & GENSTS_DEV_STATE_MASK) {\n \t\t/* need function-level-reset (FLR) or is enabled */\n \t\tIDXD_PMD_ERR(\"Device status is not disabled, cannot init\");\ndiff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c\nindex 4a266bb2caf1..56972f06c045 100644\n--- a/drivers/net/bonding/rte_eth_bond_8023ad.c\n+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c\n@@ -1477,7 +1477,7 @@ bond_8023ad_setup_validate(uint16_t port_id,\n \t\treturn -EINVAL;\n \n \tif (conf != NULL) {\n-\t\t/* Basic sanity check */\n+\t\t/* Basic input check */\n \t\tif (conf->slow_periodic_ms == 0 ||\n \t\t\t\tconf->fast_periodic_ms >= conf->slow_periodic_ms ||\n \t\t\t\tconf->long_timeout_ms == 0 ||\ndiff --git a/drivers/net/mvpp2/mrvl_qos.c b/drivers/net/mvpp2/mrvl_qos.c\nindex f43217bc589c..db5052a9ab6f 100644\n--- a/drivers/net/mvpp2/mrvl_qos.c\n+++ b/drivers/net/mvpp2/mrvl_qos.c\n@@ -260,7 +260,7 @@ get_entry_values(const char *entry, uint8_t *tab,\n \t\t\tif (nb_rng_tokens != 2)\n \t\t\t\treturn -3;\n \n-\t\t\t/* Range and sanity checks. */\n+\t\t\t/* Range and input checks. */\n \t\t\tif (get_val_securely(rng_tokens[0], &token_val) < 0)\n \t\t\t\treturn -4;\n \t\t\tbeg = (char)token_val;\ndiff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c\nindex c35585f5fdd6..8b89841e03b1 100644\n--- a/drivers/net/qede/qede_rxtx.c\n+++ b/drivers/net/qede/qede_rxtx.c\n@@ -1383,7 +1383,7 @@ qede_rx_process_tpa_end_cqe(struct qede_dev *qdev,\n \t\t\t\t\t cqe->len_list[0]);\n \t/* Update total length and frags based on end TPA */\n \trx_mb = rxq->tpa_info[cqe->tpa_agg_index].tpa_head;\n-\t/* TODO: Add Sanity Checks */\n+\t/* TODO: Add more checks */\n \trx_mb->nb_segs = cqe->num_of_bds;\n \trx_mb->pkt_len = cqe->total_packet_len;\n \n@@ -2211,7 +2211,7 @@ qede_xmit_prep_pkts(__rte_unused void *p_txq, struct rte_mbuf **tx_pkts,\n \n #ifdef RTE_LIBRTE_QEDE_DEBUG_TX\n static inline void\n-qede_mpls_tunn_tx_sanity_check(struct rte_mbuf *mbuf,\n+qede_mpls_tunn_tx_basic_check(struct rte_mbuf *mbuf,\n \t\t\t struct qede_tx_queue *txq)\n {\n \tif (((mbuf->outer_l2_len + mbuf->outer_l3_len) / 2) > 0xff)\n@@ -2473,7 +2473,7 @@ qede_xmit_pkts(void *p_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\t\t\t\t\tRTE_MBUF_F_TX_TUNNEL_MPLSINUDP) {\n \t\t\t\tmplsoudp_flg = true;\n #ifdef RTE_LIBRTE_QEDE_DEBUG_TX\n-\t\t\t\tqede_mpls_tunn_tx_sanity_check(mbuf, txq);\n+\t\t\t\tqede_mpls_tunn_tx_basic_check(mbuf, txq);\n #endif\n \t\t\t\t/* Outer L4 offset in two byte words */\n \t\t\t\ttunn_l4_hdr_start_offset =\n", "prefixes": [ "v3", "19/19" ] }