Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127122/?format=api
{ "id": 127122, "url": "http://patches.dpdk.org/api/patches/127122/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230519174611.11232-10-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230519174611.11232-10-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230519174611.11232-10-stephen@networkplumber.org", "date": "2023-05-19T17:46:01", "name": "[v3,09/19] net/mlx[45]: remove word sanity", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1c39accd91fa83093ee986d4d42f757c6158f456", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230519174611.11232-10-stephen@networkplumber.org/mbox/", "series": [ { "id": 28092, "url": "http://patches.dpdk.org/api/series/28092/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28092", "date": "2023-05-19T17:45:52", "name": "Replace use \"sanity check\"", "version": 3, "mbox": "http://patches.dpdk.org/series/28092/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/127122/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/127122/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BEE6642B4B;\n\tFri, 19 May 2023 19:47:22 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2BF8C42D79;\n\tFri, 19 May 2023 19:46:29 +0200 (CEST)", "from mail-pl1-f178.google.com (mail-pl1-f178.google.com\n [209.85.214.178])\n by mails.dpdk.org (Postfix) with ESMTP id 8542D42D5D\n for <dev@dpdk.org>; Fri, 19 May 2023 19:46:25 +0200 (CEST)", "by mail-pl1-f178.google.com with SMTP id\n d9443c01a7336-1ae4c5e1388so35698115ad.1\n for <dev@dpdk.org>; Fri, 19 May 2023 10:46:25 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n e3-20020a170902744300b001aaf2e7b06csm3713101plt.132.2023.05.19.10.46.23\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 19 May 2023 10:46:24 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1684518385;\n x=1687110385;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=YEW2rqMxztAh+f5gLeStoVZIwbQIrbDYlJl2i+QW/6g=;\n b=FejWbt26XBG/OnTcP+ZZQ57yyksEomyMMV52a96Wu67tSuBlj7o/GHc5ITkkCCmiXb\n ynatYIzdm9ZJFAux+PdY3PxEPbYsvrOYj8d84CnR4sazKZzL3pHc01p3loFZDNlcWjme\n iGsWBlstDWUNux2KsHW6F3gh2SRjN9wHayGczrc+QrFLxAwgWkoGA8jdUHNadMar44bY\n fXiAxWiG26NxqWiY3DKV/cCXfHDSday04/sva7BBkOLJrlmsdJCIAL52/NZ+TOWbubJ3\n MBEBrKxxtEA9w2mYVsR2kOpVlX3H5DUMLo4ZqMPBRv3B+4rIBoxeR8jNV1ISKYbaXuiT\n dIyQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1684518385; x=1687110385;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=YEW2rqMxztAh+f5gLeStoVZIwbQIrbDYlJl2i+QW/6g=;\n b=kAkAV/yt8MId4g8fF41ohesC1WSr6/g91qos23ngo4h5Lh/VD8NKxsiul6JwGwhWN0\n Lvaj7LJlC6vFIqYxNtmIC7XAL1hxrkX98S4XEF3+2BcJZFuG3UVOksbjvy/ai2FvrfQq\n 7GQbExA+a1ST1/Qk8ZnHkQcbOVW5h0I/HfyARmyr3RkEvo9zZRWURjnx5Lhua6ca9o8y\n HbbbKUYsTI0jxFgnpXxDFVlpow+u+nQDlx2Y2EibSLl9N5/ET7xlPE6oStO1XHWXhpZ/\n tlYYDvPk+NbeTtK6O5xubm98F2wR07tB7yvqdT9O4mKQHlnmqt3XMliNEkIwQHrdlsfu\n R2Gg==", "X-Gm-Message-State": "AC+VfDx/7p1RpbvJsgEESIA18/aLsER9rueoYMtg4LLQBFXppHEijqPY\n wHjvAlb7L7WSvH1Wcm2x7EkYxF26MeJKwaCsb4Vtbw==", "X-Google-Smtp-Source": "\n ACHHUZ5fM3op6YLYPcPGF7m/k5Sxpll6Bew17EX145o3dY6GQOQH3XfzNUWHW4jK977ksd7Kk+ZzNA==", "X-Received": "by 2002:a17:902:ba8b:b0:1ab:723:1acc with SMTP id\n k11-20020a170902ba8b00b001ab07231accmr2893112pls.35.1684518384713;\n Fri, 19 May 2023 10:46:24 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Matan Azrad <matan@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "Subject": "[PATCH v3 09/19] net/mlx[45]: remove word sanity", "Date": "Fri, 19 May 2023 10:46:01 -0700", "Message-Id": "<20230519174611.11232-10-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230519174611.11232-1-stephen@networkplumber.org>", "References": "<20230517161603.117728-1-stephen@networkplumber.org>\n <20230519174611.11232-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The term \"sanity\" is on non-inclusive naming list.\nRemove it from the Nvidia drivers.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/common/mlx5/linux/mlx5_common_os.c | 2 +-\n drivers/net/mlx4/mlx4.c | 2 +-\n drivers/net/mlx4/mlx4_flow.c | 6 +++---\n drivers/net/mlx5/mlx5_flow_dv.c | 2 +-\n drivers/net/mlx5/mlx5_flow_hw.c | 6 ++----\n drivers/net/mlx5/mlx5_rxq.c | 2 +-\n drivers/net/mlx5/mlx5_rxtx_vec.h | 2 +-\n 7 files changed, 10 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/common/mlx5/linux/mlx5_common_os.c b/drivers/common/mlx5/linux/mlx5_common_os.c\nindex aafff60eeb38..45fac9be0ae1 100644\n--- a/drivers/common/mlx5/linux/mlx5_common_os.c\n+++ b/drivers/common/mlx5/linux/mlx5_common_os.c\n@@ -234,7 +234,7 @@ mlx5_get_ifname_sysfs(const char *ibdev_path, char *ifname)\n /**\n * Suffix RTE_EAL_PMD_PATH with \"-glue\".\n *\n- * This function performs a sanity check on RTE_EAL_PMD_PATH before\n+ * This function performs a check on RTE_EAL_PMD_PATH before\n * suffixing its last component.\n *\n * @param buf[out]\ndiff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c\nindex a54016f4a235..e3048d5b6ec0 100644\n--- a/drivers/net/mlx4/mlx4.c\n+++ b/drivers/net/mlx4/mlx4.c\n@@ -1206,7 +1206,7 @@ static struct rte_pci_driver mlx4_driver = {\n /**\n * Suffix RTE_EAL_PMD_PATH with \"-glue\".\n *\n- * This function performs a sanity check on RTE_EAL_PMD_PATH before\n+ * This function performs a check on RTE_EAL_PMD_PATH before\n * suffixing its last component.\n *\n * @param buf[out]\ndiff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c\nindex 8ef9fd2db44e..25b185d8710c 100644\n--- a/drivers/net/mlx4/mlx4_flow.c\n+++ b/drivers/net/mlx4/mlx4_flow.c\n@@ -514,7 +514,7 @@ mlx4_flow_merge_tcp(struct rte_flow *flow,\n }\n \n /**\n- * Perform basic sanity checks on a pattern item.\n+ * Perform basic checks on a pattern item.\n *\n * @param[in] item\n * Item specification.\n@@ -730,7 +730,7 @@ mlx4_flow_prepare(struct mlx4_priv *priv,\n \t\t\tgoto exit_item_not_supported;\n \t\tproc = next;\n \t\t/*\n-\t\t * Perform basic sanity checks only once, while handle is\n+\t\t * Perform basic checks only once, while handle is\n \t\t * not allocated.\n \t\t */\n \t\tif (flow == &temp) {\n@@ -799,7 +799,7 @@ mlx4_flow_prepare(struct mlx4_priv *priv,\n \t\t\t\trss_key = mlx4_rss_hash_key_default;\n \t\t\t\trss_key_len = MLX4_RSS_HASH_KEY_SIZE;\n \t\t\t}\n-\t\t\t/* Sanity checks. */\n+\t\t\t/* Input checks. */\n \t\t\tfor (i = 0; i < rss->queue_num; ++i)\n \t\t\t\tif (rss->queue[i] >=\n \t\t\t\t ETH_DEV(priv)->data->nb_rx_queues)\ndiff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex d14661298cf0..52a035588755 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -8638,7 +8638,7 @@ flow_dv_prepare(struct rte_eth_dev *dev,\n \n #ifdef RTE_LIBRTE_MLX5_DEBUG\n /**\n- * Sanity check for match mask and value. Similar to check_valid_spec() in\n+ * Check for match mask and value. Similar to check_valid_spec() in\n * kernel driver. If unmasked bit is present in value, it returns failure.\n *\n * @param match_mask\ndiff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c\nindex 853c94af9cfd..6e805d547c8a 100644\n--- a/drivers/net/mlx5/mlx5_flow_hw.c\n+++ b/drivers/net/mlx5/mlx5_flow_hw.c\n@@ -5576,11 +5576,10 @@ flow_hw_tx_tag_regc_mask(struct rte_eth_dev *dev)\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n \tuint32_t mask = priv->sh->dv_regc0_mask;\n \n-\t/* Mask is verified during device initialization. Sanity checking here. */\n+\t/* Mask is verified during device initialization. */\n \tMLX5_ASSERT(mask != 0);\n \t/*\n \t * Availability of sufficient number of bits in REG_C_0 is verified on initialization.\n-\t * Sanity checking here.\n \t */\n \tMLX5_ASSERT(__builtin_popcount(mask) >= __builtin_popcount(priv->vport_meta_mask));\n \treturn mask;\n@@ -5592,12 +5591,11 @@ flow_hw_tx_tag_regc_value(struct rte_eth_dev *dev)\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n \tuint32_t tag;\n \n-\t/* Mask is verified during device initialization. Sanity checking here. */\n+\t/* Mask is verified during device initialization. */\n \tMLX5_ASSERT(priv->vport_meta_mask != 0);\n \ttag = priv->vport_meta_tag >> (rte_bsf32(priv->vport_meta_mask));\n \t/*\n \t * Availability of sufficient number of bits in REG_C_0 is verified on initialization.\n-\t * Sanity checking here.\n \t */\n \tMLX5_ASSERT((tag & priv->sh->dv_regc0_mask) == tag);\n \treturn tag;\ndiff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c\nindex ad8fd13cbe8e..377618926a8d 100644\n--- a/drivers/net/mlx5/mlx5_rxq.c\n+++ b/drivers/net/mlx5/mlx5_rxq.c\n@@ -1442,7 +1442,7 @@ mlx5_mprq_alloc_mp(struct rte_eth_dev *dev)\n \tdesc *= 4;\n \tobj_num = desc + MLX5_MPRQ_MP_CACHE_SZ * n_ibv;\n \t/*\n-\t * rte_mempool_create_empty() has sanity check to refuse large cache\n+\t * rte_mempool_create_empty() has basic check to refuse large cache\n \t * size compared to the number of elements.\n \t * CACHE_FLUSHTHRESH_MULTIPLIER is defined in a C file, so using a\n \t * constant number 2 instead.\ndiff --git a/drivers/net/mlx5/mlx5_rxtx_vec.h b/drivers/net/mlx5/mlx5_rxtx_vec.h\nindex 77c3f4efa019..f8376f2b55b4 100644\n--- a/drivers/net/mlx5/mlx5_rxtx_vec.h\n+++ b/drivers/net/mlx5/mlx5_rxtx_vec.h\n@@ -21,7 +21,7 @@\n \t RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM)\n \n /*\n- * Compile time sanity check for vectorized functions.\n+ * Compile time checks for vectorized functions.\n */\n \n #define S_ASSERT_RTE_MBUF(s) \\\n", "prefixes": [ "v3", "09/19" ] }