Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127056/?format=api
{ "id": 127056, "url": "http://patches.dpdk.org/api/patches/127056/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230519025950.1642943-2-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230519025950.1642943-2-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230519025950.1642943-2-chaoyong.he@corigine.com", "date": "2023-05-19T02:59:43", "name": "[1/8] net/nfp: reuse the ring buffer struct", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f2a450be410702e2659fc36f673b2568cad24dda", "submitter": { "id": 2554, "url": "http://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230519025950.1642943-2-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 28074, "url": "http://patches.dpdk.org/api/series/28074/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28074", "date": "2023-05-19T02:59:42", "name": "make the logic conform the coding style of DPDK", "version": 1, "mbox": "http://patches.dpdk.org/series/28074/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/127056/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/127056/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7210742B42;\n\tFri, 19 May 2023 05:00:22 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0FEA142B71;\n\tFri, 19 May 2023 05:00:18 +0200 (CEST)", "from NAM10-BN7-obe.outbound.protection.outlook.com\n (mail-bn7nam10on2113.outbound.protection.outlook.com [40.107.92.113])\n by mails.dpdk.org (Postfix) with ESMTP id C02DA40A82\n for <dev@dpdk.org>; Fri, 19 May 2023 05:00:15 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by SJ0PR13MB5769.namprd13.prod.outlook.com (2603:10b6:a03:40c::15)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30; Fri, 19 May\n 2023 03:00:13 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::ac2e:52b6:82ec:4994]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::ac2e:52b6:82ec:4994%3]) with mapi id 15.20.6411.017; Fri, 19 May 2023\n 03:00:13 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=TCMEz2kBKKJSHT7Ep1ys6qA5NzVY11gA5RRjYyj7rCydE7SoCeBTJmUtFWSP5VwnL85PBduC8uJMB+Q/lgJtiLhm7u5Yn0bgfl8nFZrebYKb7fBw9xZyIQzX+GUJDt10srVquqwwvF8cDkidbPbhys8S5Er6pDJkRD5mndBaJqG7vS+pudhr+eqUdPJCLPos5lTZ8o2a0cDtiHIFwB7iNzCjoYB8UEBRVRGMgQheZ3eFO1ONWoK0IiiIRMTbgkm3ETRXRUvHMyy5JLjEFl23xKOxM85rGQBSo6dbCHC/DELIdLGCEpkJR9Oih7WOMe3zNB0zjKP0X9O3BQ87pUslwA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=qHlPrJ0wSzG1SIcBEbcoKp/gYzNgC4iZSBeJeD3xYcg=;\n b=AV4yPuDiwz+Yjj+aSNOmywEzyt2/t49mUHkXiMCbrlTFWh+6Mv9Jrxsh6yZ0ZAj32R9iqz4SQnJ4+Ev1c6MruQZp6LqLwI2cUmx0FAtqs6jaJdCDl3edZK3ihGa4NQHoudfhV7r9GfqFMD7L2FWD58QFrryVs8EthbI/9pI/ugfIrWxVUmym7UPd9vQJplCr2Cy24rWJF7R3evCYiLIo7LEZg6ykn5e+ERXXpqXz6qdE9VjXJ+CaY1s+m2rDcjaIaRVFutI7cxf+43l+cko8yUl9eq917/TneQxjeeePHNLOqMPUVPEUvvjjgjwfg0hZgj3zveYNGbFWLPytZBTBEw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=qHlPrJ0wSzG1SIcBEbcoKp/gYzNgC4iZSBeJeD3xYcg=;\n b=AeIxMeBmq3pxhJgL6T14467a+i93/qTt08YFSnfE33iiktmxC5Wq5/+IutkOJa9z6qJFxoep1hXt7S4co1fUQbcRc2Fymw6nqSN6hB3zClpYc0fX/gT2c2Sw7KXwgGxwVXxvF+4kiPEuwvn+HKfjPrmnCtuzVh2+gL4uTRkx1BM=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, niklas.soderlund@corigine.com,\n Chaoyong He <chaoyong.he@corigine.com>", "Subject": "[PATCH 1/8] net/nfp: reuse the ring buffer struct", "Date": "Fri, 19 May 2023 10:59:43 +0800", "Message-Id": "<20230519025950.1642943-2-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230519025950.1642943-1-chaoyong.he@corigine.com>", "References": "<20230519025950.1642943-1-chaoyong.he@corigine.com>", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-ClientProxiedBy": "SI2PR01CA0005.apcprd01.prod.exchangelabs.com\n (2603:1096:4:191::23) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|SJ0PR13MB5769:EE_", "X-MS-Office365-Filtering-Correlation-Id": "3647df98-6ee0-4b5f-d392-08db58152a35", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n nv3fKy+Q4oY7PTi5bCShMCVsI6/GDUVwztiraEoU6S/XqfakFv84qEOYBfxGv6eFn5tgsqiVgfvpVQWbON2SRKxhkFHljVx63L6eFhh5UiEWyYl9NW4s1V8AMOfebJF3nce0JLcxxxMOBR5A0qmmdKAsTfbf4zaJ4zAixKfCO0LLehaPDRmxUu5m24LIdbgAaPCXu1wCbV/lztfRuAc0Yd3sROMWKFlZHEDeaSqkFgpZ/9yO9OGUZD/UnZ/x7XP0h2pEPgyiQZhhp4gFzzJrbF0p16hcmUUuyBmNErZpWw0JuCqF82nYi2G/102QHYdKp3HaXr8ABP3mwy5Bw1fiQy0+JHveYqcspVjAOf0qGsZ3sqz0ywtQFg5zH/htbhHdQp8odmdp6pV8DhZLUqxeB2yOYkKfTreXFONy2AiGkW+002LZYaBXtMAeE866EbXyrCxUymgQ26r7YSFseawG5hGRrUKB223laxJiQiSbkW2PTHa/0ibCey3gA3MpCGpiVQ/ecWXk3SROSNWvV4iQhDy/oM1KFVCmTnVODcV1mqU+vtDqv4SDFcyinNEOXIbw8NsDilT9TGIgGPTcOmh8gHwBQt+t/n3xCwqrQ4PxQdIrRT1fevLR/+cTWnkUkgwF", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230028)(4636009)(366004)(346002)(136003)(376002)(39840400004)(396003)(451199021)(6916009)(66476007)(2616005)(6666004)(6512007)(41300700001)(2906002)(6486002)(83380400001)(478600001)(66556008)(107886003)(52116002)(66946007)(26005)(6506007)(1076003)(186003)(5660300002)(4326008)(316002)(8676002)(8936002)(44832011)(86362001)(38100700002)(36756003)(38350700002);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "=?utf-8?q?hrdXriI+SCGFjUyFdC3mAPlgsfRb?=\n\t=?utf-8?q?j1H/PN8W/DfNX1cO60dstXHkr9qvA49C2oVb6hV2lCXe5RtkMm3Hm6n9SmAlmD8xr?=\n\t=?utf-8?q?bgZq66r0YoXJzNzscGsWpF5RhM00dvL/cAg+1vZVyxQlULTyrQ+P7tXSNkyuE/itz?=\n\t=?utf-8?q?ZY7U6iOXgmJtm4b+SOwgQbhLKagxozL1CLNPg5YH64BKrhOpI726AZtzus5PO1kwd?=\n\t=?utf-8?q?oVRoUonGQ+pjlSwFPo9vUYGhfA/Ob05EwAZFzSP33/xQvAWXE/IrXR2bbWiNupD3L?=\n\t=?utf-8?q?4AOX2SulQFU6ZA2rEZ0GRqOFFjuIszKK/QHIY0squhZvkxtuQYXygSWlqZsey/yW6?=\n\t=?utf-8?q?pGXRoRvQvkOaISvKqFt0zxH5o0sRuHKRCvDVf4owNfpmU7hwbIOggryTHB/ZI1meA?=\n\t=?utf-8?q?lYW95k3jXw9wJqmJWjVsLFBFEcehL6bPRz0B6QCWR3MZoLV54timrrP33KQ7ToC3J?=\n\t=?utf-8?q?VjWplGh5WGHVdklMwZ3pfvzeXrOL9bYgeBl9pEcCrZ9ZCo/1m3bWddIvksW2WAoET?=\n\t=?utf-8?q?ptzIjLWBNXrJkY1fE3rvKqJWpwZDvelg0+Pe+fOVAhmMDnA8FS0x51I6oLD+udL/p?=\n\t=?utf-8?q?bgQoWSpKxSaPCU6L7jE8j9rlzBQzujMCtNdKjYFYkTZyGl3EhulZK/IhpBGelLvcB?=\n\t=?utf-8?q?TXGd6FfaYcl0u0awuUfp6QUQDaqogUSKdAGEeYRN6uZpNn20hhWEx3wlUz4eaj4e2?=\n\t=?utf-8?q?BsPdpHWh2ZV0SVl0UGti2GYGStwUa9DvOAGHb+V4IuccP41LH9qU81K0bZ3dmKMOe?=\n\t=?utf-8?q?auVJXu8wt6lHwglI9eOmPKVrvyxQDJQQChQr1SxvtFU0aaz7S9kIoIkL7QMcFp8rs?=\n\t=?utf-8?q?HPc4P6LYsrREHmAgVQWPO3MxmPlpv1FaMfY2wvB/tCPWhuZrZZRN/uUQRYNb1yPVK?=\n\t=?utf-8?q?KiDmbF2IYfU1frS+t/l2HQgiDj6GkFQWntPptCBAvq6XaN6+fz9Gxmtn2B+bVoyR0?=\n\t=?utf-8?q?0tIUONseKBNu+1xa22I7euMFME/l/Ocjlp7fR5sfea/b4ue+DDM9mSeoqoYQLid7G?=\n\t=?utf-8?q?MOJLAH1+v5W6X29FBh1Zxt1PO2pF+v1yVJbBERJm8PhapFWuGiEMpYAkUAB05Tp2D?=\n\t=?utf-8?q?TJ7UmfvD+1FWRFr/KX3rmWxSl9OOjmAK0xPHhWd4c8K7a3XdGeJdxZ5TW4UCQrLyB?=\n\t=?utf-8?q?ktVI7S++Yx+PRl6pNuTWgcY6VNcHhAt8dJJU60xTctCB5/aB6GnmZ2Q0+kKeA1YFt?=\n\t=?utf-8?q?1ImVinRPf2rgWgK+IaqAJpICQQqMvlCeDO62zXH7oEz/m5uwdbq1HtNmcDfpWk33C?=\n\t=?utf-8?q?4cbj1Ttl7tj2hihixXIp3PHt9li6HIXP8S1l3dJOleETTMNGNpgaiSxM3fpWWbGTt?=\n\t=?utf-8?q?Y03LuYBFEk7P2JM09n0EDUEkwCsRO1r+aIRs3FxeE38rSq8BFhi5if7SwecGw91vv?=\n\t=?utf-8?q?PUGXR0+AmNdLFDoZHC/cm9WKZkT70dRsA4mjntpCTosKy2SUFnTil9s5LaeOUWHfz?=\n\t=?utf-8?q?dvBFBIlthhiYJP+1rNKoLagJ2doLkF4acT/KodiaSADJQs3nCsE3YdnMH9hX1k62t?=\n\t=?utf-8?q?SjTCSCmUCWt+7gaWjAICyAr2AlgwutT3cg=3D=3D?=", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 3647df98-6ee0-4b5f-d392-08db58152a35", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "19 May 2023 03:00:13.1475 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n l6NGGIPf+qxP5cQkmA1kpjloIab5uyoWqGeqqwSPS8KfUtFGEuM90mQRG6CmanJTgwPlhqjlLTRLHCmvzIx/Rprt68zoEN+kenZXOkg16CA=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SJ0PR13MB5769", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Reuse the ring buffer struct, make the code more readable.\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>\n---\n drivers/net/nfp/flower/nfp_flower.c | 2 +-\n drivers/net/nfp/flower/nfp_flower_ctrl.c | 2 +-\n drivers/net/nfp/nfp_rxtx.c | 4 ++--\n drivers/net/nfp/nfp_rxtx.h | 14 ++++++--------\n 4 files changed, 10 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/nfp/flower/nfp_flower.c b/drivers/net/nfp/flower/nfp_flower.c\nindex 159f88f5ae..4d60660a77 100644\n--- a/drivers/net/nfp/flower/nfp_flower.c\n+++ b/drivers/net/nfp/flower/nfp_flower.c\n@@ -320,7 +320,7 @@ nfp_flower_pf_recv_pkts(void *rx_queue,\n \tstruct nfp_net_hw *hw;\n \tstruct rte_mbuf *new_mb;\n \tstruct nfp_net_rxq *rxq;\n-\tstruct nfp_net_rx_buff *rxb;\n+\tstruct nfp_net_dp_buf *rxb;\n \tstruct nfp_net_rx_desc *rxds;\n \tstruct nfp_flower_representor *repr;\n \ndiff --git a/drivers/net/nfp/flower/nfp_flower_ctrl.c b/drivers/net/nfp/flower/nfp_flower_ctrl.c\nindex 937829c23c..1855e73c14 100644\n--- a/drivers/net/nfp/flower/nfp_flower_ctrl.c\n+++ b/drivers/net/nfp/flower/nfp_flower_ctrl.c\n@@ -30,7 +30,7 @@ nfp_flower_ctrl_vnic_recv(void *rx_queue,\n \tstruct nfp_net_hw *hw;\n \tstruct nfp_net_rxq *rxq;\n \tstruct rte_mbuf *new_mb;\n-\tstruct nfp_net_rx_buff *rxb;\n+\tstruct nfp_net_dp_buf *rxb;\n \tstruct nfp_net_rx_desc *rxds;\n \n \trxq = rx_queue;\ndiff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c\nindex 9eaa0b89c1..190498abc7 100644\n--- a/drivers/net/nfp/nfp_rxtx.c\n+++ b/drivers/net/nfp/nfp_rxtx.c\n@@ -28,7 +28,7 @@\n static int\n nfp_net_rx_fill_freelist(struct nfp_net_rxq *rxq)\n {\n-\tstruct nfp_net_rx_buff *rxe = rxq->rxbufs;\n+\tstruct nfp_net_dp_buf *rxe = rxq->rxbufs;\n \tuint64_t dma_addr;\n \tunsigned int i;\n \n@@ -371,7 +371,7 @@ nfp_net_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n {\n \tstruct nfp_net_rxq *rxq;\n \tstruct nfp_net_rx_desc *rxds;\n-\tstruct nfp_net_rx_buff *rxb;\n+\tstruct nfp_net_dp_buf *rxb;\n \tstruct nfp_net_hw *hw;\n \tstruct rte_mbuf *mb;\n \tstruct rte_mbuf *new_mb;\ndiff --git a/drivers/net/nfp/nfp_rxtx.h b/drivers/net/nfp/nfp_rxtx.h\nindex 4d0c88529b..235f083dcf 100644\n--- a/drivers/net/nfp/nfp_rxtx.h\n+++ b/drivers/net/nfp/nfp_rxtx.h\n@@ -98,6 +98,10 @@ struct nfp_meta_parsed {\n \n #define DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))\n \n+struct nfp_net_dp_buf {\n+\tstruct rte_mbuf *mbuf;\n+};\n+\n struct nfp_net_txq {\n \tstruct nfp_net_hw *hw; /* Backpointer to nfp_net structure */\n \n@@ -128,9 +132,7 @@ struct nfp_net_txq {\n \t * For each descriptor keep a reference to the mbuf and\n \t * DMA address used until completion is signalled.\n \t */\n-\tstruct {\n-\t\tstruct rte_mbuf *mbuf;\n-\t} *txbufs;\n+\tstruct nfp_net_dp_buf *txbufs;\n \n \t/*\n \t * Information about the host side queue location. @txds is\n@@ -210,10 +212,6 @@ struct nfp_net_rx_desc {\n \t};\n };\n \n-struct nfp_net_rx_buff {\n-\tstruct rte_mbuf *mbuf;\n-};\n-\n struct nfp_net_rxq {\n \tstruct nfp_net_hw *hw;\t/* Backpointer to nfp_net structure */\n \n@@ -238,7 +236,7 @@ struct nfp_net_rxq {\n \t * For each buffer placed on the freelist, record the\n \t * associated SKB\n \t */\n-\tstruct nfp_net_rx_buff *rxbufs;\n+\tstruct nfp_net_dp_buf *rxbufs;\n \n \t/*\n \t * Information about the host side queue location. @rxds is\n", "prefixes": [ "1/8" ] }