Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127002/?format=api
{ "id": 127002, "url": "http://patches.dpdk.org/api/patches/127002/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230518151638.1207021-9-qiming.yang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230518151638.1207021-9-qiming.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230518151638.1207021-9-qiming.yang@intel.com", "date": "2023-05-18T15:16:26", "name": "[v2,08/20] net/ice/base: add support for PPPoE hardware offload", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2e275138b34333affe568ec5ab3bbb39c48e4dd5", "submitter": { "id": 522, "url": "http://patches.dpdk.org/api/people/522/?format=api", "name": "Qiming Yang", "email": "qiming.yang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230518151638.1207021-9-qiming.yang@intel.com/mbox/", "series": [ { "id": 28063, "url": "http://patches.dpdk.org/api/series/28063/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28063", "date": "2023-05-18T15:16:18", "name": "net/ice/base: code update", "version": 2, "mbox": "http://patches.dpdk.org/series/28063/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/127002/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/127002/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 261FC42AF1;\n\tThu, 18 May 2023 17:35:31 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1BD1E42D63;\n\tThu, 18 May 2023 17:34:35 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id 33D0F42D55\n for <dev@dpdk.org>; Thu, 18 May 2023 17:34:33 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 18 May 2023 08:34:32 -0700", "from dpdk-qiming3.sh.intel.com ([10.67.111.4])\n by fmsmga007.fm.intel.com with ESMTP; 18 May 2023 08:34:30 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1684424073; x=1715960073;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=w0333qPrSnDw5ZEVJVVDgGgSuGQLT0TMlgiOyz2ph4U=;\n b=kBJgclnR1pyu5OnWEP/+78dGjHDcY8T1YqK1ov50yUqev3kDyZQbHSMF\n lou1NmTSU8Kw/uX9gB4C5M35SNLKa1AVQZxagnNo3UWFPlRXyy71ZdbP+\n Uam925WQyYlZ2/60iFkBCs6xU5rwEt8QcJWXeAYS+LdwJeSYM6VJwcchq\n MGZhW9wSuRplznfx5Cc6CqkN1CjIAolt3Bd61rfsNDn+Rfr5WwhjHsBK8\n iRIV0SsykbgT2o8JbPHu8G1XcvEB58/2lohRcHydIU34T7JZJBBbbNfOZ\n 3SYe9chX7VufM9HV4sJonwM+iqe66febQE8A0swz1mCiD9ErkHFPTonPO g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10714\"; a=\"341527686\"", "E=Sophos;i=\"5.99,285,1677571200\"; d=\"scan'208\";a=\"341527686\"", "E=McAfee;i=\"6600,9927,10714\"; a=\"705235109\"", "E=Sophos;i=\"5.99,285,1677571200\"; d=\"scan'208\";a=\"705235109\"" ], "X-ExtLoop1": "1", "From": "Qiming Yang <qiming.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "qi.z.zhang@intel.com, Qiming Yang <qiming.yang@intel.com>,\n Marcin Szycik <marcin.szycik@linux.intel.com>,\n Lukasz Plachno <lukasz.plachno@intel.com>", "Subject": "[PATCH v2 08/20] net/ice/base: add support for PPPoE hardware offload", "Date": "Thu, 18 May 2023 15:16:26 +0000", "Message-Id": "<20230518151638.1207021-9-qiming.yang@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230518151638.1207021-1-qiming.yang@intel.com>", "References": "<20230427062001.478032-1-qiming.yang@intel.com>\n <20230518151638.1207021-1-qiming.yang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add support for creating PPPoE filters in switchdev mode. Add support\nfor parsing PPPoE and PPP-specific tc options: pppoe_sid and ppp_proto.\n\nSigned-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>\nSigned-off-by: Lukasz Plachno <lukasz.plachno@intel.com>\nSigned-off-by: Qiming Yang <qiming.yang@intel.com>\n---\n drivers/net/ice/base/ice_bitops.h | 2 +-\n drivers/net/ice/base/ice_ddp.c | 4 ++-\n drivers/net/ice/base/ice_switch.c | 46 +++++++++++++++++++++++--------\n 3 files changed, 38 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_bitops.h b/drivers/net/ice/base/ice_bitops.h\nindex df00c859ac..3b71c1b7f5 100644\n--- a/drivers/net/ice/base/ice_bitops.h\n+++ b/drivers/net/ice/base/ice_bitops.h\n@@ -433,7 +433,7 @@ ice_bitmap_hweight(ice_bitmap_t *bm, u16 size)\n }\n \n /**\n- * ice_cmp_bitmaps - compares two bitmaps.\n+ * ice_cmp_bitmap - compares two bitmaps.\n * @bmp1: the bitmap to compare\n * @bmp2: the bitmap to compare with bmp1\n * @size: Size of the bitmaps in bits\ndiff --git a/drivers/net/ice/base/ice_ddp.c b/drivers/net/ice/base/ice_ddp.c\nindex 93ff2608d4..3e18f2bc70 100644\n--- a/drivers/net/ice/base/ice_ddp.c\n+++ b/drivers/net/ice/base/ice_ddp.c\n@@ -1623,8 +1623,10 @@ ice_get_sw_fv_list(struct ice_hw *hw, struct ice_prot_lkup_ext *lkups,\n \t\t\t}\n \t\t}\n \t} while (fv);\n-\tif (LIST_EMPTY(fv_list))\n+\tif (LIST_EMPTY(fv_list)) {\n+\t\tice_warn(hw, \"Required profiles not found in currently loaded DDP package\");\n \t\treturn ICE_ERR_CFG;\n+\t}\n \treturn ICE_SUCCESS;\n \n err:\ndiff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c\nindex a9f3ae5bf5..e290a845bc 100644\n--- a/drivers/net/ice/base/ice_switch.c\n+++ b/drivers/net/ice/base/ice_switch.c\n@@ -1775,7 +1775,7 @@ static const u8 dummy_pppoe_ipv6_packet[] = {\n };\n \n static const\n-struct ice_dummy_pkt_offsets dummy_pppoe_packet_ipv6_tcp_offsets[] = {\n+struct ice_dummy_pkt_offsets dummy_pppoe_ipv6_tcp_packet_offsets[] = {\n \t{ ICE_MAC_OFOS,\t\t0 },\n \t{ ICE_VLAN_OFOS,\t12 },\n \t{ ICE_ETYPE_OL,\t\t16 },\n@@ -1820,7 +1820,7 @@ static const u8 dummy_pppoe_ipv6_tcp_packet[] = {\n };\n \n static const\n-struct ice_dummy_pkt_offsets dummy_pppoe_packet_ipv6_udp_offsets[] = {\n+struct ice_dummy_pkt_offsets dummy_pppoe_ipv6_udp_packet_offsets[] = {\n \t{ ICE_MAC_OFOS,\t\t0 },\n \t{ ICE_VLAN_OFOS,\t12 },\n \t{ ICE_ETYPE_OL,\t\t16 },\n@@ -8291,7 +8291,7 @@ ice_find_dummy_packet(struct ice_adv_lkup_elem *lkups, u16 lkups_cnt,\n \t\t const struct ice_dummy_pkt_offsets **offsets)\n {\n \tbool tcp = false, udp = false, outer_ipv6 = false, vlan = false;\n-\tbool inner_ipv6 = false;\n+\tbool inner_ipv6 = false, pppoe = false;\n \tbool cvlan = false;\n \tbool gre = false, mpls = false;\n \tu16 i;\n@@ -8321,18 +8321,20 @@ ice_find_dummy_packet(struct ice_adv_lkup_elem *lkups, u16 lkups_cnt,\n \t\t\t lkups[i].m_u.ethertype.ethtype_id ==\n \t\t\t\tCPU_TO_BE16(0xFFFF))\n \t\t\tinner_ipv6 = true;\n+\t\telse if (lkups[i].type == ICE_PPPOE) {\n+\t\t\tpppoe = true;\n+\t\t\tif (lkups[i].h_u.pppoe_hdr.ppp_prot_id ==\n+\t\t\t\tCPU_TO_BE16(ICE_PPP_IPV6_PROTO_ID) &&\n+\t\t\t lkups[i].m_u.pppoe_hdr.ppp_prot_id ==\n+\t\t\t\tCPU_TO_BE16(0xFFFF))\n+\t\t\t\touter_ipv6 = true;\n+\t\t}\n \t\telse if (lkups[i].type == ICE_IPV4_OFOS &&\n \t\t\t lkups[i].h_u.ipv4_hdr.protocol ==\n \t\t\t\tICE_IPV4_NVGRE_PROTO_ID &&\n \t\t\t lkups[i].m_u.ipv4_hdr.protocol ==\n \t\t\t\t0xFF)\n \t\t\tgre = true;\n-\t\telse if (lkups[i].type == ICE_PPPOE &&\n-\t\t\t lkups[i].h_u.pppoe_hdr.ppp_prot_id ==\n-\t\t\t\tCPU_TO_BE16(ICE_PPP_IPV6_PROTO_ID) &&\n-\t\t\t lkups[i].m_u.pppoe_hdr.ppp_prot_id ==\n-\t\t\t\t0xFFFF)\n-\t\t\touter_ipv6 = true;\n \t\telse if (lkups[i].type == ICE_IPV4_IL &&\n \t\t\t lkups[i].h_u.ipv4_hdr.protocol ==\n \t\t\t\tICE_TCP_PROTO_ID &&\n@@ -8627,14 +8629,14 @@ ice_find_dummy_packet(struct ice_adv_lkup_elem *lkups, u16 lkups_cnt,\n \tif (tun_type == ICE_SW_TUN_PPPOE_IPV6_TCP) {\n \t\t*pkt = dummy_pppoe_ipv6_tcp_packet;\n \t\t*pkt_len = sizeof(dummy_pppoe_ipv6_tcp_packet);\n-\t\t*offsets = dummy_pppoe_packet_ipv6_tcp_offsets;\n+\t\t*offsets = dummy_pppoe_ipv6_tcp_packet_offsets;\n \t\treturn;\n \t}\n \n \tif (tun_type == ICE_SW_TUN_PPPOE_IPV6_UDP) {\n \t\t*pkt = dummy_pppoe_ipv6_udp_packet;\n \t\t*pkt_len = sizeof(dummy_pppoe_ipv6_udp_packet);\n-\t\t*offsets = dummy_pppoe_packet_ipv6_udp_offsets;\n+\t\t*offsets = dummy_pppoe_ipv6_udp_packet_offsets;\n \t\treturn;\n \t}\n \n@@ -8738,6 +8740,11 @@ ice_find_dummy_packet(struct ice_adv_lkup_elem *lkups, u16 lkups_cnt,\n \t\t\t*pkt_len = sizeof(dummy_vlan_udp_packet);\n \t\t\t*offsets = dummy_vlan_udp_packet_offsets;\n \t\t\treturn;\n+\t\t} else if (pppoe) {\n+\t\t\t*pkt = dummy_pppoe_ipv4_udp_packet;\n+\t\t\t*pkt_len = sizeof(dummy_pppoe_ipv4_udp_packet);\n+\t\t\t*offsets = dummy_pppoe_ipv4_udp_packet_offsets;\n+\t\t\treturn;\n \t\t}\n \t\t*pkt = dummy_udp_packet;\n \t\t*pkt_len = sizeof(dummy_udp_packet);\n@@ -8749,6 +8756,11 @@ ice_find_dummy_packet(struct ice_adv_lkup_elem *lkups, u16 lkups_cnt,\n \t\t\t*pkt_len = sizeof(dummy_vlan_udp_ipv6_packet);\n \t\t\t*offsets = dummy_vlan_udp_ipv6_packet_offsets;\n \t\t\treturn;\n+\t\t} else if (pppoe) {\n+\t\t\t*pkt = dummy_pppoe_ipv6_udp_packet;\n+\t\t\t*pkt_len = sizeof(dummy_pppoe_ipv6_udp_packet);\n+\t\t\t*offsets = dummy_pppoe_ipv6_udp_packet_offsets;\n+\t\t\treturn;\n \t\t}\n \t\t*pkt = dummy_udp_ipv6_packet;\n \t\t*pkt_len = sizeof(dummy_udp_ipv6_packet);\n@@ -8760,6 +8772,11 @@ ice_find_dummy_packet(struct ice_adv_lkup_elem *lkups, u16 lkups_cnt,\n \t\t\t*pkt_len = sizeof(dummy_vlan_tcp_ipv6_packet);\n \t\t\t*offsets = dummy_vlan_tcp_ipv6_packet_offsets;\n \t\t\treturn;\n+\t\t} else if (pppoe) {\n+\t\t\t*pkt = dummy_pppoe_ipv6_tcp_packet;\n+\t\t\t*pkt_len = sizeof(dummy_pppoe_ipv6_tcp_packet);\n+\t\t\t*offsets = dummy_pppoe_ipv6_tcp_packet_offsets;\n+\t\t\treturn;\n \t\t}\n \t\t*pkt = dummy_tcp_ipv6_packet;\n \t\t*pkt_len = sizeof(dummy_tcp_ipv6_packet);\n@@ -8771,7 +8788,12 @@ ice_find_dummy_packet(struct ice_adv_lkup_elem *lkups, u16 lkups_cnt,\n \t\t*pkt = dummy_vlan_tcp_packet;\n \t\t*pkt_len = sizeof(dummy_vlan_tcp_packet);\n \t\t*offsets = dummy_vlan_tcp_packet_offsets;\n-\t} else if (mpls) {\n+\t} else if (pppoe) {\n+\t\t*pkt = dummy_pppoe_ipv4_tcp_packet;\n+\t\t*pkt_len = sizeof(dummy_pppoe_ipv4_tcp_packet);\n+\t\t*offsets = dummy_pppoe_ipv4_tcp_packet_offsets;\n+\t\treturn;\n+\t} else if (mpls) {\n \t\t*pkt = dummy_mpls_packet;\n \t\t*pkt_len = sizeof(dummy_mpls_packet);\n \t\t*offsets = dummy_mpls_packet_offsets;\n", "prefixes": [ "v2", "08/20" ] }