Patch Comment List
List patch comments
GET /api/patches/127/comments/?format=api
[ { "id": 568, "web_url": "http://patches.dpdk.org/comment/568/", "msgid": "<2341626.4ghOyc4mVt@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/2341626.4ghOyc4mVt@xps13", "date": "2014-08-28T20:15:44", "subject": "Re: [dpdk-dev] [PATCH v3] lib/librte_vhost: vhost library support\n\tto facilitate integration with DPDK accelerated vswitch.", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "> config/common_linuxapp | 7 +\n> lib/Makefile | 1 +\n> lib/librte_vhost/Makefile | 48 ++\n> lib/librte_vhost/eventfd_link/Makefile | 39 +\n> lib/librte_vhost/eventfd_link/eventfd_link.c | 194 +++++\n> lib/librte_vhost/eventfd_link/eventfd_link.h | 40 +\n> lib/librte_vhost/rte_virtio_net.h | 192 +++++\n> lib/librte_vhost/vhost-net-cdev.c | 363 ++++++++++\n> lib/librte_vhost/vhost-net-cdev.h | 109 +++\n> lib/librte_vhost/vhost_rxtx.c | 292 ++++++++\n> lib/librte_vhost/virtio-net.c | 1002 ++++++++++++++++++++++++++\n\nIt would help if you made a first patch to move existing code,\nanother patch to convert it into a lib, and a last one for\nthe new example.\nSo it would show how you transform the old example code and\nwould be easier to review.\n\nThanks", "headers": { "Return-Path": "<thomas.monjalon@6wind.com>", "Received": [ "from mail-we0-f175.google.com (mail-we0-f175.google.com\n\t[74.125.82.175]) by dpdk.org (Postfix) with ESMTP id 939275942\n\tfor <dev@dpdk.org>; Thu, 28 Aug 2014 22:54:42 +0200 (CEST)", "by mail-we0-f175.google.com with SMTP id k48so1329445wev.6\n\tfor <dev@dpdk.org>; Thu, 28 Aug 2014 13:58:53 -0700 (PDT)", "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\tu10sm18662157wix.2.2014.08.28.13.58.51 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 28 Aug 2014 13:58:52 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=tQLVLob5TtlB+mSzlOQAbPIc+aph63joDe+qLoWol/Y=;\n\tb=Z5Q2BQftT3xU/ZDR/21w+vS9hWkmyyPnFwSGiBcNjLNfxKHuFcu9blhqpUtSM8TF37\n\t1qYz3i6WZ7j0jfW2R3RR0WqYdqSP2UCEtG4hoW/axPs+dfwbaLu0qTKb5VmOaF4MtCqK\n\tMecGo5X83Gd5uNhqOz2FX6LN+LsCN2+w4ZHOe8jgNzUOMltYzcKJwvepEHrnHzR2vDPi\n\t8nanVL4ZzsT95EJj/YkXONZylgIkOHuitaHwUXuBdd+ZTurFwC82Q+sf6G85L+FzItCm\n\tzuUaMuXS4UAm0AjT+qsSbW+DvLeS6IsawxPsEV0jF3/pGA1ryf5vIS3d3BkgKXg8h13x\n\tGdpw==", "X-Gm-Message-State": "ALoCoQktmvltITiiMmBjUBxugVstC8hOsTmCFFGSNyfb87onqAiGQ2rxDcyD7FjBuhbYSZYMCexU", "X-Received": "by 10.180.39.140 with SMTP id p12mr755298wik.40.1409259533085;\n\tThu, 28 Aug 2014 13:58:53 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Huawei Xie <huawei.xie@intel.com>", "Date": "Thu, 28 Aug 2014 22:15:44 +0200", "Message-ID": "<2341626.4ghOyc4mVt@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )", "In-Reply-To": "<1407254033-23848-2-git-send-email-huawei.xie@intel.com>", "References": "<1407254033-23848-1-git-send-email-huawei.xie@intel.com>\n\t<1407254033-23848-2-git-send-email-huawei.xie@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH v3] lib/librte_vhost: vhost library support\n\tto facilitate integration with DPDK accelerated vswitch.", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Thu, 28 Aug 2014 20:54:42 -0000" }, "addressed": null }, { "id": 571, "web_url": "http://patches.dpdk.org/comment/571/", "msgid": "<C37D651A908B024F974696C65296B57B0F280169@SHSMSX101.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/C37D651A908B024F974696C65296B57B0F280169@SHSMSX101.ccr.corp.intel.com", "date": "2014-08-29T02:05:51", "subject": "Re: [dpdk-dev] [PATCH v3] lib/librte_vhost: vhost library support\n\tto facilitate integration with DPDK accelerated vswitch.", "submitter": { "id": 16, "url": "http://patches.dpdk.org/api/people/16/?format=api", "name": "Huawei Xie", "email": "huawei.xie@intel.com" }, "content": "> -----Original Message-----\n> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> Sent: Friday, August 29, 2014 4:16 AM\n> To: Xie, Huawei\n> Cc: dev@dpdk.org\n> Subject: Re: [dpdk-dev] [PATCH v3] lib/librte_vhost: vhost library support to\n> facilitate integration with DPDK accelerated vswitch.\n> \n> > config/common_linuxapp | 7 +\n> > lib/Makefile | 1 +\n> > lib/librte_vhost/Makefile | 48 ++\n> > lib/librte_vhost/eventfd_link/Makefile | 39 +\n> > lib/librte_vhost/eventfd_link/eventfd_link.c | 194 +++++\n> > lib/librte_vhost/eventfd_link/eventfd_link.h | 40 +\n> > lib/librte_vhost/rte_virtio_net.h | 192 +++++\n> > lib/librte_vhost/vhost-net-cdev.c | 363 ++++++++++\n> > lib/librte_vhost/vhost-net-cdev.h | 109 +++\n> > lib/librte_vhost/vhost_rxtx.c | 292 ++++++++\n> > lib/librte_vhost/virtio-net.c | 1002 ++++++++++++++++++++++++++\n> \n> It would help if you made a first patch to move existing code,\n> another patch to convert it into a lib, and a last one for\n> the new example.\n> So it would show how you transform the old example code and\n> would be easier to review.\n> \n> Thanks\n> --\n> Thomas\nMy original order is first patch to add a new lib but not turned on, \nanother patch to remove the old example, and the third patch to \nadd the new example. \nI am preparing new patch sets, merging the mergable feature, will \nfollow the suggested order.\n-huawei", "headers": { "Return-Path": "<huawei.xie@intel.com>", "Received": [ "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 839A9590B\n\tfor <dev@dpdk.org>; Fri, 29 Aug 2014 04:01:44 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga103.fm.intel.com with ESMTP; 28 Aug 2014 18:57:49 -0700", "from fmsmsx103.amr.corp.intel.com ([10.19.9.34])\n\tby fmsmga001.fm.intel.com with ESMTP; 28 Aug 2014 19:05:54 -0700", "from fmsmsx154.amr.corp.intel.com (10.18.116.70) by\n\tFMSMSX103.amr.corp.intel.com (10.19.9.34) with Microsoft SMTP Server\n\t(TLS) id 14.3.195.1; Thu, 28 Aug 2014 19:05:54 -0700", "from shsmsx103.ccr.corp.intel.com (10.239.4.69) by\n\tFMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Thu, 28 Aug 2014 19:05:54 -0700", "from shsmsx101.ccr.corp.intel.com ([169.254.1.198]) by\n\tSHSMSX103.ccr.corp.intel.com ([169.254.4.219]) with mapi id\n\t14.03.0195.001; Fri, 29 Aug 2014 10:05:52 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,421,1406617200\"; d=\"scan'208\";a=\"583206366\"", "From": "\"Xie, Huawei\" <huawei.xie@intel.com>", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>", "Thread-Topic": "[dpdk-dev] [PATCH v3] lib/librte_vhost: vhost library support\n\tto facilitate integration with DPDK accelerated vswitch.", "Thread-Index": "AQHPwwLnZX523JG+v0SbntsPH7/0tZvmuuKw", "Date": "Fri, 29 Aug 2014 02:05:51 +0000", "Message-ID": "<C37D651A908B024F974696C65296B57B0F280169@SHSMSX101.ccr.corp.intel.com>", "References": "<1407254033-23848-1-git-send-email-huawei.xie@intel.com>\n\t<1407254033-23848-2-git-send-email-huawei.xie@intel.com>\n\t<2341626.4ghOyc4mVt@xps13>", "In-Reply-To": "<2341626.4ghOyc4mVt@xps13>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>", "Subject": "Re: [dpdk-dev] [PATCH v3] lib/librte_vhost: vhost library support\n\tto facilitate integration with DPDK accelerated vswitch.", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Fri, 29 Aug 2014 02:01:45 -0000" }, "addressed": null } ]