Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126992/?format=api
{ "id": 126992, "url": "http://patches.dpdk.org/api/patches/126992/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230518124949.879834-4-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230518124949.879834-4-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230518124949.879834-4-bruce.richardson@intel.com", "date": "2023-05-18T12:49:49", "name": "[v5,3/3] telemetry: use standard logging", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "038ddbf3a5c9ac4134bb425451b280eb7104bdbe", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230518124949.879834-4-bruce.richardson@intel.com/mbox/", "series": [ { "id": 28061, "url": "http://patches.dpdk.org/api/series/28061/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28061", "date": "2023-05-18T12:49:46", "name": "Split logging functionality out of EAL", "version": 5, "mbox": "http://patches.dpdk.org/series/28061/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/126992/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/126992/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E631942B3A;\n\tThu, 18 May 2023 14:50:23 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E2B9B42D16;\n\tThu, 18 May 2023 14:50:10 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id 8747942D3D\n for <dev@dpdk.org>; Thu, 18 May 2023 14:50:09 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 18 May 2023 05:50:09 -0700", "from silpixa00401385.ir.intel.com ([10.237.214.44])\n by fmsmga007.fm.intel.com with ESMTP; 18 May 2023 05:50:07 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1684414209; x=1715950209;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=muLJi5nGdGqYInm/NVM1JohzJc1aYGM0NZgwwBRcspg=;\n b=f2rrERyO9Zi0fE5PTeMVzfAJ1I1MbsPbd0eFnUXuLJ8OuC85+m9WWkhc\n rnL5a9chi73CD86M94Vf2O7FxNhQ/Or+gEbcvnv8NnNXag49lL0sCAGbK\n 1zD6U++75hb6JovAS4QYO6/HNbOehqwzh2rdhGRNw81hJObokNncI4X+d\n z8m0Z/ziqCyKCpAdTeNSprQzp1rA9CK3qZMnAFY2fjBimVbOHSqxqSJJN\n FL6OA1kYuUzUFL9/HdVWxNUX66RSkqhij7o9+D6DBdBeGWXkXlIxTVDCN\n febGNT4B+hjPLRb4NkahBhQnDM6UNyyG4+rySOMwjadaKSRZj0AAgRN+E Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10713\"; a=\"380259908\"", "E=Sophos;i=\"5.99,285,1677571200\"; d=\"scan'208\";a=\"380259908\"", "E=McAfee;i=\"6600,9927,10713\"; a=\"705187684\"", "E=Sophos;i=\"5.99,285,1677571200\"; d=\"scan'208\";a=\"705187684\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, =?utf-8?q?Morten_Br=C3=B8?=\n\t=?utf-8?q?rup?= <mb@smartsharesystems.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v5 3/3] telemetry: use standard logging", "Date": "Thu, 18 May 2023 13:49:49 +0100", "Message-Id": "<20230518124949.879834-4-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230518124949.879834-1-bruce.richardson@intel.com>", "References": "<20220829151901.376754-1-bruce.richardson@intel.com>\n <20230518124949.879834-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Now that logging is moved out of EAL, we don't need injection of the\nlogtype and logging function from EAL to telemetry library, simplifying\nthings.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/eal/freebsd/eal.c | 6 +-----\n lib/eal/linux/eal.c | 6 +-----\n lib/telemetry/telemetry.c | 11 +++--------\n lib/telemetry/telemetry_internal.h | 3 +--\n 4 files changed, 6 insertions(+), 20 deletions(-)", "diff": "diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c\nindex 7daf22e314..f125a0d3de 100644\n--- a/lib/eal/freebsd/eal.c\n+++ b/lib/eal/freebsd/eal.c\n@@ -884,13 +884,9 @@ rte_eal_init(int argc, char **argv)\n \t\treturn -1;\n \t}\n \tif (rte_eal_process_type() == RTE_PROC_PRIMARY && !internal_conf->no_telemetry) {\n-\t\tint tlog = rte_log_register_type_and_pick_level(\n-\t\t\t\t\"lib.telemetry\", RTE_LOG_WARNING);\n-\t\tif (tlog < 0)\n-\t\t\ttlog = RTE_LOGTYPE_EAL;\n \t\tif (rte_telemetry_init(rte_eal_get_runtime_dir(),\n \t\t\t\trte_version(),\n-\t\t\t\t&internal_conf->ctrl_cpuset, rte_log, tlog) != 0)\n+\t\t\t\t&internal_conf->ctrl_cpuset) != 0)\n \t\t\treturn -1;\n \t}\n \ndiff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c\nindex 765ad1d783..c80647d6b2 100644\n--- a/lib/eal/linux/eal.c\n+++ b/lib/eal/linux/eal.c\n@@ -1330,13 +1330,9 @@ rte_eal_init(int argc, char **argv)\n \t\treturn -1;\n \t}\n \tif (rte_eal_process_type() == RTE_PROC_PRIMARY && !internal_conf->no_telemetry) {\n-\t\tint tlog = rte_log_register_type_and_pick_level(\n-\t\t\t\t\"lib.telemetry\", RTE_LOG_WARNING);\n-\t\tif (tlog < 0)\n-\t\t\ttlog = RTE_LOGTYPE_EAL;\n \t\tif (rte_telemetry_init(rte_eal_get_runtime_dir(),\n \t\t\t\trte_version(),\n-\t\t\t\t&internal_conf->ctrl_cpuset, rte_log, tlog) != 0)\n+\t\t\t\t&internal_conf->ctrl_cpuset) != 0)\n \t\t\treturn -1;\n \t}\n \ndiff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c\nindex deba7f34a3..3feeebd814 100644\n--- a/lib/telemetry/telemetry.c\n+++ b/lib/telemetry/telemetry.c\n@@ -54,11 +54,9 @@ static struct socket v1_socket; /* socket for v1 telemetry */\n static const char *telemetry_version; /* save rte_version */\n static const char *socket_dir; /* runtime directory */\n static rte_cpuset_t *thread_cpuset;\n-static rte_log_fn rte_log_ptr;\n-static uint32_t logtype;\n \n-#define TMTY_LOG(l, ...) \\\n- rte_log_ptr(RTE_LOG_ ## l, logtype, \"TELEMETRY: \" __VA_ARGS__)\n+RTE_LOG_REGISTER_DEFAULT(logtype, WARNING);\n+#define TMTY_LOG(l, ...) rte_log(RTE_LOG_ ## l, logtype, \"TELEMETRY: \" __VA_ARGS__)\n \n /* list of command callbacks, with one command registered by default */\n static struct cmd_callback *callbacks;\n@@ -612,14 +610,11 @@ telemetry_v2_init(void)\n #endif /* !RTE_EXEC_ENV_WINDOWS */\n \n int32_t\n-rte_telemetry_init(const char *runtime_dir, const char *rte_version, rte_cpuset_t *cpuset,\n-\t\trte_log_fn log_fn, uint32_t registered_logtype)\n+rte_telemetry_init(const char *runtime_dir, const char *rte_version, rte_cpuset_t *cpuset)\n {\n \ttelemetry_version = rte_version;\n \tsocket_dir = runtime_dir;\n \tthread_cpuset = cpuset;\n-\trte_log_ptr = log_fn;\n-\tlogtype = registered_logtype;\n \n #ifndef RTE_EXEC_ENV_WINDOWS\n \tif (telemetry_v2_init() != 0)\ndiff --git a/lib/telemetry/telemetry_internal.h b/lib/telemetry/telemetry_internal.h\nindex d085c492dc..5c75d73183 100644\n--- a/lib/telemetry/telemetry_internal.h\n+++ b/lib/telemetry/telemetry_internal.h\n@@ -109,7 +109,6 @@ typedef int (*rte_log_fn)(uint32_t level, uint32_t logtype, const char *format,\n */\n __rte_internal\n int\n-rte_telemetry_init(const char *runtime_dir, const char *rte_version, rte_cpuset_t *cpuset,\n-\t\trte_log_fn log_fn, uint32_t registered_logtype);\n+rte_telemetry_init(const char *runtime_dir, const char *rte_version, rte_cpuset_t *cpuset);\n \n #endif\n", "prefixes": [ "v5", "3/3" ] }