Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126977/?format=api
{ "id": 126977, "url": "http://patches.dpdk.org/api/patches/126977/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/06a89892aa1b37996e5e629b3488c59d565393bd.1684393730.git.wangyunjian@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<06a89892aa1b37996e5e629b3488c59d565393bd.1684393730.git.wangyunjian@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/06a89892aa1b37996e5e629b3488c59d565393bd.1684393730.git.wangyunjian@huawei.com", "date": "2023-05-18T07:11:24", "name": "[1/1] net/txgbe: fix use-after-free on remove", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0fd95c5df9964d6820bd8f5aa43fef458949e959", "submitter": { "id": 551, "url": "http://patches.dpdk.org/api/people/551/?format=api", "name": "Yunjian Wang", "email": "wangyunjian@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/06a89892aa1b37996e5e629b3488c59d565393bd.1684393730.git.wangyunjian@huawei.com/mbox/", "series": [ { "id": 28055, "url": "http://patches.dpdk.org/api/series/28055/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28055", "date": "2023-05-18T07:11:24", "name": "[1/1] net/txgbe: fix use-after-free on remove", "version": 1, "mbox": "http://patches.dpdk.org/series/28055/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/126977/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/126977/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 501B442B37;\n\tThu, 18 May 2023 09:11:33 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2BB0E42B71;\n\tThu, 18 May 2023 09:11:33 +0200 (CEST)", "from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])\n by mails.dpdk.org (Postfix) with ESMTP id 3924240E25;\n Thu, 18 May 2023 09:11:31 +0200 (CEST)", "from dggpemm500008.china.huawei.com (unknown [172.30.72.57])\n by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4QMLd82zYjz18Lk6;\n Thu, 18 May 2023 15:07:08 +0800 (CST)", "from localhost (10.174.242.157) by dggpemm500008.china.huawei.com\n (7.185.36.136) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 18 May\n 2023 15:11:29 +0800" ], "From": "Yunjian Wang <wangyunjian@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<jiawenwu@trustnetic.com>, <jianwang@trustnetic.com>,\n <luyicai@huawei.com>, Yunjian Wang <wangyunjian@huawei.com>,\n <stable@dpdk.org>", "Subject": "[dpdk-dev] [PATCH 1/1] net/txgbe: fix use-after-free on remove", "Date": "Thu, 18 May 2023 15:11:24 +0800", "Message-ID": "\n <06a89892aa1b37996e5e629b3488c59d565393bd.1684393730.git.wangyunjian@huawei.com>", "X-Mailer": "git-send-email 1.9.5.msysgit.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.174.242.157]", "X-ClientProxiedBy": "dggems703-chm.china.huawei.com (10.3.19.180) To\n dggpemm500008.china.huawei.com (7.185.36.136)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When cleaning up NIC's interrupts, it is possible to add some alarms\nat the same time. However, if these alarms are not canceled, it may\ncause use-after-free problems. Therefore, after cleaning up NIC's\ninterrupts, these alarms should also be canceled.\n\nFixes: d3bb4a04eac1 (\"net/txgbe: add SFP hotplug identification\")\nFixes: e0d876ef6bbc (\"net/txgbe: support device stop and close\")\nCc: stable@dpdk.org\n\nReported-by: Pengfei Sun <sunpengfei16@huawei.com>\nSigned-off-by: Yunjian Wang <wangyunjian@huawei.com>\n---\n drivers/net/txgbe/txgbe_ethdev.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c\nindex a502618bc5..a3d7461951 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.c\n+++ b/drivers/net/txgbe/txgbe_ethdev.c\n@@ -2032,8 +2032,10 @@ txgbe_dev_close(struct rte_eth_dev *dev)\n \t\trte_delay_ms(100);\n \t} while (retries++ < (10 + TXGBE_LINK_UP_TIME));\n \n-\t/* cancel the delay handler before remove dev */\n+\t/* cancel all alarm handler before remove dev */\n \trte_eal_alarm_cancel(txgbe_dev_interrupt_delayed_handler, dev);\n+\trte_eal_alarm_cancel(txgbe_dev_detect_sfp, dev);\n+\trte_eal_alarm_cancel(txgbe_dev_setup_link_alarm_handler, dev);\n \n \t/* uninitialize PF if max_vfs not zero */\n \ttxgbe_pf_host_uninit(dev);\n", "prefixes": [ "1/1" ] }