Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126938/?format=api
{ "id": 126938, "url": "http://patches.dpdk.org/api/patches/126938/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230517161603.117728-15-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230517161603.117728-15-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230517161603.117728-15-stephen@networkplumber.org", "date": "2023-05-17T16:15:57", "name": "[14/20] net/bnx2x: remove reference to sanity", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "053e11caf6f8282055a6080314243f958df2a1f5", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230517161603.117728-15-stephen@networkplumber.org/mbox/", "series": [ { "id": 28034, "url": "http://patches.dpdk.org/api/series/28034/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28034", "date": "2023-05-17T16:15:43", "name": "Replace use of term sanity-check", "version": 1, "mbox": "http://patches.dpdk.org/series/28034/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/126938/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/126938/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4D4BA42B2C;\n\tWed, 17 May 2023 18:17:39 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E068A42DA2;\n\tWed, 17 May 2023 18:16:28 +0200 (CEST)", "from mail-pg1-f176.google.com (mail-pg1-f176.google.com\n [209.85.215.176])\n by mails.dpdk.org (Postfix) with ESMTP id 7B05B42D6D\n for <dev@dpdk.org>; Wed, 17 May 2023 18:16:23 +0200 (CEST)", "by mail-pg1-f176.google.com with SMTP id\n 41be03b00d2f7-5307502146aso637604a12.1\n for <dev@dpdk.org>; Wed, 17 May 2023 09:16:23 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n h5-20020a62b405000000b0063f33e216dasm15793009pfn.96.2023.05.17.09.16.21\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 17 May 2023 09:16:22 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1684340182;\n x=1686932182;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=2ExCDqThjCDlZxRs/cZRIJvP1uteJ/8ZUE6rrQ56gqA=;\n b=ZJSmGWFYqlFnRUN5jchkeAbhW4FcZeL9rppQxgz+kFkgGFrcI6UV9WdzEyOjtqm4tJ\n ilo5x/FYbjTOOtSvQZmr9hfOYazQEZubCpuM1f+vlPnXe5H0hYJBtzwdwAz4cyWgmtAx\n zxdtMt2xcyoXTyuhy7Qk8qGa7Y8EdIgPj0cEGNLNGDPiUE8d4YzbXJvdtlLu2uqchqpv\n CFSjR90dlaD4vnztSUtd+09yZjajC/97KE6O56tqlP96Q1sX3IGIMPGiqlXr9z4JAPyK\n 6yrY05EL0Uh9xakxfzKrXTLWy7cZS8A9ngBjU05KaA6dzarfHojpqngyhsw1LpkciJo3\n mstQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1684340182; x=1686932182;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=2ExCDqThjCDlZxRs/cZRIJvP1uteJ/8ZUE6rrQ56gqA=;\n b=GQccQv8GqspYitdKRu8URXcg6svsM/LMg5LMdabqsnD8gaehUAhEEK0H5vTxJlRrBU\n JnERzKxB8ulnYDT8AyLZq4WEA5fFH694rnjpvoMx+c2mSyeSz1HBfeOQBRzRxIjoPXCI\n hS7HBmSWvzGUw6DxePU5y06F842wOeGMx+kpmny2fZEH63L+cpyJzlt2/MoT4aa4SzVR\n qcuIq625gif7fU8+QZribMKeEw3mJDVl3vsgohZADiRnQ+V8yYU2fX4lt+SsMiLMpIkC\n yKIowLhUu/De3rpTCfeLLLDZWl6CPvrJi0seYySjmoyRF61kJtssAo2P/8GFwDJhMvYs\n No6Q==", "X-Gm-Message-State": "AC+VfDyb7X/ozhsLBBA15QvZtavrfWkPUE1NoPo+n0PX5Itsy3O4xJAB\n 12s1kTg2piesFJ/1xZZ9mCDv6CcVq+Jk9rEXFDMPmw==", "X-Google-Smtp-Source": "\n ACHHUZ7uO8eKIA6m+gGUXLfTwh3z4iX7K5q6sJpxlyFaumFj1UJ6kKDZqhNHmpO40H3KGTH+nnABPA==", "X-Received": "by 2002:a05:6a20:6a2a:b0:f6:d4d:2d with SMTP id\n p42-20020a056a206a2a00b000f60d4d002dmr47282448pzk.31.1684340182473;\n Wed, 17 May 2023 09:16:22 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Rasesh Mody <rmody@marvell.com>, Shahed Shaikh <shshaikh@marvell.com>", "Subject": "[PATCH 14/20] net/bnx2x: remove reference to sanity", "Date": "Wed, 17 May 2023 09:15:57 -0700", "Message-Id": "<20230517161603.117728-15-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230517161603.117728-1-stephen@networkplumber.org>", "References": "<20230517161603.117728-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace \"sanity check\"\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/bnx2x/bnx2x.c | 2 +-\n drivers/net/bnx2x/bnx2x_stats.c | 8 ++++----\n drivers/net/bnx2x/ecore_sp.c | 2 +-\n drivers/net/bnx2x/elink.c | 4 ++--\n 4 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c\nindex 29c16bb207c7..0d2dc2d3b3fa 100644\n--- a/drivers/net/bnx2x/bnx2x.c\n+++ b/drivers/net/bnx2x/bnx2x.c\n@@ -7821,7 +7821,7 @@ static int bnx2x_check_valid_mf_cfg(struct bnx2x_softc *sc)\n \tuint32_t ovlan2;\n \tuint8_t i, j;\n \n-\t/* various MF mode sanity checks... */\n+\t/* various MF mode checks... */\n \n \tif (mf_info->mf_config[SC_VN(sc)] & FUNC_MF_CFG_FUNC_HIDE) {\n \t\tPMD_DRV_LOG(NOTICE, sc,\ndiff --git a/drivers/net/bnx2x/bnx2x_stats.c b/drivers/net/bnx2x/bnx2x_stats.c\nindex c07b01510a06..86d90679ac0a 100644\n--- a/drivers/net/bnx2x/bnx2x_stats.c\n+++ b/drivers/net/bnx2x/bnx2x_stats.c\n@@ -187,7 +187,7 @@ bnx2x_stats_pmf_update(struct bnx2x_softc *sc)\n \t\t */\n \t\treturn;\n \t}\n-\t/* sanity */\n+\t/* input valid? */\n \tif (!sc->port.pmf || !sc->port.port_stx) {\n \t\tPMD_DRV_LOG(ERR, sc, \"BUG!\");\n \t\treturn;\n@@ -237,7 +237,7 @@ bnx2x_port_stats_init(struct bnx2x_softc *sc)\n uint32_t mac_addr;\n uint32_t *stats_comp = BNX2X_SP(sc, stats_comp);\n \n- /* sanity */\n+ /* input valid? */\n if (!sc->link_vars.link_up || !sc->port.pmf) {\n \tPMD_DRV_LOG(ERR, sc, \"BUG!\");\n \treturn;\n@@ -461,7 +461,7 @@ bnx2x_func_stats_init(struct bnx2x_softc *sc)\n struct dmae_command *dmae = &sc->stats_dmae;\n uint32_t *stats_comp = BNX2X_SP(sc, stats_comp);\n \n- /* sanity */\n+ /* input valid? */\n if (!sc->func_stx) {\n \tPMD_DRV_LOG(ERR, sc, \"BUG!\");\n \treturn;\n@@ -1301,7 +1301,7 @@ bnx2x_port_stats_base_init(struct bnx2x_softc *sc)\n struct dmae_command *dmae;\n uint32_t *stats_comp = BNX2X_SP(sc, stats_comp);\n \n- /* sanity */\n+ /* input valid? */\n if (!sc->port.pmf || !sc->port.port_stx) {\n \tPMD_DRV_LOG(ERR, sc, \"BUG!\");\n \treturn;\ndiff --git a/drivers/net/bnx2x/ecore_sp.c b/drivers/net/bnx2x/ecore_sp.c\nindex c6c3857778f7..158205266f62 100644\n--- a/drivers/net/bnx2x/ecore_sp.c\n+++ b/drivers/net/bnx2x/ecore_sp.c\n@@ -207,7 +207,7 @@ static int ecore_exe_queue_step(struct bnx2x_softc *sc,\n \t\t\tbreak;\n \t}\n \n-\t/* Sanity check */\n+\t/* Argument check */\n \tif (!cur_len)\n \t\treturn ECORE_SUCCESS;\n \ndiff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c\nindex 43fbf04ece11..2b0236aac24e 100644\n--- a/drivers/net/bnx2x/elink.c\n+++ b/drivers/net/bnx2x/elink.c\n@@ -1087,7 +1087,7 @@ static void elink_get_epio(struct bnx2x_softc *sc, uint32_t epio_pin,\n {\n \tuint32_t epio_mask, gp_oenable;\n \t*en = 0;\n-\t/* Sanity check */\n+\t/* Input check */\n \tif (epio_pin > 31) {\n \t\tELINK_DEBUG_P1(sc, \"Invalid EPIO pin %d to get\", epio_pin);\n \t\treturn;\n@@ -1104,7 +1104,7 @@ static void elink_set_epio(struct bnx2x_softc *sc, uint32_t epio_pin, uint32_t e\n {\n \tuint32_t epio_mask, gp_output, gp_oenable;\n \n-\t/* Sanity check */\n+\t/* Input check */\n \tif (epio_pin > 31) {\n \t\tELINK_DEBUG_P1(sc, \"Invalid EPIO pin %d to set\", epio_pin);\n \t\treturn;\n", "prefixes": [ "14/20" ] }