Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126930/?format=api
{ "id": 126930, "url": "http://patches.dpdk.org/api/patches/126930/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230517161603.117728-7-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230517161603.117728-7-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230517161603.117728-7-stephen@networkplumber.org", "date": "2023-05-17T16:15:49", "name": "[06/20] lib: replace use of sanity check in comments and messages", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "077faaf45b4bc35c74d89b0eee5fbfdf0c007d09", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230517161603.117728-7-stephen@networkplumber.org/mbox/", "series": [ { "id": 28034, "url": "http://patches.dpdk.org/api/series/28034/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28034", "date": "2023-05-17T16:15:43", "name": "Replace use of term sanity-check", "version": 1, "mbox": "http://patches.dpdk.org/series/28034/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/126930/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/126930/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F244342B2C;\n\tWed, 17 May 2023 18:16:52 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6A1AD42D55;\n\tWed, 17 May 2023 18:16:19 +0200 (CEST)", "from mail-pf1-f171.google.com (mail-pf1-f171.google.com\n [209.85.210.171])\n by mails.dpdk.org (Postfix) with ESMTP id 5B5D842D3B\n for <dev@dpdk.org>; Wed, 17 May 2023 18:16:15 +0200 (CEST)", "by mail-pf1-f171.google.com with SMTP id\n d2e1a72fcca58-643ac91c51fso748530b3a.1\n for <dev@dpdk.org>; Wed, 17 May 2023 09:16:15 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n h5-20020a62b405000000b0063f33e216dasm15793009pfn.96.2023.05.17.09.16.13\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 17 May 2023 09:16:13 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1684340174;\n x=1686932174;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=3FSHiMioEPFWXPJKI6LlUMhfkclZSDjL9ZE86YDb+lA=;\n b=n1a8hqKvFOxZ6t72bTjpwf8o29g1AtM2zEWvfSLS14CrRuP6fK9WNb31J+Kl6C88pw\n GO5sP8usVsxrufbd5kQ2tuBpjYAKcE8wgMD0zxOi56ByT89Ys9I6NbNRbLH7RgvkxoaG\n 0WWLulQflLyTaZnUizPsunjwZAV8s6DMYozdvq16bYw09n9HYAbcqvBNSLahj287DEFX\n 6SC9/3hsWui/6odKQU1h8hTEqpGAtvirFDVBnjdJqD5h8mSbCM8eZ6dI+2Kd7JDTKRfj\n uQf3daQVhIeDRS0xWIPjQsE/hMqW6P+BQlX24YYku/n6zMSWv++FwqBVpDIwsjX5C8Pj\n lgIQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1684340174; x=1686932174;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=3FSHiMioEPFWXPJKI6LlUMhfkclZSDjL9ZE86YDb+lA=;\n b=jlWxR+rpi0Ay3RVl62DgNqbXcmgkIJPQ7k6U9ifA3AVPpsvagBPpgnxJLq7Yd9DpY0\n hRRAtp/evNquSswgLG7nqCdjI+8RJl9aRT6x+K5JLpFxNTckPdvjloYIcink9DPGLlM4\n sxn1VoLue/KuFsiHBfPjFZo0laN8kVV3HQgIWRZeIa//xZOOlQ8UZV6hrn8c8tshb8m8\n X4ycME68rJuhu3K8MWaIrAf6GNevKAywBCL2Zox/LsKSiLa7pnflcl8mY+PFSOhqlMi+\n llP5CgiPRzf0zlirNgDiEgVd6zGGTxVbIXeABgbfYmCyFkCeCxyOR3rBHqWPUDBB+cpF\n 7YKw==", "X-Gm-Message-State": "AC+VfDzRsdS3qZRkMLZjj2VVP+NcZuNdWBk3+8ydZGuDPajVLH7/sljC\n tVkI4i2UkrtyjMHxBstJJO0WAqgZVT7vpTkqu0udUQ==", "X-Google-Smtp-Source": "\n ACHHUZ7WzC9Yo/+jppX1FHnoJ4Rld1yQe6czW/u1BP6K2GJe9o+w3kbjOprDu5GlVlKbtZ9oAcy9VA==", "X-Received": "by 2002:a05:6a20:144d:b0:103:73a6:5cc1 with SMTP id\n a13-20020a056a20144d00b0010373a65cc1mr31765556pzi.4.1684340174299;\n Wed, 17 May 2023 09:16:14 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Jerin Jacob <jerinj@marvell.com>, Kiran Kumar K <kirankumark@marvell.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>,\n Reshma Pattan <reshma.pattan@intel.com>", "Subject": "[PATCH 06/20] lib: replace use of sanity check in comments and\n messages", "Date": "Wed, 17 May 2023 09:15:49 -0700", "Message-Id": "<20230517161603.117728-7-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230517161603.117728-1-stephen@networkplumber.org>", "References": "<20230517161603.117728-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Sanity check is on the Tier 2 non-inclusive list.\nReplace or remove it.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/graph/graph.c | 2 +-\n lib/graph/graph_stats.c | 2 +-\n lib/graph/node.c | 2 +-\n lib/jobstats/rte_jobstats.c | 6 +++---\n lib/metrics/rte_metrics.c | 2 +-\n lib/pcapng/rte_pcapng.c | 2 +-\n 6 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/graph/graph.c b/lib/graph/graph.c\nindex 5582631b5301..597e9e7aa28e 100644\n--- a/lib/graph/graph.c\n+++ b/lib/graph/graph.c\n@@ -283,7 +283,7 @@ rte_graph_create(const char *name, struct rte_graph_param *prm)\n \n \tgraph_spinlock_lock();\n \n-\t/* Check arguments sanity */\n+\t/* Check argument validity */\n \tif (prm == NULL)\n \t\tSET_ERR_JMP(EINVAL, fail, \"Param should not be NULL\");\n \ndiff --git a/lib/graph/graph_stats.c b/lib/graph/graph_stats.c\nindex c0140ba92212..28d5728e5e61 100644\n--- a/lib/graph/graph_stats.c\n+++ b/lib/graph/graph_stats.c\n@@ -271,7 +271,7 @@ rte_graph_cluster_stats_create(const struct rte_graph_cluster_stats_param *prm)\n \tconst char *pattern;\n \trte_graph_t i;\n \n-\t/* Sanity checks */\n+\t/* Validate arguments */\n \tif (!rte_graph_has_stats_feature())\n \t\tSET_ERR_JMP(EINVAL, fail, \"Stats feature is not enabled\");\n \ndiff --git a/lib/graph/node.c b/lib/graph/node.c\nindex 149414dcd94c..3f0ae0c395db 100644\n--- a/lib/graph/node.c\n+++ b/lib/graph/node.c\n@@ -68,7 +68,7 @@ __rte_node_register(const struct rte_node_register *reg)\n \n \tgraph_spinlock_lock();\n \n-\t/* Check sanity */\n+\t/* Check argument validity */\n \tif (reg == NULL || reg->process == NULL) {\n \t\trte_errno = EINVAL;\n \t\tgoto fail;\ndiff --git a/lib/jobstats/rte_jobstats.c b/lib/jobstats/rte_jobstats.c\nindex af565a14eaf3..1c4b280c952a 100644\n--- a/lib/jobstats/rte_jobstats.c\n+++ b/lib/jobstats/rte_jobstats.c\n@@ -124,7 +124,7 @@ rte_jobstats_start(struct rte_jobstats_context *ctx, struct rte_jobstats *job)\n {\n \tuint64_t now;\n \n-\t/* Some sanity check. */\n+\t/* Check validity of arguments. */\n \tif (unlikely(ctx == NULL || job == NULL || job->context != NULL))\n \t\treturn -EINVAL;\n \n@@ -144,7 +144,7 @@ rte_jobstats_abort(struct rte_jobstats *job)\n \tstruct rte_jobstats_context *ctx;\n \tuint64_t now, exec_time;\n \n-\t/* Some sanity check. */\n+\t/* Check that arguments are valid */\n \tif (unlikely(job == NULL || job->context == NULL))\n \t\treturn -EINVAL;\n \n@@ -165,7 +165,7 @@ rte_jobstats_finish(struct rte_jobstats *job, int64_t job_value)\n \tuint64_t now, exec_time;\n \tint need_update;\n \n-\t/* Some sanity check. */\n+\t/* Check arguments */\n \tif (unlikely(job == NULL || job->context == NULL))\n \t\treturn -EINVAL;\n \ndiff --git a/lib/metrics/rte_metrics.c b/lib/metrics/rte_metrics.c\nindex 0ccdbabc04eb..5c075ae60230 100644\n--- a/lib/metrics/rte_metrics.c\n+++ b/lib/metrics/rte_metrics.c\n@@ -120,7 +120,7 @@ rte_metrics_reg_names(const char * const *names, uint16_t cnt_names)\n \tuint16_t idx_name;\n \tuint16_t idx_base;\n \n-\t/* Some sanity checks */\n+\t/* Some consitency checks */\n \tif (cnt_names < 1 || names == NULL)\n \t\treturn -EINVAL;\n \tfor (idx_name = 0; idx_name < cnt_names; idx_name++)\ndiff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng/rte_pcapng.c\nindex 3c91fc77644a..fedf4b5b7f11 100644\n--- a/lib/pcapng/rte_pcapng.c\n+++ b/lib/pcapng/rte_pcapng.c\n@@ -669,7 +669,7 @@ rte_pcapng_write_packets(rte_pcapng_t *self,\n \t\tstruct rte_mbuf *m = pkts[i];\n \t\tstruct pcapng_enhance_packet_block *epb;\n \n-\t\t/* sanity check that is really a pcapng mbuf */\n+\t\t/* Check that is really a pcapng mbuf */\n \t\tepb = rte_pktmbuf_mtod(m, struct pcapng_enhance_packet_block *);\n \t\tif (unlikely(epb->block_type != PCAPNG_ENHANCED_PACKET_BLOCK ||\n \t\t\t epb->block_length != rte_pktmbuf_data_len(m))) {\n", "prefixes": [ "06/20" ] }