Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126912/?format=api
{ "id": 126912, "url": "http://patches.dpdk.org/api/patches/126912/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/168431454344.558450.2397970324914136724.stgit@ebuild.local/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<168431454344.558450.2397970324914136724.stgit@ebuild.local>", "list_archive_url": "https://inbox.dpdk.org/dev/168431454344.558450.2397970324914136724.stgit@ebuild.local", "date": "2023-05-17T09:09:05", "name": "[v3,3/4] vhost: fix invalid call FD handling", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f74c1949dea51d4e4a2810521fe7353c19c88942", "submitter": { "id": 672, "url": "http://patches.dpdk.org/api/people/672/?format=api", "name": "Eelco Chaudron", "email": "echaudro@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/168431454344.558450.2397970324914136724.stgit@ebuild.local/mbox/", "series": [ { "id": 28022, "url": "http://patches.dpdk.org/api/series/28022/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28022", "date": "2023-05-17T09:08:30", "name": "vhost: add device op to offload the interrupt kick", "version": 3, "mbox": "http://patches.dpdk.org/series/28022/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/126912/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/126912/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1472342B2A;\n\tWed, 17 May 2023 11:09:18 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 04B0542D1A;\n\tWed, 17 May 2023 11:09:18 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id BBA104067B\n for <dev@dpdk.org>; Wed, 17 May 2023 11:09:16 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-573-Ecv8p0c_Mfe8x1oJj0dnvw-1; Wed, 17 May 2023 05:09:07 -0400", "from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com\n [10.11.54.2])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0B193857E06;\n Wed, 17 May 2023 09:09:07 +0000 (UTC)", "from ebuild.redhat.com (unknown [10.39.195.120])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 550074078908;\n Wed, 17 May 2023 09:09:06 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1684314556;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=N7A4+saLOt44saselSeN5om0pZFSj4g81RxexG2h/xY=;\n b=OQah3m9kkCQOUEljacQDK7xuoWnP1eQnW9r+JDDecJ68HPgT775jG6nYdVncc07jXEAZy8\n CmlhhorHU2lTb5fRIfIgcRJLJB0yrpYQ3W84RNA43Hr4jLoeXo2zLfmx75WfjPzLiv2HDI\n WKaVb8RuCpxm5MJEeOHxR1fX2D+la5s=", "X-MC-Unique": "Ecv8p0c_Mfe8x1oJj0dnvw-1", "From": "Eelco Chaudron <echaudro@redhat.com>", "To": "maxime.coquelin@redhat.com, chenbo.xia@intel.com,\n david.marchand@redhat.com", "Cc": "dev@dpdk.org", "Subject": "[PATCH v3 3/4] vhost: fix invalid call FD handling", "Date": "Wed, 17 May 2023 11:09:05 +0200", "Message-Id": "<168431454344.558450.2397970324914136724.stgit@ebuild.local>", "In-Reply-To": "<168431450017.558450.16680518469610688737.stgit@ebuild.local>", "References": "<168431450017.558450.16680518469610688737.stgit@ebuild.local>", "User-Agent": "StGit/1.5", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.2", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch fixes cases where IRQ injection is tried while\nthe call FD is not valid, which should not happen.\n\nFixes: b1cce26af1dc (\"vhost: add notification for packed ring\")\nFixes: e37ff954405a (\"vhost: support virtqueue interrupt/notification suppression\")\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\nSigned-off-by: Eelco Chaudron <echaudro@redhat.com>\n---\n lib/vhost/vhost.h | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h\nindex 37609c7c8d..23a4e2b1a7 100644\n--- a/lib/vhost/vhost.h\n+++ b/lib/vhost/vhost.h\n@@ -903,9 +903,9 @@ vhost_vring_call_split(struct virtio_net *dev, struct vhost_virtqueue *vq)\n \t\t\t\"%s: used_event_idx=%d, old=%d, new=%d\\n\",\n \t\t\t__func__, vhost_used_event(vq), old, new);\n \n-\t\tif ((vhost_need_event(vhost_used_event(vq), new, old) &&\n-\t\t\t\t\t(vq->callfd >= 0)) ||\n-\t\t\t\tunlikely(!signalled_used_valid)) {\n+\t\tif ((vhost_need_event(vhost_used_event(vq), new, old) ||\n+\t\t\t\t\tunlikely(!signalled_used_valid)) &&\n+\t\t\t\tvq->callfd >= 0) {\n \t\t\teventfd_write(vq->callfd, (eventfd_t) 1);\n \t\t\tif (dev->flags & VIRTIO_DEV_STATS_ENABLED)\n \t\t\t\t__atomic_fetch_add(&vq->stats.guest_notifications,\n@@ -974,7 +974,7 @@ vhost_vring_call_packed(struct virtio_net *dev, struct vhost_virtqueue *vq)\n \tif (vhost_need_event(off, new, old))\n \t\tkick = true;\n kick:\n-\tif (kick) {\n+\tif (kick && vq->callfd >= 0) {\n \t\teventfd_write(vq->callfd, (eventfd_t)1);\n \t\tif (dev->notify_ops->guest_notified)\n \t\t\tdev->notify_ops->guest_notified(dev->vid);\n", "prefixes": [ "v3", "3/4" ] }