Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126864/?format=api
{ "id": 126864, "url": "http://patches.dpdk.org/api/patches/126864/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230516054329.1397016-2-rongweil@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230516054329.1397016-2-rongweil@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230516054329.1397016-2-rongweil@nvidia.com", "date": "2023-05-16T05:43:28", "name": "[v1,1/2] net/mlx5: disallow duplicated tag index in pattern template", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e434bbab3ed27cb44e82c09d16d3d812cbf601ca", "submitter": { "id": 2223, "url": "http://patches.dpdk.org/api/people/2223/?format=api", "name": "Rongwei Liu", "email": "rongweil@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230516054329.1397016-2-rongweil@nvidia.com/mbox/", "series": [ { "id": 28000, "url": "http://patches.dpdk.org/api/series/28000/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28000", "date": "2023-05-16T05:43:27", "name": "disallow duplicated tag index", "version": 1, "mbox": "http://patches.dpdk.org/series/28000/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/126864/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/126864/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 472B742B1C;\n\tTue, 16 May 2023 07:44:07 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5193642D47;\n\tTue, 16 May 2023 07:44:03 +0200 (CEST)", "from NAM02-DM3-obe.outbound.protection.outlook.com\n (mail-dm3nam02on2060.outbound.protection.outlook.com [40.107.95.60])\n by mails.dpdk.org (Postfix) with ESMTP id 2051E42D3A;\n Tue, 16 May 2023 07:44:01 +0200 (CEST)", "from MW4PR03CA0193.namprd03.prod.outlook.com (2603:10b6:303:b8::18)\n by BL3PR12MB6620.namprd12.prod.outlook.com (2603:10b6:208:38f::21)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.32; Tue, 16 May\n 2023 05:43:58 +0000", "from CO1NAM11FT052.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:b8:cafe::17) by MW4PR03CA0193.outlook.office365.com\n (2603:10b6:303:b8::18) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30 via Frontend\n Transport; Tue, 16 May 2023 05:43:58 +0000", "from mail.nvidia.com (216.228.117.160) by\n CO1NAM11FT052.mail.protection.outlook.com (10.13.174.225) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6411.15 via Frontend Transport; Tue, 16 May 2023 05:43:58 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Mon, 15 May 2023\n 22:43:45 -0700", "from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Mon, 15 May\n 2023 22:43:43 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=JcRHnaJ3l2q3ySl2TjYeMguF2ahd2aOoNcI5JoIFUKhjhzo52tY70re6MQmF8+87Y/AUKcOSRJx/kw6SwcE628pPIPPRe5UJSBUkPF88QGUMDM5GGLqmA68ErPoGCpGpIoAw3fj3yzxEla5GM1sg+hGMZVCIrF4y4sLQWTS9yKjjMfPfLuuekfqmbEu2jzgbXD8WVN45j97qVWBPxpfxaZeh5I6lK65t6BvyzXDMtVLw1fZ79KJXFDk+LfgvRkLzYB+JQsSQm7gzIPClkLX8ryG3B1mMtM77WJ9ym0zUOOg6OzsMMHBs8NJQn/V+3rgCZGtNMdOgESyCMuBvfuOb8g==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=u1hlRUWm/ZUI9VMX6+snKuvZLjunGZV518Q2PXYOUEU=;\n b=M/q0lJS/a+9R4E7wbWR4x75C6sK9MpijQX8+Q6C2QRvRILZhJRSg05z+ae/esRGwbnCI/LzfePmNMldIA0hUnm03IvkkZkBvQFqEmNIN6e0Apd2KAkmVM7Sh0eHWgVZv5CHZis3b2pYBcWnrjhbRL5QAejLm93AXLsrrYekp4P6FqWyCcvU6P8ysr8mz2PkLyHfWUM4klVOPzGrzQzrXYWmF10yDr+MEkWjK+J9AiWJZIIuiFdanSR18gB5Wh84PQmemwjsMxzczD87KLAJ20CRTJ1QCi5TdFsdmEUsd3rWYEKC4q+cbOftb/Hr8XAPKVGx4JRe3tGoWAElnt/vqwQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=u1hlRUWm/ZUI9VMX6+snKuvZLjunGZV518Q2PXYOUEU=;\n b=l0F8gYfTHlpLNZ0+rMtL5iAaFD0wAC7mSqrgQrKNobC2FxIIJTl1QyPLdQfTyRB9hqezHVL1uGpbyq3i58sUB0e1eMGqwpSru1WiuxBpqbl74PSavexWgipHC07k5FXYUS9P2KhM4a2tfhUg+POj81rZZf1bRB63wxjdNPkoENZdcKMgDE5fUocRFYLJOddLKiEAMfh5FAjz1PBAgOpb6/wJmSw4MXpuKSymvrGY+ZKJwfPxS66iYtZNYqfRW1L4XvVyJ5SYx5P6WdBuaFqYyeoSKubVpaaTEtyeABSqFAg1C2X6yVlxZO2ty9Q1+Nv4d9qjnUGZloRBNgKsJhbn7Q==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C", "From": "Rongwei Liu <rongweil@nvidia.com>", "To": "<dev@dpdk.org>, <matan@nvidia.com>, <viacheslavo@nvidia.com>,\n <orika@nvidia.com>, <thomas@monjalon.net>", "CC": "<stable@dpdk.org>", "Subject": "[PATCH v1 1/2] net/mlx5: disallow duplicated tag index in pattern\n template", "Date": "Tue, 16 May 2023 08:43:28 +0300", "Message-ID": "<20230516054329.1397016-2-rongweil@nvidia.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20230516054329.1397016-1-rongweil@nvidia.com>", "References": "<20230516054329.1397016-1-rongweil@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.230.37]", "X-ClientProxiedBy": "rnnvmail203.nvidia.com (10.129.68.9) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CO1NAM11FT052:EE_|BL3PR12MB6620:EE_", "X-MS-Office365-Filtering-Correlation-Id": "aa703c16-bf9c-4eb5-bdd0-08db55d08b43", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n FdFfmzlpbN2NIhmUp9GXdrLicDiN5IDLMhdthJaII95krFtN3j3NRgZvgby+WnZxngeGcp/86Rii6oVdFaWaHtWdk1ctSohoKf2dFDu0nzRKPjCNSDn0pm1ILeorfCCLihI9TJS+be6ml6RF7kSXx5tSVK9rmkl8+wco4NEgAqfBXFUxZDZG8xV31r1KaD+ajn9Q8RlzPCzRAggmrXraMwj3jsIQ/w4QuGBpiuePsROcLBmZs6QxWGPKVtCLJ/79nCFS0Q9w3NuNaykzkPLEfEmU6a7K7iExlgCOLm9l7BbOZ3L71mf4lyhUo7ausHPG++fK4+exRgNCVYpdgr21NpSBCCq+z1USfCUjk9IoBU0oZ2VjeDGausjwpyXn5Ivh8eDn82iIvoWOpOn201LJh8VimQ6EOvDbPCKvr4P1i1z6LSPxWiEV5DcnP8mN4TNeTgmoldY/5LbO5mWtAaDFIYZjhlaoO5aBVGvCU1AnBIZkMwpYfrBITIxDJ/Ve7CQOHPiIMU36Y3/3bW4uKq772dIL9j+IbB1aTTo9zIelFA4v14fE+7DBswBwKzVUriv3/t/0hDz1CoUk9IsaZp/cKTz1ZsUZRh8YMVy8VCPaL98E0Q0lY5q3fi7ccea6YUahkUhyxWLcalrts+6W12RxMeG3sDa1rf5qW75RL6TfTFCEtAkCMxr/EMsECjcRE7dLr4PqFO9WTwOCatIpzoX+RMrUEcbrEeV6rg33gtfZx3SXep7rUSf0UxgQZmT8m+fu", "X-Forefront-Antispam-Report": "CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE;\n SFS:(13230028)(4636009)(376002)(39860400002)(346002)(396003)(136003)(451199021)(46966006)(36840700001)(40470700004)(82740400003)(82310400005)(7636003)(356005)(478600001)(55016003)(336012)(426003)(40480700001)(2616005)(47076005)(83380400001)(36860700001)(1076003)(26005)(16526019)(6286002)(40460700003)(36756003)(6666004)(7696005)(186003)(41300700001)(316002)(70206006)(70586007)(4326008)(86362001)(8676002)(8936002)(5660300002)(2906002)(110136005);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "16 May 2023 05:43:58.0150 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n aa703c16-bf9c-4eb5-bdd0-08db55d08b43", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT052.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BL3PR12MB6620", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Duplicated tag index in pattern template will most likely cause\nmatching failures such as \"template tag index is 0 data mask 0xff /\ntag index is 0 data mask 0xffff / end\"\n\nIf the upper layer application needs to match the same tag twice\nwith different masks, it should be consolidated into one rte_item\nwith the desired mask.\n\n\"template tag index is 0 data mask 0xff / tag index is 0 data mask\n0xff00 / end\" should be present as \"template tag index is 0 data mask\n0xffff / end\"\n\nCc: stable@dpdk.org\nSigned-off-by: Rongwei Liu <rongweil@nvidia.com>\nAcked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow_hw.c | 25 +++++++++++++++++++++----\n 1 file changed, 21 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c\nindex 7e0ee8d883..78011584eb 100644\n--- a/drivers/net/mlx5/mlx5_flow_hw.c\n+++ b/drivers/net/mlx5/mlx5_flow_hw.c\n@@ -4831,8 +4831,9 @@ flow_hw_pattern_validate(struct rte_eth_dev *dev,\n \t\t\t struct rte_flow_error *error)\n {\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n-\tint i;\n+\tint i, tag_idx;\n \tbool items_end = false;\n+\tuint32_t tag_bitmap = 0;\n \n \tif (!attr->ingress && !attr->egress && !attr->transfer)\n \t\treturn rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ATTR, NULL,\n@@ -4874,16 +4875,26 @@ flow_hw_pattern_validate(struct rte_eth_dev *dev,\n \t\tswitch (type) {\n \t\tcase RTE_FLOW_ITEM_TYPE_TAG:\n \t\t{\n-\t\t\tint reg;\n \t\t\tconst struct rte_flow_item_tag *tag =\n \t\t\t\t(const struct rte_flow_item_tag *)items[i].spec;\n \n-\t\t\treg = flow_hw_get_reg_id(RTE_FLOW_ITEM_TYPE_TAG, tag->index);\n-\t\t\tif (reg == REG_NON)\n+\t\t\tif (tag == NULL)\n+\t\t\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t\t\t\t NULL,\n+\t\t\t\t\t\t\t \"Tag spec is NULL\");\n+\t\t\ttag_idx = flow_hw_get_reg_id(RTE_FLOW_ITEM_TYPE_TAG, tag->index);\n+\t\t\tif (tag_idx == REG_NON)\n \t\t\t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n \t\t\t\t\t\t\t NULL,\n \t\t\t\t\t\t\t \"Unsupported tag index\");\n+\t\t\tif (tag_bitmap & (1 << tag_idx))\n+\t\t\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\t\t\t\t NULL,\n+\t\t\t\t\t\t\t \"Duplicated tag index\");\n+\t\t\ttag_bitmap |= 1 << tag_idx;\n \t\t\tbreak;\n \t\t}\n \t\tcase MLX5_RTE_FLOW_ITEM_TYPE_TAG:\n@@ -4897,6 +4908,12 @@ flow_hw_pattern_validate(struct rte_eth_dev *dev,\n \t\t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n \t\t\t\t\t\t\t NULL,\n \t\t\t\t\t\t\t \"Unsupported internal tag index\");\n+\t\t\tif (tag_bitmap & (1 << tag->index))\n+\t\t\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\t\t\t\t NULL,\n+\t\t\t\t\t\t\t \"Duplicated tag index\");\n+\t\t\ttag_bitmap |= 1 << tag->index;\n \t\t\tbreak;\n \t\t}\n \t\tcase RTE_FLOW_ITEM_TYPE_REPRESENTED_PORT:\n", "prefixes": [ "v1", "1/2" ] }