Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126863/?format=api
{ "id": 126863, "url": "http://patches.dpdk.org/api/patches/126863/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230516054329.1397016-3-rongweil@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230516054329.1397016-3-rongweil@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230516054329.1397016-3-rongweil@nvidia.com", "date": "2023-05-16T05:43:29", "name": "[v1,2/2] net/mlx5: fix sws duplicated tag index matching", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "daf4d900ca26d2c22014ccb566c31b38bf1177a7", "submitter": { "id": 2223, "url": "http://patches.dpdk.org/api/people/2223/?format=api", "name": "rongwei liu", "email": "rongweil@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230516054329.1397016-3-rongweil@nvidia.com/mbox/", "series": [ { "id": 28000, "url": "http://patches.dpdk.org/api/series/28000/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=28000", "date": "2023-05-16T05:43:27", "name": "disallow duplicated tag index", "version": 1, "mbox": "http://patches.dpdk.org/series/28000/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/126863/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/126863/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 29BA242B1C;\n\tTue, 16 May 2023 07:44:02 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1D9B342D3A;\n\tTue, 16 May 2023 07:44:02 +0200 (CEST)", "from NAM12-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam12on2069.outbound.protection.outlook.com [40.107.237.69])\n by mails.dpdk.org (Postfix) with ESMTP id DF73342D38;\n Tue, 16 May 2023 07:44:00 +0200 (CEST)", "from SJ0PR03CA0108.namprd03.prod.outlook.com (2603:10b6:a03:333::23)\n by CY8PR12MB7243.namprd12.prod.outlook.com (2603:10b6:930:58::6) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.32; Tue, 16 May\n 2023 05:43:59 +0000", "from DM6NAM11FT107.eop-nam11.prod.protection.outlook.com\n (2603:10b6:a03:333:cafe::c2) by SJ0PR03CA0108.outlook.office365.com\n (2603:10b6:a03:333::23) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30 via Frontend\n Transport; Tue, 16 May 2023 05:43:59 +0000", "from mail.nvidia.com (216.228.117.161) by\n DM6NAM11FT107.mail.protection.outlook.com (10.13.172.142) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6411.15 via Frontend Transport; Tue, 16 May 2023 05:43:58 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Mon, 15 May 2023\n 22:43:48 -0700", "from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Mon, 15 May\n 2023 22:43:45 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=gTv4iCW549PnU0nmoWYznccKm1cob/IZsSJiZGbTRKT3Ykvafv20McZ0oGOHYhuAfK43viFK00EKOsGS3ItUcqvigyBnyxI9KPqyJov0wVkCdCMJApLuXc6uPMJlnbKlHoFKbTtT9vaMWySUu8uXfkN/GO2QVhvaWwzOzL9UwZK11iyZ1JGLKAywacibGbDjryJ4QVtG0h+9EbZ20ECQDvza47zWcVkFAstZCTPWfNqYkzvicZgwxBgQm3zZwZ+Y4UUxV5Zy1zKaV9CNZpPpEtNNK2unnEFlzQCyWx/X8Y5uT2CpNJrO6V24gwkfaKT5uAeJDFUSpzwRW5nwqmve2A==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=2qyfM7sWoSdFBtESPd1TiCfTNPvwTEu9SX5T5hYUmpI=;\n b=GbZBWg24Lr1lMlaPHdnGRk/mkQtBmqH+Se6MeFPw8ddaM+5ttbFRYr0IfWkBmQc1DZFHD0n7ca/HT3c3uFJgts94uJqwPBv8xoP1PgFdE5sCCSaYTPtyXz8AW/TJP5YfHdn8MJyAAuDjkY+krCLcwkMZw1fRFtfEUd1kh4Zf77QIFXSad2/CEfq719Lgu2CAPzp7K6iCUdV/8MTsPzjm/MAs53VTp/iInXDEfQ5fQQzAt0Lvh0iG7XNgr6hopyK2sBQADX8IOrolyAae39V3JNMeO6/AuWqaIkvq8OUXoUDzCid7AlVCsffVaX6gML4h1r4askkt3Q4cb8FAS1raFw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=2qyfM7sWoSdFBtESPd1TiCfTNPvwTEu9SX5T5hYUmpI=;\n b=uPuMWQAMw4yXPmDemKZdIe6Q1UNC0YRb0A5AllDsCgz0qtlhPjmFcl9vyeUDYWLRIbC+8JgQWD4ciMkmti0jggJeKvUceFOXZUe4yLQzS4KJRiEpUgPzNyKt6Hhe574NOogxz5LkwHviokOrUuSdFoppwJdrjirvFcdB034ssIGKO+T+iV19WmfabSqnnsJeI4c8nGGrKQFpXJGQBj6Ym20B9jF9rqIS7yfv8QMxKBw3UsBHBI5TGoc7cUxFfn74oOfPwG1ylWOoUZZNnZkAcXM5V0lfh4o2EhwC7FlvKq9ieyYNGYUp/HagS3qFzpK/PkQ4zTE9mOfev7PFGy/M7Q==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C", "From": "Rongwei Liu <rongweil@nvidia.com>", "To": "<dev@dpdk.org>, <matan@nvidia.com>, <viacheslavo@nvidia.com>,\n <orika@nvidia.com>, <thomas@monjalon.net>", "CC": "<stable@dpdk.org>, Yongseok Koh <yskoh@mellanox.com>", "Subject": "[PATCH v1 2/2] net/mlx5: fix sws duplicated tag index matching", "Date": "Tue, 16 May 2023 08:43:29 +0300", "Message-ID": "<20230516054329.1397016-3-rongweil@nvidia.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20230516054329.1397016-1-rongweil@nvidia.com>", "References": "<20230516054329.1397016-1-rongweil@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.230.37]", "X-ClientProxiedBy": "rnnvmail203.nvidia.com (10.129.68.9) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DM6NAM11FT107:EE_|CY8PR12MB7243:EE_", "X-MS-Office365-Filtering-Correlation-Id": "608add54-0dac-4b22-9cc7-08db55d08bcd", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n hRqp256oGYMhzXKxSvqBTZ62xE1/y363SfS75Z5iC4fNYeVJAGYfdxwKNNny3c+dA/0ZdKoC5JFK6EV1JM5/iqp+jJ44T+pWukIxIzQn0wX2lTyXllxKwC4rvPVS/mS/ndWDQKj1nqnywWNw+5CjA3P0AKP6Y/gCCOJVyOKdHwF5QwoxmEGk114J2JHA9XTRVGHCqAgQ+tB/ioY59HZ4rb8xIpTzXRiUQKjWllqS2MjlgefteL02q2m9ieAfUiDyZd0WWZo904Ql896lkm96zqZeBNOUphU/67bGGMPbLs1h3ztJfT7MOnpiLqGZSVMe3MP3DMWrca2FFSocBhXTqjtxakPh+Z1CcKdI46QoYTU6ozSFdThAPEsR86ereM1hOwz6PdbH6pSpd6icA3EXkIE138UWQ22vaKviHpvkkhCwyLN6oMMXrqkRVkMw57N4eHB1Mg3H5NHCvQm6RQVQogGAJc4XR5cweTTDi3zgKnS1+9oqGTC1UZkgzQ3HuTNqVHp97d9+gg9eoReWu/Em+CpP2PBF91J6NlhVLLc+gpAokI5zA7Qh/6kJVuxEBK/TvQ/cTEEMIdAkS7gH/k/SBDJKy0PyOvDyCjun3iISVoaUO+vzbV3AO01CdVa8/FO4mscOGD7V3LUpNzOU/ZyBf3w9X/x3G6X3Nmx5WjCWq4PR83aZ36KCFTrxW/VyiqKVUbEMEPzGU5isV8tomQzwfS/auIlueRG8v5Rcn4B4siKV0Vi7TmN/RVIRoltBCXsb", "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230028)(4636009)(136003)(39860400002)(346002)(396003)(376002)(451199021)(46966006)(40470700004)(36840700001)(8676002)(8936002)(86362001)(41300700001)(70586007)(478600001)(316002)(4326008)(2906002)(70206006)(110136005)(5660300002)(54906003)(82310400005)(6666004)(7696005)(82740400003)(40460700003)(7636003)(356005)(55016003)(336012)(2616005)(47076005)(426003)(1076003)(186003)(16526019)(26005)(6286002)(40480700001)(107886003)(36756003)(36860700001)(83380400001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "16 May 2023 05:43:58.8561 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 608add54-0dac-4b22-9cc7-08db55d08bcd", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM11FT107.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CY8PR12MB7243", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Duplicated matching tag index is not allowed in sws\nbecause they are using the same matching field in the\nunderlayer layout.\nFor example: \"tag index is 0 data spec 0x12 mask 0xff /\ntag index is 0 data spec 0x1234 mask 0xffff\" is paradoxical\nmatching condition and \"tag index is 0 data spec 0x12 mask 0xff /\ntag index is 0 data spec 0x3400 mask 0xff00\" should be \"tag index\nis 0 data spec 0x3412 mask 0xffff\"\n\nAdd checking logic against it.\n\nFixes: e554b672aa05 (\"net/mlx5: support flow tag\")\nCc: viacheslavo@nvidia.com\nCc: stable@dpdk.org\nSigned-off-by: Rongwei Liu <rongweil@nvidia.com>\nAcked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow_dv.c | 21 +++++++++++++++++++--\n 1 file changed, 19 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex 1abc4acad7..db2bf615db 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -2294,6 +2294,8 @@ flow_dv_validate_item_meta(struct rte_eth_dev *dev __rte_unused,\n * Pointer to the rte_eth_dev structure.\n * @param[in] item\n * Item specification.\n+ * @param[in] tag_bitmap\n+ * Tag index bitmap.\n * @param[in] attr\n * Attributes of flow that includes this item.\n * @param[out] error\n@@ -2305,6 +2307,7 @@ flow_dv_validate_item_meta(struct rte_eth_dev *dev __rte_unused,\n static int\n flow_dv_validate_item_tag(struct rte_eth_dev *dev,\n \t\t\t const struct rte_flow_item *item,\n+\t\t\t uint32_t *tag_bitmap,\n \t\t\t const struct rte_flow_attr *attr __rte_unused,\n \t\t\t struct rte_flow_error *error)\n {\n@@ -2348,6 +2351,12 @@ flow_dv_validate_item_tag(struct rte_eth_dev *dev,\n \tif (ret < 0)\n \t\treturn ret;\n \tMLX5_ASSERT(ret != REG_NON);\n+\tif (*tag_bitmap & (1 << ret))\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM_SPEC,\n+\t\t\t\t\t item->spec,\n+\t\t\t\t\t \"Duplicated tag index\");\n+\t*tag_bitmap |= 1 << ret;\n \treturn 0;\n }\n \n@@ -7290,9 +7299,10 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,\n \tbool def_policy = false;\n \tbool shared_count = false;\n \tuint16_t udp_dport = 0;\n-\tuint32_t tag_id = 0;\n+\tuint32_t tag_id = 0, tag_bitmap = 0;\n \tconst struct rte_flow_action_age *non_shared_age = NULL;\n \tconst struct rte_flow_action_count *count = NULL;\n+\tconst struct mlx5_rte_flow_item_tag *mlx5_tag;\n \tstruct mlx5_priv *act_priv = NULL;\n \tint aso_after_sample = 0;\n \n@@ -7621,7 +7631,7 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,\n \t\t\tlast_item = MLX5_FLOW_LAYER_ICMP6;\n \t\t\tbreak;\n \t\tcase RTE_FLOW_ITEM_TYPE_TAG:\n-\t\t\tret = flow_dv_validate_item_tag(dev, items,\n+\t\t\tret = flow_dv_validate_item_tag(dev, items, &tag_bitmap,\n \t\t\t\t\t\t\tattr, error);\n \t\t\tif (ret < 0)\n \t\t\t\treturn ret;\n@@ -7631,6 +7641,13 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,\n \t\t\tlast_item = MLX5_FLOW_ITEM_SQ;\n \t\t\tbreak;\n \t\tcase MLX5_RTE_FLOW_ITEM_TYPE_TAG:\n+\t\t\tmlx5_tag = (const struct mlx5_rte_flow_item_tag *)items->spec;\n+\t\t\tif (tag_bitmap & (1 << mlx5_tag->id))\n+\t\t\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM_SPEC,\n+\t\t\t\t\t\t\t items->spec,\n+\t\t\t\t\t\t\t \"Duplicated tag index\");\n+\t\t\ttag_bitmap |= 1 << mlx5_tag->id;\n \t\t\tbreak;\n \t\tcase RTE_FLOW_ITEM_TYPE_GTP:\n \t\t\tret = flow_dv_validate_item_gtp(dev, items, item_flags,\n", "prefixes": [ "v1", "2/2" ] }