Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126783/?format=api
{ "id": 126783, "url": "http://patches.dpdk.org/api/patches/126783/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230509060347.1237884-4-zhirun.yan@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230509060347.1237884-4-zhirun.yan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230509060347.1237884-4-zhirun.yan@intel.com", "date": "2023-05-09T06:03:35", "name": "[v6,03/15] graph: move node process into inline function", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "c37a1c516b82053da656b4138ea28ed744ca95f7", "submitter": { "id": 1154, "url": "http://patches.dpdk.org/api/people/1154/?format=api", "name": "Yan, Zhirun", "email": "zhirun.yan@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230509060347.1237884-4-zhirun.yan@intel.com/mbox/", "series": [ { "id": 27966, "url": "http://patches.dpdk.org/api/series/27966/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27966", "date": "2023-05-09T06:03:32", "name": "graph enhancement for multi-core dispatch", "version": 6, "mbox": "http://patches.dpdk.org/series/27966/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/126783/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/126783/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DBF4242AA0;\n\tTue, 9 May 2023 08:04:23 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2003A42D3C;\n\tTue, 9 May 2023 08:04:07 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id EF6D542D30\n for <dev@dpdk.org>; Tue, 9 May 2023 08:04:05 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 May 2023 23:04:05 -0700", "from dpdk-zhirun-lmm.sh.intel.com ([10.67.119.94])\n by fmsmga007.fm.intel.com with ESMTP; 08 May 2023 23:04:03 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1683612246; x=1715148246;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=KeDv2YiEgfdAtW/ynDnajjHKdHuWTSKwXsOZMTXODNw=;\n b=Pj/ZPC/bYWvxS4vWqmYMl2kOG5bn+74i4k40C2mJaGz5OM6Jpx4jihPn\n 0uaY+8EAQePbXh7nZtcTcP6Z1MFESr8+4ZnPjdG5pQH8R7gZxUrCvEP4J\n 2B5vum1zZVIpJM3t2KFupCSI/tLFoxFFuNQ6ZfP38/VZqqHQkFNVEAw6K\n pKdGxMBrpLPExy+y2x9oVxY/qXIJBA2Ym8kmq1GpKPOigadJeCXiZaNLD\n XzkF3Y/65BIKeeAGw3YYae9j55mgCf69N3CA2mqGG60Hx6rm6ELmaDe/6\n zwu4Wy4nY6P0ZQG/7niIZ7PIIIS69Kr8J4uQ9pSV8fYBk+Xs6aG3/T6OM A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10704\"; a=\"351983063\"", "E=Sophos;i=\"5.99,261,1677571200\"; d=\"scan'208\";a=\"351983063\"", "E=McAfee;i=\"6600,9927,10704\"; a=\"701700102\"", "E=Sophos;i=\"5.99,261,1677571200\"; d=\"scan'208\";a=\"701700102\"" ], "X-ExtLoop1": "1", "From": "Zhirun Yan <zhirun.yan@intel.com>", "To": "dev@dpdk.org, jerinj@marvell.com, kirankumark@marvell.com,\n ndabilpuram@marvell.com, stephen@networkplumber.org,\n pbhagavatula@marvell.com", "Cc": "cunming.liang@intel.com, haiyue.wang@intel.com,\n Zhirun Yan <zhirun.yan@intel.com>", "Subject": "[PATCH v6 03/15] graph: move node process into inline function", "Date": "Tue, 9 May 2023 15:03:35 +0900", "Message-Id": "<20230509060347.1237884-4-zhirun.yan@intel.com>", "X-Mailer": "git-send-email 2.37.2", "In-Reply-To": "<20230509060347.1237884-1-zhirun.yan@intel.com>", "References": "<20230331040306.3143693-1-zhirun.yan@intel.com>\n <20230509060347.1237884-1-zhirun.yan@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Node process is a single and reusable block, move the code into an inline\nfunction.\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\nSigned-off-by: Cunming Liang <cunming.liang@intel.com>\nSigned-off-by: Zhirun Yan <zhirun.yan@intel.com>\n---\n lib/graph/rte_graph_model_rtc.h | 20 ++---------------\n lib/graph/rte_graph_worker_common.h | 33 +++++++++++++++++++++++++++++\n 2 files changed, 35 insertions(+), 18 deletions(-)", "diff": "diff --git a/lib/graph/rte_graph_model_rtc.h b/lib/graph/rte_graph_model_rtc.h\nindex 10b359772f..4b6236e301 100644\n--- a/lib/graph/rte_graph_model_rtc.h\n+++ b/lib/graph/rte_graph_model_rtc.h\n@@ -21,9 +21,6 @@ rte_graph_walk_rtc(struct rte_graph *graph)\n \tconst rte_node_t mask = graph->cir_mask;\n \tuint32_t head = graph->head;\n \tstruct rte_node *node;\n-\tuint64_t start;\n-\tuint16_t rc;\n-\tvoid **objs;\n \n \t/*\n \t * Walk on the source node(s) ((cir_start - head) -> cir_start) and then\n@@ -42,21 +39,8 @@ rte_graph_walk_rtc(struct rte_graph *graph)\n \t */\n \twhile (likely(head != graph->tail)) {\n \t\tnode = (struct rte_node *)RTE_PTR_ADD(graph, cir_start[(int32_t)head++]);\n-\t\tRTE_ASSERT(node->fence == RTE_GRAPH_FENCE);\n-\t\tobjs = node->objs;\n-\t\trte_prefetch0(objs);\n-\n-\t\tif (rte_graph_has_stats_feature()) {\n-\t\t\tstart = rte_rdtsc();\n-\t\t\trc = node->process(graph, node, objs, node->idx);\n-\t\t\tnode->total_cycles += rte_rdtsc() - start;\n-\t\t\tnode->total_calls++;\n-\t\t\tnode->total_objs += rc;\n-\t\t} else {\n-\t\t\tnode->process(graph, node, objs, node->idx);\n-\t\t}\n-\t\t\tnode->idx = 0;\n-\t\t\thead = likely((int32_t)head > 0) ? head & mask : head;\n+\t\t__rte_node_process(graph, node);\n+\t\thead = likely((int32_t)head > 0) ? head & mask : head;\n \t}\n \tgraph->tail = 0;\n }\ndiff --git a/lib/graph/rte_graph_worker_common.h b/lib/graph/rte_graph_worker_common.h\nindex b58f8f6947..e25eabc81f 100644\n--- a/lib/graph/rte_graph_worker_common.h\n+++ b/lib/graph/rte_graph_worker_common.h\n@@ -130,6 +130,39 @@ void __rte_node_stream_alloc_size(struct rte_graph *graph,\n \n /* Fast path helper functions */\n \n+/**\n+ * @internal\n+ *\n+ * Enqueue a given node to the tail of the graph reel.\n+ *\n+ * @param graph\n+ * Pointer Graph object.\n+ * @param node\n+ * Pointer to node object to be enqueued.\n+ */\n+static __rte_always_inline void\n+__rte_node_process(struct rte_graph *graph, struct rte_node *node)\n+{\n+\tuint64_t start;\n+\tuint16_t rc;\n+\tvoid **objs;\n+\n+\tRTE_ASSERT(node->fence == RTE_GRAPH_FENCE);\n+\tobjs = node->objs;\n+\trte_prefetch0(objs);\n+\n+\tif (rte_graph_has_stats_feature()) {\n+\t\tstart = rte_rdtsc_precise();\n+\t\trc = node->process(graph, node, objs, node->idx);\n+\t\tnode->total_cycles += rte_rdtsc_precise() - start;\n+\t\tnode->total_calls++;\n+\t\tnode->total_objs += rc;\n+\t} else {\n+\t\tnode->process(graph, node, objs, node->idx);\n+\t}\n+\tnode->idx = 0;\n+}\n+\n /**\n * @internal\n *\n", "prefixes": [ "v6", "03/15" ] }