Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126673/?format=api
http://patches.dpdk.org/api/patches/126673/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230503114921.4588-3-talshn@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230503114921.4588-3-talshn@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230503114921.4588-3-talshn@nvidia.com", "date": "2023-05-03T11:49:20", "name": "[2/3] net/mlx5: support CQE compression on Windows", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b254b5bc6fa1072dc910deefbf7b3acb4f0c855d", "submitter": { "id": 1893, "url": "http://patches.dpdk.org/api/people/1893/?format=api", "name": "Tal Shnaiderman", "email": "talshn@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230503114921.4588-3-talshn@nvidia.com/mbox/", "series": [ { "id": 27920, "url": "http://patches.dpdk.org/api/series/27920/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27920", "date": "2023-05-03T11:49:18", "name": "Windows performance enhancements", "version": 1, "mbox": "http://patches.dpdk.org/series/27920/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/126673/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/126673/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C2B3642A4E;\n\tWed, 3 May 2023 13:50:52 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 23CB742C76;\n\tWed, 3 May 2023 13:50:47 +0200 (CEST)", "from NAM10-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam10on2065.outbound.protection.outlook.com [40.107.94.65])\n by mails.dpdk.org (Postfix) with ESMTP id 266F542D12\n for <dev@dpdk.org>; Wed, 3 May 2023 13:50:46 +0200 (CEST)", "from CY5PR19CA0120.namprd19.prod.outlook.com (2603:10b6:930:64::10)\n by MW4PR12MB7167.namprd12.prod.outlook.com (2603:10b6:303:225::19)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Wed, 3 May\n 2023 11:50:43 +0000", "from CY4PEPF0000E9CE.namprd03.prod.outlook.com\n (2603:10b6:930:64:cafe::2c) by CY5PR19CA0120.outlook.office365.com\n (2603:10b6:930:64::10) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.25 via Frontend\n Transport; Wed, 3 May 2023 11:50:42 +0000", "from mail.nvidia.com (216.228.117.161) by\n CY4PEPF0000E9CE.mail.protection.outlook.com (10.167.241.141) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6363.21 via Frontend Transport; Wed, 3 May 2023 11:50:42 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Wed, 3 May 2023\n 04:50:29 -0700", "from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Wed, 3 May 2023\n 04:50:25 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=dQWLX26Am1QQQxRKKzCZIQbeTV5SaxMF/WQp2D8yn0zsRmpSUl9RmfBeaKdKA1vOTPPTFKcAb1IhjvmPcy/c3o5Gr7scwh0YgJsPRj30/U02EkdY7TQpildcsoY3IZKzfHnjZ602xdK8ucuEoUqR5m+D+9ljFHCA3YbzQEA+l22ic9MJjzYTyvcvTcADUw/G87hrbw00Eki9aMqCWQNOC3ipJu+atPJovV/RlzxvqkzB/HmQhFDO07TOupAaUY64vmOJncWVes71XXgm/UuSR0kP8Sijshzpohwc/aDbyyvNBUjyBCnbC/ACVleemwHwfP63z5q64jPPpE7jCMQtHg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=xVFLSacvd7FSUbgxgJZjVfI7P3WVne1whRBEQAu10fc=;\n b=dKhK7jSx1SMarMN7NhWI/vvOz1jfrM3/BQgwIj/2To8bFEZ3XJRq9FkLrncl8LLN+O0M55vTEmeFvyY23la2uyiv4kFd45zlt0NdeqaiwvrHucVBkFMptbfuQq3LvCrmp9q4RO/WPfyQIPoXC05/OsG2ISPbrwZw6eDhv80HOikk+YpPL51FoaHN109L4ivVmZzh2h5dzVAy6idsUwLwHt8GaEN7XCaoIPwrL+CtUSOquFsayEEgC9Ofx7EEnFRK1nV++0hWw0csl85JtIST7YVFY2/ceDzFCpgOkT9qRh5kspNlX9dI+O5RgjafTw8A4f8NIK2PXjg4AUFs4B5TVA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=xVFLSacvd7FSUbgxgJZjVfI7P3WVne1whRBEQAu10fc=;\n b=HvZPMGyCzuva38UEqrmcL2Wv+m2es+Q1pfwvP5RsmaHWEKes7+EQgDWGAQ3G/WGqhxAc6f1n4CbF1gbrkvYzakokuLzBEtyjRF/fdcpS/yPp8P2XKnSKzS+T8AU2Yy9fNjnx+Cy3qe4l0+7wRoCKm4saO5OOJXTdTyeD3Jz1nxCBwIihMGfgTDlBFDbvYp8cJtctf1jesyjL9bqhIY77Ly1bQnVoYBpAcMXETZ7Wrd95kSbMttgWju1ZaKfNY2UmeV/xc9rij6+2fNYl7ePAPN/4teH7IwA9Yv5mux1jyIOhRze/dZR0U1K9NEzEuR2JvZ4945sgMuIsrSNrt8Jwxw==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C", "From": "Tal Shnaiderman <talshn@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<thomas@monjalon.net>, <matan@nvidia.com>, <viacheslavo@nvidia.com>,\n <rasland@nvidia.com>, <pdamouny@nvidia.com>, <tamerh@nvidia.com>", "Subject": "[PATCH 2/3] net/mlx5: support CQE compression on Windows", "Date": "Wed, 3 May 2023 14:49:20 +0300", "Message-ID": "<20230503114921.4588-3-talshn@nvidia.com>", "X-Mailer": "git-send-email 2.16.1.windows.4", "In-Reply-To": "<20230503114921.4588-1-talshn@nvidia.com>", "References": "<20230503114921.4588-1-talshn@nvidia.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.231.37]", "X-ClientProxiedBy": "rnnvmail201.nvidia.com (10.129.68.8) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CY4PEPF0000E9CE:EE_|MW4PR12MB7167:EE_", "X-MS-Office365-Filtering-Correlation-Id": "a74e035c-42eb-4d4f-16fc-08db4bcc9fa9", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 3GzWWXdU6U7ZMXexa7Wt3jcPz7Y01jExW0WSOB2+J4YcmDYnk2+xJiUzDMqRjgm5EnK60oVerUQLQZcWvnS0zHejpRXUUJVGweBjFrVnuCm7/2TNwxRtYciESt/5WkipfYUBDe8c9sz70SDR7ulfjpwaYEUefncv3A2yDl1MdF11ykCJuy2p/o6xH78ugXh63ATRhVWrGpsGoWxHN1AxMetY5PvolUeDZFYG+er+gQ3w9TZqmbQNflQ+6LiKxgCWbwb+63RMqR31zLW7uFqswFYNJcxuBiIvd4CT6p3Q7MgI8MoXfxpkLq1SJzkhGo6mgDsht3QfCHFYakC4CTyDv4g2XvFLVAdhauIQwCoKqXEZU7ygYgF4TNlWgus1MMpV9beuf3riyNPz7v/ync/1B28iW0T9jt2FDd5As3a7eajIk7CLjRGN4YjXAFtfu4qdUvHz7UEurLQBUa879X1ndZ1OfmumHfvu4fWjyXoHrYJOiHDD3gkoXpHxvOkByrUcrpdYZIqh4dOH+BWAEUXLViqMLA4PU35MjJQYY0p9CbDmBQdidXNauCGzPFhu1V3zXDS+aJRlHKm0xfIf1I6pfBy5beR+juz5waOpUHLu2qAH/dP38JL292JJSaUivNuyrmWugcgOFc6yGqy5yHIFgprUNIyRmcHoM5Eo0eVlX1zO/zNFqGcG1g9FGeN0A9fnSAZ4SYw3ZH52TRZXcuuYcA==", "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230028)(4636009)(136003)(376002)(346002)(396003)(39860400002)(451199021)(40470700004)(36840700001)(46966006)(5660300002)(107886003)(36756003)(82740400003)(6666004)(478600001)(41300700001)(40480700001)(55016003)(7636003)(356005)(316002)(40460700003)(70586007)(70206006)(8936002)(8676002)(4326008)(6916009)(82310400005)(7696005)(16526019)(6286002)(186003)(336012)(426003)(2616005)(86362001)(36860700001)(54906003)(26005)(1076003)(47076005)(83380400001)(2906002);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "03 May 2023 11:50:42.6033 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n a74e035c-42eb-4d4f-16fc-08db4bcc9fa9", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CY4PEPF0000E9CE.namprd03.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MW4PR12MB7167", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "CQE Compression reduces PCI overhead by coalescing and compressing\nmultiple CQEs into a single merged CQE.\n\nAdd supported for the CQE compression feature on Windows.\nfeature is enabled by default unless not supported by the HW\nor if the rxq_cqe_comp_en PMD argument is explicitly disabled.\n\nSigned-off-by: Tal Shnaiderman <talshn@nvidia.com>\n---\n drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++\n drivers/common/mlx5/mlx5_devx_cmds.h | 1 +\n drivers/net/mlx5/windows/mlx5_os.c | 12 ++++++++++++\n 3 files changed, 15 insertions(+)", "diff": "diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c\nindex 096bd1d520..a31e4995f5 100644\n--- a/drivers/common/mlx5/mlx5_devx_cmds.c\n+++ b/drivers/common/mlx5/mlx5_devx_cmds.c\n@@ -1062,6 +1062,8 @@ mlx5_devx_cmd_query_hca_attr(void *ctx,\n \tattr->cqe_compression = MLX5_GET(cmd_hca_cap, hcattr, cqe_compression);\n \tattr->mini_cqe_resp_flow_tag = MLX5_GET(cmd_hca_cap, hcattr,\n \t\t\t\t\t\tmini_cqe_resp_flow_tag);\n+\tattr->cqe_compression_128 = MLX5_GET(cmd_hca_cap, hcattr,\n+\t\t\t\t\t\tcqe_compression_128);\n \tattr->mini_cqe_resp_l3_l4_tag = MLX5_GET(cmd_hca_cap, hcattr,\n \t\t\t\t\t\t mini_cqe_resp_l3_l4_tag);\n \tattr->enhanced_cqe_compression = MLX5_GET(cmd_hca_cap, hcattr,\ndiff --git a/drivers/common/mlx5/mlx5_devx_cmds.h b/drivers/common/mlx5/mlx5_devx_cmds.h\nindex 9e7992b1c6..edcd867c4e 100644\n--- a/drivers/common/mlx5/mlx5_devx_cmds.h\n+++ b/drivers/common/mlx5/mlx5_devx_cmds.h\n@@ -284,6 +284,7 @@ struct mlx5_hca_attr {\n \tuint16_t max_wqe_sz_sq;\n \tuint32_t striding_rq:1;\n \tuint32_t ext_stride_num_range:1;\n+\tuint32_t cqe_compression_128:1;\n \tuint32_t set_reg_c:8;\n \tuint32_t nic_flow_table:1;\n \tuint32_t modify_outer_ip_ecn:1;\ndiff --git a/drivers/net/mlx5/windows/mlx5_os.c b/drivers/net/mlx5/windows/mlx5_os.c\nindex 0caa8931e4..6527269663 100644\n--- a/drivers/net/mlx5/windows/mlx5_os.c\n+++ b/drivers/net/mlx5/windows/mlx5_os.c\n@@ -237,6 +237,18 @@ mlx5_os_capabilities_prepare(struct mlx5_dev_ctx_shared *sh)\n \t} else {\n \t\tDRV_LOG(DEBUG, \"Tunnel offloading is not supported.\");\n \t}\n+\tsh->dev_cap.cqe_comp = 0;\n+#if (RTE_CACHE_LINE_SIZE == 128)\n+\tif (hca_attr->cqe_compression_128)\n+\t\tsh->dev_cap.cqe_comp = 1;\n+\tDRV_LOG(DEBUG, \"Rx CQE 128B compression is %ssupported.\",\n+\t\tsh->dev_cap.cqe_comp ? \"\" : \"not \");\n+#else\n+\tif (hca_attr->cqe_compression)\n+\t\tsh->dev_cap.cqe_comp = 1;\n+\tDRV_LOG(DEBUG, \"Rx CQE compression is %ssupported.\",\n+\t\tsh->dev_cap.cqe_comp ? \"\" : \"not \");\n+#endif\n \tsnprintf(sh->dev_cap.fw_ver, 64, \"%x.%x.%04x\",\n \t\t MLX5_GET(initial_seg, pv_iseg, fw_rev_major),\n \t\t MLX5_GET(initial_seg, pv_iseg, fw_rev_minor),\n", "prefixes": [ "2/3" ] }{ "id": 126673, "url": "